From patchwork Sun Jun 9 01:44:33 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Rheinhardt X-Patchwork-Id: 49721 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a59:c209:0:b0:460:55fa:d5ed with SMTP id d9csp1816763vqo; Sat, 8 Jun 2024 18:44:56 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCW8UBjUWyHKWxAZV0CX6iMXyqNHT2lbAYM+AYNI9PooJ4c2YpXyBLAtyjCBl1e4397PQ0jZgQ2fyBfCOV2IU2kkS5WyEEFwtyLkLA== X-Google-Smtp-Source: AGHT+IEX3SoWKFY4zTmq6+zfeNjeHImZg0C9YziweaxL857l9zatsGQf+g35Z1RquHSIRHXbrfxk X-Received: by 2002:a17:906:fb11:b0:a68:c5b0:9890 with SMTP id a640c23a62f3a-a6cd7a80f9dmr422230166b.42.1717897496465; Sat, 08 Jun 2024 18:44:56 -0700 (PDT) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id a640c23a62f3a-a6f1464e04csi33550166b.647.2024.06.08.18.44.56; Sat, 08 Jun 2024 18:44:56 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@outlook.com header.s=selector1 header.b=FFBo649p; arc=fail (body hash mismatch); spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=outlook.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 508B968D736; Sun, 9 Jun 2024 04:44:53 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03olkn2022.outbound.protection.outlook.com [40.92.59.22]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9730568D6FB for ; Sun, 9 Jun 2024 04:44:45 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nfBOMzcTDTnAv+olE+qjrsdYxG98pF10rE7NsIs73BT8UPZzUOxPEmu8kWllpsvW50mCjUJkBK1MEd8K0wAg0KMh1RgFe5cijUD7Yv8AT1bzjDu4bZZVYrcRokB/AcT1KHK+4DgkNN5x05p8l+TvQa/hMnLSi+iEeaasuZ9n7BVWWCF7WCCgM9sKoj1UrIAteSDuuJCKrVQf4vd82Y7g2uYMuhoMP80jkr3NExw8/0W4/BpbqNQFxiTP0ITuvM3ax31+R/dm/Fgi0QV7WhhhfO/ViIIUtEwZ/OrU+gqY9KGaDho9ZvlO6eBf/owDxK1McGUq0e39BcbkmgDPt4KVvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YkFBqNJD7bto9qZtNQGIRAOsPHZlaAmD0ZxZ3P86zQo=; b=nJLFuGWki0I6pm0b/QP73M6B6q9tPsvCi7XslCS9d3VY08H+4QADZOamwTHuvKKF4zwrdpsxtiNc5fnBZZqvEiQvTO5j2wSjX336mnkbJwTwMu10DxCEWwUPumrJSqjZzjAzzsugy3Pg3G0hNjjxuklwEvQucJN+IIch7lhEo6pF53F6WSOkSJ6vZNahkfBAHehVcSa4sBcLJqq82au9T0s0twQ6eC23v+YKIsUWWNhb51ReGnXz8P/HcoZVge8fPOlN4ryHR1nxbFVLO2p5WeF4xfLr16nPa8cGT3yzCjEnxENYXI5PFrYmlLJOcr2LajYmIqTKCxZU0PRBH7910Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YkFBqNJD7bto9qZtNQGIRAOsPHZlaAmD0ZxZ3P86zQo=; b=FFBo649pmtjutb2GYGLSR+BW8vHrrdd6zjTRHK8b/tAAZLA0D3eDSL5VA5d9IS2DxooD/DNUImbAe5q2wOdBGM0MbGyVp91eOFhhvZu/SHVudKXQO1ii8prtoBDwSa56mCxn72Rcr44rXBgK0NlXFpRJUQfA2ji9G9P4noy0I22hanX9HzGI42VWeV245Rz1+95DbAm/ZiNHbzi4MxJNeCJhGW5aHEBQOnl5Jbscc/VVpdts5DJ4GYbOHiP7ZvXLh5LKp4uU03q6CKbv53zFhLCYlRMcM6ZtXVBZz1CdaoNUVx9sl4F8Txb82VeTCbYL5bLN493H43scOTg9250BYg== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by PAXP250MB0494.EURP250.PROD.OUTLOOK.COM (2603:10a6:102:28d::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.36; Sun, 9 Jun 2024 01:44:44 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::384d:40d4:ecb7:1c9]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::384d:40d4:ecb7:1c9%4]) with mapi id 15.20.7633.021; Sun, 9 Jun 2024 01:44:44 +0000 From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Sun, 9 Jun 2024 03:44:33 +0200 Message-ID: X-Mailer: git-send-email 2.40.1 X-TMN: [lfLVAJv5SpBJmbOkFmYiU9MVrD2Ve/koyyTCQj2F344=] X-ClientProxiedBy: FR4P281CA0200.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:e5::9) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: <20240609014435.2857624-1-andreas.rheinhardt@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|PAXP250MB0494:EE_ X-MS-Office365-Filtering-Correlation-Id: f0d60b5d-e573-469e-a7eb-08dc8825bcbd X-Microsoft-Antispam: BCL:0; ARA:14566002|461199019|440099019|3412199016|1710799017; X-Microsoft-Antispam-Message-Info: mN+W4ON/jAY0lM0qESzggCAq4VAZujiQfM8VCEk1JEN8vBZflbruMF413iGxsJzOrrPEWeKohh4vh+01NG7nNGDLVdS101ajRp/x2KF5Fhxb6odjx5VyoxZ6HafNDO73P7CVJn55uwBmarwxNht8sJ62omIfNFa3zlJPQV2Y/CFACMFdc7/Ms9L+gRiRiVMMYrJdnEwLC1D5fLMf6J29fhcan3/jSVily2ZNfAc09x9tlNFlBcPqPaGwFXsPCGnLIGab/YioyOWV+Dlt/ciPt0ccSPRWGFISi3gcWjgnOzt2Git13YBkbrHLzLsf/6SDG87agsLIT3R8C6jut6e9T7S/sdduLGOM+lbbV/X/MCzMRtoZz6mnVV8McY5m3xaIiIbc1tSEYFgL/sIxS0YRWbUfALsqzlTXXivLjPbl9gf7N3SnIjbrwif/JgXZGCKlzJKfnqt0lYOmNJCgybzlIp3h2cw29tnB/836k920MiyYubCovz8kRHveQYVbBiUeVnJi8gE59Ao0SYOVX/LndA48yShv7zNPPgvOhq9FzbvhLI9o+IoM4A3uqxP4H5rbFzuU8l29cSDXecdXas6HsWKsrP7fD3x4m5lLsDhXbRGkA+XYS2wFWnwwlvXejK4W X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 5RUW4dEYNvmMy7qNImEuRfI8TpzHYXuOs2hEpyR/UYvxzCOUi9oJ6L1p7UgJAgVo7VlwZYNSaINYnEuAgd0yv9P8aTnIYA9Jw40xpmrW1gAGhh6aLsPv7uGO/4XsorX7pll/DlUrhgUz50iT3O4+VMrDOnN5BUs16XDIIJxvfyGaSWrgYyShZZQn/rEQb7B/rwkNKLzGmuQE6o/4g4b+WgRN075dSlm3AhYCLZ3iyOL/IKzhewsgmcgUUncybh3WCQ2fThJ6J5soINiqT3FT9rUiiiaW5VPp5cm5u1pezM4MKn0K1nW344IpPjwrWXydfIeJZtRgHa2KjwO3yYVXpdXCgXE9Q4OlgXm4y+0pTPeiw4ELFFBLl4di75q4WOe4RybYXweUtIrwzpYa6ubjdgIVVWA9qCSMb19K12r0cOzvjQpjY1BXw67yhxfHhfoP1UJzbtYAZRKS7N994UsphkYM6a4vNs/PYkaFP4N4KtstKWcVRN2vljnk7BB0S6sATVQY1iLK4q5j22T1SAUxz+alNTZBf/Jt83xNmbTFTjtS2r6VoSw+q2lWPQyAKC1f/LNWmtiNupb5aT+snMtalKtaE9qEGH/LUrRbeklik3KtOFGOi5atXDs7VPGhFhuobt6mccatq9Ue9ws5FC1hvSa/4m/kPm2bSW+pZcmAC8JQXsWOlMwotuiULNE2Njmxx8gxYLiEPOXDJnP/dsFzzTp5a8x48wh1cm3QQ89kxrAfWPfbFv4SmzuYJiefYWBo3kxFX4Uj3Me2X50+4drp0mAdHkJlsYifXa2ZIWNPpzU1uu+Js3zcAbQZrVx3twvSGczU6uXeZXvQN3VeZ8HnygUgFKYLbnOrkBAKpBeDuM5SP4c1E693UPMYBxSNVPo2kjwxSds09auKDthX8yigDsycQ+j75mdrPuu2xeM5T1UZ2kRI5c7dt60T0vUz37Hss565egcmBcWxL3hrq2hZD3tHfJZUKkRbNGLGHm7a5UnRarW8GfTPoBFStgKfP0Rv1L5Rnuh+E+Hfh/F5dspbb6SH2NQCoqvbsvD1Njju8jjJzR2CSX7fXvwftyWpersLjyF58g3FeY0Na43iNUNkE2zcXGs2cYXgA0eTjB6DoqfBdH+2Ji7ur7h1UDCY4Ricks8xaDmqS4ipI3Kq/v/sB2FhzCIfggu+xtxk/srQ5+EnNA5ouhilheWH55jkHDwjJq/c3QMe5dFBeekW8N9SDsjb8eEfyKO4b3pTqKeqVXdtdZZjDHzTkZAl3iR31vuQsU/Gov3Bx9+08VECx5LK+Q== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f0d60b5d-e573-469e-a7eb-08dc8825bcbd X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jun 2024 01:44:44.2971 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXP250MB0494 Subject: [FFmpeg-devel] [PATCH 1/3] api/api-band-test: Remove write-only variable X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: kHz03ZgRgYiT Besides being write only it had the wrong type: An uint8_t is definitely not enough to store the size of these buffers. Signed-off-by: Andreas Rheinhardt --- tests/api/api-band-test.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/tests/api/api-band-test.c b/tests/api/api-band-test.c index bbaa6edb58..d40e31b850 100644 --- a/tests/api/api-band-test.c +++ b/tests/api/api-band-test.c @@ -31,7 +31,6 @@ #include "libavutil/imgutils.h" uint8_t *slice_byte_buffer; -uint8_t slice_byte_buffer_size; int draw_horiz_band_called; static void draw_horiz_band(AVCodecContext *ctx, const AVFrame *fr, int offset[4], @@ -158,7 +157,6 @@ static int video_decode(const char *input_filename) return AVERROR(ENOMEM); } memset(slice_byte_buffer, 0, byte_buffer_size); - slice_byte_buffer_size = byte_buffer_size; result = 0; while (result >= 0) { From patchwork Sun Jun 9 01:45:47 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Rheinhardt X-Patchwork-Id: 49722 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a59:c209:0:b0:460:55fa:d5ed with SMTP id d9csp1817012vqo; Sat, 8 Jun 2024 18:46:05 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXHk9h3Rf+gl0Aap5vkN55OAu5YISOQ82kGNdodLllFupE1XuQvTsZIbXF9DWcs+lpoan9eZ15uabI3pCGOMKPmvBPFN2ttNWcOQw== X-Google-Smtp-Source: AGHT+IH5d3SYen/Fy5XrwzObPxxGS8T9rZnU3qU1gGHaNWO5OXvT9eb6wyqHq6yRwmYxBxY8/IO7 X-Received: by 2002:a2e:3314:0:b0:2eb:e060:15a0 with SMTP id 38308e7fff4ca-2ebe060165dmr2807491fa.47.1717897565398; Sat, 08 Jun 2024 18:46:05 -0700 (PDT) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id 4fb4d7f45d1cf-57aae2663a3si3242202a12.582.2024.06.08.18.46.04; Sat, 08 Jun 2024 18:46:05 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@outlook.com header.s=selector1 header.b=tWuLAJZ3; arc=fail (body hash mismatch); spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=outlook.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D00B968D746; Sun, 9 Jun 2024 04:46:02 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02olkn2022.outbound.protection.outlook.com [40.92.49.22]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7126268D72C for ; Sun, 9 Jun 2024 04:45:56 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GzEvbEUoIR59F6Gxtx9Fz0r0ivpR81cTmuAJ0CULt+8mdKUC2TqwlRZmjSp/S4trFY5FQ33heDdPVZ0+CZzx7EnJJHmj03aW352bodX/5p3fvPgauzkEGipvp67t/3ASzU0rdTmPe1VU4AfQuRAXecqn+s1ooghOqr3bWt3g62+5LgwxFc8QjbdfwoRplORY9XHvPWWTaC9y33zblvO8Dg3LDtSqKmTbBtmqYcSA8du57OJZDYlbbX+Mw1/qMCPeY6aypwtphOHI3KKI+9dloEQIh+QfYALq36CQpWKTnGwCVImwViYBBY/sQT/mddNVLa3t92MN0Vsfj07jImga6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=E9GEWTuAmb0fGZg91JgdbpgQwUdNGRPEPwCwfhKjk/Q=; b=fYpLRJAlb5eXflxTdu9QZ/u6eNWPaGT7vWZOHY7kr0wQJAgIFnMzOH+amRWgdNNeOTGHAm3a0E+LP00qT/eEuRL/W+v66cf749AcvkLHFAbglhm6XO0ZO1bjBus/rIEBTaGQS1UCOpXTcIYbkqbRsFu+Wcb80CNcRe8pqnHIVBkzxsXRiaBAforYDNtMwk6bMcscGLhxUndLGSalzIggwHaS1UDEIAKrnQ5/nR7ph0YNWRjGrjq/+X9ZpXE5oXbgeNjR8FFWFNq0M5xwHda3DmOkRMyC0B2U+WPJ3KgpmoFCzAZ09O7yxR4kOSBCz4hoy1EnwSIsgq/1fRhKCsPkLg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=E9GEWTuAmb0fGZg91JgdbpgQwUdNGRPEPwCwfhKjk/Q=; b=tWuLAJZ3pTsFw0nNoHuleIZYjubelU5qJEQeGHeKUzxZt5Q9Dt6jgWXgPi0HqCRDk7oyxbgykAwdCZHvD1uSgluzoRsKFLHw9duOTvab3P4s56N6YXBtu8Ar4opzpGpwS8xZwpjlqv4mhVUisVoqNXwC+1AvR4sdOp/yFW5yEZts2rVs2EeZyapwHDS6DElFyD8ivbHcf5fUT3e2bMtOJ2gDjmxkgYq4TZ3YALdNPmhbp9s8uxX2gdm3Ops+lOdg91JJGRgOB186a1udhR2kX+0l+Zd8fHz8CiQVTuLTAcyTCiIy3s7e4plVpX79hUSvcdfqvLJYSF+0oXOUPaWRWQ== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by PAXP250MB0494.EURP250.PROD.OUTLOOK.COM (2603:10a6:102:28d::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.36; Sun, 9 Jun 2024 01:45:55 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::384d:40d4:ecb7:1c9]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::384d:40d4:ecb7:1c9%4]) with mapi id 15.20.7633.021; Sun, 9 Jun 2024 01:45:54 +0000 From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Sun, 9 Jun 2024 03:45:47 +0200 Message-ID: X-Mailer: git-send-email 2.40.1 In-Reply-To: References: X-TMN: [+5M8nOin1TJZbcjMlPJSRXSi0aEZDJ/KndV+GAZJGGs=] X-ClientProxiedBy: FR4P281CA0017.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:c9::13) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: <20240609014548.2857665-1-andreas.rheinhardt@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|PAXP250MB0494:EE_ X-MS-Office365-Filtering-Correlation-Id: 218458df-5539-4533-5cf3-08dc8825e6da X-Microsoft-Antispam: BCL:0; ARA:14566002|461199019|440099019|3412199016|1710799017; X-Microsoft-Antispam-Message-Info: xtlmjzBkFHNHUZxKhGm2xnQYwXk83/yGPtVP/Hz+OJhY90M6GLxy9Lwo4Uix0Ik+yR0gcwgdYt8+/teji6aG6Wq9y8UFk+CvVcoERsnqHopQHxOLkdPZSYklMewTgDB2XOuL6nlANoGacJf3djMiv51DtOcgLE8DLdsVp57Pq6CQ8ArYFwFYGKOwcLZRi1u+JCDq7hgsQ+fUMB3DEkLEKppoPOBMUBWWr+1GRvkiD6Os8MtOU5yVxeMzZuGfrWaBTTOZsB1XbovPIvkmQjCPDcvG+bk5RGixMHv3TnSMtf4YZ+D2pr0+n3w81heT6ynML2YQObW2DJ5xqvADZLmKD+f3ZnVhMk8CljdNpxJb5PyMCW5kblZuAF2G8G2FaN8QFtois/5yavetq6gHx9/NSV6AhYxHf8+0EkIYV+/MO5lxTOcMUg18gqRBT2Qvo9hO9PwKZlpY8p+j8P9+z1oxLUdYCPP2/SM8/qhYAg8Q74sp79GwJBXl41GtHt9UVR8MeeLLWwHDxmY0tdHsFbSeuh9BI6P4A2CSdxTZM3wxjN2Hev0Xz73fBrpfe6WslAb2gMhhlU6JmuIzrPH7YZrVxtpxBDU8qM3lmp7HMstnuK5eXdb/ymPlZKuZMOZkr3wE X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: j9hYZWpUXwA/9muZiSTFO2KUfKMpTRuMML6Fv3hHhZiEARqystWeJ71nQHPUgr8VvoEmpNEslQoWOkv/wlsJBpki6ajlqtJA1wb+wSL3te5pagbMTyMnNCUbFXYyw/jY9tST0PJZ5ktFyfsiZeQPuLKcNlfOIWi07xt0Q7R0k1OHyK5368YLgbOBr7w7XyZfNDvePjdmBZTMLrmK3Hb4LlmxeKJNNImJP+w6fW4fvRo0bem2sjXKEaYqzov60eCNFs7Ehc5/aFGjmXlTl7MHzSDSoSA7LCk5uYBUo5i4L5NiVZcbr8wo9PC9orHGbwH1YeJUHlrM/x2BRg/SqkVDOuDQTFkU14A6XGaHv8+tHdmkmyoGTjoZx4CDA6Oj1+hi3/BmGUFYCYsQwtUr9V0IpXAXvdOHueN28eZrejxRitiJ5KLUeXx3QIKh/2XFo4XWM9ZFp3SjfVvoQf99rAOePU8qwVBm2nNeL+RO8FSkwTLjkjCquxfWCMOr5ozJ11hyASR/usUfGJBIQ/rVmGSMF2RPdoh4nfF3EkMYYBj2noiu7SWCCeQesCBw86btgSKJperxtuhQ+RvoS2uL+27s6pu6yCX87FXGdHwHT3DmC6apNeq4sdsfi9Cg4nC8E0Gj4pArKPmtYFTu1w9eo8UGFuylEI1wN4Yo7+RdmpkF2leX7psUnXEwIiYOTUg9jDDXhKq7Pcr3jPB46qy6d4RqPzSWyWtw40D9ii5oYnnoYFn70n6Wq3j8ceddgfF5HD46VGAvmswedyeY+KfDdlcxr7mXi0elkHPjFKuCHgn9KEr01CumvP9V1zInZ9h2gxStRTiaTJAGZTGvwo2YElBwfekedfpMSm+23sMfbEdGZMC9uvw3J0Yt/EpsiP0U7O3Dp455HTa7Y3zMejsD2Ocs5gWOBBVDOpnLnV8zb7IiJ2xHddux8dQlmB/u/yx1vVzvZskeCDo5Gch50ZgFW23CVC+3+/5lJkLlIITu0UXx/RnvIDMTPVXAkZOHJxEbABp3n+bOz2tdQ4BaUAkBtdFhFdMxRpsYzK2/b5LnK7IECOlECUnyA2+eqLa1eitM7Tt8DWdkoKDZPFExmL/i68DU3ZeuMxIyJojicsmDGU+BDKLKu5XGUs2h6uSiA+81RR8UrAFr2Dq4idz+mVN2549CECYqKrTk3ibqd7BoJEJPFvAqWZ/tZkK9UYxe6m6dyEQd9GOnaT5gnhC2jub71vjpjZ3c1a1XlCNGAbYqLjc4EdhWmDdissiOagqOTHd+vtbK0gzTTQ5prW4Doi9KVCPlbw== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 218458df-5539-4533-5cf3-08dc8825e6da X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jun 2024 01:45:54.9410 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXP250MB0494 Subject: [FFmpeg-devel] [PATCH 2/3] api/api-band-test: Perform codec admissibility check earlier X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: LbzTvglRotRT Signed-off-by: Andreas Rheinhardt --- tests/api/api-band-test.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tests/api/api-band-test.c b/tests/api/api-band-test.c index d40e31b850..e088d0854a 100644 --- a/tests/api/api-band-test.c +++ b/tests/api/api-band-test.c @@ -106,6 +106,11 @@ static int video_decode(const char *input_filename) return -1; } + if (strcmp(codec->name, "flv") && strcmp(codec->name, "mpeg4") && strcmp(codec->name, "huffyuv")) { + av_log(NULL, AV_LOG_ERROR, "Wrong codec\n"); + return -1; + } + ctx = avcodec_alloc_context3(codec); if (!ctx) { av_log(NULL, AV_LOG_ERROR, "Can't allocate decoder context\n"); @@ -139,11 +144,6 @@ static int video_decode(const char *input_filename) return AVERROR(ENOMEM); } - if (strcmp(codec->name, "flv") && strcmp(codec->name, "mpeg4") && strcmp(codec->name, "huffyuv")) { - av_log(NULL, AV_LOG_ERROR, "Wrong codec\n"); - return -1; - } - byte_buffer_size = av_image_get_buffer_size(ctx->pix_fmt, ctx->width, ctx->height, 32); byte_buffer = av_malloc(byte_buffer_size); if (!byte_buffer) { From patchwork Sun Jun 9 01:45:48 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Rheinhardt X-Patchwork-Id: 49723 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a59:c209:0:b0:460:55fa:d5ed with SMTP id d9csp1817042vqo; Sat, 8 Jun 2024 18:46:14 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUhAs4upWD3CZVNO1spAVBBoazZWBRt73XJ14I5CkDCe1L1o1NK8ZqMp+KQdjn+eCxhz7mgoKhD+gFhQgbNYrV+3OuSPG07IbUM7A== X-Google-Smtp-Source: AGHT+IEkQwKhzPhM4NUILTby+RINYuD0B8au/HKgZOxGumOCtAtWjFiVmeTj23NN6KIgHHX2m2a2 X-Received: by 2002:a50:cd1c:0:b0:57c:73ff:d13e with SMTP id 4fb4d7f45d1cf-57c73ffd1b2mr832533a12.31.1717897574339; Sat, 08 Jun 2024 18:46:14 -0700 (PDT) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id 4fb4d7f45d1cf-57aae28bf67si3286464a12.630.2024.06.08.18.46.13; Sat, 08 Jun 2024 18:46:14 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@outlook.com header.s=selector1 header.b=k8rl6V9B; arc=fail (body hash mismatch); spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=outlook.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5217268D753; Sun, 9 Jun 2024 04:46:08 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02olkn2022.outbound.protection.outlook.com [40.92.49.22]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8F6BC68D74C for ; Sun, 9 Jun 2024 04:46:01 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JBEXIqI4+4w7yFrU+PbkzfbFKRqbIUfKXjgoTRJVSSPIfDbxuus8+10v578NBYcAIBC8ezon+CPcHnUn/Nsyae3qDpwRSa8CKiMdDkO8ogmaMvgmfACN2l78XdimI52CbbX7tZ6A9Y8SCd4TAn6mE0hQaoOoUNxInF1RcW3OxRMIHZDFvVNmdCpXQOXwu8hBl1u0XxzuhJAeIZVbbxbN9gKQr558jqjoW7+daRmJ4QIVZt7lI6EnTwtxV/uwBmP5L4GHF0KBo0ZZ+TF7JY4qe/z8HXCCoL3daiYlDzYt1n4gop9Cm2J3YC40j1n5Iu05Yra5AW7ycec7PMeaVV4bXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Kisy3lyAp4e0A+KoYXDZjGz16/4vtuvK0eE1FzHh+uM=; b=PyPH6xiUqUUV5lUyYjgNsUj5//dqQmYpPlPQE8MtEvDZgzm8cQ+sgUq+/NTK7zLMDXmLjcgb9isW8bsNqXO4+/qjZzHeUwoEmV4BhIiJJuLVr4NgLiRHA76obiZL38j4Yrvj6N1JKMItpDIK4XlVBk+UtFzcURQ05+kwLyd+Iiad1xzQR0wkvtYpWo70shpr2bIxTFLJ8rDPi1UtDGOE6ar2yyi4NPLfistcTw+iMBOsqMkWn9vPQTTwYM9rSaTRY5kCx3yuionszWn5OShZ9u4OHgHR7TSobkxVlTq/qA54voG1rtGzRIhrwS9C7J4PQssBIooZthjOF0VVX1rMNQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Kisy3lyAp4e0A+KoYXDZjGz16/4vtuvK0eE1FzHh+uM=; b=k8rl6V9B9wmktYlrSveATEMvD+Gi3O5HL/Q4akGL6N60IvvnAotSNvQlevQDNpm/ddzpS+v/NJofBjpsLVGnFEMjw/xpx6fNCiDGs1EC7VRDEXBP5CH1p66U2Z/9XmN+Df92qjqygvX72vRGz1Zxe2aLDnOtSLxbvtTKQmaCzArCFObVrxWxGLrurrhEmLvW+vgA3XIDzGZLJYd/gJTmWNmiz3n+6kWQf+/KQLZ+BJ6ExcihcV4Zljcl6UEuMarAsA7Tyu0mQKAj0Sj4nmShEOHhitc3WSYuai/9xq+FJhmu82W6siS5Xss/j2iDIMSt6jXkaIrMCYobH3GY8m301w== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by PAXP250MB0494.EURP250.PROD.OUTLOOK.COM (2603:10a6:102:28d::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.36; Sun, 9 Jun 2024 01:45:57 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::384d:40d4:ecb7:1c9]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::384d:40d4:ecb7:1c9%4]) with mapi id 15.20.7633.021; Sun, 9 Jun 2024 01:45:57 +0000 From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Sun, 9 Jun 2024 03:45:48 +0200 Message-ID: X-Mailer: git-send-email 2.40.1 In-Reply-To: References: X-TMN: [wdHjOtJNpN5uCLQfVRTf0bcnwF62Slh1clnKQu7a/sI=] X-ClientProxiedBy: FR4P281CA0017.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:c9::13) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: <20240609014548.2857665-2-andreas.rheinhardt@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P250MB0744:EE_|PAXP250MB0494:EE_ X-MS-Office365-Filtering-Correlation-Id: 5b3418dc-015d-4d4e-3092-08dc8825e822 X-Microsoft-Antispam: BCL:0; ARA:14566002|461199019|440099019|3412199016|1710799017; X-Microsoft-Antispam-Message-Info: 2IPNb7BElgpiTS+8OJHjLg56WX3T/AsN7bwTzpp6D73keKfgN8/NxSq4O1G50na1NFDFSKY9qv+9RIqOwZZPeghVFimBhpsgPenRroTQzEcNnRv5EwnNYwmeFYBIB7/b6UP1vwNZA/VVBnAAr10E1iyn83MgVhYzxxiRMTt8uWIb+3Mm/Sxj1w91UvvWcK0hOXEjLfe6BuYbhnBEWwfB2NDUFAddlbKDAdULHQsdMAvW6p77StJ5csap0PQxdPRa3mLHMO0VUlf3hXF55OFVwQ+Bz1H9sIrknJ95slB7+Ww+cDdrMCFcKKPOSfNdAnjS/5PZfbw5UTlWTiGxMFs30ekDS6By8PObju4TNQIi8hhxEgWlc4dnA2DXe4bNT8Ewf+Y/5tbtRAS+Imwnecq+le1U/iX+9biaN2dHFN1azU8BOfxjxCIl8XRP8QePdYf7HDAGsduMCZNwxJSd9aWZ9ALz9BywYW97nlx43IJCed+6CWBSPgljSH9kxDyqHwQb1MPshi78Ur6aBnujc1G4/VRAJO9Q2GiaiLjnbECzXtjIGZjnDXU58NsDZD9AYCNzQyHZT+nNHcuuS7/w1twVHXMGvAAxBDv1nqjXXl7Xe/U= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: RbNPikHdpHvJpguSexJQ4dzH88oDjrhuDwn/RCSBa6gZORvclQU2cuUF/K+Ve28+WMWLHoS+5lbanFdWupVio+1sTytMFaShP068OLtJovAFcZ1pcZPMjBxW2pmXfra/yAHDr9is6Fbis45oEJrwRuuAZeWxAYCVFwKp9jahcetpg4pjVS3zmr3rs8dKcxV0E+2jK6T00rBUCXUZlwtaBcPuhkZV2fQwpmQGZ3755tXoXPZhABk6hFV4RVD9GFCDvpXTvF7DC6tOEiMXfptYVJwwY3FIYRuhiudOTo2ma48MN/LS6f1bl+Df+jeSJCnJdQKaTJL0Drvpy4rTwHDP7QTS8epuhR37bf6q/SkqvxWExJInG9pZeapkPeJ+0FB2zrOh0dSsUDPsTm3+fuGKo8a6mqJKHAjgPdobOOFY5QLHd50BDpwYi7X3dEgFU5WajRjJLlj85wZAe6N40yHQDwP4K6NEdzop4Otg6za7/HEhCKgMnUFNc1629OTbKPo5TWgss+TDlQSd3ESj9TZicLdC96GXN83VxMbFl1tGGNqAc1WuXuGQ1DpavjUyKX/vSSO4eaFult/+OJxtWdeY8gmeBkoNz3LB8mPSDIzxkftN/9MBqGwi6+gmsA6upmqalScf5Aq323G1JStq+7tVfd68r9zhA9lrZ8QuFv/ByjBmWq2JqRDyR3vliuWAqwbpogaediad2OYJzcuo8FUr9/y6OlNTUs12EXOBWby0C8P+BKHjWstzBT+gCVcMPCxLxIObcKxfWq+fkDXycXwZIKBJt8/A+Tb2kjTDiHeuYrBoNML5ug+8KgAIl2bOY6yeAEmrCQHeCCwC/K+VE+9Dn+IrJVbj/8Nlq7RTI3ogSdy8MYqkPtdYKzNsx+D/wbzGCeFa0iwkCLoyYVgoPXaiHwhxS7/BQyB7uqmCiahlWimpYeA1wG/SwZRtHJ/Bw3SioIGGVhZ/HycozOwy9ABSaLgXzRCjPgIn4k+RgcyhykIr5XMzWkBCMNMHTDkdw6Rf8lxB3xc3o89H7CmTPvwP4bPKd5MCuXcAu3ojQ97Jn8vMe3g/YhWV9u131g8qOzTzNw0eWyGtT8t4E+r1rxrGx3/KZrIwyq4T7+bsdF0h9kMCvurvA5M/592lG6EqTvhEYqp10V6fJlFNM1P/G6ahl9cEoD8W/j3j0hIso2DWqn30ijIocrro+OpmHBjeMAvB5n9H6IjhjkxtynJXVs+B6BkO//XcP584EutqjAW/7VQKQ+bsaA7A7FKnoTcD7ZNaa8vzkmd2xdT2lJ4hSCS9cw== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5b3418dc-015d-4d4e-3092-08dc8825e822 X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jun 2024 01:45:57.0955 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXP250MB0494 Subject: [FFmpeg-devel] [PATCH 3/3] api/api-band-test: Query codec capabilities to decide admissibility X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: +1IpgQqzUt1m Signed-off-by: Andreas Rheinhardt --- tests/api/api-band-test.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/api/api-band-test.c b/tests/api/api-band-test.c index e088d0854a..c3612bedb9 100644 --- a/tests/api/api-band-test.c +++ b/tests/api/api-band-test.c @@ -106,8 +106,8 @@ static int video_decode(const char *input_filename) return -1; } - if (strcmp(codec->name, "flv") && strcmp(codec->name, "mpeg4") && strcmp(codec->name, "huffyuv")) { - av_log(NULL, AV_LOG_ERROR, "Wrong codec\n"); + if (!(codec->capabilities & AV_CODEC_CAP_DRAW_HORIZ_BAND)) { + av_log(NULL, AV_LOG_ERROR, "Codec does not support draw_horiz_band\n"); return -1; } @@ -222,7 +222,7 @@ int main(int argc, char **argv) { if (argc < 2) { - av_log(NULL, AV_LOG_ERROR, "Incorrect input: expected %s \nNote that test works only for huffyuv, flv and mpeg4 decoders\n", argv[0]); + av_log(NULL, AV_LOG_ERROR, "Incorrect input: expected %s \n", argv[0]); return 1; }