From patchwork Thu Jul 25 08:25:04 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Martin_Storsj=C3=B6?= X-Patchwork-Id: 50724 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a59:cc0a:0:b0:482:c625:d099 with SMTP id h10csp387158vqv; Thu, 25 Jul 2024 01:25:18 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUr3n+B0lZIJfNGOu4YeKCATlbKsZMk2tk0mXLY5/PulUpPTi5nF8duU+Ke95fEzoVWEHJMTcdIVRW6SsA83r0BYB7EiLbJ0dSPTg== X-Google-Smtp-Source: AGHT+IHeQwepttI5fewMQltdbNR2c5na0EehIkh0rp3rP9bUzIJMvfg6pBQEllmrCERkjp9Gtc3q X-Received: by 2002:a05:6512:31cc:b0:52c:8abe:51fb with SMTP id 2adb3069b0e04-52fd3ef705cmr1645343e87.10.1721895917923; Thu, 25 Jul 2024 01:25:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1721895917; cv=none; d=google.com; s=arc-20160816; b=aQbj+5Rc0bGNanEFS8+uXX80IufcPE9B5lHxNli6OxrKq6RVQx5ewAjUFF3LitNCuT nm9lLoOsyNx5gGWv8JwLOCWo5M9RUfdeER3xMwY7mBWKj3DBCfwoqIKZHIyyPgPz/nS8 zhPahFTuJzWVo4Ij/e99/xzVqWVSfH/xbYQ3EviWDKKhxeh8Mf4Y0tkNWG0jJCNOf1hP hun7E4SEzAXj1PtHPOn5h88kQs66Ou2ZpVF4QpUD6O3kporcKi2xjQOjzS5ml3dnD3lY LxYtJ6NkNYPwRNpWTb9pUg7AKUuYY0Laufw9y3gNNAPlV9T+DVNKdj9ZBwaY3guu0gLA tcGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:message-id:date:to:from :dkim-signature:delivered-to; bh=4PKCy2nS7HbHMa9jK7RycvVlncrDyjpHTrgnmrxVMjk=; fh=YOA8vD9MJZuwZ71F/05pj6KdCjf6jQRmzLS+CATXUQk=; b=X5ZoPhLrNehJAFDfq3hc7iZuVtzpuUf95/WHBPtGlKyBggoP+an4aftnkAV3Xng+dn dGM5sKsquz2T9Ma3bivEs4FWNiEFo+hNxfP7tjx8PPsU9Hw1TOwCDTkfa5f3lyVb3T/M feMhn3sEnDCTmX/CJghHL7i30jNG83F8PULdRCSHVKDpiv/nf0Kyt6Acb5QAKDc+KxR7 VkbkyG9/tKvbJ3uYaBRvgGu4k+TcVkMsryqqTWWf7Bkp2RXdFzasU5EA4ug32cXKW30X /1sHOJvLyPoGgEm1kQqCnlG0wJhaOC6pdMj3KLYcHT9WyACRyn6uC+zz5Ijy3rHyVMqu QUcw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@martin-st.20230601.gappssmtp.com header.s=20230601 header.b=z3GOrckx; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dara=fail header.i=@gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id 2adb3069b0e04-52fd5c05d2esi335909e87.525.2024.07.25.01.25.17; Thu, 25 Jul 2024 01:25:17 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@martin-st.20230601.gappssmtp.com header.s=20230601 header.b=z3GOrckx; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dara=fail header.i=@gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 30F0A68D3E5; Thu, 25 Jul 2024 11:25:13 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com [209.85.208.171]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B311868CC49 for ; Thu, 25 Jul 2024 11:25:06 +0300 (EEST) Received: by mail-lj1-f171.google.com with SMTP id 38308e7fff4ca-2ef32fea28dso7069201fa.2 for ; Thu, 25 Jul 2024 01:25:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=martin-st.20230601.gappssmtp.com; s=20230601; t=1721895905; x=1722500705; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=4VZOKz/qAfeQ2SRW99SbEum9FQZwFXh1ATJo6nbJZ9Q=; b=z3GOrckx/FqLSzhr0ecT6lOMlSJaL2zhQTEaqXhTRbizsprTJ75dtMY/k63crmmaw9 CWGoMaMWAavjAzNxg3OhHKnwdoABozncGZYDdMWPsqulQm8FVNpkSoJ0EWVY3PGRrO06 HYyQZ9HnDEbJ9Z/mnndxi/XFnZaRVKC0D0ELywLGDJEBJ42AS+fHm5nDiohjFIJoMUyI A6jBbupK/zPI9f08hxcRtUVFLl6zpFgx7+NHLJPpAWoMnJLa1z63jYar1nYjxpvbkaoX VnP9ptNRTBDBf2qdRJDN5P478il9iYik/gWcR+AJ8d2z2N7SS7TrJB2gR8oVtm462wS4 l2Jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721895905; x=1722500705; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4VZOKz/qAfeQ2SRW99SbEum9FQZwFXh1ATJo6nbJZ9Q=; b=blzZLTw7GpVFRD2fZRA2uIBpEFxxlMKmnJeFU1wYzq6Bnjzswcn4Xeth1npSeF9D4x iXXophc5nxWGzAw8Ze3kwXRNHqF8mVb2W2CDNoKURsGGL+jEIWTbriOpGQ6Ncw6kTg6J 8fmjgcp1YF4VATnPoCB8Xv7DsbINBtG4x88xRCqciacelktWfJsLzrfjxs5paJoK3JxL VqiRRAUvJOg+upk9bHeqwfGr9A3NZCyH2cAp7FliXgAonKx8T4I9MhvSvQXp7yHjv9F+ 4C7a5DPY191UgRpyInOH3mbK8s2eII4oG4ooUMIv1b1LsR3nktaQiKSH2VVL6JFqIvoG jEIg== X-Gm-Message-State: AOJu0YzBEyqXLXsWArW2m+vpHpFdpUyFCGATKOr88CLovAdDPu1r8uK2 WrfmWEgL25JBKapgv5gmPqyuTMdQAi+VuFx36TUE8luo6u2mwEovAfhgVghgpry00xS+NPTb9DX AoQ== X-Received: by 2002:a2e:be0c:0:b0:2f0:3cff:30ce with SMTP id 38308e7fff4ca-2f03cff31ccmr11392871fa.0.1721895905273; Thu, 25 Jul 2024 01:25:05 -0700 (PDT) Received: from localhost (dsl-tkubng21-58c01c-243.dhcp.inet.fi. [88.192.28.243]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-2f03cf56483sm1304671fa.66.2024.07.25.01.25.04 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jul 2024 01:25:04 -0700 (PDT) From: =?utf-8?q?Martin_Storsj=C3=B6?= To: ffmpeg-devel@ffmpeg.org Date: Thu, 25 Jul 2024 11:25:04 +0300 Message-Id: <20240725082504.883576-1-martin@martin.st> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [GASPP PATCH] Omit the "-c" argument from the preprocessing command X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: HBKEcQv6mA6Q A command like "cc -c -E" is tautological; the -c is ignored, when we explicitly specify that we want to preprocess only. Since https://github.com/llvm/llvm-project/commit/6461e537815f7fa68cef06842505353cf5600e9c and https://github.com/llvm/llvm-project/pull/98607, Clang now warns about the unused "-c" argument in this case. We already did omit the "-c" argument when preprocessing (with cl.exe) for armasm, but do this for other cases as well. --- gas-preprocessor.pl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gas-preprocessor.pl b/gas-preprocessor.pl index 19b0131..aa3abc0 100755 --- a/gas-preprocessor.pl +++ b/gas-preprocessor.pl @@ -155,6 +155,8 @@ while ($index < $#preprocess_c_cmd) { $index++; } +@preprocess_c_cmd = grep ! /^-c$/, @preprocess_c_cmd; + my $tempfile; if ($as_type ne "armasm") { @gcc_cmd = map { /\.[csS]$/ ? qw(-x assembler -) : $_ } @gcc_cmd; @@ -163,7 +165,6 @@ if ($as_type ne "armasm") { # Clang warns about unused -D parameters when invoked with "-x assembler". @gcc_cmd = grep ! /^-D/, @gcc_cmd; } else { - @preprocess_c_cmd = grep ! /^-c$/, @preprocess_c_cmd; @preprocess_c_cmd = grep ! /^-m/, @preprocess_c_cmd; @preprocess_c_cmd = grep ! /^-G/, @preprocess_c_cmd;