From patchwork Thu Jul 25 14:35:17 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?R=C3=A9mi_Denis-Courmont?= X-Patchwork-Id: 50730 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a59:cc0a:0:b0:482:c625:d099 with SMTP id h10csp590824vqv; Thu, 25 Jul 2024 07:35:31 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUWwKRHKiCxiBt9r1VUff7hlgMl/+BnWEv2R9hYmhJNzwCjeVrUP1hbIQnwXIPS6pp1JOKXz1iNl5w4LMI0NkPWpGNmvCOL5R6YLA== X-Google-Smtp-Source: AGHT+IHZsH1ICJSa/0BUGU2vszQ9pTy2gxsD5fkPxEmuscP9ZWQjJ06WTvl/Dk45gFqQf1ea0TV/ X-Received: by 2002:a50:d746:0:b0:5a1:e7e6:ce37 with SMTP id 4fb4d7f45d1cf-5ac2c0cfca5mr1873247a12.26.1721918130953; Thu, 25 Jul 2024 07:35:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1721918130; cv=none; d=google.com; s=arc-20160816; b=O6JbgtfBAH9mZ6Iyu8LiqE1cHmDHLQMw/Xgk6KILed+YT6RsESrqR/dAIMTOrwEgCI xRoy5YD4DVIpjqlwDNK0k84HQZgPippaxc7CztO4YsvDgG8COYi1oySe6NjMpMkdfT2g owz0hecp9QgbagCNmXyL3xejzAka3YF0RHxX1YgrboMYHOPT5PNVc2rM4Ths7ZFI1eBJ MQ7WPNshLwYC6FvCF1V9S9rwG6sljBV/2pz4z2Y/WN9IAZRAHIVHS5CFjqBgx+8Ey1OG 3MzLrsT0vPiHRFZrT6PsbMQ1pV+CidK2iKOw++3iPFiGsPgXqKebFkuQ/KZbr/lWpFGC SULg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:message-id:date:to:from :delivered-to; bh=GCL3gTyE/Al3VDjLOWElCE4uZ1nWw/ZmQCjAQgcov9E=; fh=YOA8vD9MJZuwZ71F/05pj6KdCjf6jQRmzLS+CATXUQk=; b=gnvRtz+9nUT1BXv3pB0QFYUHiGRYz0vD/L3kYYDo0L8Wij4vkgOkvhxeI2KPcsKaQK udd9FBd2wo6eNzCNbW5kVV8rBygOTROlsPHgIKZeBy3xewRN4t+6De8vRFqC+YDEHN5H yKo1KrQRL9Iva5k+MYArSNy0uO5fkBF/IaqRr7Dpf5r2s4khcMz4hgYDTLNu6L7lMkPm gxy6B8Ag+nZzL9lBh1CHtAakSZ6stIwAXlAmdAVHSxsAkhjPf3UT9v2kHdofPl7nY3hq ssexr/cBSx8l3sj9uVYJuCAlmUAJkXAbOImor0GigQqc6hp3V0f16F58NC0Pbk1saEU3 jXAw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id 4fb4d7f45d1cf-5ac637809d7si1139378a12.193.2024.07.25.07.35.29; Thu, 25 Jul 2024 07:35:30 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5BED168D6B8; Thu, 25 Jul 2024 17:35:27 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from ursule.remlab.net (vps-a2bccee9.vps.ovh.net [51.75.19.47]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E283D68D628 for ; Thu, 25 Jul 2024 17:35:18 +0300 (EEST) Received: from basile.remlab.net (localhost [IPv6:::1]) by ursule.remlab.net (Postfix) with ESMTP id 2CB48C013B for ; Thu, 25 Jul 2024 17:35:18 +0300 (EEST) From: =?utf-8?q?R=C3=A9mi_Denis-Courmont?= To: ffmpeg-devel@ffmpeg.org Date: Thu, 25 Jul 2024 17:35:17 +0300 Message-ID: <20240725143517.12683-1-remi@remlab.net> X-Mailer: git-send-email 2.45.2 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] lavc/riscv: don't set vxrm if unnecessary X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: 3w6odOP+5ZWo While narrowing clip is nominally a rounding operation, the rounding mode has no arithmetic consequence if the right shift is by zero bits. --- libavcodec/riscv/h263dsp_rvv.S | 5 ++--- libavcodec/riscv/vp8dsp_rvv.S | 1 - 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/libavcodec/riscv/h263dsp_rvv.S b/libavcodec/riscv/h263dsp_rvv.S index 97503d527c..2a57284e4b 100644 --- a/libavcodec/riscv/h263dsp_rvv.S +++ b/libavcodec/riscv/h263dsp_rvv.S @@ -30,14 +30,13 @@ func ff_h263_h_loop_filter_rvv, zve32x vssseg4e8.v v8, (a0), a1 ret 1: - csrwi vxrm, 0 -2: auipc t1, %pcrel_hi(ff_h263_loop_filter_strength) + auipc t1, %pcrel_hi(ff_h263_loop_filter_strength) vwsubu.vv v14, v10, v9 # p2 - p1 add t1, t1, a2 vwsubu.vv v12, v8, v11 # p0 - p3 vsetvli zero, zero, e16, m1, ta, mu vsll.vi v14, v14, 2 - lbu t1, %pcrel_lo(2b)(t1) # strength + lbu t1, %pcrel_lo(1b)(t1) # strength vadd.vv v16, v12, v14 # Divide by 8 toward 0. v16 is a signed 10-bit value at this point. vsrl.vi v18, v16, 16 - 3 # v18 = (v16 < 0) ? 7 : 0 diff --git a/libavcodec/riscv/vp8dsp_rvv.S b/libavcodec/riscv/vp8dsp_rvv.S index 7e062d9f13..e50e27ce82 100644 --- a/libavcodec/riscv/vp8dsp_rvv.S +++ b/libavcodec/riscv/vp8dsp_rvv.S @@ -166,7 +166,6 @@ endfunc # a3 = DC func ff_vp78_idct_dc_add_rvv, zve32x - csrwi vxrm, 0 vsetivli zero, 4, e8, mf4, ta, ma sh zero, (a1) vlse32.v v8, (a0), a2