From patchwork Mon Aug 19 08:39:52 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Martin_Storsj=C3=B6?= X-Patchwork-Id: 51078 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a59:b6ca:0:b0:48e:c0f8:d0de with SMTP id s10csp1785446vqj; Mon, 19 Aug 2024 01:40:06 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCV6Fl0qYCGEGpppclktqEW7la3Js1Xqf9ytSsebrmaeWYYwXDmLRoUHxSMNEIPvspoFEkVOCvTwtAOQUGb+TlFFu64bD/DkbOXn7Q== X-Google-Smtp-Source: AGHT+IEBCmvcBGt0uK/DZ4EtFmK3L2DfbDxDJBJtKJxKUWH+KeycyzN30W2qxt3DhiW0+K3uM2SD X-Received: by 2002:a17:907:7208:b0:a7a:9d1e:3b25 with SMTP id a640c23a62f3a-a83aa01c56dmr409262766b.30.1724056806044; Mon, 19 Aug 2024 01:40:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1724056806; cv=none; d=google.com; s=arc-20160816; b=NwW7jFubCjLpb8CyHhSwXsfKPWeniIhS91uv7BQnmW3uBRpsGi12fAus6MQ9VJ2inG aPUXBvJcbCaAWk8VwGz4XnrodcGqq9n6+TWGWoFsSUFB7rNzsG+xTQ2YlTp87znA7zAx 8DfRjVe3dQYvVG/XUzzlsPgwFMD/fgbRasIqf4Lx3WNhdwidi0QWYenkjs0uxqA/9Zts 1bexHH2krTnYUGZUIeH8JFDWmIbQw1UkdYAn4g8EiVuFmtOVYYoaHXXKw79QZkKgXxQ9 HQ9AbFr3mvATPIrZ224RspJyNZlOuWLKj4Oz7IeXdckLfzhMOQRQCnb6yWcfTZhuB5pJ wtxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:message-id:date:to:from :dkim-signature:delivered-to; bh=TT59TZI8JEySLbMxR/ERtAcE35Kd9iGKyqjiGR4E3qI=; fh=YOA8vD9MJZuwZ71F/05pj6KdCjf6jQRmzLS+CATXUQk=; b=SRRiJpkGiM4vGmyJ9+VJXKeV+h0Dr4yG+tqpMajdfRIybvRomhr3OUEtzhPZo0x+Qf xM3AR4zgzRvGASQbVVdDvWl07ihTzY4GvkrrmjVu165780f2Som8JtvTds4iYpWXLEhq sD/ZSmbdfygmZ5TZgfa6x76PgsPPMV84wjXTpIY2MBBbsG0iwXHAu3mVzHpDVm0MVDZs mYADyc4Ee3saA62p9TnFSYR4W0/Kk7thsIP4rvo5N+sruEGZQwbd7MCSpSoM5/pz8x/t 77dkyQIMXHp1BQUtMK8hXJh21XLzIkScYi4jh3JIE5J7IYqIKuysaaDSTzP3A1hzFAcl 6QDA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@martin-st.20230601.gappssmtp.com header.s=20230601 header.b=wpyDCx8T; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dara=fail header.i=@gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id a640c23a62f3a-a8383939056si519652266b.412.2024.08.19.01.40.05; Mon, 19 Aug 2024 01:40:06 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@martin-st.20230601.gappssmtp.com header.s=20230601 header.b=wpyDCx8T; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dara=fail header.i=@gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 71E4768DE3A; Mon, 19 Aug 2024 11:40:01 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0CA7668DC72 for ; Mon, 19 Aug 2024 11:39:54 +0300 (EEST) Received: by mail-lf1-f50.google.com with SMTP id 2adb3069b0e04-52f025ab3a7so5065426e87.2 for ; Mon, 19 Aug 2024 01:39:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=martin-st.20230601.gappssmtp.com; s=20230601; t=1724056794; x=1724661594; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=WytjEwY1BULwpWemO0vXvw1XsGeXCMkM2D+fm/UGmU4=; b=wpyDCx8Ts2WUxG84nXXFvn+atBve1vhaVgvsl6eas2ccM1RmmqvMGAYkXPneixilP7 j7L5yMf/kq/b/M2+fbvzgv8jCi8CP6hvoGEEPG4Phm0JT/dr81XDbPZOCQGorV5I+U7E gpPYAEmJAMPH/M35TqJPSSLWIL4OdFni6AezJShJwAmWWD2xTSD4JlB+OJHWVGObmXpB 4RoE7J+jaHOlrnR8L/O1yE4cHcXzXem9B0Oe2mO8Wj32yCi/4yU31DDcXRuK1erDOoo+ mWTjv2q4j4PSoLYJv+Ymgol/UmavtgXpDd1XzzspIfFWOHJeqLZrpxw90gpvJcAZmjOr s2kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724056794; x=1724661594; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WytjEwY1BULwpWemO0vXvw1XsGeXCMkM2D+fm/UGmU4=; b=cMXWWS+lbI8Nvel+bGhV5soaU0G7C1y6EMqaUvqqLyKi0MFcfRyLB2a2W/0dvKPLuP Nnm/BbQ64cMtGbc8u5F9PML+hdoK+2BuWVgrXfX3zLNBw362pgHpxEFFkfMM33gJZuz3 p0H3ACYeG74+/iZfLqfNqR32+9M/VtFzLL6DkJZTh2IsEfh09Fczf3EQI6b6POvqlBt+ LIlOwVupooaSXC0krSLboruZz9SGJanarEI0BiSxLpgAAAnSO3NvytVKzHJ5d1Si7D+n iz0Mq+YAi+mmK3Ns4cpmITPOCtDE4vdaZa0JbClBWFRUR+O6aM6sQdCQpmazynzZS9V7 a3Ug== X-Gm-Message-State: AOJu0YwUGmC3Uch2NZrJmYd3O+Z2aC3ZVFyXJDUtY7Q+zTl5d1bapZzS 86IJQXeHtp6qklkH8S3R9n0+NsrQyGrImNVHIvoyR04c8cdySOEZpHJ11NBCZ4AL/KoI5n3XWYp dUA== X-Received: by 2002:a05:6512:1243:b0:52f:c27b:d572 with SMTP id 2adb3069b0e04-5332e07fcd3mr4172271e87.59.1724056793286; Mon, 19 Aug 2024 01:39:53 -0700 (PDT) Received: from localhost (dsl-tkubng21-58c01c-243.dhcp.inet.fi. [88.192.28.243]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5330d3ff1e2sm1470335e87.138.2024.08.19.01.39.52 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Aug 2024 01:39:53 -0700 (PDT) From: =?utf-8?q?Martin_Storsj=C3=B6?= To: ffmpeg-devel@ffmpeg.org Date: Mon, 19 Aug 2024 11:39:52 +0300 Message-Id: <20240819083952.1390578-1-martin@martin.st> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] libswscale: arm: Don't assume aligned output in yuv2rgb functions X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: kHwuijok4rk0 This fixes failures in recently added checkasm tests. While the buffers in most cases are aligned, libswscale in general can't assume the output to be aligned. --- This fixes FATE failures like in http://fate.ffmpeg.org/report.cgi?time=20240819041749&slot=armv7-linux-gcc-9. --- libswscale/arm/yuv2rgb_neon.S | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libswscale/arm/yuv2rgb_neon.S b/libswscale/arm/yuv2rgb_neon.S index 10950e70b4..474465427d 100644 --- a/libswscale/arm/yuv2rgb_neon.S +++ b/libswscale/arm/yuv2rgb_neon.S @@ -75,8 +75,8 @@ vzip.8 d7, d11 @ d7 = G1G2G3G4G5G6G7G8 d11 = G9G10G11G12G13G14G15G16 vzip.8 d8, d12 @ d8 = B1B2B3B4B5B6B7B8 d12 = B9B10B11B12B13B14B15B16 vzip.8 d9, d13 @ d9 = A1A2A3A4A5A6A7A8 d13 = A9A10A11A12A13A14A15A16 - vst4.8 {q3, q4}, [\dst,:128]! - vst4.8 {q5, q6}, [\dst,:128]! + vst4.8 {q3, q4}, [\dst]! + vst4.8 {q5, q6}, [\dst]! .endm .macro process_1l_internal dst src ofmt