From patchwork Thu May 21 08:06:09 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Martin_Storsj=C3=B6?= X-Patchwork-Id: 19791 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 15F7B44BC77 for ; Thu, 21 May 2020 11:06:18 +0300 (EEST) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E8B1D68A43A; Thu, 21 May 2020 11:06:17 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-lj1-f193.google.com (mail-lj1-f193.google.com [209.85.208.193]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 627C1687FF5 for ; Thu, 21 May 2020 11:06:11 +0300 (EEST) Received: by mail-lj1-f193.google.com with SMTP id o14so7206555ljp.4 for ; Thu, 21 May 2020 01:06:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=martin-st.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id; bh=FqGM8cixR28gMVEFk3K6gEuFEwAe4nVk/gua/hC3krI=; b=O2LGN/6OM+d5L3fBpJWVBFE/b8nd+YyadH//UHW/hcxP6weu8SIpWFO/cJ2tM8IOQg t5J8w+u8TLUHhyR24gLukNeasrB0YavlttBgaA7ujWj5OxrpNC08W9r1tFl6OAdzZ1Dh U8IFd+FE+QOKsbeYKcZNJlwePZCZdwlRQoVUc+7y9ZxZecLDehD1UhpVivFJu5aQWc0s noSDF6zVAQuPLoT2nLlFEUp56LGbDniMR+nHz+HUIDHQYLRGC6Y86+t3QVPDHojHEAOC 5CmP9lXeHfc1LU6RLM+k5bQ0a2B5d7uwKUeFYy+dOhaZP8m32U6vFE0hg/WSjaXIyhXx EphQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=FqGM8cixR28gMVEFk3K6gEuFEwAe4nVk/gua/hC3krI=; b=Kc/Mm0ss/8c+q0SdVselS3snASHOl0idzDlQrNWGiqT8wjs73YhLPKkaqhsKDAtjwY YZQT1wtcihQk21+QCwEPsa721hBAzN6ZuOVowb2qtP9JK1OeDoGhmUfzkf/YF+NdDbvO 1Tiq11qSn37u/zj5SNRn0APc1yrpxvJZURLa8EQiOFVGTnRnFLrklZ/2z9cexBW849wu lK2a5y3iJRFvcPoahXZY81yGaBCdAfWe5zA5XoXDACLvM2rnowzE/Ag49w2cS0LKXTfs uM6hT8iyoR4y/dsLGiQLiPJkqvcavzNmaoYPPdfwwf7Ce8sl8QATxnoVET7cuo6E/HMo SD7w== X-Gm-Message-State: AOAM531LLRsj8NWghwfsPdKVHzMrVHKW4RmDfrgJc5rcVDLkz/L1p2uZ DWPxyOEF+7U/X7GIIWjAudb07SnH0gA= X-Google-Smtp-Source: ABdhPJz5TvjsRiZdjtOFphPTEGOpbY3QmwWmVOx1bFvzWW1AlbPYkBCqPManNY2Dc1ux1lkVONqWfA== X-Received: by 2002:a05:651c:118d:: with SMTP id w13mr2597282ljo.304.1590048370397; Thu, 21 May 2020 01:06:10 -0700 (PDT) Received: from localhost.localdomain (dsl-tkubng21-58c01c-243.dhcp.inet.fi. [88.192.28.243]) by smtp.gmail.com with ESMTPSA id a15sm652624ljj.101.2020.05.21.01.06.09 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 May 2020 01:06:10 -0700 (PDT) From: =?utf-8?q?Martin_Storsj=C3=B6?= To: ffmpeg-devel@ffmpeg.org Date: Thu, 21 May 2020 11:06:09 +0300 Message-Id: <20200521080609.6790-1-martin@martin.st> X-Mailer: git-send-email 2.17.1 Subject: [FFmpeg-devel] [PATCH] cbs_h265: Fix use of an uninitialized variable X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" This fixes test failures in fate-cbs-hevc-* in certain configurations since c53f9f436440be4e18. --- Not sure if this is what was intended, but the current code doesn't work at least. --- libavcodec/cbs_h265_syntax_template.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/cbs_h265_syntax_template.c b/libavcodec/cbs_h265_syntax_template.c index 55da1a0a11..a3c1d1c7ca 100644 --- a/libavcodec/cbs_h265_syntax_template.c +++ b/libavcodec/cbs_h265_syntax_template.c @@ -552,7 +552,7 @@ static int FUNC(st_ref_pic_set)(CodedBitstreamContext *ctx, RWContext *rw, flags(use_delta_flag[j], 1, j); else infer(use_delta_flag[j], 1); - if (current->use_delta_flag[i]) + if (current->use_delta_flag[j]) ++num_ref_pics; } if (num_ref_pics >= HEVC_MAX_DPB_SIZE) {