From patchwork Tue Jun 16 14:10:10 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: 2rd bunji X-Patchwork-Id: 20425 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 970A544906D for ; Tue, 16 Jun 2020 17:10:43 +0300 (EEST) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6631E68B6F6; Tue, 16 Jun 2020 17:10:43 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from APC01-HK2-obe.outbound.protection.outlook.com (mail-oln040092255034.outbound.protection.outlook.com [40.92.255.34]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B655368B584 for ; Tue, 16 Jun 2020 17:10:36 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NuoBKsFJjQU+l47AF5pbFy4HPYaT6fZrQSUmRzYEd40/9plpcINzwWqP0MmgUKMXM5k8Hz6M5bs/Exc/9xwQBxPTjJoPx9OekQ74lz+XRX/ZH2rvvlRcHSLfZ9ILiAmrABMJbKtpjRMFaMQu7A2GyJ3/1m9NV0pwVz3xpioIFCfHsyS5N3LSfFXc5/GfwzIe04NpycDngQyCwm7DOVuTrgXHkWPazfEoI/v9zcb+Hb/GPfTb65a2uLQFM083BkKA9kgM+rKMMQp03EJQ877rZytt99VBCmBEVqW8WAxy5Nveu+LmJGfEqs7nZe80Kp4xeekWf/V/5tKKdbBOyeA8xg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=O8DcPNvmz5GsfUylcMkhay+kqTKUizxR7QYfky4BdNA=; b=R2asdVZ9MDDqD/ArpwDWl2ZP/zmk1wQxx8QO7gMmXjrqFVwVgUNEA2i9gYFAbtHQOUaC5w4zudCpRsWzX+LCu9Z3TgQWreKY+qz6E4Gtp5YFhwpuskFt7ondDMaJkhVIIxiUtJBDUM2p8uYkZ5b7Txp1ZpSZIat6dCyTlRAZXayBSxos2K6wiLxXC5dERvEAKMqt+4j2Bbvt5dd5Gg63Lho1As8R2AXkRNeVga6Au8UG3ttp7J4aCGRfw+jZh1wBXemdoITZ7hsfMK9xjYbEAFmRXjsTygV+RiizW0ixt4qejkFJoP74BelSnNRshZgjZ3yF9L9hXq83+XOtrSz0Lw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=live.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=O8DcPNvmz5GsfUylcMkhay+kqTKUizxR7QYfky4BdNA=; b=V3XsUuyWMPxPDI2ynR5g31k+BScj3ayXfCYpGQPNgaIKKOpg2AqOjfJtogq2uJ5uMx0jZHhbkd7gX5CyMMFbhbL0mxB0vT1EjOXc+kEXyl4bc4Qvhg5DRAwZf1DIq12pqbMfPlf1evaKmBnW10W4dvS/cJ6M8+L+3nOoNaZ18b07kntg8XjMyT43p6CcaaCx1TaDBOlCAyzHYsYPg1kSsfWw14tKi6b/t/NXpvHgrwbOPB3pGT2EVnibj4wH34or0Key2iQudnbpkJR+3aLiNxhBP4ovxA5pXfm1mD0uKe5CXYo7Bpcw6uOPD/twgkvq08vvvqYotq7QJ1LOB7rKkQ== Received: from HK2APC01FT047.eop-APC01.prod.protection.outlook.com (2a01:111:e400:7ebc::43) by HK2APC01HT173.eop-APC01.prod.protection.outlook.com (2a01:111:e400:7ebc::315) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3088.18; Tue, 16 Jun 2020 14:10:33 +0000 Received: from HK0PR02MB3458.apcprd02.prod.outlook.com (2a01:111:e400:7ebc::53) by HK2APC01FT047.mail.protection.outlook.com (2a01:111:e400:7ebc::342) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3088.18 via Frontend Transport; Tue, 16 Jun 2020 14:10:33 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:EEB2797403E75CE25538ED9F76F16935A99DF78C107E6B31D9FB84B1E3F6B6D9; UpperCasedChecksum:1EBDD9A01ED70884CA5D9F6CAE35994B77CB532F491080B0DEA3A13AD847919D; SizeAsReceived:7389; Count:47 Received: from HK0PR02MB3458.apcprd02.prod.outlook.com ([fe80::7de7:d504:5335:3e63]) by HK0PR02MB3458.apcprd02.prod.outlook.com ([fe80::7de7:d504:5335:3e63%7]) with mapi id 15.20.3088.029; Tue, 16 Jun 2020 14:10:33 +0000 From: Lu Jiao To: ffmpeg-devel@ffmpeg.org Date: Tue, 16 Jun 2020 22:10:10 +0800 Message-ID: X-Mailer: git-send-email 2.27.0 X-ClientProxiedBy: HK2PR03CA0052.apcprd03.prod.outlook.com (2603:1096:202:17::22) To HK0PR02MB3458.apcprd02.prod.outlook.com (2603:1096:203:7d::22) X-Microsoft-Original-Message-ID: <20200616141010.1926-1-sourpotato@live.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost.localdomain (180.167.199.182) by HK2PR03CA0052.apcprd03.prod.outlook.com (2603:1096:202:17::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3109.9 via Frontend Transport; Tue, 16 Jun 2020 14:10:32 +0000 X-Mailer: git-send-email 2.27.0 X-Microsoft-Original-Message-ID: <20200616141010.1926-1-sourpotato@live.com> X-TMN: [RifMtSs+1en2XKMBNZOVK7XequLiv/pw5V9fxFbET1k=] X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 47 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: 2a707de2-0e40-4c72-9706-08d811ff084f X-MS-Exchange-SLBlob-MailProps: K3wx5smWY1Pz/kP/XA2aTFjokNUdcEYFxYDNIz9mqTBpjZ9GJlk8rpmKOj8aQ5DKta9q3Lb3292p6pPmfKZQtwg+Fw1zq2fiFUDa1YkcoPTR7ZUPIxKSe5Pnwfr2Bsszdii2KWGvFORb0UR7cM1VRpz/RcOJnauTG3dlkMOI8jIYgQC0Xfdh7KMcXORFN9yyhZyN4EPsaLCVgwB2TTardUC1zRxbOpixo5rGJl4GK1UXuac516FN68deEAMQwls2/luraVafALTDHAJM6Ii8Fu3rHGeSCU45TAQxOgQmenz6qUmWKM2vyiiq8q1Myh7wCrTmD4lIk0XnyzCA5ERYnPU50iKqhQZVLbkJLo5HN69bIaSFHZWQzOeRNQt66oV+sUx7+zOnamllVYSYWRo4vttorB7zsc5N+2YzgoMpvjYSR/rJTTiEZbWj/qULUjm2BfLCHfmES3X+P5yubcE+V1Wydcov9G3pXHWDNSZEJ8mThE4ENFZywhphjs1hH/Qg1uS6mof2Bu63/XSXE2bJfXfGpmBpZ//GP8Ki6Tmn10qriJr/1YeZjHLaJLzF/ypyq9UIKVyCBnSgPPeIkkwPwm9nSrP6vwTTJaT1hxVzKTT1a4+zzerKsJd76BEaizxymlGKeyil4UyobRnjSj40gS0vqkoKNeWiTu2FYHHItPNFnUILANk3c+4t13z9g1wMDsPT0yC1jppsb5zA1nNHGQDpFUVNCQGz1QIG3xPkRtrzNAvVrBCCWqdU8oy30iKRjLaposbRg8QFyEtNK94+HOGYCLaaN6L74IPg9dlEN4/wvooAAeFDHLNOAgP522NRRDOMq+mSGztspqtu1R++3FUG6G/4B9MLidf+hlEWB9rjf7lf1AFTxDJsVOwCZ/THw+cpi3Fr7WMKHXyFrApJbdXE4CitY05ploHwZj0CDjg= X-MS-TrafficTypeDiagnostic: HK2APC01HT173: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bcMEMI82OFY9+th9EMBOUWaYGN2ngiy02Mxz+SDK47MSPWgtZOAW1E9GPVliuv8Xo/tFUuYk1B2L1TaMD8YADaPgsyO0nGxQh1dTVXFQOIlIrvCUoQnnbLF9DzrR1ALhe1K8zCNtuKbo4KVPlpomUZZGalK3m96TZK2GE1wELHmH9X5XwG7faihTLhwElDg30InwlrO4phxsiFX++4XFKjo1Tk9POKXGlrH2W44l/S0ieT3JidRJCfqOdwW//2u/ X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:0; SRV:; IPV:NLI; SFV:NSPM; H:HK0PR02MB3458.apcprd02.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:; DIR:OUT; SFP:1901; X-MS-Exchange-AntiSpam-MessageData: Bu4WongFZeUGxCJazvfbVgWttwc7xMRAwn8wJ9lyzYqdV5/04/rOKqconrEvEcYYWw6cvwZS8eMyM0dwctjh6sAWkk2tI0I7UL2/eY5q4o0edh7b7AQ1dGpJ7BJYPvCaxlSXbupA580ZmgFnEdZUxg== X-OriginatorOrg: live.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2a707de2-0e40-4c72-9706-08d811ff084f X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jun 2020 14:10:32.9659 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK2APC01HT173 Subject: [FFmpeg-devel] [PATCH] area changed: hevc_amf set default gops_per_idr 1 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Lu Jiao Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Previously gops_per_idr default 60 would make amd gpu encoding hevc has erratic seek bar behaviour as descripted in this ticket: https://trac.ffmpeg.org/ticket/7272 --- libavcodec/amfenc_hevc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/amfenc_hevc.c b/libavcodec/amfenc_hevc.c index 77e57d2461..b0cb57cb96 100644 --- a/libavcodec/amfenc_hevc.c +++ b/libavcodec/amfenc_hevc.c @@ -69,7 +69,7 @@ static const AVOption options[] = { { "gop", "", 0, AV_OPT_TYPE_CONST, { .i64 = AMF_VIDEO_ENCODER_HEVC_HEADER_INSERTION_MODE_GOP_ALIGNED }, 0, 0, VE, "hdrmode" }, { "idr", "", 0, AV_OPT_TYPE_CONST, { .i64 = AMF_VIDEO_ENCODER_HEVC_HEADER_INSERTION_MODE_IDR_ALIGNED }, 0, 0, VE, "hdrmode" }, - { "gops_per_idr", "GOPs per IDR 0-no IDR will be inserted", OFFSET(gops_per_idr), AV_OPT_TYPE_INT, { .i64 = 60 }, 0, INT_MAX, VE }, + { "gops_per_idr", "GOPs per IDR 0-no IDR will be inserted", OFFSET(gops_per_idr), AV_OPT_TYPE_INT, { .i64 = 1 }, 0, INT_MAX, VE }, { "preanalysis", "Enable preanalysis", OFFSET(preanalysis), AV_OPT_TYPE_BOOL, { .i64 = 0 }, 0, 1, VE}, { "vbaq", "Enable VBAQ", OFFSET(enable_vbaq), AV_OPT_TYPE_BOOL, { .i64 = 0 }, 0, 1, VE}, { "enforce_hrd", "Enforce HRD", OFFSET(enforce_hrd), AV_OPT_TYPE_BOOL, { .i64 = 0 }, 0, 1, VE},