From patchwork Wed Oct 14 02:58:11 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Pokotilo X-Patchwork-Id: 22935 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 58F6944ACAF for ; Wed, 14 Oct 2020 05:58:54 +0300 (EEST) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3619C68BAA3; Wed, 14 Oct 2020 05:58:54 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 258DC68BA8C for ; Wed, 14 Oct 2020 05:58:48 +0300 (EEST) Received: by mail-wr1-f54.google.com with SMTP id t9so1881942wrq.11 for ; Tue, 13 Oct 2020 19:58:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wmspanel.com; s=google; h=mime-version:from:date:message-id:subject:to; bh=PpgirATAZ+95BjQYtbhp3BKYRcwnZ4KBk8h3UIVqsUQ=; b=SaepKAQU+PwqwP2GatXnkYmUxFiNCjLNin50/MMk+QLLKL0O6OoyaKmAu8g/u0D/6a yLmN7Elf716zOtfVLcctD7ufXy7Gen9uZkT4NYMcGzRfL4zHIrdyVa7DNkAoNAHrO2mz 1kheYiGqbojMbKb8mz5eLRFGXVvjiMo2LGhfg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=PpgirATAZ+95BjQYtbhp3BKYRcwnZ4KBk8h3UIVqsUQ=; b=doam8WplvIIwhAcmfkvcsPloMvehPJQJxeNVwDQyhljilUgcSSjRAZiQk6jWAJEjSC ylYVS85IK50ELi8600gMfl3iT9qkSxSI9Glf4xfgOhaP0A4+Yi1NhdNidMGQnzd5G6vG qraO92YrNKe8NeKTKbT3pdYLc5rxFsshW3dsHAiwGPRkxqCNP1LkBaAfMkDnffsfqN+k qvN3OMztJA4sZQ0WcIaW/PQF1h10q3NwDACKw/38DakggIIMI9E9e5D4YkaXDnblUjdd ijlcBbLCsB0zjF0OQKxOkzaDZ7eO/721WAZW7LTd8snYd5bvKpo09BlTHFhfYo0HahGK S9QQ== X-Gm-Message-State: AOAM531tiuWEVbACaIZQZHAcXs6bDNWHG0sckd/tyWyF/hRu1budSXhZ PFgqmZkrBoucT2ObZ8wck9nD5ms4f81W156v9ecB6fDylpqDvw== X-Google-Smtp-Source: ABdhPJyn85PME04CZPz2kUZ28OKC0CC3BcQTcAS6eOcPHDYIYx7QIEKdV3i83ayIbSK0EYLtIDpMLUtc8ZIkq/qRtHU= X-Received: by 2002:a5d:67d2:: with SMTP id n18mr2724989wrw.310.1602644327404; Tue, 13 Oct 2020 19:58:47 -0700 (PDT) MIME-Version: 1.0 From: Alex Pokotilo Date: Wed, 14 Oct 2020 12:58:11 +1000 Message-ID: To: ffmpeg-devel@ffmpeg.org X-Content-Filtered-By: Mailman/MimeDel 2.1.20 Subject: [FFmpeg-devel] [PATCH] lavc/qsvenc: fix poor video quality with "-force_key_frames" X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Subject: [PATCH] lavc/qsvenc: fix poor video quality with "-force_key_frames" if run ffmpeg with "-force_key_frames" flag without this fix, all new frames will have "MFX_FRAMETYPE_I | MFX_FRAMETYPE_REF" after some time and video quality will become very poor. Need to reset FrameType in free_encoder_ctrl_payloads. --- libavcodec/qsvenc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c index 1ed8f5d973..9e3c201416 100644 --- a/libavcodec/qsvenc.c +++ b/libavcodec/qsvenc.c @@ -1240,6 +1240,7 @@ static void free_encoder_ctrl_payloads(mfxEncodeCtrl* enc_ctrl) av_free(enc_ctrl->Payload[i]); } enc_ctrl->NumPayload = 0; + enc_ctrl->FrameType = 0; } }