From patchwork Sat Nov 14 17:15:28 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Michael X-Patchwork-Id: 23629 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 2BEE444974C for ; Sat, 14 Nov 2020 19:22:10 +0200 (EET) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id EDE9C68B916; Sat, 14 Nov 2020 19:22:09 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-qk1-f193.google.com (mail-qk1-f193.google.com [209.85.222.193]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C82FF68B84C for ; Sat, 14 Nov 2020 19:22:03 +0200 (EET) Received: by mail-qk1-f193.google.com with SMTP id d9so12641041qke.8 for ; Sat, 14 Nov 2020 09:22:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=kOj2PqxG4eJlClgwK3qSOWvpE9gZ0tBNKxrd/rmaO+w=; b=KxEs449sOQUgEBqyheT+ScJZIr+USjQtWhEXMBkbxg4e63i4bi8+GxSq5994zujza+ RCfh2Yzx3sStk9BCCvZ9MnHs0GyiwEisBY5mtwtCInJb1fiQwVaQ87JmbPdjfPeAlVIL xeiTstFvqOyhAjF3ir3yUGgpQNTc9UVAD001MqxXh1tQkmwGuxPFfJMa88uT0qgm04IL 3Q+j+EMbQCNmVwFLrp2oJ7p8N0gCdoeBoCTOQn42Rcaxd6jWSBPqmBUYdUR+z6e2pPKm QOD0lAqaiNDXlW89/DD2mOSb13RfM8joaAhvq9otfzFlYV8o/16L/rBITOIA8KW5r6Aa mrpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=kOj2PqxG4eJlClgwK3qSOWvpE9gZ0tBNKxrd/rmaO+w=; b=hdZ694l0wdCJQqFf9A20oLydfdFmfGv29NXg79a4OdpnD5c2vYnyd/l602OXF8ZllY G2ZL5TR8EKi3VquL950TsA8rI+7N4erWmMdEkdQf7aItNrHrvMf4atqH0RPaj6IFrD0P sAFe+NawmrTXtGYSyJpCOaod9s2LikvihFem4gg7XUZP+K4Tb+rxeWP2MKnfRchsqQJx IlVtNaRw2tLPIHh6zZYpkKkz3JD+lX0RohMOLsYJvDQpfUS2a6P0n+wJMLq6WNEtpC4n 6GjM1bMD8+LgR+DXu5i3OZUrT+sy9YeY4EsGLlvKHGf4JYiKQvHzxFlxHLaWjIj9Nsmv Lyng== X-Gm-Message-State: AOAM5316q78OoLxf4hVbxhFz2BEqGuJQkaj2cOdJ1N2gdniv3iOiRjgI YR8nD3qerczo8YeDxSdqTNAt2yWlb1k= X-Google-Smtp-Source: ABdhPJxEX1DgowSpcsEGqur4Kk5ITGQ0v3WINjVsWpy7TH2wyRhDG0QSSYP8dQIQ/9LvKAnob6/reQ== X-Received: by 2002:ae9:ef82:: with SMTP id d124mr7121150qkg.480.1605374130197; Sat, 14 Nov 2020 09:15:30 -0800 (PST) Received: from callisto (c-73-175-137-55.hsd1.pa.comcast.net. [73.175.137.55]) by smtp.gmail.com with ESMTPSA id q15sm8900247qki.13.2020.11.14.09.15.29 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Nov 2020 09:15:29 -0800 (PST) From: David Michael To: ffmpeg-devel@ffmpeg.org Date: Sat, 14 Nov 2020 12:15:28 -0500 Message-ID: <87zh3jkggf.fsf@gmail.com> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH v2] configure: fix the bigendian test X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" There are two issues: When build systems enable LTO in CFLAGS, the unused global integer does not make it into the compiled object file. As a workaround, check if the compiler understands -fno-lto and append it after CFLAGS while building the endianness test. The hexdump output is line-wrapped, so the expected value will not be matched when its four bytes are split across two lines. Use the POSIX "-A n" option to disable printing input offsets and delete all newline characters to output continuous hex values to grep. Signed-off-by: David Michael --- configure | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 51e43fbf66..47160b4bbc 100755 --- a/configure +++ b/configure @@ -5756,10 +5756,11 @@ done check_cc pragma_deprecated "" '_Pragma("GCC diagnostic ignored \"-Wdeprecated-declarations\"")' # The global variable ensures the bits appear unchanged in the object file. -test_cc <