From patchwork Tue Dec 8 22:40:41 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Marvin Scholz X-Patchwork-Id: 24444 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 3CF3B44B524 for ; Wed, 9 Dec 2020 00:41:02 +0200 (EET) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1B22E68A112; Wed, 9 Dec 2020 00:41:02 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3433A68A0F1 for ; Wed, 9 Dec 2020 00:40:55 +0200 (EET) Received: by mail-wr1-f65.google.com with SMTP id 91so13940452wrj.7 for ; Tue, 08 Dec 2020 14:40:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=WKExVVMZlD4y/bro/IBHdlhmERMVdRSgM1bGxn9U0Ds=; b=D6rLM+x5R0RzR9QLLTDZqvHiecT3tLSz+H9JlUHkYLIlwWxqXidRnIycnxAaV1jeS/ SSW4yWIs6q6HosekTJDRC3Xu9IyGNuzFd5+qUPEDgPEZrmamxfHuSetqeA1DHaZtKS5S AWEVP++/lkzqRb09iFZnpgJkp6Zu6S8ctYky2CSfYniV+BcMJPhUQEMzyquVZa4NIpBe J49rJkvIJSVrpzzKAIdPGk9Oer53GnoX00OzmnESTP+9BlEw1flF4faiIFYGHbpLVpkg 8LY6oJdBhP47s+Bpje9Sby6kr3nn1YPo3cQutYr5K7vtX6nbsloPiHf69zr2e+krTWyB vswA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=WKExVVMZlD4y/bro/IBHdlhmERMVdRSgM1bGxn9U0Ds=; b=RIRHvhjc0/KMe6bQ3buUeBL7x4beX9lCQiU9myhK795ds9kteOvq5HFN9zKh96P+XP lPBubkDKo1sLnJpEF2bnMqRGBhE7/iCFkkg19gXekykmbycWFyP1mXhtqvQnlb5KMrt/ MoxuLXZIsOOZFb7dkKCGIP6YfeGV60f6SOXphSnQKKUPsKXkijfDNf7oR9IjVT5DQuM4 rovc8VoPdkMei4FK/Ezz4vM5FSDjtU0/V/XRfUUg7DFi3UcWdGix1W+GlFA1ZTaBWnlr t1cdByT1MWUZoyIrdcgTK2aMd3ORRXFYFhcakopt1LTpwjOYtUxfr9yoAchY9BwTu/UB JI+Q== X-Gm-Message-State: AOAM533Ibl95p/fKd5zR9cTKv+ygV0usnmzAICOEULUc3+yZpj6UjXl0 ojTQl5DewXgTbw+rpVww+A9LmuGLi/g= X-Google-Smtp-Source: ABdhPJwWaoiiYEWLzq3Wss0ymq6uitAGnrCMBJzmnZOhb4TMv+tE8jMs1gzJM4Nh8d3I0AxaboqVtQ== X-Received: by 2002:a5d:558a:: with SMTP id i10mr262154wrv.363.1607467254492; Tue, 08 Dec 2020 14:40:54 -0800 (PST) Received: from ePirats-MBP.fritz.box (p3e9d4894.dip0.t-ipconnect.de. [62.157.72.148]) by smtp.gmail.com with ESMTPSA id c9sm498230wrn.65.2020.12.08.14.40.53 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 08 Dec 2020 14:40:53 -0800 (PST) From: Marvin Scholz To: ffmpeg-devel@ffmpeg.org Date: Tue, 8 Dec 2020 23:40:41 +0100 Message-Id: <20201208224041.73947-1-epirat07@gmail.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] avcodec/bitstream: use av_assert0 in GET_DATA X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Marvin Scholz Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" For builds with asserts disabled, if the default case would ever be reached it could lead to uninitialized use of variables as v is never assigned to anything. This caused the following clang warning: libavcodec/bitstream.c:374:5: warning: variable 'len' is used uninitialized whenever switch default is taken [-Wsometimes-uninitialized] COPY(len && len <= nb_bits); ^~~~~~~~~~~~~~~~~~~~~~~~~~~ libavcodec/bitstream.c:343:9: note: expanded from macro 'COPY' GET_DATA(len, bits, i, bits_wrap, bits_size); […] To prevent the uninitialized use, use av_assert0 which aborts when assertions are disabled. --- libavcodec/bitstream.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/bitstream.c b/libavcodec/bitstream.c index 7570fb2204..875e9302f3 100644 --- a/libavcodec/bitstream.c +++ b/libavcodec/bitstream.c @@ -107,7 +107,7 @@ void ff_copy_bits(PutBitContext *pb, const uint8_t *src, int length) v = *(const uint32_t *)ptr; \ break; \ default: \ - av_assert1(0); \ + av_assert0(0); \ } \ }