From patchwork Sat Dec 19 18:50:39 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Franziska Thul X-Patchwork-Id: 24590 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id E3AD644A2B3 for ; Sat, 19 Dec 2020 20:50:46 +0200 (EET) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C1A1A68A9A1; Sat, 19 Dec 2020 20:50:46 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mout.gmx.net (mout.gmx.net [212.227.15.18]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id EFBE66897BF for ; Sat, 19 Dec 2020 20:50:39 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1608403839; bh=aD+Y5yptshSfv4nJhodWrcI0kwsT3ccS6Gq15Sh9fYc=; h=X-UI-Sender-Class:From:To:Subject:Date; b=bir/9ZUVGcyWVAryX2VoY3Bm8uHNvZeeGzCz/BlVWjol1fYib+NHdcvdx9Et2MGaW iXAMfMp8+qs+YgqqDC+SyGL8Uk+VNSP1tJePZ2rYlhvYrf7f9+9hv3x7dGLtuwsXbr zZZ9Z+00z0VWz9bw82xmoFf5R+zRQOtIPV0Qe25o= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [77.6.107.143] ([77.6.107.143]) by web-mail.gmx.net (3c-app-gmx-bs71.server.lan [172.19.170.216]) (via HTTP); Sat, 19 Dec 2020 19:50:39 +0100 MIME-Version: 1.0 Message-ID: From: Franziska Thul To: ffmpeg-devel@ffmpeg.org Date: Sat, 19 Dec 2020 19:50:39 +0100 Importance: normal Sensitivity: Normal X-Priority: 3 X-Provags-ID: V03:K1:412diZOa03KrIUQcShgbqEoZ1iXlqqv91bW/IldgizaYqwTKkXt5sDel6BFuXNRt0GBEh qeLiBHtT+7Yu0GVdCXHHp1X9aYo2pRh2/gJ+4SedbR0rd1LJvoHMCJJjx+Dat8cY7PlmD1B/nr8v koSNMH8Grz9xBJV8HefQMLAW4bkjdEuIgWVw1Qp2j0XnzOM9h/EyIR2T0z+0rhqIeyQbkLDRAnyT ekJUcS2FaibMkirhcv+RAJdtTRzRQLWX+MXrqdpImaQ+VlHsKCZ7PG0NC4TdJ2QxcrJrxvDXKqJx yM= X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:TCxQtpDEbRQ=:+tZMQB+TicO1YT1CNSMBdY MsFAGWc4b9IH/jFKqryCCZRQMF7zRtp4Byh5XUlw2uMCswchqoR1dXJddqqu0HMc1huXKVmS3 lloV02xn+KvAGLx6XwIWuewMw1LkNE7myS2sxELZSRo8Y0PbZBeh24it4EbFiexXaoGF5DUAi eoRPJjRidqFkYRIR+6W0UmIBTOJ96z40eFY7gRsulIoXOW7zmk3JjjS5OufFeDYOi5kNI8J8o sG2CNAL1bnNhZd7QmmNW9u2gaJaCiC4AS5EAHiMQ4J29vPx7HQPMhg2Gk/PrlA6BM6SscxEyt 4XVFP1U+2w0zubDVFQwe6q4bemZCUIPnH8W6HKG5sx2GhbfFJjmCjKZXWe+oi3Y7k9l3FBH+I t8cGVEadhAEFkfR3eg9ckMcXEqoeMidUQx5H5WCHDuqwKEvT3c80el1h7CeVt+D6RSmM5axVy HCEub4ecyXbsomfcGzAOLquSHv8YvxAwbQMoIImgrrdiW1BUnWd4hwonlTSmxaMWaeGzt7hs7 8PJvszU2uLfKU31f0HW/FvgYmUNDBsq2aOJxv5YWcf7iXASVI39BTJgR7ePL25NuIRIApWLiY yVQgzpPOtWbsc= Subject: [FFmpeg-devel] [PATCH] libswscale/swscale.c: Clarify what exactly 'data is not aligned' to X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" libswscale/swscale.c emits a Warning that 'data is not aligned', but doesn't explain why, leaving users without any clue on how to address this issue. This patch simply adds that data is not aligned 'to 16 pixel boundaries'. Idealy, the warning would say which values are not aligned, too, but since the variables' uses are probably explained elsewhere, I could only speculate. --- libswscale/swscale.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) -- 2.20.1 diff --git a/libswscale/swscale.c b/libswscale/swscale.c index 9cb7e8f6ac..69349a7349 100644 --- a/libswscale/swscale.c +++ b/libswscale/swscale.c @@ -311,8 +311,7 @@ static int swscale(SwsContext *c, const uint8_t *src[], static int warnedAlready = 0; // FIXME maybe move this into the context if (flags & SWS_PRINT_INFO && !warnedAlready) { av_log(c, AV_LOG_WARNING, - "Warning: dstStride is not aligned!\n" - " ->cannot do aligned memory accesses anymore\n"); + "Warning: dstStride is not aligned to a 16 pixel boundary! Cannot do aligned memory accesses anymore.\n"); warnedAlready = 1; } } @@ -325,7 +324,7 @@ static int swscale(SwsContext *c, const uint8_t *src[], static int warnedAlready=0; int cpu_flags = av_get_cpu_flags(); if (HAVE_MMXEXT && (cpu_flags & AV_CPU_FLAG_SSE2) && !warnedAlready){ - av_log(c, AV_LOG_WARNING, "Warning: data is not aligned! This can lead to a speed loss\n"); + av_log(c, AV_LOG_WARNING, "Warning: data is not aligned to a 16 pixel boundary! This can lead to a speed loss.\n"); warnedAlready=1; } }