From patchwork Tue Feb 9 23:31:51 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Jan_Ekstr=C3=B6m?= X-Patchwork-Id: 25527 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 3C84C4483BF for ; Wed, 10 Feb 2021 01:32:02 +0200 (EET) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0A5A168A154; Wed, 10 Feb 2021 01:32:02 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com [209.85.208.174]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 98283689C62 for ; Wed, 10 Feb 2021 01:31:55 +0200 (EET) Received: by mail-lj1-f174.google.com with SMTP id f19so443566ljn.5 for ; Tue, 09 Feb 2021 15:31:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=EUKrPlge8Tl6RMd/FXzFJg+wXKtvX3dBmII6Ebp4APU=; b=MKP5HgrMm5FJquOTu7gQy+e4mGn1r9+Fw04hfFyRe+mdEoLZ/VPFgmbuJvvC/EsDVE 0ZgZpEBVq5ZMQjJc9bcAxe5S97ZSQ+9K9Y8ui+Kh38JpkwFdrdhvsOeNUIQA1ms/73bS rvltdNF0UlXRUf1IlCEPE8ZcwLquU7IWqP1R+Oedy6/krjWujoQ0Zsx1jg16NkchwOL7 jQMxbCmXC0dA8Antkmmkl6vMN/aNKoXv2rFSOeAKsqNxu82REqM7/J4DDD9OIijreIrZ RWxdJawLwCzfUP523/QUCe+Vz73k2fJV4Lv/uLHSZJ2tPaBy2S4LuhVsnmVcwQK62K1Z H93A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=EUKrPlge8Tl6RMd/FXzFJg+wXKtvX3dBmII6Ebp4APU=; b=eHr8RgkR3j3Qj+wtjH/g6sCSspzHTkTizld+HcMr/JEEtKnaVWbfI4BjBW5l/Egpn6 fpHq/PmZkZ2ldETOtLH+84Bl7K7h4kI1V0arqZwYmWLUe+wt693kM7+qewLbqB5DN7Se RFudaD5BY3gNp7bqTPWGw37pMfN1PIxv1AdHie3EWO9j9VkkrSxnztnX+V9Dkaddp1Fa qo7Uo13Z8C5X7WEaKmA3HUXXyoaT/q2UCdWGfaYZJhpUm/OrE+LPzH1yLoSI0D+DlzZR fHsaDYFp3uHNKsoFyA0SERJAaOV3gYYmjIrsITPsLB9NmJNygA10R/BKrGo6FDD+6LNV 5ySA== X-Gm-Message-State: AOAM530XP94GlX9pXFjmeKSnFl3j34ZoterE0/1hlrwdv+wrLqK4/Osw YyfeHPTIPeG0FsSoULBIJlQHEYsVpcg= X-Google-Smtp-Source: ABdhPJzyWUAJ5H/5jeQhaXk5ZGsYyVzM09O4G9Uwc2E7NrRIHS/uUfqjWKa/XVEcM595PJiAbVFPfw== X-Received: by 2002:a2e:2f19:: with SMTP id v25mr159189ljv.184.1612913514919; Tue, 09 Feb 2021 15:31:54 -0800 (PST) Received: from localhost.localdomain (91-159-194-103.elisa-laajakaista.fi. [91.159.194.103]) by smtp.gmail.com with ESMTPSA id g20sm2773lfr.50.2021.02.09.15.31.54 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Feb 2021 15:31:54 -0800 (PST) From: =?utf-8?q?Jan_Ekstr=C3=B6m?= To: ffmpeg-devel@ffmpeg.org Date: Wed, 10 Feb 2021 01:31:51 +0200 Message-Id: <20210209233151.11174-1-jeebjp@gmail.com> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] avformat/movenc: remove unnecessary HDR metadata log messages X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" These made sense before 3ebf449766d4b69a7774c4990fb24fe71c848a3e when the creation of these boxes was specifically requested by the user, but now they have become unnecessary as they are just like many other boxes: If the input has the information required, they are written, otherwise they are not. They were moved to verbose verbosity level (which happens to be the last level still relatively usable), and now appear either once (normal MP4 muxing), or thrice (with the faststart flag set) in any normal MP4 usage, without giving much useful information. Thus, remove them in their current form. --- For the record, I am not against having f.ex. the mdcv box writing function warning in case the side data is there, but it lacks the required information. But just always logging this stuff, even if the user didn't go anywhere near streams with such information does not feel like something useful at this level of verbosity (esp. with the faststart flag causing it to appear thrice). Jan --- libavformat/movenc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 372c04295d..62192e5c24 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@ -2025,7 +2025,6 @@ static int mov_write_clli_tag(AVIOContext *pb, MOVTrack *track) side_data = av_stream_get_side_data(track->st, AV_PKT_DATA_CONTENT_LIGHT_LEVEL, NULL); if (!side_data) { - av_log(NULL, AV_LOG_VERBOSE, "Not writing 'clli' atom. No content light level info.\n"); return 0; } content_light_metadata = (const AVContentLightMetadata*)side_data; @@ -2052,7 +2051,6 @@ static int mov_write_mdcv_tag(AVIOContext *pb, MOVTrack *track) side_data = av_stream_get_side_data(track->st, AV_PKT_DATA_MASTERING_DISPLAY_METADATA, NULL); metadata = (const AVMasteringDisplayMetadata*)side_data; if (!metadata || !metadata->has_primaries || !metadata->has_luminance) { - av_log(NULL, AV_LOG_VERBOSE, "Not writing 'mdcv' atom. Missing mastering metadata.\n"); return 0; }