From patchwork Sun Feb 14 21:09:23 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul B Mahol X-Patchwork-Id: 25626 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id E07D544BA7F for ; Sun, 14 Feb 2021 23:09:39 +0200 (EET) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A5F70689FB4; Sun, 14 Feb 2021 23:09:39 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id CF2156898E4 for ; Sun, 14 Feb 2021 23:09:32 +0200 (EET) Received: by mail-ed1-f51.google.com with SMTP id i20so4111179edv.2 for ; Sun, 14 Feb 2021 13:09:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id; bh=HVoLpHeGClIAt8BLaNyOYSBiBPXQxdHDA7ti6zg/ZC8=; b=YpIbhZu6165JTjRZiSocxf5QOtzueyhjHFHEIf01IP6lwnxdai8YpXUHHU/UX87dIK oojD9t9scnFqLTWSeiSfZEdSFNMlf5pnpBSc0M7sMtG4J/YmCjy/2iN3RiWW669cQFjK jkrLIt8Vlif33dcLlwjNqT2ORBIqLS2ekiK3uQcIBJzyG1dQBkpn1PBPzt8QSq2sBIh2 Bk+WuSmA31JyUQaTORyGCEjBR+QmrkI9ej+IGMgce/btQXRYePwpFrg8VOjY4v42YzRu qZex5m6AGSoo0vqJQNJIj2h7IVPOSr4QsyJcvCQYjuI9dt9ji1pw3D2Gy8fQrkvaHVii VIKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=HVoLpHeGClIAt8BLaNyOYSBiBPXQxdHDA7ti6zg/ZC8=; b=iTGXgJlyClt3OQE7JsIRv2IWeQKND7meblGRyr+cE9q+MZToOD/J9G7agX46lUw6zR 49LWf96ILZSTl/aVX9qB8S6ZDgyffBR4xoOH1c4i3KNE7sKlVpTFQm+taudqNmg990Yt 59DhS3fqe/Qb6wMPT7QVx4VIATo5gQXE8SsZ40UiTVS3xkkxMhzLTx/0lNtN9GWRLuSk s/OWNHPXpaHuiJEgPx6VoOHBwOhMHX0ufDMFPYNduiJa3zKQyNoTmLsgjkjdDFDq7on1 sCAhfAMKjo1bW/8KCfTnBK5nLWEhLHyUh2h6tRFcfdZWv2E9xxbbMDDiJM3CIbI5jV+s ULfg== X-Gm-Message-State: AOAM533lcQ0O0BQb1aEJ4DI3N10n4hIbQpFYZWq3d+hnS3oaOHwAOopN TkhP4+VU8nmTh5V8CWEQc2mtksyPUJDdjA== X-Google-Smtp-Source: ABdhPJx8iR/n20wKiDF52XbDUPBsnd1Gti0B9EdpcGsJj6bKM5ajeYFmfYEO3T/5feSIkV3JSIByHg== X-Received: by 2002:aa7:c312:: with SMTP id l18mr10282961edq.278.1613336972312; Sun, 14 Feb 2021 13:09:32 -0800 (PST) Received: from localhost.localdomain ([94.250.162.225]) by smtp.gmail.com with ESMTPSA id t11sm8843555edd.1.2021.02.14.13.09.31 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 14 Feb 2021 13:09:31 -0800 (PST) From: Paul B Mahol To: ffmpeg-devel@ffmpeg.org Date: Sun, 14 Feb 2021 22:09:23 +0100 Message-Id: <20210214210923.12099-1-onemda@gmail.com> X-Mailer: git-send-email 2.17.1 Subject: [FFmpeg-devel] [PATCH] avformat/utils: fix undefined behaviour X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Fixes following report: libavformat/utils.c:1429:14: runtime error: applying zero offset to null pointer SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior libavformat/utils.c:1429:14 Signed-off-by: Paul B Mahol --- libavformat/utils.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavformat/utils.c b/libavformat/utils.c index 3e955b85bc..e4f100fda2 100644 --- a/libavformat/utils.c +++ b/libavformat/utils.c @@ -1426,8 +1426,10 @@ static int parse_packet(AVFormatContext *s, AVPacket *pkt, pkt->pts = pkt->dts = AV_NOPTS_VALUE; pkt->pos = -1; /* increment read pointer */ - data += len; - size -= len; + if (len > 0) { + data += len; + size -= len; + } got_output = !!out_pkt.size;