From patchwork Sun Mar 21 04:09:51 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nuo Mi X-Patchwork-Id: 26507 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 03F9F44855F for ; Sun, 21 Mar 2021 06:34:42 +0200 (EET) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D1FAA68A58A; Sun, 21 Mar 2021 06:34:41 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-oi1-f179.google.com (mail-oi1-f179.google.com [209.85.167.179]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B73AD6880A8 for ; Sun, 21 Mar 2021 06:34:34 +0200 (EET) Received: by mail-oi1-f179.google.com with SMTP id i3so9436220oik.7 for ; Sat, 20 Mar 2021 21:34:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=SYJIvK/8Pueu31SV3lGwpTWnOpgdv+0S2jAHLPzfdj8=; b=B2iyyZDUpSGH9ljAjUS3UIgbV8dNbNdlKY3qPRXjnZLR9RmQqpB9DLqaxSlerCCPA+ +hCtwtxGvYCgcns6BsJVYMnLfdWlL7XZisS4IErpbmPvESRkP0X0yqHwfrumRkWgE2/w Km10EkL2fWa5D/AKcS5hB7s8CuQqnevAdESulj+zCEyGXA1L3jryCv6FqK8SUgTLKFcG 1ipFYxpgsBgQl14zsD56QSRokhGhTUc50ldIjtrKIMHV/7vXqiLYp0e9qlK70kco5IJ+ WpZU84B7wMvHm8gFSDILFzgBZsWINYJq3tpmXQYqG58WpGCr5xS+8Gg4UO4m7UhoY1vt tfVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=SYJIvK/8Pueu31SV3lGwpTWnOpgdv+0S2jAHLPzfdj8=; b=SJ/CjJLSn0a8GUHhPbylz+EBuv4JsENj+mBYoOW9X5jkgwCNwKXxhdS+xxujxkiHgE LH6DE+/hg6NUZpdcLDPSRlsx3/lcqU0KTyjvMYrQAY1pTEqCaPy7N3cFZSCTu8vcbOBB IlzW8tisQpG0dSYlyubiEzMU8FgH6jqWkZXcd2+P4rZjn9uBrhZPLyUmLIX2BcnTUQzT f85po8r7iWD/5pNSY7thMvpqV/9ZzDnAMUWqbVM1LnM0yU3ZU91iLSUjdQirBvN9oiDM 8PROQ6oaJaIuS6TrRiEgrsv4vtuiqHKCyJu8KFjw0nt1KMYOWmZY6/EZNez4oGDvZRQ2 ktVg== X-Gm-Message-State: AOAM532u+HTjCDyd2qYWO8T+5W7B9srPWCkvZO+WZLk7O/g2xmzS1JYE 6QaSYSHlTXU7Tvw1rZasfQc81/ZLzkE= X-Google-Smtp-Source: ABdhPJxuozp6ygvFkOWlqvguIToi7L+YOcTuGP6Peey4EXACFOZutzUUS2qz7ztyDnFZG4fI5suxuw== X-Received: by 2002:a17:90a:d903:: with SMTP id c3mr6433763pjv.27.1616299809693; Sat, 20 Mar 2021 21:10:09 -0700 (PDT) Received: from Nuomi.localdomain (23.83.245.51.16clouds.com. [23.83.245.51]) by smtp.gmail.com with ESMTPSA id d13sm8826509pgb.6.2021.03.20.21.10.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 20 Mar 2021 21:10:09 -0700 (PDT) From: Nuo Mi To: ffmpeg-devel@ffmpeg.org Date: Sun, 21 Mar 2021 12:09:51 +0800 Message-Id: <20210321040951.24026-1-nuomi2021@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] avcodec/cabac: do not use signed values for ff_h264_cabac_tables X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Nuo Mi , derek.buitenhuis@gmail.com, anton@khirnov.net Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" The type of ff_h264_cabac_tables in unit8, it's not signed. Also,H.264 Table 9-44 and H.265 Table 9-52 never used a signed value --- libavcodec/cabac.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/libavcodec/cabac.c b/libavcodec/cabac.c index 6649feebeb..fe6bac3d47 100644 --- a/libavcodec/cabac.c +++ b/libavcodec/cabac.c @@ -54,7 +54,7 @@ DECLARE_ASM_ALIGNED(1, const uint8_t, ff_h264_cabac_tables)[512 + 4*2*64 + 4*64 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0, 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0, // LPS range - -128, -128, -128, -128, -128, -128, 123, 123, + 128, 128, 128, 128, 128, 128, 123, 123, 116, 116, 111, 111, 105, 105, 100, 100, 95, 95, 90, 90, 85, 85, 81, 81, 77, 77, 73, 73, 69, 69, 66, 66, @@ -70,8 +70,8 @@ DECLARE_ASM_ALIGNED(1, const uint8_t, ff_h264_cabac_tables)[512 + 4*2*64 + 4*64 10, 10, 9, 9, 9, 9, 8, 8, 8, 8, 7, 7, 7, 7, 7, 7, 6, 6, 6, 6, 6, 6, 2, 2, - -80, -80, -89, -89, -98, -98, -106, -106, - -114, -114, -121, -121, -128, -128, 122, 122, + 176, 176, 167, 167, 158, 158, 150, 150, + 142, 142, 135, 135, 128, 128, 122, 122, 116, 116, 110, 110, 104, 104, 99, 99, 94, 94, 89, 89, 85, 85, 80, 80, 76, 76, 72, 72, 69, 69, 65, 65, @@ -86,9 +86,9 @@ DECLARE_ASM_ALIGNED(1, const uint8_t, ff_h264_cabac_tables)[512 + 4*2*64 + 4*64 12, 12, 11, 11, 11, 11, 10, 10, 9, 9, 9, 9, 9, 9, 8, 8, 8, 8, 7, 7, 7, 7, 2, 2, - -48, -48, -59, -59, -69, -69, -78, -78, - -87, -87, -96, -96, -104, -104, -112, -112, - -119, -119, -126, -126, 123, 123, 117, 117, + 208, 208, 197, 197, 187, 187, 178, 178, + 169, 169, 160, 160, 152, 152, 144, 144, + 137, 137, 130, 130, 123, 123, 117, 117, 111, 111, 105, 105, 100, 100, 95, 95, 90, 90, 86, 86, 81, 81, 77, 77, 73, 73, 69, 69, 66, 66, 63, 63, @@ -102,10 +102,10 @@ DECLARE_ASM_ALIGNED(1, const uint8_t, ff_h264_cabac_tables)[512 + 4*2*64 + 4*64 14, 14, 13, 13, 12, 12, 12, 12, 11, 11, 11, 11, 10, 10, 10, 10, 9, 9, 9, 9, 8, 8, 2, 2, - -16, -16, -29, -29, -40, -40, -51, -51, - -61, -61, -71, -71, -81, -81, -90, -90, - -98, -98, -106, -106, -114, -114, -121, -121, - -128, -128, 122, 122, 116, 116, 110, 110, + 240, 240, 227, 227, 216, 216, 205, 205, + 195, 195, 185, 185, 175, 175, 166, 166, + 158, 158, 150, 150, 142, 142, 135, 135, + 128, 128, 122, 122, 116, 116, 110, 110, 104, 104, 99, 99, 94, 94, 89, 89, 85, 85, 80, 80, 76, 76, 72, 72, 69, 69, 65, 65, 62, 62, 59, 59,