From patchwork Thu Feb 20 16:26:00 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Almer X-Patchwork-Id: 17855 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id EEE5F44A728 for ; Thu, 20 Feb 2020 18:27:32 +0200 (EET) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C56A468B0C2; Thu, 20 Feb 2020 18:27:32 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-qv1-f65.google.com (mail-qv1-f65.google.com [209.85.219.65]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D891A68AD79 for ; Thu, 20 Feb 2020 18:27:25 +0200 (EET) Received: by mail-qv1-f65.google.com with SMTP id g6so2154349qvy.5 for ; Thu, 20 Feb 2020 08:27:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=DhebleULarixTzFYATpZXtbDQxZTdpwLTvAMpP/YqKw=; b=bO9qznrUfwaS/YXoiQKqMa5duuMA/aLhCZb9kKfFa+v7uRvFa+h8b2mgbtuACxZYWm IfCygklX1INtiUjs57gOPc0CE4l64k5HP3XlXOlwS3NAUx7xmyiFgRHyROX28/Lh0PuO McPoDgc3oC6r9uE82FvOWGspeyH0cQDC8zB3u02MXN/v5Z4SV8yON1DcfxArKpIUY+j+ qPufaraq0qsb9Gc/oa8CH1Ao20lXnq07xgXdAPANrx2YAO/z/2SL2z0BRyOMei5rAg+1 B/UyskZW3rJonF6/7iC5+PTycb3E7BUrBUMTfu+veI7oKBS1eywicnFs/1h1ViKWzrZM 3bhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DhebleULarixTzFYATpZXtbDQxZTdpwLTvAMpP/YqKw=; b=jzmAmu9GFY3zwt2oxGJBld56/GC4Edrc0nkzeXYZQy9r95IkuWaG7STS7pVnylSJZu POsuNPYLqx5+fv7LMTzcAo6SB0panRPHLV/1Ql1EHfADBYvRrCZo34RAfkvuIOhwvbl2 8KJhoKNms1RyGLqXyO31UIKw5vvh6fnruK6oybD9U5vNjKpoSpEFuzE4hfKSBEciTrQ1 Gp5AJ75dY2dJ3ffAuBZ/8uQsWb+kQeg6PNAvBnyciPDeZzGJihf4iIxkKGFTNcYc80fs QrpzaeH3kv/6QwuqodWnKnVkjkT79JA2gZJ+e6a7IjGH4D2iFDgFMWew0uSvw7bWJa0O HuAg== X-Gm-Message-State: APjAAAUp5Z6NOgCgo3m2MvmfexP98JAcHxAa7vIIb0rzE9mYrm6EGkH6 rW7aFsLrPnq7Vmh+y4uiFuHzEghI X-Google-Smtp-Source: APXvYqybGh0F56uu2T5yrSSdL8twg8yZfdM0TyMOCuNzxHzTCCtNVDFzBSXZ+O1p5yaOgGKrUypY3w== X-Received: by 2002:a05:6214:176e:: with SMTP id et14mr25405745qvb.133.1582216044222; Thu, 20 Feb 2020 08:27:24 -0800 (PST) Received: from localhost.localdomain ([191.83.214.166]) by smtp.gmail.com with ESMTPSA id t23sm2004003qto.88.2020.02.20.08.27.22 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Feb 2020 08:27:23 -0800 (PST) From: James Almer To: ffmpeg-devel@ffmpeg.org Date: Thu, 20 Feb 2020 13:26:00 -0300 Message-Id: <20200220162601.943-1-jamrial@gmail.com> X-Mailer: git-send-email 2.25.0 In-Reply-To: References: MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 3/3 v2] avformat/dashenc: always attempt to enable prft on ldash mode X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Signed-off-by: James Almer --- Now it can be overriden if you explicitly set write_prft to 0. libavformat/dashenc.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c index a52cbc9113..7032adc84d 100644 --- a/libavformat/dashenc.c +++ b/libavformat/dashenc.c @@ -1394,6 +1394,12 @@ static int dash_init(AVFormatContext *s) c->frag_type = FRAG_TYPE_EVERY_FRAME; } + if (c->write_prft < 0) { + c->write_prft = c->ldash; + if (c->ldash) + av_log(s, AV_LOG_INFO, "Enabling Producer Reference Time element for Low Latency mode\n"); + } + if (c->write_prft && !c->utc_timing_url) { av_log(s, AV_LOG_WARNING, "Producer Reference Time element option will be ignored as utc_timing_url is not set\n"); c->write_prft = 0; @@ -2352,7 +2358,7 @@ static const AVOption options[] = { { "lhls", "Enable Low-latency HLS(Experimental). Adds #EXT-X-PREFETCH tag with current segment's URI", OFFSET(lhls), AV_OPT_TYPE_BOOL, { .i64 = 0 }, 0, 1, E }, { "ldash", "Enable Low-latency dash. Constrains the value of a few elements", OFFSET(ldash), AV_OPT_TYPE_BOOL, { .i64 = 0 }, 0, 1, E }, { "master_m3u8_publish_rate", "Publish master playlist every after this many segment intervals", OFFSET(master_publish_rate), AV_OPT_TYPE_INT, {.i64 = 0}, 0, UINT_MAX, E}, - { "write_prft", "Write producer reference time element", OFFSET(write_prft), AV_OPT_TYPE_BOOL, {.i64 = 0}, 0, 1, E}, + { "write_prft", "Write producer reference time element", OFFSET(write_prft), AV_OPT_TYPE_BOOL, {.i64 = -1}, -1, 1, E}, { "mpd_profile", "Set profiles. Elements and values used in the manifest may be constrained by them", OFFSET(profile), AV_OPT_TYPE_FLAGS, {.i64 = MPD_PROFILE_DASH }, 0, UINT_MAX, E, "mpd_profile"}, { "dash", "MPEG-DASH ISO Base media file format live profile", 0, AV_OPT_TYPE_CONST, {.i64 = MPD_PROFILE_DASH }, 0, UINT_MAX, E, "mpd_profile"}, { "dvb_dash", "DVB-DASH profile", 0, AV_OPT_TYPE_CONST, {.i64 = MPD_PROFILE_DVB }, 0, UINT_MAX, E, "mpd_profile"},