From patchwork Wed Jun 2 01:22:24 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mohammad Izadi X-Patchwork-Id: 28038 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a6b:b214:0:0:0:0:0 with SMTP id b20csp85377iof; Tue, 1 Jun 2021 18:47:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxcvDPHpPdFlKHoGDI9mCC6drO8ECPCTG+sOCt12y+RmUfeQyzelSZVsFTNh0QlPCPth0xi X-Received: by 2002:a17:906:5f92:: with SMTP id a18mr18127448eju.25.1622598439147; Tue, 01 Jun 2021 18:47:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622598439; cv=none; d=google.com; s=arc-20160816; b=Oleld9JTPN7IshXOCHRxZHD8KruY4R2WlGWERPCfmr8b170WyrfBB6xio5KHWRVPGY rvxvsR3uOawkR1dgQ1huCFduirG00Zs0kRaXTEJnhP7NPiKNu0VCBiNn1b4+ERCbTulg XEJKPy6jQ517mk7TvRo04SQ6063ovEB7Q6wSa7Yz0ytf3nE30H5FSUOKg1bk5a6vRIlz bMlGd27s9QutOOzqBdBG0hdQnUes81lyXkQbXXgTS4WesQLXMT0y/Ip9aTWOKeDp4dVs uNh5Hvj3iLqV9yddVz3eO/Qo90bEY4IjwETnHXtWAE3aGKHzozSb26NZanpJAZaqBVWs meiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:to:from:references:mime-version :message-id:in-reply-to:date:dkim-signature:delivered-to; bh=/5v8xlUPgN6RHWp2ov40dmJSqt42I9tgm3f5X0RBYOw=; b=tBOTQ9bI9296pB81wsZipuASFali0Kck96YzbXCg9L7i9eAHbvxkOkb51DXtUlO/RS dr9fY0PId+WeOb9KMvjP4rYbbQrLyWj095sJTiTgiyZBMwsDneITRl3VqNVldUNVKRZm ZhUS8KbX4oPnpBkYXQoFffHIDeEziaVgFS3X29k30n881ZMvdgQSG7eWwev5AQrM8Rfc La+MbP++Vg5oYwedxlaTTXTSvgYmUXL1RnfH3LZolFL+VGyhSXvhw/iVWeaTEDta0JrP 1YmkAtbYZy3m/w2WSTUd5/ypw/G2vlEq4QLHRIXmozIO4k8GA53GW6iR0f9K+FM0ctWB Uw1g== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@google.com header.s=20161025 header.b=fLKOSCcP; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id j16si870820edj.357.2021.06.01.18.47.08; Tue, 01 Jun 2021 18:47:19 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@google.com header.s=20161025 header.b=fLKOSCcP; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6CE306808F2; Wed, 2 Jun 2021 04:47:05 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-qt1-f202.google.com (mail-qt1-f202.google.com [209.85.160.202]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 75E4668980E for ; Wed, 2 Jun 2021 04:46:58 +0300 (EEST) Received: by mail-qt1-f202.google.com with SMTP id w1-20020ac87a610000b02902433332a0easo554398qtt.0 for ; Tue, 01 Jun 2021 18:46:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=jGgFBJZGSnC8HhocC2LdKbwNmPHFrkF5bmZ+tOb6XWs=; b=fLKOSCcPT/QESb+dl2wpul27hwggEgd7/swwIdSQZl9+NfuZoHrzAdGsH9A2kuB89L 9OGbbt3qz113l7lC8vPIjNgIbYyAOq8t+QqhKcghjd2E7PPzKxMS7A9BnzX+zp9eMT5j FE4L0ttvLdz8S1AEy/IM5rzVTrDhxnr/OOinTfi/AdzD9gP2/kWVPVRVmqb/5oBe/GMu DvF67FJY9/vQzyJsbK+z2un7MQ6L8Mz2BadLqeT+5Fhu9IFiwchF2EMvnldDPSFy20G5 2u9DWhQq+wOxhjtVCSKFklMUXro+3KVa3OaEBw46pZ+lGGMzibt3omyPGLVfe4gpROM6 IU2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=jGgFBJZGSnC8HhocC2LdKbwNmPHFrkF5bmZ+tOb6XWs=; b=S/eNjrjVfejsYL6Nz1Njd0YxzHYrutqUHq5xCZgRJqyHwNbMkUflgrVGrW3SYYIYwY 4bYfyvrcxV6uUkWYzTlUsVTbCjw8mAoHa3lxwFwqXa9qh+JjUMsRPXlWYECmAcJrFhyM 2SKrzAn5agFXYOMlVwgKFFEU+tSdakeUZpYD/u5hRNpTc1H0XSw/i0/+vdd6t4EyEgyE bNRLvsMLwqPLpPvOW9hgx+ZHhP8sPipd/du+89G/tblwekXho6E1GsoZzN9uHUVoNatH N5iGmLYS4U12BbWgQG9Ch0YVTC0HHVAoi2kiJ4Aslf/lwIROfXD8x8KcnSj4Lvg6jjaD 9Z7g== X-Gm-Message-State: AOAM531ouUJ8qsI1KwscCeSakj7SBGOcedTev4FZy6MFOAmlhet25uqp K3mSaogbeDauI7NsUROqRiRLru5X5J4SevAgY2a20/C35P/qdkiJmUXrgac4frO4s7RdcVUCqyg aAcYPsYkodEYL+AKFCeATK9lz2T9MH3LoJPAtFm9OSN3KlrnJz2YfWkMS3FfL X-Received: from izadi.mtv.corp.google.com ([2620:0:1000:4001:bea5:b791:898c:3efb]) (user=izadi job=sendgmr) by 2002:a05:6214:2125:: with SMTP id r5mr26093356qvc.28.1622596948883; Tue, 01 Jun 2021 18:22:28 -0700 (PDT) Date: Tue, 1 Jun 2021 18:22:24 -0700 In-Reply-To: <20210528114847.GH4777@pb2> Message-Id: <20210602012224.439513-1-izadi@google.com> Mime-Version: 1.0 References: <20210528114847.GH4777@pb2> X-Mailer: git-send-email 2.32.0.rc0.204.g9fa02ecfa5-goog From: Mohammad Izadi To: ffmpeg-devel@ffmpeg.org Subject: [FFmpeg-devel] [PATCH] avcodec: Pass the HDR10+ metadata to the packet side data in VP9 encoder X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Mohammad Izadi Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: BgxuexGurtuL HDR10+ metadata is stored in the bit stream for HEVC. The story is different for VP9 and cannot store the metadata in the bit stream. HDR10+ should be passed to packet side data an stored in the container (mkv) for VP9. This CL is taking HDR10+ from AVFrame side data in libvpxenc and is passing it to the AVPacket side data. --- doc/APIchanges | 2 + libavcodec/avpacket.c | 1 + libavcodec/decode.c | 1 + libavcodec/libvpxenc.c | 94 ++++++++++++++++++++++++++++++++++++++++++ libavcodec/packet.h | 8 ++++ libavcodec/version.h | 2 +- 6 files changed, 107 insertions(+), 1 deletion(-) diff --git a/doc/APIchanges b/doc/APIchanges index c46f4d5304..60995579e5 100644 --- a/doc/APIchanges +++ b/doc/APIchanges @@ -13,6 +13,8 @@ libavutil: 2021-04-27 API changes, most recent first: +2021-05-25 - 8c88a66d3c - lavc 59.2.100 - packet.h + Add AV_PKT_DATA_DYNAMIC_HDR10_PLUS 2021-04-27 - cb3ac722f4 - lavc 59.0.100 - avcodec.h Constified AVCodecParserContext.parser. diff --git a/libavcodec/avpacket.c b/libavcodec/avpacket.c index 7383d12d3e..800bee3489 100644 --- a/libavcodec/avpacket.c +++ b/libavcodec/avpacket.c @@ -289,6 +289,7 @@ const char *av_packet_side_data_name(enum AVPacketSideDataType type) case AV_PKT_DATA_ICC_PROFILE: return "ICC Profile"; case AV_PKT_DATA_DOVI_CONF: return "DOVI configuration record"; case AV_PKT_DATA_S12M_TIMECODE: return "SMPTE ST 12-1:2014 timecode"; + case AV_PKT_DATA_DYNAMIC_HDR10_PLUS: return "HDR10+ Dynamic Metadata (SMPTE 2094-40)"; } return NULL; } diff --git a/libavcodec/decode.c b/libavcodec/decode.c index 75bc7ad98e..40f688e40c 100644 --- a/libavcodec/decode.c +++ b/libavcodec/decode.c @@ -1488,6 +1488,7 @@ int ff_decode_frame_props(AVCodecContext *avctx, AVFrame *frame) { AV_PKT_DATA_A53_CC, AV_FRAME_DATA_A53_CC }, { AV_PKT_DATA_ICC_PROFILE, AV_FRAME_DATA_ICC_PROFILE }, { AV_PKT_DATA_S12M_TIMECODE, AV_FRAME_DATA_S12M_TIMECODE }, + { AV_PKT_DATA_DYNAMIC_HDR10_PLUS, AV_FRAME_DATA_DYNAMIC_HDR_PLUS }, }; if (IS_EMPTY(pkt) && av_fifo_size(avctx->internal->pkt_props) >= sizeof(*pkt)) diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c index 66bad444d0..ca5c1a9f71 100644 --- a/libavcodec/libvpxenc.c +++ b/libavcodec/libvpxenc.c @@ -64,6 +64,11 @@ struct FrameListData { struct FrameListData *next; }; +typedef struct FrameHDR10Plus { + int64_t pts; + AVBufferRef *hdr10_plus; +} FrameHDR10Plus; + typedef struct VPxEncoderContext { AVClass *class; struct vpx_codec_ctx encoder; @@ -121,6 +126,8 @@ typedef struct VPxEncoderContext { int tune_content; int corpus_complexity; int tpl_model; + int discard_hdr10_plus; + AVFifoBuffer *hdr10_plus_fifo; /** * If the driver does not support ROI then warn the first time we * encounter a frame with ROI side data. @@ -316,6 +323,55 @@ static av_cold void free_frame_list(struct FrameListData *list) } } +static av_cold int add_hdr10_plus(AVFifoBuffer *fifo, struct FrameHDR10Plus *data) +{ + int err = av_fifo_grow(fifo, sizeof(FrameHDR10Plus)); + if (err < 0) + return err; + av_fifo_generic_write(fifo, data, sizeof(FrameHDR10Plus), NULL); + return 0; +} + +static av_cold void free_hdr10_plus(struct FrameHDR10Plus *p) +{ + if (!p) + return; + av_buffer_unref(&p->hdr10_plus); + av_free(p); +} + +static av_cold void free_hdr10_plus_fifo(AVFifoBuffer **fifo) +{ + FrameHDR10Plus *frame_hdr10_plus = NULL; + while (av_fifo_size(*fifo) >= sizeof(FrameHDR10Plus)) { + av_fifo_generic_read(*fifo, frame_hdr10_plus, sizeof(FrameHDR10Plus), NULL); + free_hdr10_plus(frame_hdr10_plus); + } + av_fifo_freep(fifo); +} + +static int copy_hdr10_plus_to_pkt(AVFifoBuffer *fifo, AVPacket *pkt) +{ + FrameHDR10Plus *frame_hdr10_plus; + uint8_t *data; + if (av_fifo_size(fifo) < 1) + return 0; + + av_fifo_generic_read(fifo, frame_hdr10_plus, sizeof(*frame_hdr10_plus), NULL); + if (!frame_hdr10_plus || !pkt || !frame_hdr10_plus->hdr10_plus || frame_hdr10_plus->pts != pkt->pts) + return 0; + + data = av_packet_new_side_data(pkt, AV_PKT_DATA_DYNAMIC_HDR10_PLUS, frame_hdr10_plus->hdr10_plus->size); + if (!data) { + free_hdr10_plus(frame_hdr10_plus); + return AVERROR(ENOMEM); + } + memcpy(data, frame_hdr10_plus->hdr10_plus->data, frame_hdr10_plus->hdr10_plus->size); + free_hdr10_plus(frame_hdr10_plus); + + return 0; +} + static av_cold int codecctl_int(AVCodecContext *avctx, enum vp8e_enc_control_id id, int val) { @@ -384,6 +440,7 @@ static av_cold int vpx_free(AVCodecContext *avctx) av_freep(&ctx->twopass_stats.buf); av_freep(&avctx->stats_out); free_frame_list(ctx->coded_frame_list); + free_hdr10_plus_fifo(&ctx->hdr10_plus_fifo); return 0; } @@ -835,6 +892,7 @@ static av_cold int vpx_init(AVCodecContext *avctx, #endif AVDictionaryEntry* en = NULL; + ctx->discard_hdr10_plus = 1; av_log(avctx, AV_LOG_INFO, "%s\n", vpx_codec_version_str()); av_log(avctx, AV_LOG_VERBOSE, "%s\n", vpx_codec_build_config()); @@ -851,6 +909,14 @@ static av_cold int vpx_init(AVCodecContext *avctx, if (avctx->codec_id == AV_CODEC_ID_VP9) { if (set_pix_fmt(avctx, codec_caps, &enccfg, &flags, &img_fmt)) return AVERROR(EINVAL); + // Keep HDR10+ if it has bit depth higher than 8 and + // it has PQ trc (SMPTE2084). + if (enccfg.g_bit_depth > 8 && avctx->color_trc == AVCOL_TRC_SMPTE2084) { + ctx->discard_hdr10_plus = 0; + ctx->hdr10_plus_fifo = av_fifo_alloc(sizeof(FrameHDR10Plus)); + if (!ctx->hdr10_plus_fifo) + return AVERROR(ENOMEM); + } } #endif @@ -1211,6 +1277,15 @@ static int storeframe(AVCodecContext *avctx, struct FrameListData *cx_frame, AV_WB64(side_data, 1); memcpy(side_data + 8, cx_frame->buf_alpha, cx_frame->sz_alpha); } + if (cx_frame->frame_number != -1) { + VPxContext *ctx = avctx->priv_data; + if (!ctx->discard_hdr10_plus) { + int err = copy_hdr10_plus_to_pkt(ctx->hdr10_plus_fifo, pkt); + if (err < 0) + return err; + } + } + return pkt->size; } @@ -1542,6 +1617,7 @@ static int vpx_encode(AVCodecContext *avctx, AVPacket *pkt, const struct vpx_codec_enc_cfg *enccfg = ctx->encoder.config.enc; vpx_svc_layer_id_t layer_id; int layer_id_valid = 0; + AVFrameSideData *hdr10_plus_metadata; if (frame) { const AVFrameSideData *sd = av_frame_get_side_data(frame, AV_FRAME_DATA_REGIONS_OF_INTEREST); @@ -1618,6 +1694,24 @@ static int vpx_encode(AVCodecContext *avctx, AVPacket *pkt, vp9_encode_set_roi(avctx, frame->width, frame->height, sd); } } + + if (!ctx->discard_hdr10_plus) { + // Add HDR10+ metadata to queue. + hdr10_plus_metadata = av_frame_get_side_data(frame, AV_FRAME_DATA_DYNAMIC_HDR_PLUS); + if (hdr10_plus_metadata) { + int err; + struct FrameHDR10Plus *data = av_malloc(sizeof(*data)); + if (!data) + return AVERROR(ENOMEM); + data->pts = frame->pts; + data->hdr10_plus = av_buffer_ref(hdr10_plus_metadata->buf); + if (!data->hdr10_plus) + return AVERROR(ENOMEM); + err = add_hdr10_plus(ctx->hdr10_plus_fifo, data); + if (err < 0) + return err; + } + } } // this is for encoding with preset temporal layering patterns defined in diff --git a/libavcodec/packet.h b/libavcodec/packet.h index fad8341c12..a9d3a9b596 100644 --- a/libavcodec/packet.h +++ b/libavcodec/packet.h @@ -290,6 +290,14 @@ enum AVPacketSideDataType { */ AV_PKT_DATA_S12M_TIMECODE, + /** + * HDR10+ dynamic metadata associated with a video frame. The metadata is in + * the form of the AVDynamicHDRPlus struct and contains + * information for color volume transform - application 4 of + * SMPTE 2094-40:2016 standard. + */ + AV_PKT_DATA_DYNAMIC_HDR10_PLUS, + /** * The number of side data types. * This is not part of the public API/ABI in the sense that it may diff --git a/libavcodec/version.h b/libavcodec/version.h index 48165b9ac4..1288cecebe 100644 --- a/libavcodec/version.h +++ b/libavcodec/version.h @@ -28,7 +28,7 @@ #include "libavutil/version.h" #define LIBAVCODEC_VERSION_MAJOR 59 -#define LIBAVCODEC_VERSION_MINOR 1 +#define LIBAVCODEC_VERSION_MINOR 2 #define LIBAVCODEC_VERSION_MICRO 100 #define LIBAVCODEC_VERSION_INT AV_VERSION_INT(LIBAVCODEC_VERSION_MAJOR, \