From patchwork Wed Jun 2 13:56:07 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Diederick C. Niehorster" X-Patchwork-Id: 28061 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a6b:b214:0:0:0:0:0 with SMTP id b20csp568150iof; Wed, 2 Jun 2021 06:56:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx4YstmxvGeCE0okrosXrIBkmjXb+ILiE12HqhGZxQOLJhWWpwHOv2mw5VQT7IbvKsmZTE6 X-Received: by 2002:a17:906:2bc6:: with SMTP id n6mr28428006ejg.256.1622642188771; Wed, 02 Jun 2021 06:56:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622642188; cv=none; d=google.com; s=arc-20160816; b=Lwx9Zer0BBhhqBj1fJZJiYxu4y14AcaKzS4azbuxwPf+ZVF9JAzUpHGAcE2dORsSCu FQ+iRg2Yl/fdkQwUjVN4WSdcl/74xziGL+15NFGgKd9gSoVo+9lw3eTW4QIBYYlqf25Q qPRmEP8IjORrZ5jiBTUIx8Y4q3OhIU+jikoAs0SCN/wER2la7+iJTN1qhVYTIYOxK2+y r5l/GltMcEutdy1Pm87i7DybgI9c9f9GNV6F4huQOrRxBVhygQ7sEOxgJIIv7NK0YGNC vkMuke8HIgHPPsSYNkQQa1EvsckE9YotF8YCy0XLR+IQ3WnCIsTk5/apcN63uPoNEJgg sE8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:message-id:date:to:from :dkim-signature:delivered-to; bh=gYViOgrhl/55j73Z09yyJapeB+lMwXGxyYO0405RFmw=; b=NADkElpTvCE5I3mgeofFQLuBWciEolSCF6MKNIr90uP6y7X2nWmTzN6dlshpLV2xcR bpc+1LX2aX2vMxDPmYYImDWAk5SeHx8rixXp2OnbntONkgOm48U1w16rRaylbqkcs3Hx 6nHXvr6H2Uai7A4R4YedcwdUZ0ppNUm2MT1tpasxLq7JRGXflO8OMi5dhIaI36qzG1LR gKHK+x/BZ+6SQXTknLKzUNJvUJE+oYGhrYwGTutJtksE/5oCDj/ZnF8DxevSKRnWD3z3 Sk3T/4cgeKM77GNLUK3macjKJTMJYdOEyxQYbgelzfqsDtszP8xFe7lbO7HJWDQ+FGB3 53jw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=uzuMZoGk; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id m9si21476678ejj.281.2021.06.02.06.56.28; Wed, 02 Jun 2021 06:56:28 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=uzuMZoGk; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3679368A0C3; Wed, 2 Jun 2021 16:56:26 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2CCB46899D2 for ; Wed, 2 Jun 2021 16:56:20 +0300 (EEST) Received: by mail-lf1-f44.google.com with SMTP id p17so2773079lfc.6 for ; Wed, 02 Jun 2021 06:56:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=TIR+EewMurdQE+JaK4wwwNM9/ZGlV6RZNEmqKToXkRY=; b=uzuMZoGk5BN4adG5wcFHXpMwYmMbebobX0b2poazvo5BfcopfKO8MTXxvqYUzDNYz4 HaPQl6MYAIrfVX1HX2qqyeFeyqGyYWnRMGyK1ppSqcBgpRrIZ3+WdY00izHMX1spJw4K MkLrPptpSa/bv7bMzpUNDHl4YHEkkU7aC3qQP70e4uCfiX1YnK3Ab9/ImHG6+/qWISKi JazCFpKUw68737X2kefjmOoW97z4MoMnRAc3CmEnUUJG1A5SQ1RRpzrouJm4RWy7D/Lh AircSpGVR9+STkb+VHlhvvSu+XKoMf9uxjnn8ejwci5xhZKRtE8nqTK2r6SSPWu51Zbs hi8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=TIR+EewMurdQE+JaK4wwwNM9/ZGlV6RZNEmqKToXkRY=; b=gvn5kEKTWqbCWLUYfXuxPZmNvkU/NtrfBxoW8bQAZod43XhuvEG8VJARBjmp/yzgDa 8U6DyTkSIRP71gJrlCn+iv0/RuIn/aErHtUumv+yTz3lJO6jjVbK1QJEtXWX1+p+9N0s KdYJwGf9CBgqXN9RIyZho711hhNMGCrEsKHGssCiCoqc88t53wksNXE+XQtyqdR+Q19M Px3Oyk7rjwbQbJaMDUoHskVTBrA0C5L6rzlkw9m/iy0nzDK9lkH5Hd+DV+szKtnyW81y 298hImqYZHticmDIlOH7YhSqPZeWNSJIL7TmkabQFAEZ22AfEzUvHIQqd0b98kERCudw WBMg== X-Gm-Message-State: AOAM530RbLQn1Mm3cFu31eDCAB8FWRyBEj48ILj4sCWVbiyRBhbLlkoT m86LYxhffnSVcFSlfYYbijt+wimmakny2Q== X-Received: by 2002:ac2:430f:: with SMTP id l15mr22217010lfh.297.1622642179183; Wed, 02 Jun 2021 06:56:19 -0700 (PDT) Received: from localhost.localdomain (deedock.humlab.lu.se. [130.235.135.183]) by smtp.gmail.com with ESMTPSA id w23sm2538314ljh.126.2021.06.02.06.56.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Jun 2021 06:56:18 -0700 (PDT) From: Diederick Niehorster To: ffmpeg-devel@ffmpeg.org Date: Wed, 2 Jun 2021 15:56:07 +0200 Message-Id: <20210602135607.2507-1-dcnieho@gmail.com> X-Mailer: git-send-email 2.28.0.windows.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] avdevice/dshow: set no-seek flags X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Diederick Niehorster Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: Ob64X/+M4DfD avdevice/dshow is a realtime device and as such does not support seeking. Therefore, its demuxer format should define the AVFMT_NOBINSEARCH, AVFMT_NOGENSEARCH and AVFMT_NO_BYTE_SEEK flags. With these flags set, attempting to seek (with e.g. avformat_seek_file()) correctly yields -1 (operation not permitted) instead of -22 (invalid argument). This actually seems to apply to many other devices, at least the gdigrab, v4l2, vfwcap, x11grab, fbdev, kmsgrab and android_camera devices, from reading the source. Signed-off-by: Diederick Niehorster --- libavdevice/dshow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavdevice/dshow.c b/libavdevice/dshow.c index 8d0a6fcc09..207a1f8701 100644 --- a/libavdevice/dshow.c +++ b/libavdevice/dshow.c @@ -1335,6 +1335,6 @@ const AVInputFormat ff_dshow_demuxer = { .read_header = dshow_read_header, .read_packet = dshow_read_packet, .read_close = dshow_read_close, - .flags = AVFMT_NOFILE, + .flags = AVFMT_NOFILE | AVFMT_NOBINSEARCH | AVFMT_NOGENSEARCH | AVFMT_NO_BYTE_SEEK, .priv_class = &dshow_class, };