From patchwork Thu Jun 10 21:45:08 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 28199 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a5e:c91a:0:0:0:0:0 with SMTP id z26csp898439iol; Thu, 10 Jun 2021 14:46:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxva8c1QSbDE6sn1SVj0idxHHQUrjEIh28tk2eCMzOcgbtxjBQAOCngnIzZmF+EOiB8qPc0 X-Received: by 2002:aa7:d78d:: with SMTP id s13mr547656edq.208.1623361578657; Thu, 10 Jun 2021 14:46:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623361578; cv=none; d=google.com; s=arc-20160816; b=iDitIJBNGF8lS3UlY7F/fxoMxzTdNDtU52/a1XtnScTxbqU06Q0uxxe49KqTXzvFDQ vXKPjBAwSDfq6NBcnEEK+nzza83iqRPSLleB13lRv4pTxuD7PVI+GqX/4wxm6+76ocFh IvV6W4zmQlk+E9CWkUUFn/D/9/G461pKGqNovNBvmp+AXFty3hZ/GnesM5mswDYfyoDm LbPKR2ryIn8JLs8t4+z/k8g/MpMccaJLw5OBTUQMpBXGVb7c3BcAUXqoJ3oT3YXC61dy zprabUO/wvz0eVJnleVly/obciQSrb+96R6k4NfUhimmtRdM/vKYRzUdoYExjN7Ju/qR ToFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:message-id:date:to:from:delivered-to; bh=giox2NTKL8T8o3RmEWBdc2VgU+yCGXGdcjHxfMsHkZs=; b=LDMBF7wyednPwHmCOB82/5/5GumVzJ7Jc8zTr7GorVro4YG93SmJUm9BB4gfKnVhw9 S4/bCKi590pDGgpNAdg635rt/KGUJovYuzGha/X50gk3qUXgEcY4qah31FNaRmtbOMT9 9JcRZVCKlABzoglnYaRj6GbF1NS4HGPnu6TsqQayNqNNA006kDSPDTCFm6kEXsNSXsqc L4RTUhrvPTY8A76HfBMisBlZ9pQ+WulCSw93RDXvdObYKVz5olO2+29qjFiSziLdqSbp vK5iJbjlR1+M9oKLjfuHNJjrAYmDS/ZQeCTEZS1ovMjshsa2zEMkhWGj/ovFSOjpgfm0 azvw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id go15si3017147ejc.608.2021.06.10.14.46.17; Thu, 10 Jun 2021 14:46:18 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 82D936805AA; Fri, 11 Jun 2021 00:46:14 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from vie01a-dmta-pe03-1.mx.upcmail.net (vie01a-dmta-pe03-1.mx.upcmail.net [62.179.121.160]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A9BEC68019F for ; Fri, 11 Jun 2021 00:46:08 +0300 (EEST) Received: from [172.31.216.235] (helo=vie01a-pemc-psmtp-pe12.mail.upcmail.net) by vie01a-dmta-pe03.mx.upcmail.net with esmtp (Exim 4.92) (envelope-from ) id 1lrSV6-006aDY-0C for ffmpeg-devel@ffmpeg.org; Thu, 10 Jun 2021 23:46:08 +0200 Received: from localhost ([213.47.68.29]) by vie01a-pemc-psmtp-pe12.mail.upcmail.net with ESMTP id rSU8lpVUuljeHrSU8lPqKE; Thu, 10 Jun 2021 23:45:08 +0200 X-Env-Mailfrom: michael@niedermayer.cc X-Env-Rcptto: ffmpeg-devel@ffmpeg.org X-SourceIP: 213.47.68.29 X-CNFS-Analysis: v=2.3 cv=BoHjPrf5 c=1 sm=1 tr=0 a=2hcxjKEKjp0CzLx6oWAm4g==:117 a=2hcxjKEKjp0CzLx6oWAm4g==:17 a=MKtGQD3n3ToA:10 a=1oJP67jkp3AA:10 a=GEAsPZ9sns4A:10 a=ZZnuYtJkoWoA:10 a=nZOtpAppAAAA:20 a=mK4nYLUvolFrDl1DOU8A:9 a=Y5PMgwl996SDHimx:21 a=FqJCBAUlySB4Uda_:21 a=1fhp2MxaeJtTNGEnv6mo:22 a=Z5ABNNGmrOfJ6cZ5bIyy:22 a=bWyr8ysk75zN3GCy5bjg:22 From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Thu, 10 Jun 2021 23:45:08 +0200 Message-Id: <20210610214508.6833-1-michael@niedermayer.cc> X-Mailer: git-send-email 2.17.1 X-CMAE-Envelope: MS4wfLYs7mpDdpTX0SG8N48iPXOl0llfcNy65cGpOJSmQZa1DER5ClExhdZVBGtwmlsxwfSbMgQKl5XHgeaf2f96CR6fAu6Sivmm5BX028G81tMd6mSpBEba NCtXUqafScHa8Isb/OxVT46jAq+Uok/ikHyxZvNOPDJ9Z0NsY/ZKZjRd Subject: [FFmpeg-devel] [PATCH] avformat/rpl: The associative law doesnt hold in C X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: Rul2PDVKfXVv Add () to avoid undefined behavior Fixes: signed integer overflow: 9223372036854775790 + 57 cannot be represented in type 'long' Fixes: 34983/clusterfuzz-testcase-minimized-ffmpeg_dem_RPL_fuzzer-5765822923538432 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/rpl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/rpl.c b/libavformat/rpl.c index fac377b68e..296cb2c984 100644 --- a/libavformat/rpl.c +++ b/libavformat/rpl.c @@ -103,7 +103,7 @@ static AVRational read_fps(const char* line, int* error) // Truncate any numerator too large to fit into an int64_t if (num > (INT64_MAX - 9) / 10 || den > INT64_MAX / 10) break; - num = 10 * num + *line - '0'; + num = 10 * num + (*line - '0'); den *= 10; } if (!num)