From patchwork Wed Jul 21 18:00:18 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anselm Busse X-Patchwork-Id: 29001 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a5d:965a:0:0:0:0:0 with SMTP id d26csp6402794ios; Wed, 21 Jul 2021 11:00:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzkxni5HkRi21DXOLKxl+kI2TFgVDv43iIlnsj1t+WpCKdaVdt8uNDCO0tpTU9FlT99Mbge X-Received: by 2002:a05:6402:22c6:: with SMTP id dm6mr50004336edb.228.1626890452892; Wed, 21 Jul 2021 11:00:52 -0700 (PDT) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id c17si30241899edr.45.2021.07.21.11.00.52; Wed, 21 Jul 2021 11:00:52 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@outlook.com header.s=selector1 header.b=F4Pb84PC; arc=fail (body hash mismatch); spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=outlook.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id AF36F68A94E; Wed, 21 Jul 2021 21:00:48 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-oln040092064011.outbound.protection.outlook.com [40.92.64.11]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6F41E68A5AD for ; Wed, 21 Jul 2021 21:00:42 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BaDGeuCNxbyHIqepUeWUwuNXXrmoGRyspUUk2wy+HLXbxouy1c5Z040CVdFhnrghW+dKtcZzsOEPzww1WXjPP4pbR9Y5MvB3cl9+rM7KAoR3fATLhPYyouVk0NoA/GhqFdguuOtOtoPCPMQEMwze6cs4nQfqCcqO8SRMsO9IR1Tt8ToiF9Zl+yQ/1PAAxcJfQ77BFFipZw920NkEpiGQRySjmIEZ03cD64baG/gnflIfMxPPWDzAZyhyYJqTO34YDy3OtxtqN4A+zBNpmEbVsYesczQzXyyaRaz8fPj9dCWpZPXFYDO0UB5ghz3xVbaA2U9MkVaNa8l5KIzZ1ewpdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Y4h2Nffif0nGGLz7cwlgt431h/JEN9u0Oyjn/83i0FU=; b=eqiHqE0hi1mCYsMgLycRFZIBeWD5EjdgBIZ7yww2cEu7HcE5tCeE4iCxPBNlVdz/iPFIXL+4NUrla69FRYeFKQwXpGvUejADX4tgGhlEmidI1RE/+kU8ERCLpYdt02RJDzjvDRB6QywnGPisaF0KRUfe0sfwhP0SjfnO8QphLKXei9OH7dgFtU4SYqoG9xaeGyHZl64u4PHHa4knkjfWE22GVhK/bqTbuqgNtJfwfBdmFvi2qdQRneqy9MXvOtnrtb3uy1Nag44yZhzZBGC1JO9LelKXnWosEB9V2i6JuDrKwuBaXfWQ+TuO/HuQl+azCrqIq4QOVH9l/VIufLM9EA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Y4h2Nffif0nGGLz7cwlgt431h/JEN9u0Oyjn/83i0FU=; b=F4Pb84PCfGp5nVzau1OLIww3a1PQCSmAlLYg2DcS38PGlXRO0NlUjtNt5A/Tsnv+fNJCRC7D4YNs77hZ7jntFaS88JJI5q89l5HWOk701Jhn+IyK5peN9MqDKYYo9nnBZBxuWGhTyF3UWGu8U14HAjc5yrDQSxNwKLzdzpPlA7P81n5e1xERmqtNMDkGwGKYZWfB+MDww/KXdM/lKFuLZpnmdpLRXp2DuH/i5TXQlyKcHqpBmrtM14/18L/bM6nm9pUfdTQVNvbB06sC8i5rBaAU5Qw8KgHiUzD/wIw7vLwbfJCO6b2ARbuUaHqef/1s5RwDfJwypYpWy5qmBRQABQ== Received: from HE1EUR01FT033.eop-EUR01.prod.protection.outlook.com (2a01:111:e400:7e18::53) by HE1EUR01HT081.eop-EUR01.prod.protection.outlook.com (2a01:111:e400:7e18::266) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4352.24; Wed, 21 Jul 2021 18:00:40 +0000 Received: from AS8P193MB1447.EURP193.PROD.OUTLOOK.COM (2a01:111:e400:7e18::4b) by HE1EUR01FT033.mail.protection.outlook.com (2a01:111:e400:7e18::178) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4352.24 via Frontend Transport; Wed, 21 Jul 2021 18:00:40 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:A774A209A046B6003600E2727D71ABFC278ABF857DA661EB749D7CC72695021A; UpperCasedChecksum:692C598357872D28FDF2B9532F4F0DDCA23F0A30EAC91AC3B7267271BE8DDA5A; SizeAsReceived:7309; Count:45 Received: from AS8P193MB1447.EURP193.PROD.OUTLOOK.COM ([fe80::25c8:8edd:9302:2671]) by AS8P193MB1447.EURP193.PROD.OUTLOOK.COM ([fe80::25c8:8edd:9302:2671%6]) with mapi id 15.20.4352.025; Wed, 21 Jul 2021 18:00:40 +0000 From: Anselm Busse To: ffmpeg-devel@ffmpeg.org Date: Wed, 21 Jul 2021 20:00:18 +0200 Message-ID: X-Mailer: git-send-email 2.32.0 X-TMN: [+8UBxw7pubCBPbXwx/mBVoZD7gSuQtz8] X-ClientProxiedBy: ZR0P278CA0151.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:41::12) To AS8P193MB1447.EURP193.PROD.OUTLOOK.COM (2603:10a6:20b:39d::7) X-Microsoft-Original-Message-ID: <20210721180018.36844-1-anselm.busse@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost.localdomain (91.65.110.237) by ZR0P278CA0151.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:41::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.22 via Frontend Transport; Wed, 21 Jul 2021 18:00:39 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 45 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: 1ae47648-8bb1-4d7d-8246-08d94c717349 X-MS-Exchange-SLBlob-MailProps: lHNTL7xaWTgjyw6CBs9bRf+J7UYhV8HIxDfzUbVRPIUwONAHgSSf7Ti010XV8wzMfCai8K5gE5O0wlyUpLTywNKa6jiA3Te9tZLWoHBTQ1rZDpJtUSji6XCPulJzV1WxmGE6SmHw/RkganoipjU/FUkxTEXXNlFVuNvl7ATbH8flVyFBWdMfJq+CwK4kX4XuDIoEyI+/+rlogBaNYK28fILKxk7Mwttv95TyEHQvrfAA6SwKB49QQrG9x/SVQbdkh136SM9MS0PBuqLaXr4blzXR6+5rGpWVe/VN8qz880x+LpA+QmF2GQsCOjmFRRZ8iAYIu9WpstaqZRL8gbdtOpDnVGu0uYJJ3VZ2ZCaSeBm8vMNMtphKt+V9fvAfJk9PRwramBmr45nLzGCkNxtGtyIiOs02ge1Fzl7LJX8tK3X3pESimUwF2puu2kMkcWxvM6228oF+SXTw5yEB93rJYjY8/ATIB5H0o0DSNpo/vrI94zqVsQPPGtcFzMqepaz0XUD1PuCAgiOmOKsnltNjdvzDYBYhBIA8I3Q7b5fouMISD7aXt9MGcyjAYKz9hTcVeoH6BlJU7Ml6T3yKbso3t4ifbAgxLy342IPBaCK2hzhEGtMP4P2jbINIrB80sadSsxMGdQbmaJMf0HveA5mM4lZzT8jS001U2rIlYpmBNw+ZjsHMdDPi1Ji/yr2AIjYSf4FOMvyKHeLpKyFJJDn46vNCFnzYFQ5/M3gLZn8vkpfd7JgPxAat68memdhym8NyOT4PhUrteff0NVpjx+9n1JdnVnu8mTNEEqwbMj9sl27jEoSiNfzHSQUZay5aN5XbclWYd1KFi0S7aw1Ix0lB/4snoJ25Wa1E6b1oXtBlSrSInpaFP/pDFdEy5gvhlh5oe8435SZAGKgeTEOvwX6Y8b9wV6YxsfRH2iGb31+xC67wc0L1D2VTASoSx1RunDcS5zrBJW/RdpE= X-MS-TrafficTypeDiagnostic: HE1EUR01HT081: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ONfkqfvucUisfYOwlLpmMvQqn8DdmrR54u5yYlWyEZPcZTxVDyYKBvmZa/19h4LBappVYDr7hKk1Hfxu71lWBqR4ncr1Df+EFfR2kgqroRq/axrh95NfVfoHT/KIEMtTaCC0F66iykTB9eO4y1+XlPM8UsNMnYm5zfXujHAZqhYfS67canTENi/2vNLM/FTR4sdJZqkENRDm5P4xEuxKRXJVs18GPD7iZbjjcf5eiqeQ/JxSQH02JwrBpgY13KltYPeBONBgcQE6ren6q+IGO8ttrg7x1X95FtOajE3SbITErwdlzwRUXDBNcfv3kV5V/UP9JrOoZKLINVUWxD+op3amPZcsHJaXudyS0ATA8G9C1ORLlrHRKvdh+9oUgWCdklPteYcFxvJiukkZPIRQ8lw/QQJ29/4FuKnb4D7bFGUBJGCoi5JHRflEd3V/twvXvSels+MZZtNqcwKUf9muWO1s/Hfh+gJtElAkS9qAEBI= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: u3YGpQjXOrdGyoyjZmeThYLm/RBnaknUK6OgCr4lvWsvqwedExrABkjLMDhHLYZr8JeaK+bIE5vQfGfhkTrh6p/ZH++uKaTzuim8LZpvF9huDFOd08onCg3UMc8jcy8zOJro7JysvvRZMxiq6dKDKw== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1ae47648-8bb1-4d7d-8246-08d94c717349 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2021 18:00:40.1875 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: HE1EUR01FT033.eop-EUR01.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1EUR01HT081 Subject: [FFmpeg-devel] [PATCH] Fix for bug #9231: B-frames parameter is ignored in videotoolboxenc X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Anselm Busse Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: D++FdElZIgus This commit fixes the bug as report in https://trac.ffmpeg.org/ticket/9231 by removing the line that overwrites the user settings for max_b_frames. Signed-off-by: Anselm Busse --- libavcodec/videotoolboxenc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c index 4eaabed5d8..8dfd6e3d0c 100644 --- a/libavcodec/videotoolboxenc.c +++ b/libavcodec/videotoolboxenc.c @@ -1398,7 +1398,6 @@ static int vtenc_configure_encoder(AVCodecContext *avctx) } vtctx->codec_id = avctx->codec_id; - avctx->max_b_frames = 16; if (vtctx->codec_id == AV_CODEC_ID_H264) { vtctx->get_param_set_func = CMVideoFormatDescriptionGetH264ParameterSetAtIndex;