From patchwork Thu Sep 2 08:26:56 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhao Zhili X-Patchwork-Id: 29945 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6602:2a4a:0:0:0:0 with SMTP id k10csp65056iov; Thu, 2 Sep 2021 01:27:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwK+JJ5hPAtbKqIdI7GRMyPQ6MlhGApTf+j/QJ4p4Q5zAa00KFhE1eXapZkX4f7TP4yjcL5 X-Received: by 2002:a17:906:3e1b:: with SMTP id k27mr2528236eji.284.1630571238727; Thu, 02 Sep 2021 01:27:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630571238; cv=none; d=google.com; s=arc-20160816; b=Ssn8UpiYiAW8wSRjr27qgbEceEUAnJAyPJs+sdqJrjkvsYESIvc0gFQO6jWiy8xa2H QTXw/zf99d7G2DoHEujncWu2nHs1kR/pmk9fGLADEiLDryIbJTeYlAyLVSQuCsN9fkO0 qyuErKzsC6yAqGXdHo7QTaqbQUO6EgHYrLJ/zGQWrpljS6Amc9+mglKHc0mRjsNfpK4f DKSq7IIfRwwn92iM7ir9VSAaAo4DtuWM7ASVaL0+Uv0lnSKHCMvffKbBGq/HX8dnZCNA C2ss4SGO3kVwwNwnRTLPzs4nAf+Cdkzwr4bSgr1brbCKJSHJ5W2BfgMtGVqiHuYb0m+A Mv6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:date:to:from:message-id :dkim-signature:delivered-to; bh=ws1lv64TyUFFKzHnTzXlR9hhCG7OtlIxCobPMDVzH0o=; b=xFNuysf+5oA7iA90eET7v8Ssh0dGP80rf8tOMiTXsLXOrwY4OTny6ShYMbWgfQrkvb ROflkB4TY/wFIw18xtgRDVu5Zp3WOA7nL7qXEG/xtrbnmOjjAryF1fKUeSCzErLfQcif K3kCd6Hh84oYzooGb2fMdDLdp96SQJJkdsvg+78wo56ybLG7t80y3by0ph5NGq4f2xqd M8zbX0HPXtupw1pXO+Eam1iWyqGCVkI6GjPn4b7caszI8ZXj7avmPak/T/TTiiE6yHNA ok18g/e9Fzo/wgVCKJ70TvXlg6wtSo1gb8B3+VWMhcjqAMVIkPTQ0TeI24j9ooREjePk ehIg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@foxmail.com header.s=s201512 header.b=nmf0fPgs; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=foxmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id o5si1370237edq.137.2021.09.02.01.27.17; Thu, 02 Sep 2021 01:27:18 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@foxmail.com header.s=s201512 header.b=nmf0fPgs; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=foxmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 821EA68A15F; Thu, 2 Sep 2021 11:27:12 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from out203-205-221-173.mail.qq.com (out203-205-221-173.mail.qq.com [203.205.221.173]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A6AD668041C for ; Thu, 2 Sep 2021 11:27:03 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1630571220; bh=bhwzuJVZrCedPltwesvGWlTp3vRUQfoqTCjzshoRU1s=; h=From:To:Cc:Subject:Date; b=nmf0fPgs0Ib4bTv8l/tVl9xtA14HnCk48pO/epWd8BQUKMC2Jxwvm8CbK+WZnor6p 29Tjbvcfejet8ocY4S9yUndwLKj0H+r8LoiJCBaujQN5dFX+bmqGxNCT2R8MJXTv0/ ViWT0olHiNMMwe1eQcbbdWzOfRA12kBRavNB16KY= Received: from ZHILIZHAO-MB2.tencent.com ([59.37.125.37]) by newxmesmtplogicsvrszc8.qq.com (NewEsmtp) with SMTP id 6BA3C68A; Thu, 02 Sep 2021 16:26:58 +0800 X-QQ-mid: xmsmtpt1630571218tzzy1bqwy Message-ID: X-QQ-XMAILINFO: OEaI/iTChbuglwyh7AdoGtlIwmiO2LsxQvokJq9cpsK2I5yzt//2u7pM4DNhSj Gu0SUOsPqjhDH2kMkG1zgDqUW/4aXRg2Gk1FMbFS1zp9n+BTEsFI9Kov1S5QL80AyYpu9JOdH6Kd TT6L1xBRnAgFv93ybmqma5IQp8KCTLGuOyHB3NUDCDhGVmpkAwVvwYdlmO7poYeou6iB27NO8v12 7zTVls6YMV2HJRkm3geBtpGScrIXrt4IY2lkLRH/d07GeZ/+BeZmvII3A1ACr5mDyHvQeDIW322r sWRkYL65PzB8qah1+42CpwAi1menYmeXoMDpnOSROQNCNpfhvoaZDP+7jn4KwD+y4Iy1rG2N9tk0 gZ61ssU8k/RM8xC0zXnCU81bYD8UDhNf+6xyZYEpIFWrQI3u+EQnuef/bT2AKjLerWG1lTDTkJP1 vop8QUtC0NOr+LbBTbWYafYo+zFg7nxibpUkR1qnPgbY9/ohHCp0cKqdMvMgbLptrCDQgrCO6DZL 4C/jniXed3T+P7MY6Uc7nkMs3OnfVm8bUG6cVcxvzqKqiE6PgvE7gea9l6mJmSLUXBM0hxht+j4s 1160RNs8ku4B5c95BRokMnBCn8r3fchNpb5MisP3Rur+8Ls8F/xpJW2yhQOEO9gXf/7GU9Co1LGO yqIwpiURC+6QGkzYUl+JTWjRU7iQ2l+gpdug1D3eBpLSGA+5FfQyCXUZi5aTZsdFxe6C4pWnWBRP 0CeOx2P0J4LYO82PnVxXrxB+4HAjaCZ8RW8B9+Vxb7JvnhkhiS0aIXVI7ojYoGnWdyJzaz6TkpGW 9pSpzqnlvs2dO1CvJqRytDFwIgRTzybHwAmrlRYp6EnTbblNSQoSO4 From: Zhao Zhili To: ffmpeg-devel@ffmpeg.org Date: Thu, 2 Sep 2021 16:26:56 +0800 X-OQ-MSGID: <20210902082656.74061-1-quinkblack@foxmail.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] avformat/mov: reword log message about dref X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Zhao Zhili Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: RcgGDJB9Dehu Most of the times it's just 'url ', so it's not unknown. --- By the way, there is a patch to add support for dref.url https://patchwork.ffmpeg.org/project/ffmpeg/patch/1596807454-17939-2-git-send-email-mypopydev@gmail.com/ I agree there are safety issues. libavformat/mov.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index c5583e07c7..c4024fc402 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -708,8 +708,8 @@ static int mov_read_dref(MOVContext *c, AVIOContext *pb, MOVAtom atom) avio_skip(pb, len); } } else { - av_log(c->fc, AV_LOG_DEBUG, "Unknown dref type 0x%08"PRIx32" size %"PRIu32"\n", - dref->type, size); + av_log(c->fc, AV_LOG_DEBUG, "Ignore dref type %s size %"PRIu32"\n", + av_fourcc2str(dref->type), size); entries--; i--; }