From patchwork Sun Mar 8 15:49:47 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andriy Gelman X-Patchwork-Id: 18092 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 51DA944AC31 for ; Sun, 8 Mar 2020 17:55:59 +0200 (EET) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2E02168972E; Sun, 8 Mar 2020 17:55:59 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-qt1-f193.google.com (mail-qt1-f193.google.com [209.85.160.193]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id CB2B06880FE for ; Sun, 8 Mar 2020 17:55:52 +0200 (EET) Received: by mail-qt1-f193.google.com with SMTP id e20so5332480qto.5 for ; Sun, 08 Mar 2020 08:55:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=2w4YT2S4S/Oe75b5Gwov4XBBz7AG6WZgstjvCngQS3M=; b=SdkSZ+XrWHW185/Ir7MLIdSyq4jX9lCDRdiSMrdVVnXL//T8NM13M1FelzMrvs5t2R UakG+MPYPI3aJmf7oWkO0c+In+11XPNFFJrEgM4lArIgy/Kn3hNV8P5LmpQU8OAVn69h igp2mllwonfSui7sC0BVPcHROmsqU8I9pZcCAbB0A8rX7fvrmzUNYli2Kp/pqgKO4SFG amoI8IcKOfIqL8+o40G3NsQsyM33LgAZpR/Mo7H/3H/hHTAtIJu1Xxjh7qDU61mDFV0f ch83Pre2FD90fYBaxEZCbaqe3S2Js2BUlWg49Y1P1RsMtk/Yyu+LfbretbDV5746PbnE fx6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=2w4YT2S4S/Oe75b5Gwov4XBBz7AG6WZgstjvCngQS3M=; b=gD6kjxpXEXzECuKQzmQsPIXBcfwt8VGI7iPEkRhbwLruqfGR1kPPPh70T8TFqZjAKG ixfTlNxMtBv7HnWmlTrtDiHPfTjS/nwfjoq6L2FXzl0uwev2LbjWwcprULsmCn5uH1qq 4VuCpBT3mn83w/99V5riIkdXI03icydzYN7YJILj0P1PZFx5AvQs53A7imjVn9o/AKDs Zjxu/Fmim3MIVL5xk+u94T5WoLdaqxFbW/QVfFJx9RJ9FRWQQDHZmfNpktyqtBLaQur5 hEXx/y+GMyr5OqbCjNAhW/14CXu3EPYnvwlt5Gb3J9bU7zPju3WVXjpAiDGgJiyUYr5B aDGg== X-Gm-Message-State: ANhLgQ3+pg9OylgHXHfRjgt80OK7E+UbkEFyjIoUEcWFFSFKZXN7M8Tg etsSXTAR+guIWTaCuL+2n8bXNu4M X-Google-Smtp-Source: ADFU+vsE/jpOBQdSXOWFiSpxW+MSLcv72eyxg6svt6isFzuBgzgQZDGmCsa57YA7eoo0qwH53vVI4w== X-Received: by 2002:ae9:ef87:: with SMTP id d129mr12028949qkg.329.1583682604802; Sun, 08 Mar 2020 08:50:04 -0700 (PDT) Received: from localhost.localdomain (c-71-232-27-28.hsd1.ma.comcast.net. [71.232.27.28]) by smtp.gmail.com with ESMTPSA id f19sm12856075qtp.46.2020.03.08.08.50.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Mar 2020 08:50:04 -0700 (PDT) From: Andriy Gelman X-Google-Original-From: Andriy Gelman To: ffmpeg-devel@ffmpeg.org Date: Sun, 8 Mar 2020 11:49:47 -0400 Message-Id: <20200308154947.25191-1-andriy.gelman@gmail.com> X-Mailer: git-send-email 2.25.0 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] lavc/v4l2_m2m_dec: Init reserved bytes to zero before ioctl call X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andriy Gelman Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" From: Andriy Gelman struct v4l2_selection contains reserved bytes which should be set to zero before the ioctl call. Fixes valgrind error: Syscall param ioctl(VKI_V4L2_S_SELECTION) points to uninitialised byte(s) Signed-off-by: Andriy Gelman --- libavcodec/v4l2_m2m_dec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/v4l2_m2m_dec.c b/libavcodec/v4l2_m2m_dec.c index d666edffe46..c5ee86b9935 100644 --- a/libavcodec/v4l2_m2m_dec.c +++ b/libavcodec/v4l2_m2m_dec.c @@ -39,7 +39,7 @@ static int v4l2_try_start(AVCodecContext *avctx) V4L2m2mContext *s = ((V4L2m2mPriv*)avctx->priv_data)->context; V4L2Context *const capture = &s->capture; V4L2Context *const output = &s->output; - struct v4l2_selection selection; + struct v4l2_selection selection = { 0 }; int ret; /* 1. start the output process */