From patchwork Tue Nov 9 10:56:28 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: YuTong Song <13102179620@163.com> X-Patchwork-Id: 31339 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a6b:d206:0:0:0:0:0 with SMTP id q6csp977302iob; Tue, 9 Nov 2021 02:57:06 -0800 (PST) X-Google-Smtp-Source: ABdhPJwAYi4dGDWR1Q5ZepURZ89E1m774YDAu0DSQwXmgNklfahmnkdgwj+3SddCOU7eUGjCtI56 X-Received: by 2002:a05:6402:d0b:: with SMTP id eb11mr8882201edb.388.1636455426694; Tue, 09 Nov 2021 02:57:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1636455426; cv=none; d=google.com; s=arc-20160816; b=vP5fOJ88bkJ9Nir9KqnrnKi8cSMvheiYJldsMcGlQNGQtQFCxId8q1RF9s4KnnsrUi 9wIOeQUPk2bhFyX0zgenBIAbe5LTUyeyVXCp9EyX8LVDh9eVpacM4DVZwhglsKgzEOFA cD9P0K09j/QL+ALbCnr7GBpp5MdPO3wxn2tB3I9Ntz0xS8gCfwRsNL9NazaJMEwCDHEp RGmkhweeFVRGfncSCYUTzJahJqHztcIyBbLOq2FFNXDG2sx1PbXKbxELfkLNmxWzopHP gOVqWX7KMlXrfScuqsgoooUSMXGJxiUETwXldevQOeiIl+jnskJBpPRrLsNI4kkT170y gHzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:message-id:date:to:from :dkim-signature:delivered-to; bh=pF2CbRyogqhRWOJT+v0STBJ1Yl3Ou1BbYXlsHQuqv9E=; b=Bu60fvxlLKLRhkZJM1LqL8WSjlpuFG0p2U/nDMB/DFK9DtfDej3i2vOfjSRxRtMzEs OCm59tg6CD/SYSqWh64RQ/iyDXPsCZdojqovT1kX5FpTXWeGty0k4KfEQD0jqVvS5D7z I/fANtvOV8CRKZAkqRtNmot3CSWXJ2Iui4X+auYKVZKNrd3+2GAVwgMERnW8E6w+kP4B GQozerGhLRX+Ky5Woz72RQ05k27nk2heQ8FsSKpZLVIPNqdazYllH1NPcHgYxEg1ll1/ L3ftuFiZiBYpEK5br79hc831Sg4+v6Gi9KZTBjGRlaIGR7NVSq3+t0iSa8rsn5XFEYq7 /aXg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@163.com header.s=s110527 header.b=W0i3GTTX; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=163.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id z17si38111976edc.136.2021.11.09.02.57.06; Tue, 09 Nov 2021 02:57:06 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@163.com header.s=s110527 header.b=W0i3GTTX; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=163.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3A2FF68A5FE; Tue, 9 Nov 2021 12:57:03 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from m12-11.163.com (m12-11.163.com [220.181.12.11]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D5485680717 for ; Tue, 9 Nov 2021 12:56:55 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=q/F8I SDuRwfYJVO0sDgkdSa+J0FEjvdfFU1sdv65j2o=; b=W0i3GTTXTMFOxMm4UaOo7 Sd9tqT6EYVEwRZcI9KpmJmGwUZq5Ex2K9sjgOE6AL4RntRRGBhA9vV1o++sOW9zx Eae+3K5D+X6EfrwnznEviEK6UQcO4Cu1Zk0D/ojf701KYbCOHlj3gDuqnRYcr1DH wxLqtMVdwvSFDU4hng2RII= Received: from localhost.localdomain (unknown [103.107.216.230]) by smtp7 (Coremail) with SMTP id C8CowAB3vrb1U4phgoieDw--.42220S2; Tue, 09 Nov 2021 18:56:53 +0800 (CST) From: YuTong Song <13102179620@163.com> To: ffmpeg-devel@ffmpeg.org Date: Tue, 9 Nov 2021 18:56:28 +0800 Message-Id: <20211109105628.9731-1-13102179620@163.com> X-Mailer: git-send-email 2.30.0 MIME-Version: 1.0 X-CM-TRANSID: C8CowAB3vrb1U4phgoieDw--.42220S2 X-Coremail-Antispam: 1Uf129KBjvdXoWrKFyxGr4UWFW7WFWrCF4fuFg_yoW3XFc_GF W8WFy8Ars0van7ta1UZFWrKw42gFs5ZrW8twsrtrW7AF95JFs8AwnrZrnIgw15Ja1UCF95 Kw1xXryxtw1aqjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IU1qQ6tUUUUU== X-Originating-IP: [103.107.216.230] X-CM-SenderInfo: jprtiiisrxmlisq6il2tof0z/1tbiYxVGj1aEFVkLpgAAsM Subject: [FFmpeg-devel] [PATCH] libavcodec/videotoolboxenc: fix pixel buffer memory leak X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: songyutong Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: GUoAtq/c3wK+ From: songyutong In function vtenc_populate_extradata(), there is a manually created pixel buffer that has not been released. So we should use CVPixelBufferRelease to release this pixel buffer at the end, otherwise will cause a memory leak. --- libavcodec/videotoolboxenc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c index 8a02d3d1a0..c06b506cc9 100644 --- a/libavcodec/videotoolboxenc.c +++ b/libavcodec/videotoolboxenc.c @@ -2548,6 +2548,7 @@ static int vtenc_populate_extradata(AVCodecContext *avctx, pe_cleanup: + CVPixelBufferRelease(pix_buf); if(vtctx->session) CFRelease(vtctx->session);