From patchwork Wed Nov 10 12:59:40 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Rheinhardt X-Patchwork-Id: 31361 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a6b:d206:0:0:0:0:0 with SMTP id q6csp402897iob; Wed, 10 Nov 2021 05:00:03 -0800 (PST) X-Google-Smtp-Source: ABdhPJxdHMTmu9rl8WxDu8bsh/qBXvtVk8PZ42Z0h0FI2IF7HKeu6Rv6hutdgM+lvUpX6HxuGWcv X-Received: by 2002:a17:906:e28b:: with SMTP id gg11mr20752228ejb.23.1636549203325; Wed, 10 Nov 2021 05:00:03 -0800 (PST) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id g23si35076731ejk.552.2021.11.10.05.00.02; Wed, 10 Nov 2021 05:00:03 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@outlook.com header.s=selector1 header.b=rYxFdQ4g; arc=fail (body hash mismatch); spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=outlook.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E183D68A89E; Wed, 10 Nov 2021 14:59:58 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05olkn2049.outbound.protection.outlook.com [40.92.89.49]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C68E7681865 for ; Wed, 10 Nov 2021 14:59:51 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CLEaf9NlwrkE3/erM5v55Sv6DAjd18F1+LJRLQauyIzo5PPCjlpeGzmWF/2Ap0/bBDsiGnU6A/vP4QHUBoCKySpurnRlC9VBN9jG1dSAT1YmLo2xOpKz+8/L09lgaXu64PZ0H1QpZDBoyRgDDYDD11wpCPz3i6KHP/NhC9W3HGeln769/WIuQgOu/lN3gcwJdP51SxG4XfkqatXPB+eZAGttG/KGILzgWM27V2eywzha5xE3Ewvk8OBhor0+oR+fthuxqoyVskrp+YRm6/t2m9Bk5lR1++oxkJASsZf1CVnVDqcPrgnD1d/VEywKKIJPxJzmxQngKY0w4UpWWOLN7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OWHl/9Mr+TBwdOePOhn0BkBlwSD/8nb5wQQiUujeUsc=; b=N9TUSKKPDEum1fBBmA97AWnmtmVKDsufuBMBirnvZPhkbtrptN8JirjdsRLdgwHanGFOxXpX6qWTL3TeYArjAAMdr+S3++eAOGfMBxroZsKlP/jEh207+f01pgIZQshW2U0fu12GrAWQ0b2NGKvMS1kx7O1A3pTeWVkOyGj6B5lFl+GgjTzbUad68aIthkkXWNpCfXlhuXnIkqjL3xnhJTNgaHIU2PDm7nlCv2Ut63d9RKVpF2TOpfpe4MTD5/WO3FBzTHC5rRESdewEIGOcEKNjivnAN8WvPCs4rMczsPorBgKHdT9LgoeIhyrTGlRVQKWcyGzt4eQt7oYBnexnAQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OWHl/9Mr+TBwdOePOhn0BkBlwSD/8nb5wQQiUujeUsc=; b=rYxFdQ4gt1hyRQ1TYRkyznBhMlHbvZegPlG/xPCfAlGaUriB7RhnrLgf2fTJo9HrA7lOiu4cgYjQC45CPtD5h5vByV0iBfPy7bpKRfb2sz5LNhqCBKMHQ+cqXh8GaNejYiwaHdBYarsPR6mKPeRmDPlfzUVolO/PEIepezOPnLI+hfuKySkYxk5sQWlx4J3mO4NT1ju4QRP7NXsr7eXvgHHW3jZs3BAyRV9U3UPL4mMnmcdXRMhVkkgLM34zCegFkA1lGXgDv8bYS03UGgO8plHrejC5s1rI+rYf8zLtYhMg7WkzGEoIB24AYfmG1dD7uULV9f2Zs+ngq0ySAK9Bow== Received: from AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) by AM5PR0301MB2435.eurprd03.prod.outlook.com (2603:10a6:203:11::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.11; Wed, 10 Nov 2021 12:59:50 +0000 Received: from AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::700f:d70b:3bb8:4d51]) by AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::700f:d70b:3bb8:4d51%8]) with mapi id 15.20.4669.016; Wed, 10 Nov 2021 12:59:49 +0000 From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Wed, 10 Nov 2021 13:59:40 +0100 Message-ID: X-Mailer: git-send-email 2.30.2 X-TMN: [uaJAtqBGulujJuBDHqcvkFPBGCeWq4gG] X-ClientProxiedBy: AM0PR05CA0077.eurprd05.prod.outlook.com (2603:10a6:208:136::17) To AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) X-Microsoft-Original-Message-ID: <20211110125941.891020-1-andreas.rheinhardt@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from sblaptop.fritz.box (188.193.171.90) by AM0PR05CA0077.eurprd05.prod.outlook.com (2603:10a6:208:136::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.15 via Frontend Transport; Wed, 10 Nov 2021 12:59:48 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 28efa125-1c07-4f31-012f-08d9a449fa2d X-MS-Exchange-SLBlob-MailProps: gjx25WM8ZNW0zY7tAuNIKRoEeWMNkk8PBw8QIykAgTVzX9aVHeWCoGMZY8j3qSBcrsBsHgvcDzvjwmGezS104kcPSz5r0NpKwiF4rAz3QcYBeRyymhZ3hVwESvqZx91XnWQTH8eQ/zF7JZscCqvCSTbBdEcbMAxRcQimqWv3uiscbkLsOnfHcMnjizK44Nzzpo62qxXU5r/SDAY1RoBcvPTOZjjHffKCo7+k0dbgcR7s733V1vFr3vzLQO3zVnX2ujpw2U0sheYcClhc2FmENqWt8L8UYAsqYH9vFdleRXzfB7F3sVo82c4wJvMwmm+kPrmmwesUdQa84kkpShx7mkGrPsp30FcdvKsjt7g0sv36jOBl3iIJfiEJbOvAt7Z3PbA+ejAgtjcFjaCoMGb/AJ3VArQ5e6kp35bWb7OxNjB7l1YnsY764WcqMncf2VELh6v3z1wmoq6qg1jBynh4l6oPbMUKOz3jMY1NSYFFVVAJWy9nn3ns601LNdlO1BMXgrcUD2llwp3M9aEX27sRiExzIAlyopxHL5tSmXzTLFuGrlDj4qRj+O7rS4heD0xd3yg8JXEV6158T2TfMePhmT5kxULJDc8xOisMwLhTaUK/1V4Pi/h5JyIfdaCF/RzfEEac/OXXxBuptJz4UyMHl6HQ8M0jf/H63+g2FmVAy459aFiajhWhtCBPG74Bel1wP51Onu89iPmOT/6HeugfrEkE8FAwVs7L8UkyzsAxpVg= X-MS-TrafficTypeDiagnostic: AM5PR0301MB2435: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JVsnTdMxFHIv8emDIM7EP12W1e+l3updXAYPVCX1yeX1tRtKD2B+TAkJKD7LHmAIQdXcBBXUoeEPv/zwGYpjdGNFsD1LNkGBaon8rS1ZaJgyzsgia/kNXSmF1qKF7efGYz9UulmnJvLfk13tab5R7Yu7JIg8kGKRzP/AufQPPopDKJvQW+UU79+2IHUAkAAz5E2ZHVRD1wmcutytVeQurZNG9tgOLhBgXOJk2aXj27o4RByfNGfqu5JDFYfqS9CR8okJD17k33J2Pf9kKYIZmdZ1hVdCSdc9E6QhSxR5HhEdX5E1/E9Jc3fFFzGWhDvJCgLS9PN+ufRqyPxcvk3EXiCW6alFGZJ3nnF18z/HEsHldz0jt3qrcgKXn/q/2iT0yxAc5R6ugxpJu8PpDc1r+UC1a5ogJNbSpH7+TI41WlgkQ57RAfkhwIyqIt5Y9x54juU9zbxIuDn+4DOMIbVNWcImDzRkeTdPmvS/SdxwU5JMkoaWSUS+TU7mmkzUfGlp7vhXWyIcKOMhii9HSd3mMj4HF+xMtV9mXoE9djK6Mqc= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: t0z5Vv1UI/YPc21VBG4mgAdJ6EXwdz3GHkVJ/yP2niAIrEd6ZKfwqflB8vHxB7G06heXY2zsZyAYV/7y+IYsEbdP2aCWH8WLq9/JfvKcTXqq+FA+hfB11wxPZUx6NVyBmFE12+p1Kz30r8N25y1nTGqqbQl2LqvD4a7nWbMbbF8Mh3ITc9TZoqD1t1mfTWARmvi9nYguN437AL7kmvnB5KURl9UyV7SqfZtb4rFozoL9QwlVJmEiUQNonZAP49DOGgJg45IQB8YQfzRJifZwv++sUa8w7ay2bNHdt7JbCyam5UeSvHnBmXznTazMhnSVFi8cttwVboTFYzGeZcL1s2PzeZTZSoR5tJPkBiYLkCGqfYax9UI9yHBb8cz/Rt4b8xA6ZeTy2tNAayLiN1v2EkkTMiuSj31lEVKT+0J3iZGzQ+i3UqE66AHUk7cjRsbKD+EG3Dwf0JgM5ak/b+dnOoggXdVyH6KS/hAQ/kLwtT7tmIc23oL2tSO28PjpMWsGFxwXES0xTrdr3Ds5XQxEIIhHDnKNzmQ+eS8tzKlBlC9PptcfzRJVz3dDjoHLW0O9W3egAThHBvlZqCVFyQH84MGiZ59BpxFJzjm45rpNiJflJnPXUbVI0DKvWsKPUi8Mwp1mHUy97yZPTbcYhz3VFlOoJkwYM4T/SupbWM8K+eWRuyk5ZVVm6C1Ya0cTshefuTN5KfsRHKiaNCu6uTKi6g== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 28efa125-1c07-4f31-012f-08d9a449fa2d X-MS-Exchange-CrossTenant-AuthSource: AM7PR03MB6660.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2021 12:59:49.0280 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0301MB2435 Subject: [FFmpeg-devel] [PATCH 1/2] avformat/hlsenc: Remove nonsense memset X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: SREULR8ff38T The memset here is both unnecessary (avio_read() ignores the previous content of the destination buffer) as well as nonsense (for a char buf[BUFSIZE] sizeof(buf) and sizeof(BUFSIZE) are not the same; the latter is sizeof(int)). Fixes Coverity issue #1465863. Signed-off-by: Andreas Rheinhardt --- libavformat/hlsenc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index 98608a834a..557cf1bee3 100644 --- a/libavformat/hlsenc.c +++ b/libavformat/hlsenc.c @@ -2382,7 +2382,6 @@ static int64_t append_single_file(AVFormatContext *s, VariantStream *vs) } do { - memset(buf, 0, sizeof(BUFSIZE)); read_byte = avio_read(vs->out, buf, BUFSIZE); avio_write(vs->out_single_file, buf, read_byte); if (read_byte > 0) { From patchwork Wed Nov 10 13:00:30 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Rheinhardt X-Patchwork-Id: 31360 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a6b:d206:0:0:0:0:0 with SMTP id q6csp404051iob; Wed, 10 Nov 2021 05:00:59 -0800 (PST) X-Google-Smtp-Source: ABdhPJxSnOxdG7H4pJ6NGkZ27ikOfp+NcWWRMLrDfOnbqHkZAIlr/k08fFROdygtfeCNmFrUS25y X-Received: by 2002:a17:907:d9f:: with SMTP id go31mr21228389ejc.412.1636549259462; Wed, 10 Nov 2021 05:00:59 -0800 (PST) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id i18si59642469edc.119.2021.11.10.05.00.48; Wed, 10 Nov 2021 05:00:59 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@outlook.com header.s=selector1 header.b=Xl8ntnKB; arc=fail (body hash mismatch); spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=outlook.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id EA16C68A98A; Wed, 10 Nov 2021 15:00:45 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-oln040092074060.outbound.protection.outlook.com [40.92.74.60]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 50ABD68A72B for ; Wed, 10 Nov 2021 15:00:39 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NrQXOguMvJiftRmpQwGwwuSaynIz8/Q5P2P332VlmcoKszA1YZUphJVcidgB5lGPvF0gL7GMWVSOFPzLHZEmtcQQoG76Ash39tEXE4r5dQGsfCbzeaX2fKUZPQzcFteIddbhNEpgP7X5Rpe0nMBiPme/CG2Ay0daE5dHF/KndlAvTfDxNMNkv5V0Nrk2UZlfakqu0bWeRRDMv+p0MF0NChEw24eW+Vxdc3NCZi0OEluwZhNSZJyuFRy0l5Md+zJJXsv9E0axyI1vAAS3ZO1rw3/gxpVh0TTlywNpyr0/76dT7n/jYzq03RYdV+C8uihq0yErqMJv6VDu+iptmBaVrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rarLIut1975+6b7iBXPDXlWi4Yp5QKn5Y+gVGsZ6l/Q=; b=FcslenX0BQc3tU8PJWDQ1Sw0bI0INVFs4w/BGQc7aRBl44pIP2tKxxvv2LOmOTFt6xX16lSsWy3kF+Ob7Xz5yskZupBcs4dUiSMpwqEWtBF9zfx+zRqPAMsTUxvooEIbjXa+ypdm7DB9hBRblmUO2IYXH9nGqgNvDzkqw/38WUrLYfDokEEwujt8ecETfgoc+Sm8GTJ1i7MuA9Xbi56EGSUAe43lhUOMbDkCyxo6pRSXpzdCrMep6Z6VK3HL4FUftccMLtcwnp/B9vTbIZ7pHF4d3xzIb8PdBUduTgxQAlxyItIQy2p9egz1Zm2AJ2+4SMgcD5odtSsyUfp14lAqUQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rarLIut1975+6b7iBXPDXlWi4Yp5QKn5Y+gVGsZ6l/Q=; b=Xl8ntnKBtEto1JH8xdcBUBHtJx8pumL+dgF7HLiOA0sjwO5ekqAMQ8Lsck712NhcG7kV5NKDaX2mHFwzcJpw4gKbwmvIvin2spoKU69gZaskxhiHjkRzQzNolOu9599LmrQ4iGmcwhG7JL5BzDq4ldcqz/MTSc5X9B71QgJBGl5lsWw0SLaa4XiJgNox+daFpbSsZgq8gBCc6hNg0DfKtUyxNnscjS3aTCfkdg3NsO4keHFg/v733SwFRdg7shEhFzhpEF/DkgF6LOW6nU2E3ZKPG7FBvc5OLPUAFVmlogvEmtR2+UlZlEGYch7vkGHJ7chpeT7D174HwHW1+T3Xlg== Received: from AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) by AM5PR0301MB2435.eurprd03.prod.outlook.com (2603:10a6:203:11::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.11; Wed, 10 Nov 2021 13:00:38 +0000 Received: from AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::700f:d70b:3bb8:4d51]) by AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::700f:d70b:3bb8:4d51%8]) with mapi id 15.20.4669.016; Wed, 10 Nov 2021 13:00:38 +0000 From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Wed, 10 Nov 2021 14:00:30 +0100 Message-ID: X-Mailer: git-send-email 2.30.2 In-Reply-To: References: X-TMN: [/lN/60NUpK66gEkbplQwlVPhrpDQ7MCx] X-ClientProxiedBy: AM0PR01CA0086.eurprd01.prod.exchangelabs.com (2603:10a6:208:10e::27) To AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) X-Microsoft-Original-Message-ID: <20211110130030.891161-1-andreas.rheinhardt@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from sblaptop.fritz.box (188.193.171.90) by AM0PR01CA0086.eurprd01.prod.exchangelabs.com (2603:10a6:208:10e::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.15 via Frontend Transport; Wed, 10 Nov 2021 13:00:37 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6aef4aea-789a-42b5-c444-08d9a44a1785 X-MS-Exchange-SLBlob-MailProps: gjx25WM8ZNW0zY7tAuNIKRoEeWMNkk8PPCnEXgYRWIf0aCdJ5QEgQTTDzu8cNMwgp5pATog+zXJGBig2AP7OY95RhV96ZBLxP7Mf1qYx+aY2wtTQTJfY4kJxADNX/8DKsB1mHurJ+evMjhNghx/yW/+9IGxGg6ax/1+WbHHgiU04TR8Qsyx7I4QQxeOjqOrK4hv4rtxMvInfLvXj3knYT2SExQo4wgXLqk5tXjhvS066LfVsWGvGl9wmjxjvmwynvJ6bu7O4spCDZ6TnYVkIZjtQQCSl+uk1LWJtlTLR3Oq5XhP7YD5jnJGOaMiWyFaohovy5oCv2kOs2fDhloLhp2r7vkDqHW4+0UChlCju+3GDN94iNk22uqY6QTmvC4+qRf2ErG9sTkhTj3iD+WAlI4torpUjv38EF+WAUzQpIXMxWspEhg3KeCzzfilocqUl2pc8cUx6m7fLStmVgyaUKV+IFRdOjbXTEDmBD4T6IMbXq/b2/WoVlF32G3OdD3EmYJ1AMRS71l8B8OGO1MxrU7mpO51ZNcTJQU1EUq/oL3iFkbdoCp2ggHuX+2bFFI+C0XXjX/7USlflLGpB0gk+roF9jzaif8t9we1qggSuMDcvf3u1oYCd24aAvU2sO1NPzf7l3/cLPXNKkC1F2DPn1KN0UtHwys3oi2mYE0SpEsf0iCaFvrRw9itRvlE2ZesEPwjvCwjLn2P6S6o91sMP+r868OkEJKU96JJYxM818Ck= X-MS-TrafficTypeDiagnostic: AM5PR0301MB2435: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Nl+8yt8d1if4lR45uPGyibdAFNYtcIYfR5QHPlB+BDQVyl4ll46UJ+Il5o8DLbUvKPYpKj5I1+YXRfJNny6XJjNNbUc1NFi0xSt/I0rTvzLcnyFOxqB5GFF+o1rHxlxiOOplkSH+NBy3rMu4dU6ubg1z3X1okEdkegDGP3ku+FORtCcvcrfppZCPhHH5AxyMlfJOzwaPsOKwbne9VHcWF5LiY9LHUKN3yedLKu1hex888aJEjemVItkezR2qQrbqRHDSQuqOEM0rt5YzmSvPlWE7Ja/49B7HFU4XcSsodPVJuBYh2k53OVM2T5gJPpnhkFXyDyphOvyPO4RJBKitWaPkigBwl4AUQT19dKZKYbci/W72Psl0okEB3YYrX7pekP1U7gJzR+3R/YEc1cStFfvqhuqfdPBcsxqmDSrJYQMNect22VU5+JTVaVow7ZwyupuffNUWGOXZrTChWdrNOqZ7VcNY2KsvT9yQ3D1YWVIjfT2v+YchgRM8U+20APbDWm6lH0Ka3LHh12Fp02PNLLVL1tkwWbOG3hKQ/8ef8cs= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: +kdwq5cfxgKKghMc2NnSNtF6/QW4twvPKyAzcPhpL0IQPIh44grH/luKRTSLen9V95+NNqzPO3JrRWuzjhgn2kXXK6vlXikFvaZVwEStIOe0w6xt4B5wBHK23/QogiUR9kxbsxlNXzd3KYGIRYaZLfrWVMpEGYCn31rr73M/scGzhSFxBYCT566dkksxHPNBfSnojs8uiw5Xc4HRZt8Ezx1q7o6le/72lIh/qRK8iebp8MGfCZnf3zmstVCfS21lE8/LG2DNvF3sCB/1s32fTc6otahFUqt6H5oQOmTdLMgRwwNOTXqpO3pGQ/5FTrbEwgI51Ys0FKGJvHYy183tGYT2xorZuULve2E+CtkE+I+X2iOqm4jEVo+J//KyMijQjMiqvu4FoRHNK1KiMgrnatE84EVHc3nfXAy4LpvKx3xTP4YswUNE/Oa7V/g68lZotK8HvOKwxG0wPFAjR4BovjzdUt6luA6YWc3p58yO4eNlSpc2typb0gZjBGT5/Ndnl3C+Ioy+H7sE06V+znq4WWnNIJByqu3PNxPk7neaCdr+M9EzIYJHDjcFsZi+Ysl3KPwBgxGWADeDhMuzdnRh3spEX6fMkOZCvdSRODDuCkpP5Bdz+y4GaXtS3NFP/XkCx6izrycvn3ZQomhhVi1QmIKmyVGwKvlxpYOF5L+GgyTOm3FVdYijquLHNf10D8apM8Rjnw7wzgaStvAdrHw7iQ== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6aef4aea-789a-42b5-c444-08d9a44a1785 X-MS-Exchange-CrossTenant-AuthSource: AM7PR03MB6660.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2021 13:00:38.0993 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0301MB2435 Subject: [FFmpeg-devel] [PATCH 2/2] avformat/hlsenc: Only write something if there is something to write X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: 0r1yJj4aiBEm This is especially important in case avio_write() would be switched to an unsigned type like size_t, then a potential error from avio_read() (with negative return value) would no longer be handled gracefully by avio_write(). Signed-off-by: Andreas Rheinhardt --- libavformat/hlsenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index 557cf1bee3..cfd0c036d1 100644 --- a/libavformat/hlsenc.c +++ b/libavformat/hlsenc.c @@ -2383,8 +2383,8 @@ static int64_t append_single_file(AVFormatContext *s, VariantStream *vs) do { read_byte = avio_read(vs->out, buf, BUFSIZE); - avio_write(vs->out_single_file, buf, read_byte); if (read_byte > 0) { + avio_write(vs->out_single_file, buf, read_byte); total_size += read_byte; ret = total_size; }