From patchwork Sat Nov 20 16:32:56 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Rheinhardt X-Patchwork-Id: 31515 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a6b:d206:0:0:0:0:0 with SMTP id q6csp4226561iob; Sat, 20 Nov 2021 08:33:20 -0800 (PST) X-Google-Smtp-Source: ABdhPJwN0vMfARwVcZfMlPXLlTGOXwwdZ4YO28UCv7IAJfxMRnV3JT7/detAZuj7/wRMds6eeH6M X-Received: by 2002:a05:6402:3551:: with SMTP id f17mr34897703edd.129.1637426000316; Sat, 20 Nov 2021 08:33:20 -0800 (PST) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id hu16si5732674ejc.408.2021.11.20.08.33.19; Sat, 20 Nov 2021 08:33:20 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@outlook.com header.s=selector1 header.b=O3gvrTTn; arc=fail (body hash mismatch); spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=outlook.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2BF6868A255; Sat, 20 Nov 2021 18:33:14 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-oln040092069072.outbound.protection.outlook.com [40.92.69.72]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3690F6802C1 for ; Sat, 20 Nov 2021 18:33:07 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m15ETAIn6HQ8xKi6q1EwrPEdDg+czEdsLVBxClo2DZFlA92O22i30dlsWsRVdl+3y4TDESAVh3DrK8l3MkYHU6oLfBFMLq8y8fjubag90N8vDjHLJnQUhx656yAPaKZLjTOFocXud9zE03oLGULV4AWeqXxscK4M7+JrLXzMkg5CCKcgnioIggV9etAF7X5RCiqaJPFsnrGuie8BZURylASQ9zI5xfe5YrFKAIl3flJE3q6PaFbhpfItiSy2eKJTm0j9cs6L19rWW7FKVojT+NhM4mWoBAKaYY5LmHdwiDhQmMVWnNz6Hx4LK5I19IxQVRdUrgKuZXfgewy1t7204g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+qemubXDQHSZZMphK7Arpmaf2zM6Tp1a/o4sR6Gp1+g=; b=YmHnPfzN8uDjZn31Q8PIX0F7v/F4c8x+YCHIprpS91kyZ23aUrxl+orYrJzkhLCXHlL4Qln2jAK5fhlWs0eVndvIA8ijF+BTKCZBhFdrxzJhxG4zHbpvAPTrBldQxko2NfMJZsK5nlPwJ69Kg4F2KNtjYNUqguJxmqlEP8bKaNjqEoBOeDQmSqwC5eKcmKJWqlQm7mnB1AahZSRxCIKEubylxOEYTVNUbLv3e3vNwVcFLxvO7e87vz5tZwkrN+Vl5fj3KMsJeBuMgYCC+8lafh0VQNB+bSQ1TVJ5EVIVAfA7w0sfxT+GdQPSKCEB0kwcCQBa9sIGOKGb5l62CqOSnA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+qemubXDQHSZZMphK7Arpmaf2zM6Tp1a/o4sR6Gp1+g=; b=O3gvrTTnq/b0ZrqHCTZZHQLHxD2G7DQoy2ykEUfi5tjo75K/i85RUoy2OEPYgdZKb1TPvJcmzW/KgIvp3eAE4vh2QZvArVgYpuI7+kdyrpEZshU8C3d22a1mpSpLkPtj0w+UvO2gFDWalLbyeK2eRHOiirBwCPTSeUVjh00Deod+OO5f0GcJdVop7U78NMmsBOaUypK7hTICVZ6mLJvRBEIvGzrlkiruS4MSP/QA7Gqr0ozdW6GWwXAGTWFP5ZYMDih43Jlrs9FPDZ4ZDrQBILDRKM0BuhgihpzZFw9M2lM5RjMucsoeaW2OJtnvqiUxAuPYijRMjvQDovP6logeGw== Received: from AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) by AM6PR03MB3687.eurprd03.prod.outlook.com (2603:10a6:209:30::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.22; Sat, 20 Nov 2021 16:33:05 +0000 Received: from AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::700f:d70b:3bb8:4d51]) by AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::700f:d70b:3bb8:4d51%9]) with mapi id 15.20.4713.024; Sat, 20 Nov 2021 16:33:05 +0000 From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Sat, 20 Nov 2021 17:32:56 +0100 Message-ID: X-Mailer: git-send-email 2.30.2 X-TMN: [erwOCkXyE7nKRNrSfmkabZtzeZ+LaJgq] X-ClientProxiedBy: AM0PR02CA0140.eurprd02.prod.outlook.com (2603:10a6:20b:28d::7) To AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) X-Microsoft-Original-Message-ID: <20211120163257.1417652-1-andreas.rheinhardt@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from sblaptop.fritz.box (188.192.137.12) by AM0PR02CA0140.eurprd02.prod.outlook.com (2603:10a6:20b:28d::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.22 via Frontend Transport; Sat, 20 Nov 2021 16:33:04 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7bf00c63-c97b-485c-d432-08d9ac436d93 X-MS-Exchange-SLBlob-MailProps: EpEO96k6Wol9fKQIkSXRM6aCPlv/tY+rFa6DwWNvV42YIha2tMmejo+iXCxFRdmWNZ7/cFt3on/fdUIis/A0/sgBiyTwcyMvzSmzxl1ywEVi1Dl7QbvMPY0irsoIhCOosPYFHeZE0DubTFtwDQ9ezg70bVW2yw7DWEbdXcuKIB1leSy/mRfp3fd7hWZmrsPKCop3gUGsjoxZpGLubX57X/WuBydkw8QkIM8EpMaIt5MYYXUKURTvzAdxlQwn5UUj+ZjosOYSO4qv8t+9VJRSgZCnLbyJt8U2+mBbBtCNvpztO5dV/PeUpI5fGZFm0Fvryk0qZTIL3p4nY9TtBMnG4UZeOY1y3RMHOliMCXGtSMWIKbqMxqQZv/8ysjyghTnrU4D20ebhjSczdTVgpVL22RWPrle1TPFDOMX+E+EddXHRdc/goq+Wc9yC5mjfumUWzuanj8K5qY2L8PEyGMFpDvRVjXup23Zqq8GtugovmSYcnX+Sn0lKRvEw+PbAOpQjbOcNWypUec1ffkBVFrUzZeiCzUO/hSNDP0tI830eYBy0glWV1oCwuuE3UQ35nIpd5pymofSivsddRhbVZHuPK3+foAK8YBceTKpJVtsqPYAQ473omw1J2ib9IxYH4i7QBadpXiu5kFfcKU9dhWjYvN3sp8y2fukWjT/OSByGldTDohX/5Q8lP5nKMZ+rtRMlM0pC3s8OzTlv0vR0s2df3Wt//vyX2OBZnWhFTAVU38lxkKq3tZ5Ur0tXJO3x09w4ShiU16OLqzc= X-MS-TrafficTypeDiagnostic: AM6PR03MB3687: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: y4CiHQLFgM2MZfNKdjwWDhZRqQ1s0XBDro2CE23VDmH8UDDNR/r81iqoKxbVhxFFSP1P7GUnzQ7bwhdAidmUV756cF69+mJ4Ch9Vm/Ms6uWASeAU9Q3pNLAE3StkUprIJn4msWLvcdAZWsjvKSz+fO9CFoF7Sq6Fj3ul+wXHPnpq6RCAklZ1NhRjldNiKUKa4u4qhc8r78zhbOEBUJEb5M+D2XkgH+7qEsiE4p5TVM0Cwc0Jb6fmdinbPV1ML+KMUz0Ogw3PTstyQTch9bmOuws+weSAamPu+IrDd8+UtKOQJe2SZJnABdBOJkvmVFIlT88OPD66vjbXqqUQ7JeK+9IgcCFMVyYxBeEmXpBAAQLCppgccWDIxH7H1hF67qL/qs1KweRqWyU9Ryldt/AHGmjH0Aq+kkQAawmunULCoUe2nb9FIzu7T3kigxy6cDjTuBXc3ik66tacRlfafDwG54ofBbJ8wNzjXTOC/YSO3iHaKcb5nZ2zE2Vq2CJaf5ERbVJmzC+nu/+OxvZBAXDb/bUS/6Kxz8VYtzFOP9YDOADsLCwkphuZB+n8C+2AN8Lmz6+KuQHpYUiSN5RJRE97EA== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: uzq42UJux+6V8Gf99uAbglhKo9BlZ/MIJx1yOUfW5v629yplN0gSyGFatlT1lkr9Sd2OS7S/fJvRBMbT3UZ/jU5kJciTkoq2Wbo8ix8Gu3YjAcMDTeEHukcwIkjLd54OZANtbQx+BfO4gCT8uJSXC1s3WuGSDhyP6Z9ZaKJAs8/aSXRXQiZise28sjq6RIgdVNiQL6btLEsBbZ75LqN/2uDPWuS0wffslwruGv/6xmTdzt1sWVAVjTODpmQVF6XRPZGzqK4FY+p91iUZdMSztR7TdDZr2ubPAk4xtDTK5scqU/EjQNUSTxuRqaiKXbG/lSqCJMHNR20w4/J9+OG1wXD0pNL6rlyqUVHDLSLpRSnbVP0URTQvuBXdRopeIxzHGpBz/67oYrb1NnfZEBbLsgMxFvoIpZRzd0fAcsYYuwherHxSmk0x1QZovhdnWJF/zZPmKrp7YMbGfo5XPml7GZA/BmgWVNPuKKBfZq3DH8TgEeEdlylRUz7Q1VojEG2FJAkB1L1RVEwrsO+5+BofFeRgtp93o4CF6H5pO/LHSpGbu6VAGpRlJ85JyFC2IPSVrcNwv1QXIIzaaf//ME8hxWNzcSZZmOm6WVwc/p/WeeYcD1uJo+NeVnCCIrL1GFUFWX0dvPL/mjyEA5PRXiOeqDbg3+edk2INS3cSdUDqQct8fsDfamXfX6XmOh13v9aFa2Fj0yPi0KAR4Yl5+JYLAQ== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7bf00c63-c97b-485c-d432-08d9ac436d93 X-MS-Exchange-CrossTenant-AuthSource: AM7PR03MB6660.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Nov 2021 16:33:05.4938 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR03MB3687 Subject: [FFmpeg-devel] [PATCH 1/2] av(codec|device): Don't cast pointers to int X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: 5yKwnVlEMuwb C99/C11 6.3.2.3 5: "Any pointer type may be converted to an integer type. [...] If the result cannot be represented in the integer type, the behavior is undefined." So stop casting pointers to int; use uintptr_t instead. Signed-off-by: Andreas Rheinhardt --- When did these asserts actually help the last time? libavcodec/dvdec.c | 4 ++-- libavcodec/x86/h264_qpel.c | 8 ++++---- libavcodec/x86/me_cmp_init.c | 6 +++--- libavcodec/x86/mpegvideoenc_template.c | 2 +- libavdevice/xcbgrab.c | 2 +- 5 files changed, 11 insertions(+), 11 deletions(-) diff --git a/libavcodec/dvdec.c b/libavcodec/dvdec.c index a7424fd1d4..b72a67d01c 100644 --- a/libavcodec/dvdec.c +++ b/libavcodec/dvdec.c @@ -399,8 +399,8 @@ static int dv_decode_video_segment(AVCodecContext *avctx, void *arg) int retried = 0; int sta; - av_assert1((((int) mb_bit_buffer) & 7) == 0); - av_assert1((((int) vs_bit_buffer) & 7) == 0); + av_assert1((((uintptr_t) mb_bit_buffer) & 7) == 0); + av_assert1((((uintptr_t) vs_bit_buffer) & 7) == 0); retry: diff --git a/libavcodec/x86/h264_qpel.c b/libavcodec/x86/h264_qpel.c index a2d8a64976..320d98933a 100644 --- a/libavcodec/x86/h264_qpel.c +++ b/libavcodec/x86/h264_qpel.c @@ -338,7 +338,7 @@ static void OPNAME ## h264_qpel ## SIZE ## _mc21_ ## MMX(uint8_t *dst, const uin LOCAL_ALIGNED(ALIGN, uint8_t, temp, [SIZE*(SIZE<8?12:24)*2 + SIZE*SIZE]);\ uint8_t * const halfHV= temp;\ int16_t * const halfV= (int16_t*)(temp + SIZE*SIZE);\ - av_assert2(((int)temp & 7) == 0);\ + av_assert2(((uintptr_t)temp & 7) == 0);\ ff_put_h264_qpel ## SIZE ## _hv_lowpass_ ## MMX(halfHV, halfV, src, SIZE, SIZE, stride);\ ff_ ## OPNAME ## h264_qpel ## SIZE ## _h_lowpass_l2_ ## MMX(dst, src, halfHV, stride, SIZE);\ }\ @@ -348,7 +348,7 @@ static void OPNAME ## h264_qpel ## SIZE ## _mc23_ ## MMX(uint8_t *dst, const uin LOCAL_ALIGNED(ALIGN, uint8_t, temp, [SIZE*(SIZE<8?12:24)*2 + SIZE*SIZE]);\ uint8_t * const halfHV= temp;\ int16_t * const halfV= (int16_t*)(temp + SIZE*SIZE);\ - av_assert2(((int)temp & 7) == 0);\ + av_assert2(((uintptr_t)temp & 7) == 0);\ ff_put_h264_qpel ## SIZE ## _hv_lowpass_ ## MMX(halfHV, halfV, src, SIZE, SIZE, stride);\ ff_ ## OPNAME ## h264_qpel ## SIZE ## _h_lowpass_l2_ ## MMX(dst, src+stride, halfHV, stride, SIZE);\ }\ @@ -358,7 +358,7 @@ static void OPNAME ## h264_qpel ## SIZE ## _mc12_ ## MMX(uint8_t *dst, const uin LOCAL_ALIGNED(ALIGN, uint8_t, temp, [SIZE*(SIZE<8?12:24)*2 + SIZE*SIZE]);\ uint8_t * const halfHV= temp;\ int16_t * const halfV= (int16_t*)(temp + SIZE*SIZE);\ - av_assert2(((int)temp & 7) == 0);\ + av_assert2(((uintptr_t)temp & 7) == 0);\ ff_put_h264_qpel ## SIZE ## _hv_lowpass_ ## MMX(halfHV, halfV, src, SIZE, SIZE, stride);\ ff_ ## OPNAME ## pixels ## SIZE ## _l2_shift5_mmxext(dst, halfV+2, halfHV, stride, SIZE, SIZE);\ }\ @@ -368,7 +368,7 @@ static void OPNAME ## h264_qpel ## SIZE ## _mc32_ ## MMX(uint8_t *dst, const uin LOCAL_ALIGNED(ALIGN, uint8_t, temp, [SIZE*(SIZE<8?12:24)*2 + SIZE*SIZE]);\ uint8_t * const halfHV= temp;\ int16_t * const halfV= (int16_t*)(temp + SIZE*SIZE);\ - av_assert2(((int)temp & 7) == 0);\ + av_assert2(((uintptr_t)temp & 7) == 0);\ ff_put_h264_qpel ## SIZE ## _hv_lowpass_ ## MMX(halfHV, halfV, src, SIZE, SIZE, stride);\ ff_ ## OPNAME ## pixels ## SIZE ## _l2_shift5_mmxext(dst, halfV+3, halfHV, stride, SIZE, SIZE);\ }\ diff --git a/libavcodec/x86/me_cmp_init.c b/libavcodec/x86/me_cmp_init.c index 701eb1ab25..9af911bb88 100644 --- a/libavcodec/x86/me_cmp_init.c +++ b/libavcodec/x86/me_cmp_init.c @@ -131,7 +131,7 @@ static int vsad_intra16_mmx(MpegEncContext *v, uint8_t *pix, uint8_t *dummy, { int tmp; - av_assert2((((int) pix) & 7) == 0); + av_assert2(((uintptr_t) pix & 7) == 0); av_assert2((stride & 7) == 0); #define SUM(in0, in1, out0, out1) \ @@ -195,8 +195,8 @@ static int vsad16_mmx(MpegEncContext *v, uint8_t *pix1, uint8_t *pix2, { int tmp; - av_assert2((((int) pix1) & 7) == 0); - av_assert2((((int) pix2) & 7) == 0); + av_assert2(((uintptr_t)pix1 & 7) == 0); + av_assert2(((uintptr_t)pix2 & 7) == 0); av_assert2((stride & 7) == 0); #define SUM(in0, in1, out0, out1) \ diff --git a/libavcodec/x86/mpegvideoenc_template.c b/libavcodec/x86/mpegvideoenc_template.c index b32b1b0350..30c06a6b2c 100644 --- a/libavcodec/x86/mpegvideoenc_template.c +++ b/libavcodec/x86/mpegvideoenc_template.c @@ -109,7 +109,7 @@ static int RENAME(dct_quantize)(MpegEncContext *s, const uint16_t *qmat, *bias; LOCAL_ALIGNED_16(int16_t, temp_block, [64]); - av_assert2((7&(int)(&temp_block[0])) == 0); //did gcc align it correctly? + av_assert2((7&(uintptr_t)(&temp_block[0])) == 0); //did gcc align it correctly? //s->fdct (block); RENAME_FDCT(ff_fdct)(block); // cannot be anything else ... diff --git a/libavdevice/xcbgrab.c b/libavdevice/xcbgrab.c index 8164101c5e..64a68ba497 100644 --- a/libavdevice/xcbgrab.c +++ b/libavdevice/xcbgrab.c @@ -277,7 +277,7 @@ static int xcbgrab_frame_shm(AVFormatContext *s, AVPacket *pkt) av_log(s, AV_LOG_ERROR, "Could not get shared memory buffer.\n"); return AVERROR(ENOMEM); } - segment = (xcb_shm_seg_t)av_buffer_pool_buffer_get_opaque(buf); + segment = (xcb_shm_seg_t)(uintptr_t)av_buffer_pool_buffer_get_opaque(buf); iq = xcb_shm_get_image(c->conn, drawable, c->x, c->y, c->width, c->height, ~0, From patchwork Sat Nov 20 16:36:31 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Rheinhardt X-Patchwork-Id: 31516 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a6b:d206:0:0:0:0:0 with SMTP id q6csp4230864iob; Sat, 20 Nov 2021 08:36:52 -0800 (PST) X-Google-Smtp-Source: ABdhPJzQeTq5Ck5nF5Rs4HStjJP3SFnsUTQGeEMLcfE+TPeTIrKd5bp33rs5weU/tlt5QZsDy71f X-Received: by 2002:a17:906:3647:: with SMTP id r7mr21296745ejb.124.1637426212679; Sat, 20 Nov 2021 08:36:52 -0800 (PST) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id hv20si9671224ejc.429.2021.11.20.08.36.52; Sat, 20 Nov 2021 08:36:52 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@outlook.com header.s=selector1 header.b="q/OYzC3+"; arc=fail (body hash mismatch); spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=outlook.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8511E689BB4; Sat, 20 Nov 2021 18:36:49 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-oln040092072054.outbound.protection.outlook.com [40.92.72.54]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7DB9E689BB4 for ; Sat, 20 Nov 2021 18:36:42 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oAH+PY8L23L82g1nj7m7YcAh9pNnI4lbhiI6CckYvvVhyfndkc4NMYt88aO1iA9OtVQS2/ATdroIXWru7aRRL1nmeCqP3R/bsc1Ew3CgkX88lI5YaGovE7o2KpHtvU1pVdoAqXNHFNfGtgygl1S2tgP6V5doLD/1bZyZgZahNqHVy7e+K9qsgBKTfA4FlDNEetQ9TSkPpyyh+xgOLVfdi5DhfuTArR6P3fA5tG7vLthBLFAPsdvA0PvWJ/X3u0+ICIzrMNP4mHhLFArGfpVtCYyvT0ouVLNPZu2lRqciigu+mQtFZ0VHtiw+o/OwgV4c1BJmnTaBy+zKFEyWF9wLqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WBJE1cZEpxo+1N2F3nS/K75YMUrAUCBa0tCe2GiNHcw=; b=kOnO5OarBB1YHblQNYMeDcpI2VpOg40HOVo4a+5O0KVJRW0vGTw4N3/I7pafqOxQdYpilg/3YByZbFTQ25klVYrK6ycKGIqo/2/uGanzsiiO8NfYbY5eAFUvu/1fmnFNhhDi2hgnSxPJjV15FBwsYSMrRjVMOKzRsf1A1HnrPoj6tS0mDctDoviyKrekCw2N+RgP1KfBFQSy2ZyiruDbq8mEUUHoX44B1R+sIeMO1uP8i/inPTMgCIZBvGE/9JfgX31cMGwvpQQBZrhcDYJ00ED+jljlIYmdLAPJkmCSfOi7qwXFiN9JkaG+rZR4aA/549rfqoDgR+GHDtApYHWbUQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WBJE1cZEpxo+1N2F3nS/K75YMUrAUCBa0tCe2GiNHcw=; b=q/OYzC3+/IDX71oyskOFwmGe5cZ1L1XaTT0Bu68kVFrKuycuH4tsVxjoiGpl/oQqCwfPAQ5gnjtrovXIviPCE5FP2iyuLyQj2JaFmslzIEtIroo8dRaKMdvTh0hhInhWp+39UB2juwyP0FTNB9yUli8nqiRSPHwn51lkBHiqZZnhs390neHNCuhZqs1DV1Rj0wGSdxJgwVuB86kJOGFErqWZkLRet0DAHdJ2CTwyJz0NVUynRztY0ANUJuZsWFCC8QVdtHLOTc1kn6SMasj0ue77KdPcG+s6OiNXqvXZ62+xBS+zTVJWDWDymWDyulCvYH2twrKPkOkufLKdpZCaQg== Received: from AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) by AM6PR03MB6007.eurprd03.prod.outlook.com (2603:10a6:20b:e8::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.24; Sat, 20 Nov 2021 16:36:41 +0000 Received: from AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::700f:d70b:3bb8:4d51]) by AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::700f:d70b:3bb8:4d51%9]) with mapi id 15.20.4713.024; Sat, 20 Nov 2021 16:36:41 +0000 From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Sat, 20 Nov 2021 17:36:31 +0100 Message-ID: X-Mailer: git-send-email 2.30.2 In-Reply-To: References: X-TMN: [T6alA47gBMV5O3QltrVMc8oh2zhEpw25] X-ClientProxiedBy: AM4PR0101CA0058.eurprd01.prod.exchangelabs.com (2603:10a6:200:41::26) To AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) X-Microsoft-Original-Message-ID: <20211120163631.1419565-1-andreas.rheinhardt@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from sblaptop.fritz.box (188.192.137.12) by AM4PR0101CA0058.eurprd01.prod.exchangelabs.com (2603:10a6:200:41::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.19 via Frontend Transport; Sat, 20 Nov 2021 16:36:41 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 02cbc577-21d6-4661-7b89-08d9ac43ee5d X-MS-Exchange-SLBlob-MailProps: 3tYrFWTD79BMtr0nZNjOVOYA+gzxcA9wzAXuanXl98OXfiNCKepRf28A536yLOCbwRZj3UXnJpwdY3yXolso7hPCw42WdbeY8GzBspWqHV5VoLktF3w2Naq/FifcWRWfM9XSMxdZjcwoBVJRWVzSF/JpiSqdKjqqNEbccc0t/6nUjbZ6uMCsnVKUgC0h8uMT6g1fAhftMEixQKZsD7a1HFCYQDccQ3JeZbWIAD6CY1L4yxKldYxl/ldGVR8+ZIyUlf1DbXjSf+w3en3CAMtF/H3JvIEnNtzG0rOxpOaL9jhKthAmb5nAti1JYEmUrhsTJ5HOn8HWM9jzYBwKUp61MdyNIQAVaXjdRfE+m6/MOIORujDvtnxtXO4DXdutS7G10G6csJbfMM2DRUWa+679koH6v8Ij0L/FFm463x/hj7kwmtyc2hQsbGy/ZyvKxmub8EmP0PGYF18scLxdZAi53BSbWY2rGUHSk2/FMMQA4x0BRwcC+MVxYbgOZ0wSVMe7xQvjyKTxVQTvUPBEAB0aTYQIiAscMu2tNVZ4IQmSvHauKdjyCnCF9GsYbGmo5oqAYrQ5gUzucR/ENG3vwj6tV6wdMH7c6R0j0hbJCAUFEeF2+wm4DBBt72gvTYKUz81YyFl+jp1r2ee9j0uyUUzfsO9geOEwzgDLSK8gqVsZD8FC22Z28ZnpB83Lrv7Ovarz8RfEa/HtBK88bDEcyh92l88c9CYy3fc608Vm4pd8Fn22ZMXe2mzL8F2PSwGXVETRMeSxSpznhQcLXdZZjVa/CwJpSI11jLRc X-MS-TrafficTypeDiagnostic: AM6PR03MB6007: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IOIvR4went50ncK9lL2Uw3udCx5KTZ2j6Rak40/84dBwWgT77DiAsvatp2EIhk3bgnu8T7TiVPx95ehOnBOhHd+eX3JuDeoY89ZXoPim8yMLT+fYEBmCEgZiAi2ATOB4SOOA3I7OVn2k36nWGKc4w6JK3bvVBw/3pGQzaA06Q3B8RWOS783MWwkYSSf8F6b2DzW2bivXs7MixzxoNuVUmr4jNYTROnM9XMJGKWmMym3UWQvFlNpZJ1cM55+dGGdPG2hlo9BOkYTLWeF9G0BGJksGWqjD7yxpRdT0ZXeYbAU9cAoWsn6zbVKlGDgC7nQMGulTww9HjkO18YVE7skG3eMKKps4XZNAXharNewpTZTWGjIq+GNYMb4aZUoHH7aehnut50bGDP3y8vHI6C3ypyPOU0UCkc4EUTxeE0u0AZuHt/JSpQS2MIGtvRUYMlWb/UCV2F6b51UTdw559fcDSBa/jyIoM98LiiITSDlQe6AdGEMvV2ge6pElasIgnNfNWdBVG8aBH8xZiQF93ZQqvyT8p0XJt6ZkWU50Um7rWYzm/wsfAYx5gRnHvbcHdL5KhQwEi53iM3soGTK7Tdxn6A== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Q5weoRRTRSV3uog9EkHJztxmFjENdV1DfAsuECJhXLYN9g5FoFUxbWL5iPo1jNr3eefORVm66gxPNLRHmsh3K6E5b7Zitf89tCkKg4nG9srFgj1BF5hInfkt07yz3bDL+r2HXqhbT2nYRBoOSnliVj6wpQifTBknqKRy8Ti4IhSBmmeWMdSRWx7ipcYBMVz95UkVeWt9pXcc3ZsD+5X0hDIS9DK/rtZGtZFkJyCPJ8P+3Fz6O73T94Z9tPhbPk9gCBG0vfyeQ8ii0eJuqx9ooBNxUAhEiXDqjSSKjNVKQRAvsoPSNuYv6F4oSTmR9vgH/1t0Kl54s/2qP8+dbRBTBFd0QciT9+XKp2HC+/KfqDFofKQjhe4Q/mW06ocxHfJa8c8wiYSaDGIanV4flSSKzWZctsTdB7IgDxB6/Rpx2e6pChGCezUMpplu8khvtrhTxAMhT+lVCKp+//TDajzimTRB9iICmDSa3TnTT4Enoihzu+xFJqjKYMRTkvo6hlRJJrKkqOsx648wnHndLjObvglf4KdNFi1jgHlVlrjlwkbjP7E32+b37IbPtUasbjKUAz4WGnwmlPv5WDdYCEMiMUIBGBLW/Xm9TGw35BD2rAKyjt173agc0ZKokTiXTVLrGEvhFnKPVqwuXO+x/hvMlVYB8aw/K+DXq0SV7GcyuGyyuf50PWqVGIrHTerqmNQWh1SEOpQm83RoxNaAzOaLPA== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 02cbc577-21d6-4661-7b89-08d9ac43ee5d X-MS-Exchange-CrossTenant-AuthSource: AM7PR03MB6660.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Nov 2021 16:36:41.3527 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR03MB6007 Subject: [FFmpeg-devel] [PATCH 2/2] Revert "Disable warnings for casting pointers to integers, there is nothing wrong with that." X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: QitbbwCYKf/g This reverts commit 5258f64a14713499cf84840b3ab3a1ee7cdcaeb8. The premise of said commit (that conversions from pointer to int are ok) is wrong: C99/C11 6.3.2.3 5: "Any pointer type may be converted to an integer type. [...] If the result cannot be represented in the integer type, the behavior is undefined." (C90 6.3.4 contains a similar restriction.) So don't disable -Wpointer-to-int-cast. Signed-off-by: Andreas Rheinhardt --- configure | 1 - 1 file changed, 1 deletion(-) diff --git a/configure b/configure index d068b11073..82e60b5da3 100755 --- a/configure +++ b/configure @@ -6903,7 +6903,6 @@ check_cflags -Wwrite-strings check_cflags -Wtype-limits check_cflags -Wundef check_cflags -Wmissing-prototypes -check_cflags -Wno-pointer-to-int-cast check_cflags -Wstrict-prototypes check_cflags -Wempty-body