From patchwork Mon Dec 13 06:40:55 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Xiang, Haihao" X-Patchwork-Id: 32396 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a6b:cd86:0:0:0:0:0 with SMTP id d128csp5040839iog; Sun, 12 Dec 2021 22:41:21 -0800 (PST) X-Google-Smtp-Source: ABdhPJxDRzrs0j2RJckplRlvsYHdZwWdyfzlq5l5ndU1owUvt/Fn0rzovuDyzqI7LU6OaHWmAkwj X-Received: by 2002:a17:907:9608:: with SMTP id gb8mr42465370ejc.301.1639377680871; Sun, 12 Dec 2021 22:41:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1639377680; cv=none; d=google.com; s=arc-20160816; b=OUqKgHZvL20vlNEQ0Kqcng5PnqIhI8JbK5KtDSaiefYDTBzTpPH2xyGr7xRW8bM26f Q/6WElBqfZcfxA+mdk6FEAfh18eoMksqZn5xamcw5XfYPBvyza6f7Kz50N50b1u9nMzt 9dRF31onSBtdT9OLaic/MWpHYxhvYBzT2WRTvlyXLVxFrUdtrEUQys7vBp7YAl0+8ZjS jdnOQfjOdErE31o+1iiN1Oqj7Txw8V87PAgIgah6p34gDotMJfxf+NWd32OvFI73b3+m lRv1Q+G0C+fPsuKzl6vSXxsDZDvsU0obGaIUR4DRtj0JW6EPb+NGCtW1rWtvxe3zNVpq fEUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:message-id:date:to:from:dkim-signature :delivered-to; bh=V3phbNos2c1h0aeMFV3wY572dJk4Hwm3QuueF+NcNio=; b=jzXDwSVhxeUV3wScCEvTl+aiRATFGIHqvN0OOfCkLtzZ6Y9sfJ0O9arzvgI1NOoMOt q+wEOLdOePW40LFHNjfaumSzk8jbdBOv0t98Bg69V8rFDkZxSANpfbgQ+00W2GpM3Ujf qgYww7r+E8sUzdWIMiqmpTwjJ0X9L/HoKx8qVqroLK96zi8OD1at/k3D6x+2DxcyY/Wq mlJJ275y6hKIu9CJfWGZsy7w6KeA7Wv5TKLTYWaLo3oCiXu8ige/OFGs1UZt0biUaatw PDkT9zPfH9Kyj9EWs8D2yRUATcY4aoK6DNYos7jI9CSeVOtm8BvrEvKzxs36044s9Qmk 3zpw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@intel.com header.s=Intel header.b=SFRU2491; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id j2si16069362edr.366.2021.12.12.22.41.20; Sun, 12 Dec 2021 22:41:20 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@intel.com header.s=Intel header.b=SFRU2491; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5A6A268ADDC; Mon, 13 Dec 2021 08:41:16 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id CD86368A7C8 for ; Mon, 13 Dec 2021 08:41:08 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1639377674; x=1670913674; h=from:to:cc:subject:date:message-id; bh=wmKBK8+E2/WsDtgkzkPSHBbLx3U9a7ejKapaMuqtDlA=; b=SFRU2491O9NNTcXv6iiEs1VgrpH3+bCX4xz6l7mXvt0W500qM04jtq05 Bs+mTlwHRtTkxynkRVs43ZRasW30lSCsFvkd6fFM7P2PtgXm69ioyITlv 1ZlbKWuDVVAZi9wdkAO5AJ7z/nCfcFVE/gwhAGYwfeWXOFSA4ccpBg68N 6UAR3UPHGrbuq4L4hVjj+yJ+BBsZW3Pt3zDWqxIy9s89P9AgBcinXLqTv rVmQn9525SywTMyPlxPdJ4S/Gi09uPr1IU+/RD0rrgUyP3+i4xLTcSzc1 zKHNy7bXPCcDka7OKwZ2I7jDkVga/18dbiZ7cwwbSBhs/ArkZwq7gWsZ1 A==; X-IronPort-AV: E=McAfee;i="6200,9189,10196"; a="219354823" X-IronPort-AV: E=Sophos;i="5.88,201,1635231600"; d="scan'208";a="219354823" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Dec 2021 22:41:06 -0800 X-IronPort-AV: E=Sophos;i="5.88,201,1635231600"; d="scan'208";a="660771796" Received: from xhh-dg164.sh.intel.com ([10.239.159.167]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Dec 2021 22:41:05 -0800 From: Haihao Xiang To: ffmpeg-devel@ffmpeg.org Date: Mon, 13 Dec 2021 14:40:55 +0800 Message-Id: <20211213064055.17139-1-haihao.xiang@intel.com> X-Mailer: git-send-email 2.17.1 Subject: [FFmpeg-devel] [PATCH] lavc/qsvenc: set base address for V plane X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Haihao Xiang MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: GtGbXT3eyrNx The SDK checks Data.V when using system memory for VP9 encoding. This fixed the error below: $ ffmpeg -qsv_device /dev/dri/renderD129 -f lavfi -i yuvtestsrc -c:v vp9_qsv -f null - [vp9_qsv @ 0x55b8387cbe90] Error during encoding: NULL pointer (-2) Video encoding failed --- libavcodec/qsvenc.c | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c index 26a94cd419..7431ccfca5 100644 --- a/libavcodec/qsvenc.c +++ b/libavcodec/qsvenc.c @@ -1389,8 +1389,23 @@ static int submit_frame(QSVEncContext *q, const AVFrame *frame, qf->surface.Data.PitchLow = qf->frame->linesize[0]; qf->surface.Data.Y = qf->frame->data[0]; qf->surface.Data.UV = qf->frame->data[1]; - } + /* The SDK checks Data.V when using system memory for VP9 encoding */ + switch (frame->format) { + case AV_PIX_FMT_NV12: + qf->surface.Data.V = qf->surface.Data.UV + 1; + break; + + case AV_PIX_FMT_P010: + qf->surface.Data.V = qf->surface.Data.UV + 2; + break; + + default: + /* should not reach here */ + av_assert0(0); + break; + } + } qf->surface.Data.TimeStamp = av_rescale_q(frame->pts, q->avctx->time_base, (AVRational){1, 90000}); *new_frame = qf;