From patchwork Sat Dec 25 14:10:36 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Liu X-Patchwork-Id: 32914 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a6b:cd86:0:0:0:0:0 with SMTP id d128csp8926752iog; Sat, 25 Dec 2021 06:12:08 -0800 (PST) X-Google-Smtp-Source: ABdhPJzMkWZ40o9uLm4thJhgbeIAMp9RaQXkw4zFIKfFEaO9xUqRBm0lGcOhJQvJpkQA41jISC34 X-Received: by 2002:a17:907:948d:: with SMTP id dm13mr8753824ejc.607.1640441528109; Sat, 25 Dec 2021 06:12:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1640441528; cv=none; d=google.com; s=arc-20160816; b=fVjbOGjxDnbJ/grBOGK1SeQM1O52jvC1ZtuJgWkO5POQk1Ohhm3WSU43xkobjTtU6c NnbKNUmDKZkEBkmLh7VTiV3KHvh+zrNzuU2SfXCRklrDacarci+XkaCQRtO7DTLd+QTN XVVOXvo7I4rSwlZQgXs6Y2PbLY3QHPD3B2+N3D7YEJFyUxnoOjiW2KgIUbO6VqGEPnvp qi7eqbz/DyaoceXzSvmX9xsosdQTJ38a/eHu06NtTT9PiVWYKZRUgpnN6SpsIIhyvHN/ kP8Qwi4D2YI3fyv9h7kE0dpY7jRNycnTwLL3SzEGUzu7MbMM8j4adrJjyTQPWmwgayck SSNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:feedback-id:mime-version:message-id:date :to:from:delivered-to; bh=D+Mean8443+LHEfO4+wCbBXOWONDWemX9MEI+J10wrA=; b=HQZmmjs1QravWFCqCwSms6nmlOXHqH6jcYYEIvHokZYDoiOTrZso/Ciyz5pZqfvU1n fY/fY0MT6s9ChqV9bzL6TXNmihhFnkQVo8LS3ADS9mMaefrSYLyHJSFgQOumibTNPRwI LDWusvjxClA2+tSaMqRcf0uYs4zbh34/eSLKmCmmQL84LacGMR768nS8nqUoWIGJsM+Y 7ytI5gIdL6JUC+4hDW/MChCF/IcyR8NYKnzzISSEWk2fn3hgKDQKlHeP61DhjY+2gblT Sk4s1tOr5BQ3V+7yPCE0YJ5TpDSvdsr4vmxZy7dkiFndA4MNrTn2XNV9AnuokZO+ECbS dKtA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kuaishou.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id c5si5102302edm.245.2021.12.25.06.12.07; Sat, 25 Dec 2021 06:12:08 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kuaishou.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0D86D68B0FB; Sat, 25 Dec 2021 16:12:03 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from smtpbg587.qq.com (smtpbg128.qq.com [106.55.201.39]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 685CC68AECF for ; Sat, 25 Dec 2021 16:11:55 +0200 (EET) X-QQ-mid: bizesmtp31t1640441438to6phd3a Received: from localhost (unknown [114.245.24.111]) by esmtp6.qq.com (ESMTP) with id ; Sat, 25 Dec 2021 22:10:38 +0800 (CST) X-QQ-SSF: 01100000002000Z0Z000000A0020000 X-QQ-FEAT: urA2/mOlKa9KbcPrk32yGxLpYO0ZvKf/MAkVu9U7Xg8Jz98x+07gX+FLFWNZz ixYvAWiEepOh6R/F0b7xGWsSeaKSLyZKHVTAmIxhmn0jteiTZQDxhjRlFQg3a/iKTexNRAo St8M8ePuRxrvOPVRHgL1doiVolHum5lAX5fRjYi1dNqyIcvBD4OyjpzrYjBJay4YCaZCSW3 GuE6HGL0ReRe9r5h/Ba9n7VvUjngbwmZhC3p9lVpWuihy1Pxpc0FF5BKn011PLbDR23iuWr +ARaU7wLW+UIIA6T+l+T8eex0zJWK8LM/wVScK3HYhFcP8r1rf1/QJl+1LMYDuNPas/HAJY L4Tap/0dLdP5C3SbySQL9pm2JZFFw== X-QQ-GoodBg: 0 X-QQ-CSender: lq@chinaffmpeg.org From: Steven Liu To: ffmpeg-devel@ffmpeg.org Date: Sat, 25 Dec 2021 22:10:36 +0800 Message-Id: <20211225141036.46998-1-liuqi05@kuaishou.com> X-Mailer: git-send-email 2.25.0 MIME-Version: 1.0 X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:chinaffmpeg.org:qybgspam:qybgspam5 Subject: [FFmpeg-devel] [PATCH] avformat/fitsdec: remove always true condition X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Steven Liu Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: Ag8wMcG+YBAQ From: Steven Liu Because the AVBPrint->len is unsigned, so it should alway true, the AVBPrint->len < INT64_MAX is unneccessary condition. Signed-off-by: Steven Liu --- libavformat/fitsdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/fitsdec.c b/libavformat/fitsdec.c index 54412c60ff..6477c5ab1f 100644 --- a/libavformat/fitsdec.c +++ b/libavformat/fitsdec.c @@ -174,7 +174,7 @@ static int fits_read_packet(AVFormatContext *s, AVPacket *pkt) goto fail; } - av_assert0(avbuf.len <= INT64_MAX && size <= INT64_MAX); + av_assert0(size <= INT64_MAX); if (avbuf.len + size > INT_MAX - 80) { ret = AVERROR_INVALIDDATA; goto fail;