From patchwork Wed Dec 29 06:59:34 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "zozobreak@163.com" X-Patchwork-Id: 32940 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a6b:cd86:0:0:0:0:0 with SMTP id d128csp11885641iog; Tue, 28 Dec 2021 22:59:51 -0800 (PST) X-Google-Smtp-Source: ABdhPJxfhHu8BEcaCk4QhtGjEUhgWaj1ILYJR00TTm24AxRUYCMqdNFoYSUg2ZZE7KUDbdNgi3Bh X-Received: by 2002:a05:6402:195:: with SMTP id r21mr23852059edv.174.1640761191448; Tue, 28 Dec 2021 22:59:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1640761191; cv=none; d=google.com; s=arc-20160816; b=nDJUBrVfYKJ2v9ezUgZN1r4TMAaaT0a9hxqMvb5zST6SDLiHwIxR64FbzEVxQaHmIY vXeyAzCaAuowWcwjvMGjPdEXy6LoFtylzfnjoRXrq0qEbiCSe9PyQEzo/SscVgQKDsmo 61imi34m9Ts6tLlZtS3v7BUO9RqX8deHyLviewEgZooznh9lrZG598ABwfATLPj+luNq pa6uIyrK3HaKwW4xE8HpE1t1SPnWFrU24fxFa7gQkJpbIaulwhSMYtgpnhjH4OBZROIK vhq7n8FxtgsvMHabhTJeAkXYzEqsfTkKOcBDx5HIHlIoiUBVYG5GgJ+BMuVKrMYnU79F C7CQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:message-id :mime-version:to:from:date:dkim-signature:delivered-to; bh=qpffxVvblJ/H+ismrmzQEb4+oj9usMatjKure6H4MuQ=; b=o9GCgdDAYsD4cJOI2RPGDWMbZ8UH//WtIMM5vR8edaBSiYmoN5uBM1rfEV+jWs6iQS Cs36BrLKju0/4iaUtZiO070xKOzukbeHuIiBHjO7UVz3od/VLtq/DtpD/zgbOVoZs0kO jO7tVdjCL06tvb7I44AkUxlYWh5O8RxNFAxrKkOJrpfGTMBXck/esZN98Nb6uJ2Fa9Ml rO69nw64AkFekCc3RW1xZY6pI9yoQou0gNYuJc5MVnICMq1iT5YUpmdbh7+iW5hHVUpw kE6wlKK2FHNu+pLP2bJWunAEqoEZP6N+AYkPCmSLQSMY5GRH9GlGkHUYXbhJhqBQ6erp bLNA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@163.com header.s=s110527 header.b="pZ/isuWm"; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=163.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id hd13si7663772ejc.164.2021.12.28.22.59.50; Tue, 28 Dec 2021 22:59:51 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@163.com header.s=s110527 header.b="pZ/isuWm"; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=163.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 774FB68AE9A; Wed, 29 Dec 2021 08:59:46 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from m13109.mail.163.com (m13109.mail.163.com [220.181.13.109]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id F14B468AB82 for ; Wed, 29 Dec 2021 08:59:38 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=Date:From:Subject:MIME-Version:Message-ID; bh=bSc+o JeREU9TGiDbjNIU/RHxC6LH6XR/ycFWAC+4r9I=; b=pZ/isuWmG2OzzVQEnO5A5 oG8LY7W3sICAQqKonA0lHWPyM1UU1mPgGpmjRRfGj249b909OFjq6baOz+uPWAY5 Cz5xmZqJ4+XEeLr9Va1qsjT5He864KM8e4F+GvojnrBM1v0P8Ic3ui4KPoAZ6gEa CBLLgXBsUGJA4fPGhWVoQA= Received: from zozobreak$163.com ( [220.249.79.114] ) by ajax-webmail-wmsvr109 (Coremail) ; Wed, 29 Dec 2021 14:59:34 +0800 (CST) X-Originating-IP: [220.249.79.114] Date: Wed, 29 Dec 2021 14:59:34 +0800 (CST) From: zozobreak To: ffmpeg-devel@ffmpeg.org, zozobreak@163.com X-Priority: 3 X-Mailer: Coremail Webmail Server Version XT5.0.13 build 20210622(1d4788a8) Copyright (c) 2002-2021 www.mailtech.cn 163com X-CM-CTRLDATA: zuA6+WZvb3Rlcl9odG09NDEwODo1Ng== MIME-Version: 1.0 Message-ID: <6af89717.4282.17e04fca8e8.Coremail.zozobreak@163.com> X-Coremail-Locale: zh_CN X-CM-TRANSID: bcGowAD3+clWB8xhQ6QOAA--.14626W X-CM-SenderInfo: p2r20upuhdyqqrwthudrp/1tbiSBR4w1+Fcc+RawAFs8 X-Coremail-Antispam: 1U5529EdanIXcx71UUUUU7vcSsGvfC2KfnxnUU== X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: [FFmpeg-devel] [PATCH] avcodec/libx264: add warning log when droping picture at 'h264_select_output_frame' X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: zozobreak@163.com Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: zCJ0DWHR2m5s since there is only debug log 'no picture ooo' when droping a picture, I spent much time to troubleshooting a wrong sps 'num_reorder_frames' param changed by webrtc's 'ParseAndRewriteSps', FFmpeg keeped silence about this error, so a warning log is much helpfull about this. Signed-off-by: zourenyi Signed-off-by: zourenyi Signed-off-by: zourenyi Signed-off-by: zourenyi Signed-off-by: zourenyi Signed-off-by: zourenyi Signed-off-by: zourenyi --- libavcodec/h264_slice.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/libavcodec/h264_slice.c b/libavcodec/h264_slice.c index c21004df97..f8bf8fe36e 100644 --- a/libavcodec/h264_slice.c +++ b/libavcodec/h264_slice.c @@ -1533,7 +1533,14 @@ static int h264_select_output_frame(H264Context *h) } } } else { - av_log(h->avctx, AV_LOG_DEBUG, "no picture %s\n", out_of_order ? "ooo" : ""); + if (out_of_order) { + av_log(h->avctx, AV_LOG_WARNING, + "drop picture(%c, %d) because of ooo\n", + av_get_picture_type_char(out->f->pict_type), out->poc); + } + else { + av_log(h->avctx, AV_LOG_DEBUG, "no picture\n"); + } } return 0; -- 2.32.0.windows.2