From patchwork Sun Jan 9 11:44:33 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Rheinhardt X-Patchwork-Id: 33164 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a6b:cd86:0:0:0:0:0 with SMTP id d128csp1875050iog; Sun, 9 Jan 2022 03:44:54 -0800 (PST) X-Google-Smtp-Source: ABdhPJxIgrgUDMB40VqqPjCSeeDNhbKtZv+DRvbOpr11Ar0x6Yo1wpkbqQeoEB4QmouBhePLts2L X-Received: by 2002:a17:906:417:: with SMTP id d23mr4446147eja.469.1641728694428; Sun, 09 Jan 2022 03:44:54 -0800 (PST) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id b10si2112289ejj.220.2022.01.09.03.44.53; Sun, 09 Jan 2022 03:44:54 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@outlook.com header.s=selector1 header.b=rq5Dv7Xm; arc=fail (body hash mismatch); spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=outlook.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id DEF8268020F; Sun, 9 Jan 2022 13:44:49 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05olkn2031.outbound.protection.outlook.com [40.92.90.31]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7D1F568020F for ; Sun, 9 Jan 2022 13:44:43 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CMBohNijRhAuVctDJJjO9xvJOx8cM/xA8x5+AJkhUpxo389dOjAxVKxqsVqCNLZBC9z3MiYlIeKcdNmvT2gSJcoJz5LSaK3pfX7yqqySZXcstzgpW7ccTqplVSQyPdkNlHuBQGWRziR8YwnC6bsNiJ+9ucciJf8XhsMiY99SJ05uuzTeyPcN4zoQPK1C4NcCL9oqfIoTAQQgOkAlNyQfRINqrO0naN0R3o0Uplhef0Dnn1cxrXF+a/smyZVV64Cl7aqhE1SttminKne2luZa16cTPoiAjeh61o+0HGjoVVZFStaxJ8qk0vemMwhytSWcWQ3/bYFJ7coGRiRue+KIyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=w/HdQKAGUqYB7Vp1ZsjcSUifWPAFSJJ2z59vpqAcfsk=; b=NR+g6SD+JzeyZsbJjDAcdn+Tn2wnhv7lFBeoaZ2if4o7iixRZVxADpMoaqT5PKXWnX9uFkxPtAi5XhRAfN0MFV6sAYGZWepPtv84YxljemNaOuegDfbN2BBkzCI+Bx9nMuGFSSaNcslc2ja8wNJVjuzgV18pJwnjcrHolgGt4A5EsSbNRzh6TvhMd3zqL+B1tJo85wUWhZhV8OQ8o4hbC4bKpgEiOnw0zRDTM7tPgSEYS8RkZQsewsnVZCkrlBpVspFNKCvcVm34qS7pDyJks5QOtKVCIg6qf7QpWe/rV8z8LRSZc49sSizwzjLMTtmIOfoiqb6VsVPLPGvQHzGi6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w/HdQKAGUqYB7Vp1ZsjcSUifWPAFSJJ2z59vpqAcfsk=; b=rq5Dv7XmvdpAOO5HDEJsCtgMmfsUaBIAmTtjQWM4ipxtcjA7GqIB9LIPibcE7FmSJBiVn68gYMxToMP22RIM/NpLXXkw4Cs58HKchaRskAKDIUBDfCKe7JQeKQM0EHBR4agMR/RlwC+1cQcqEZrd2wyhDlWEKP9qejcYmKsNdIbHMz9gcUW9+Dl0AkSqhc/ADbn1AOjhHhE1EJirZ5sGlOV6LLvuLW47uhiXyFsrqpiLX4hFEr6UIxzM2b9qXIMdrLkdlB+0eEFQURseZUe8zxlQycm+swjUgnkgdu9CiKGpBIEQHfsvjTJvgtAXHjuSqvDuM/CVQ95FClcTqE+FeQ== Received: from AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) by AM6PR03MB5544.eurprd03.prod.outlook.com (2603:10a6:20b:f2::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4867.9; Sun, 9 Jan 2022 11:44:41 +0000 Received: from AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::19fc:be9f:2c9c:53f5]) by AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::19fc:be9f:2c9c:53f5%9]) with mapi id 15.20.4867.011; Sun, 9 Jan 2022 11:44:41 +0000 From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Sun, 9 Jan 2022 12:44:33 +0100 Message-ID: X-Mailer: git-send-email 2.32.0 X-TMN: [9zxEbvHzt7IDotBU5p8iwkiFoGyGznaY] X-ClientProxiedBy: AM5PR0502CA0013.eurprd05.prod.outlook.com (2603:10a6:203:91::23) To AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) X-Microsoft-Original-Message-ID: <20220109114434.4018068-1-andreas.rheinhardt@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 951b98cf-0da5-44a8-32f5-08d9d3656c82 X-MS-Exchange-SLBlob-MailProps: S/btQ8cKWiR3EehW4kxQzdNcP2D/mG1JjN4v9/x/ItmTjHyjcttvkYH6hYgtGdpRKcvBALzybumfKBN+E4l2fTEcwLdNIKfZJMm16YdrcyE9lqFl1Rzw4M3zSS4E+LiiiwY9nyasTI7OaQOLGS3+Rt8f+fgV5EPR6Bg24RXsv9k5u+jI7klfHNIl5j/OaW+HtDAE5h5H8Bk9IpH7Ny1Y0cDSlta19hNe9V0Sjv/Hl6a1tS7ZXGD9BTwkikpncO4qi2nUMM07Cb2VSbwBL8Bx5OI934X0GpRUY886PFmcPNVqJjGAYY7EbF0DXVkIuu+/dvaQdCOUjAvnLc6kOVoAhABkYSC2lOvs1kdfVfDq/EthfCyRgorv4JAzQGTDlJMhbrc3xBx4jz/gR7FnbORmSpniHSYnV2gIOuWuXdys4tc3ExVNqAaMBe6ycMRMqNF6W1vVU2ljHy9fXWFsLzcOmITS1ndtiGNuSA/XGOtop0KpwRnHV3gwK77UYN4kWPVzxJFnSdJfPpLBhxV0XqokpOwY38006OY2UQfNUe52JYciNzzCiUmjWdeDdB7GqufTAwrocykkrL3Vm0zO0VIAsOXdXTOlI8sj0I3dXk7sVUri81zLwWt92xwU5eC1fL4K4xrhSj7yYrItYBkvQDkaDlBlB1qLuYgSMB1veX3cyr6YP5EvqU/LWkmkVaFQca5htQH0/Q+WyBX68jv3MxRtktYjlIUdqHzK682daqK3S3UDBxVrWCpvvYerrnRw278Mw9p/QAJ69iQ= X-MS-TrafficTypeDiagnostic: AM6PR03MB5544:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: S14yg41gwbrA1qg/YNSNbpvQtDOzCjZEBS9o7TtEKe11bOUKTMofko0oPyggwmlukoRmL8nYsGJJshdgTGyrBpZrfqiECaiAFhV6V0a0gC+ACQd0yMTcgSxEre/o+Oam3bfw//w9HtBwkAamdRMg+Wt2Z/3w/9A4hSPBRlOl+f2x/wjJqarIPUW6BKNSyR0p/M01hsKnYbgfMf5mfA1/QaHq7S1m2XPWh8+GSU4X8AYwmi12wwt164dzOI1VFExUP5GjFSAakrotSzf9kSQ5eQAXXA9XDKkYoBo7fNnZDKoJybxsdyJmeTSvhmn9XQI0quH296522vSJaP42IQGERSBURBrM+tvJzoxWx4omEL7Ch+MZw+F8fZC0FpcH0+8Xb09EiIiRPB2TecV2Z9yXP0Mb+Z6LMkYYLukbeKYMUNKk1yxdBnTLr2aEQ7hNdc16igsKqN9Kml/7b6TK0vPd2yV3QMrMyA9wH3c0ZUNVuQkBQ8oEY38rcv2NyD4wlnFVP1WCx0y17fRlC/G/UHpqSi8c7gTH3vXq9LelH07J5Bv/QUFROQieEarFQr4l+PZvVKacswxuVtwIQSTz59GQGA== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 9MNr+tPpsFKFGqwok72YRAc4m1zSEjqD1VpoN2rJfN+9sGqdvZ2+5EaqSKME6WeyRK0onIuuXN1b4bCwKX95ymPi+GSkd68PDIAkPKBMrmdRLPD04ih4P8L43h7qxzOB/xwLcllOCpb5myxcgOXhf01w9TRl/KG4CflbT/xfYt5m9gp6yGvoIeKJ/n9sIf7iR9RxWyTyn2CL0fPUvq9Tb3SgHPpYg4UujDFptLnX+WlshwjblD3KQdAi28ELp7ALkvhk616DG5eaYUsnxYTIDVJTjErsQj6bLq/gzvsIziM28XQiouWNLjg1BMq7KnBwsUrJqgJ0asjeftnpKQvsdqIs4XRbFdl5EMfiHNliLNBP2/CGpQathrgHq6wql9qJnQI6sMhxMalVq+G6GuNvzdMQgSoRHV7wSgU7fFOXDFv61g79RSJ2nSmILnuNoWWG7O+V6LMVXrj+juCENHxuTDxZsrgPJ76q9C+wodXN6XKkHaUVLmE/4x5om8x2M9J5CtSyGIUP5bwyDt+4uN5Lz3wI5F6Rhbt82+er2r+lzZQRXCsXlz9UUo619Xd1HuumnRJvh+BVEsuPNSdao/sfu9AzUV8UkwdZlQJ3xpKseUV6uG0Q6yF2uUhlsHrd9UjtRmxY31/1870EBCBQut7wcZKrX9XnGckh4eIo+tzkTQPt5DHGQdQ0wQSEa9dTvDP4wACBh7ynfkbk1GoLmjn25Xzf+LlR+uPtU82SCVb9duRQe8cYiCWZogVlOlor23bPH51kGA1Qg8svi9nvaZdS4nFFUuqTs2U5f31OF0JDjF7uymKakMztMCQh9Ng498TNIPwxvEqhqEVvfQ+m+HVpFJuDEsko3g++LuuX/04SVE8pvjJQ9zMuVODXVARvk05wzBXqfrSWZbVjA8aYVWPa4fEqVnkGO0bOWFZlRwuPQudeDOzdlwIsTJpIDgSO9TLQ6NYrLtypW8UnTLzKGIsJXg== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 951b98cf-0da5-44a8-32f5-08d9d3656c82 X-MS-Exchange-CrossTenant-AuthSource: AM7PR03MB6660.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2022 11:44:41.8703 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR03MB5544 Subject: [FFmpeg-devel] [PATCH 1/2] avcodec/mpeg4video: Split off data in a header of its own X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: 7WWhktAAwRXp Signed-off-by: Andreas Rheinhardt --- libavcodec/ituh263enc.c | 1 - libavcodec/mpeg4data.h | 3 +- libavcodec/mpeg4video.h | 35 --------------------- libavcodec/mpeg4videodata.h | 61 +++++++++++++++++++++++++++++++++++++ libavcodec/mpeg4videodec.c | 3 ++ libavcodec/mpeg4videoenc.c | 1 + libavcodec/mpegvideo_enc.c | 1 + libavcodec/msmpeg4.c | 2 +- libavcodec/msmpeg4data.c | 2 +- 9 files changed, 69 insertions(+), 40 deletions(-) create mode 100644 libavcodec/mpeg4videodata.h diff --git a/libavcodec/ituh263enc.c b/libavcodec/ituh263enc.c index d944c4879f..5a7791111e 100644 --- a/libavcodec/ituh263enc.c +++ b/libavcodec/ituh263enc.c @@ -39,7 +39,6 @@ #include "mathops.h" #include "mpegutils.h" #include "flv.h" -#include "mpeg4video.h" #include "internal.h" /** diff --git a/libavcodec/mpeg4data.h b/libavcodec/mpeg4data.h index 30179d9801..c5a2b14721 100644 --- a/libavcodec/mpeg4data.h +++ b/libavcodec/mpeg4data.h @@ -28,8 +28,7 @@ #ifndef AVCODEC_MPEG4DATA_H #define AVCODEC_MPEG4DATA_H -#include -#include "mpegvideo.h" +#include "mpeg4videodata.h" /* dc encoding for MPEG-4 */ const uint8_t ff_mpeg4_DCtab_lum[13][2] = diff --git a/libavcodec/mpeg4video.h b/libavcodec/mpeg4video.h index cec8b30c32..87d9c9996e 100644 --- a/libavcodec/mpeg4video.h +++ b/libavcodec/mpeg4video.h @@ -27,7 +27,6 @@ #include "get_bits.h" #include "mpegvideo.h" -#include "rl.h" // shapes #define RECT_SHAPE 0 @@ -118,40 +117,6 @@ typedef struct Mpeg4DecContext { int rgb; } Mpeg4DecContext; -static const uint8_t mpeg4_block_count[4] = {0, 6, 8, 12}; - -/* dc encoding for MPEG-4 */ -extern const uint8_t ff_mpeg4_DCtab_lum[13][2]; -extern const uint8_t ff_mpeg4_DCtab_chrom[13][2]; - -extern const uint16_t ff_mpeg4_intra_vlc[103][2]; -extern const int8_t ff_mpeg4_intra_level[102]; -extern const int8_t ff_mpeg4_intra_run[102]; - -extern RLTable ff_mpeg4_rl_intra; -void ff_mpeg4_init_rl_intra(void); - -/* Note this is identical to the intra rvlc except that it is reordered. */ -extern RLTable ff_rvlc_rl_inter; -extern RLTable ff_rvlc_rl_intra; - -extern const uint8_t ff_sprite_trajectory_lens[15]; -extern const uint8_t ff_mb_type_b_tab[4][2]; - -/* these matrixes will be permuted for the idct */ -extern const int16_t ff_mpeg4_default_intra_matrix[64]; -extern const int16_t ff_mpeg4_default_non_intra_matrix[64]; - -extern const uint8_t ff_mpeg4_y_dc_scale_table[32]; -extern const uint8_t ff_mpeg4_c_dc_scale_table[32]; -extern const uint16_t ff_mpeg4_resync_prefix[8]; - -extern const uint8_t ff_mpeg4_dc_threshold[8]; - -extern const uint8_t ff_mpeg4_studio_dc_luma[19][2]; -extern const uint8_t ff_mpeg4_studio_dc_chroma[19][2]; -extern const uint8_t ff_mpeg4_studio_intra[12][24][2]; - void ff_mpeg4_encode_mb(MpegEncContext *s, int16_t block[6][64], int motion_x, int motion_y); diff --git a/libavcodec/mpeg4videodata.h b/libavcodec/mpeg4videodata.h new file mode 100644 index 0000000000..b20096067a --- /dev/null +++ b/libavcodec/mpeg4videodata.h @@ -0,0 +1,61 @@ +/* + * MPEG-4 encoder/decoder data. + * Copyright (c) 2000,2001 Fabrice Bellard + * Copyright (c) 2002-2010 Michael Niedermayer + * + * This file is part of FFmpeg. + * + * FFmpeg is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * FFmpeg is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with FFmpeg; if not, write to the Free Software + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA + */ + +#ifndef AVCODEC_MPEG4VIDEODATA_H +#define AVCODEC_MPEG4VIDEODATA_H + +#include +#include "rl.h" + +/* dc encoding for MPEG-4 */ +extern const uint8_t ff_mpeg4_DCtab_lum[13][2]; +extern const uint8_t ff_mpeg4_DCtab_chrom[13][2]; + +extern const uint16_t ff_mpeg4_intra_vlc[103][2]; +extern const int8_t ff_mpeg4_intra_level[102]; +extern const int8_t ff_mpeg4_intra_run[102]; + +extern RLTable ff_mpeg4_rl_intra; +void ff_mpeg4_init_rl_intra(void); + +/* Note this is identical to the intra rvlc except that it is reordered. */ +extern RLTable ff_rvlc_rl_inter; +extern RLTable ff_rvlc_rl_intra; + +extern const uint8_t ff_sprite_trajectory_lens[15]; +extern const uint8_t ff_mb_type_b_tab[4][2]; + +/* these matrixes will be permuted for the idct */ +extern const int16_t ff_mpeg4_default_intra_matrix[64]; +extern const int16_t ff_mpeg4_default_non_intra_matrix[64]; + +extern const uint8_t ff_mpeg4_y_dc_scale_table[32]; +extern const uint8_t ff_mpeg4_c_dc_scale_table[32]; +extern const uint16_t ff_mpeg4_resync_prefix[8]; + +extern const uint8_t ff_mpeg4_dc_threshold[8]; + +extern const uint8_t ff_mpeg4_studio_dc_luma[19][2]; +extern const uint8_t ff_mpeg4_studio_dc_chroma[19][2]; +extern const uint8_t ff_mpeg4_studio_intra[12][24][2]; + +#endif /* AVCODEC_MPEG4VIDEO_H */ diff --git a/libavcodec/mpeg4videodec.c b/libavcodec/mpeg4videodec.c index 325593a795..37088b7a6b 100644 --- a/libavcodec/mpeg4videodec.c +++ b/libavcodec/mpeg4videodec.c @@ -34,6 +34,7 @@ #include "mpegvideo.h" #include "mpegvideodata.h" #include "mpeg4video.h" +#include "mpeg4videodata.h" #include "h263.h" #include "profiles.h" #include "thread.h" @@ -56,6 +57,8 @@ static VLC studio_intra_tab[12]; static VLC studio_luma_dc; static VLC studio_chroma_dc; +static const uint8_t mpeg4_block_count[4] = { 0, 6, 8, 12 }; + static const int mb_type_b_map[4] = { MB_TYPE_DIRECT2 | MB_TYPE_L0L1, MB_TYPE_L0L1 | MB_TYPE_16x16, diff --git a/libavcodec/mpeg4videoenc.c b/libavcodec/mpeg4videoenc.c index b77653d453..8871d83281 100644 --- a/libavcodec/mpeg4videoenc.c +++ b/libavcodec/mpeg4videoenc.c @@ -28,6 +28,7 @@ #include "mpegvideo.h" #include "h263.h" #include "mpeg4video.h" +#include "mpeg4videodata.h" #include "profiles.h" /* The uni_DCtab_* tables below contain unified bits+length tables to encode DC diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c index 15b6669e46..afad9c8be1 100644 --- a/libavcodec/mpegvideo_enc.c +++ b/libavcodec/mpegvideo_enc.c @@ -64,6 +64,7 @@ #include "aandcttab.h" #include "flv.h" #include "mpeg4video.h" +#include "mpeg4videodata.h" #include "internal.h" #include "bytestream.h" #include "wmv2.h" diff --git a/libavcodec/msmpeg4.c b/libavcodec/msmpeg4.c index e76aec6dfc..f12586dd64 100644 --- a/libavcodec/msmpeg4.c +++ b/libavcodec/msmpeg4.c @@ -34,7 +34,7 @@ #include "mpegvideo.h" #include "msmpeg4.h" #include "libavutil/x86/asm.h" -#include "mpeg4video.h" +#include "mpeg4videodata.h" #include "msmpeg4data.h" #include "mpegvideodata.h" #include "vc1data.h" diff --git a/libavcodec/msmpeg4data.c b/libavcodec/msmpeg4data.c index a3a8144664..63f30ac544 100644 --- a/libavcodec/msmpeg4data.c +++ b/libavcodec/msmpeg4data.c @@ -28,7 +28,7 @@ */ #include "h263data.h" -#include "mpeg4video.h" +#include "mpeg4videodata.h" #include "msmpeg4data.h" uint32_t ff_v2_dc_lum_table[512][2]; From patchwork Sun Jan 9 11:45:50 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Rheinhardt X-Patchwork-Id: 33165 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a6b:cd86:0:0:0:0:0 with SMTP id d128csp1875813iog; Sun, 9 Jan 2022 03:46:17 -0800 (PST) X-Google-Smtp-Source: ABdhPJy7Xi9iynpLpLqfHH5ktyQpavO3HdSR/n0SJFmv9bTOkpwDuqnC7ZV2vbGQ8WpjMWXrEXUH X-Received: by 2002:aa7:d503:: with SMTP id y3mr17561888edq.224.1641728777303; Sun, 09 Jan 2022 03:46:17 -0800 (PST) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id s8si2087015edj.587.2022.01.09.03.46.17; Sun, 09 Jan 2022 03:46:17 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@outlook.com header.s=selector1 header.b=huewf+46; arc=fail (body hash mismatch); spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=outlook.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1C96268ADAB; Sun, 9 Jan 2022 13:46:15 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from EUR04-DB3-obe.outbound.protection.outlook.com (unknown [40.92.74.60]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 38B06680979 for ; Sun, 9 Jan 2022 13:46:08 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LgyxanqpTOlSVFCzNsjc7JLjCdRr82BCzx03vFH7z3AP0+5H3yzo/3DDS9Jv3ezRCdsuuqlxCKUX1PKsia0edrCp1lfmiGVpVh5COX3usCqXCtR3rZP1v/3rRgPIipFSCeWkBJNYcoK2y6ja7mk0ht2e6skn2fx1c6SgaIEiUQVXXqJIjDS3x2cx8FTrnQs6vKCL41baMy65klCwlKe/q18HxMjNJXP4ZADcB+gjDTZc2xF8R72JJqeL66FQ6D/Ty7qn1Nl2fskdM3G12FytKUaH0rMUnmrqPTExhHdGsTZjCuuobmmbxG38XPJgk2S2Ge9imoWskbd+nJz+2iiiKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=x8eDmyKjPyyDgDfuys8oAgemhXZG9S7OmOVAYA54XKU=; b=kAeCWgR81Xh6tN2fP5MlWH2ggHibjW6mt6sshtgypaNuhA8JvzD5T5lPOAswecJPZAYIqJYmR5YxJJH/3X4bUPXGBEW75wnsGhlQ+m7C9vx6qlKXUVHktGOVWzo0JNHlYNx4Gqi3sSByMicER09GbgtMZkLNsRx/0s05I1xit9hJCDMUGmDD3YyipuXX2Rj7/utKr2GWTo5hyUjBIdHteylnoKWK3OBX6rRqWRB08k4dChKpJA3e7wa3lTCAcTVdcbg5BOi0GGn9oOx/Iu6BsShsaARH2OCtG4lBXNjJXf1XEJVVOLdw44fXZEPHKH3e/4cPzEa//7KEL80ayzb1/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=x8eDmyKjPyyDgDfuys8oAgemhXZG9S7OmOVAYA54XKU=; b=huewf+46PA1S+kwhiaUgym0LXmnePE3I4JKf0YBJnnk4TqkbhhiR0zST7azedRLhEiYnFCiZaRrIIxxJm3E7n1inMWwggHfCVA26Aw/oknpw9GgBJCM1eOl+megseh7nFO/GlI23LMrqPuOSIg3nJCP4GDsewkRfRSAYa/1TP4+WxNX6ewVVP/auxqpABYypiJ/wo9EDBj3XlbExNf5pipIaxvqv4PlkKH3sUeUVWpsWtn04bB3d1Uq4mAmVrPOBKKWRv1stbXTx4OyvThtYyi5D0AGCYRFKtfd59D2uBbU5PvIzJSWSPelPwxN7keFAPMr8dBGQ41oWQDFGiVi6YA== Received: from AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) by AM6PR03MB4886.eurprd03.prod.outlook.com (2603:10a6:20b:85::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4867.11; Sun, 9 Jan 2022 11:45:57 +0000 Received: from AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::19fc:be9f:2c9c:53f5]) by AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::19fc:be9f:2c9c:53f5%9]) with mapi id 15.20.4867.011; Sun, 9 Jan 2022 11:45:57 +0000 From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Sun, 9 Jan 2022 12:45:50 +0100 Message-ID: X-Mailer: git-send-email 2.32.0 In-Reply-To: References: X-TMN: [MqmdG+g1/akOW86sM9qM12Z/QX25W63f] X-ClientProxiedBy: AM4PR0501CA0046.eurprd05.prod.outlook.com (2603:10a6:200:68::14) To AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) X-Microsoft-Original-Message-ID: <20220109114550.4020372-1-andreas.rheinhardt@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c302aad8-ca89-4005-129d-08d9d365998c X-MS-Exchange-SLBlob-MailProps: S/btQ8cKWiR3EehW4kxQzdNcP2D/mG1JEnf6WKKIgw5nISnP6X7/sTyksnEgt32Dz5WTVMwMdkVfQLSpkKMOVKGeczT3b6dxgJHbzFojLvI+07VndXSpEpJpQNQAM/o+TkG7VOSjLtzl/lQf51HOZJX4iCWd8mrLN2xRkDwrVhu1MT0L/KLFm/umGG1l3c6wPsqYaa9Bg2YVdu6LbaJJAIi8eYu0ew0bO1yRUxDDtQD0W+cN+gT8aW2LM8vDHk6PmMtiWohbwv69FSReGsmVwgAZvR46LHWlHvX5cAlqALgNMguk7dD0er/oweu9I4bNaGcG20RH8cpcMzMgtLjf61wEfWmaNI00aQqVhUviIAQo2SYNwknd5YIQQvbYRLyDyCCCiQzWP79tJtcjo3YdvNELdZ3rwvLprKjrn1vYfi91cjsGmKHgwgj6FY3lRT9O6K4wUz++u1wKw7L6G3v95ViMjGyoDs3QX/AR1hF+je+ub49ICMbX8ZzRVtFV5ppyNh+Pi4gTummGY/tPwjdmDojXJs7sPRsGaQPVxG/ra9ojOhj8taxHBa98dR2ANlJhtGkvgTWOMiFeQ+FEIKvh8xOG0bhQao2Gx9ylu3H6e0Butj2/XgXCKUQjHrwW7RpduktyrKe0D4NP5+LsZbQLdtqzsk9gP/UcgQKxtyGLkV0+xQi1zA5+n0MI77UMkNPsLo3a9+5ps8az+YI3GNo25o9pZrzethCV9LMuN4KJLQZaudK8yFsup/1DSjgYsu85vB4QBJVCw0E= X-MS-TrafficTypeDiagnostic: AM6PR03MB4886:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /pwjUzeNdIXNrrmHp/JkDDZWjtUdXykCAMMupQjpwOTXEu6Ir8p/4EvgzLDxYoTNjiKaVIWqR7BKTCgAitNX7CH0lMIY+vDmBYEMHdM/xntg9L6L8YHWbNtNF1f9NCXvHrq3shaQi6I6yQE6Zt00bjEomp4TxMpOI/7syYnSdse5hlOi2dNplN/p6Gro2fNKzRuVYhNEDB8pEVJIxpY8EvdFzZaZbP2jSujw64YIjJFYuIWRxPCaWoYjt7dlnZk3FBgaKZlz9trhVsHia4DA8MWvcN5FrCZpCsvLXmEzUCWV78Iy64vn3hZ+Fg1tOEshDU1YSF899Kz7nI2xJwsEI0eWcXWuiKzHNpLBEeM/OMUBSHZyXHja1KsPbeotlcw3bjuvTJZerZjvQfcmfuOQGlOuDtoVx116qTMwk1I/uiYaDOwnGjepErOsOIOeurIrjWRnpXFx/YE3IHgXTb7/qxAueGL/lRmFncG2fBkalBF1YeCZVCgW6485/u9lU68DJR56Hz6HQaNJNohpUyyb7l9maor8K43vGQndk55PANE60s+0XYYLVyvz1wIilwQ3z6BoQzeTdrXxr5QZ2ikyuA== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: sNqWnu/xy4PQWzKDZdXfRfeJyIZIVdqxNwXNsCIq98TQ/aNIOJ/kGmpynzhVZAdrM6c3qWGlzqd8r6ZANPI5QqNz7uluXjUsJJKj0cO8IWpl3gpYOQYk0cae21oGwhDVDMO/0/MU5hUB4/Xg3m5/bh2jGRf2AJWK1CBJftm94L5tXAWbnnQvuKkcvZXP0XTBIV9GN22zSRmFRCG2E8MVSGGvaVU41ZChagbL0mKcCreaM5FhBS8z3wjBkfqOgxEdmXMDptg2l9+PC3GYzQLU7Alx81fauZ+hTptdUX1gOyT0LAkjQh70CaZnNyWoZGOjzyV6njAIuAhrS81Vu0F8rqPWHvY/zdjzdsQh2PTSUfYUXr1lojjwS3+7P0pbEn7uieadlpKodaVp/FixlyHtlzzZHjH0Rq+9SO8Rw/mL1Ty7IzrWbTGwaEn4E6QBcjG8ofOu/tlSkyL7zWR+llvK/VlxQtApPaa3OMpeJzGeMXvLMAY6w5DCEfZ6pgF6rVics8YMyX8P2scfur6vy7LNlIfhpgl2oeisPn9/JJyliQjakwxwb8ihS9nd8JNQpsefjwPxpC54QgzN9IAUW7caF/yB/gIfXC4Z0sgxlOmah7U1pcQQ9m1yw7dbM79xLlUFdXSoMoZdDbe/kJyq15bJc8eAqNrYvk5GpKuRLGpfHh2nn3oXtzGmEE9qks+Ml0tyZX4+bFHsgQFne7l7Haf1pzMecruc13bZaNWCQcbLXdP9dMlNRK5u2cvrlyrbbaDDvZI6bgP27agUDPzlnZqthO0/IYAythNJoqqMgLv6M7273s/+X6M+9zyKn1R7i+82rEd2HfM0fvrBW38tHzvMsiARpHYYT21z07WhzTImnu7IJg2avmdlIRUbflPAznY4T84ZR86y5nB8p6WMTCw7zieeTrVcgphJymA62YFV4kqxoFnNNAAFTUuJx5AcZOVEu1mHpkB3y4GWE41CMPc0Tg== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c302aad8-ca89-4005-129d-08d9d365998c X-MS-Exchange-CrossTenant-AuthSource: AM7PR03MB6660.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2022 11:45:57.2605 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR03MB4886 Subject: [FFmpeg-devel] [PATCH 2/2] avcodec/h264_slice, mpeg4videodec: Don't use %s to write single char X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: cpF2yH3kGlow Signed-off-by: Andreas Rheinhardt --- libavcodec/h264_slice.c | 4 ++-- libavcodec/mpeg4videodec.c | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/libavcodec/h264_slice.c b/libavcodec/h264_slice.c index c21004df97..f9c300bc2b 100644 --- a/libavcodec/h264_slice.c +++ b/libavcodec/h264_slice.c @@ -2168,9 +2168,9 @@ static int h264_slice_init(H264Context *h, H264SliceContext *sl, if (h->avctx->debug & FF_DEBUG_PICT_INFO) { av_log(h->avctx, AV_LOG_DEBUG, - "slice:%d %s mb:%d %c%s%s frame:%d poc:%d/%d ref:%d/%d qp:%d loop:%d:%d:%d weight:%d%s %s\n", + "slice:%d %c mb:%d %c%s%s frame:%d poc:%d/%d ref:%d/%d qp:%d loop:%d:%d:%d weight:%d%s %s\n", sl->slice_num, - (h->picture_structure == PICT_FRAME ? "F" : h->picture_structure == PICT_TOP_FIELD ? "T" : "B"), + (h->picture_structure == PICT_FRAME ? 'F' : h->picture_structure == PICT_TOP_FIELD ? 'T' : 'B'), sl->mb_y * h->mb_width + sl->mb_x, av_get_picture_type_char(sl->slice_type), sl->slice_type_fixed ? " fix" : "", diff --git a/libavcodec/mpeg4videodec.c b/libavcodec/mpeg4videodec.c index 37088b7a6b..515a09d8a1 100644 --- a/libavcodec/mpeg4videodec.c +++ b/libavcodec/mpeg4videodec.c @@ -3076,11 +3076,11 @@ static int decode_vop_header(Mpeg4DecContext *ctx, GetBitContext *gb, if (s->avctx->debug & FF_DEBUG_PICT_INFO) { av_log(s->avctx, AV_LOG_DEBUG, - "qp:%d fc:%d,%d %s size:%d pro:%d alt:%d top:%d %spel part:%d resync:%d w:%d a:%d rnd:%d vot:%d%s dc:%d ce:%d/%d/%d time:%"PRId64" tincr:%d\n", + "qp:%d fc:%d,%d %c size:%d pro:%d alt:%d top:%d %cpel part:%d resync:%d w:%d a:%d rnd:%d vot:%d%s dc:%d ce:%d/%d/%d time:%"PRId64" tincr:%d\n", s->qscale, s->f_code, s->b_code, - s->pict_type == AV_PICTURE_TYPE_I ? "I" : (s->pict_type == AV_PICTURE_TYPE_P ? "P" : (s->pict_type == AV_PICTURE_TYPE_B ? "B" : "S")), + s->pict_type == AV_PICTURE_TYPE_I ? 'I' : (s->pict_type == AV_PICTURE_TYPE_P ? 'P' : (s->pict_type == AV_PICTURE_TYPE_B ? 'B' : 'S')), gb->size_in_bits,s->progressive_sequence, s->alternate_scan, - s->top_field_first, s->quarter_sample ? "q" : "h", + s->top_field_first, s->quarter_sample ? 'q' : 'h', s->data_partitioning, ctx->resync_marker, ctx->num_sprite_warping_points, s->sprite_warping_accuracy, 1 - s->no_rounding, s->vo_type,