From patchwork Tue Mar 17 11:29:23 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ming Qian X-Patchwork-Id: 18266 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 104A444AF27 for ; Tue, 17 Mar 2020 13:29:53 +0200 (EET) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C903068B5FA; Tue, 17 Mar 2020 13:29:52 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10064.outbound.protection.outlook.com [40.107.1.64]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D22D268B0CE for ; Tue, 17 Mar 2020 13:29:45 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GrxIyLhqoW5wradXIa9hqEX5JBEFWH2vhyV2Tu6vnFFJNqinuoZRlNgm/Ou6rg0Whf8gYUYzrEYdEgK3Wd/2krrwYKDDj5I+eR8Kq+jxTTLwhgxB5rtX9radDKhaum57dATZI4IBcNKgpe5rysZJnzgh6laSvhaAL/OrO+NE9DVwFTso23Qgrgo3tLeoT9GSQntvdwj7qG8Q2TUc1c8/43dTSDOpLQs0sT88DrjS8PBXwcAeZeymdNrTlryQkRqjkmys1Wm1mKGYslDGDzv/ens4C+TreNBXD0OYAHGLsgyFKjLqIo5uRuqmLql5dFs+5Xol6ePXmM1ILcXOYvYpkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Cdm/ncPtH18/U9rSu5gXZVMg+l1U2yQFNkmvfKR4MPc=; b=SjI7g6ldS/5O5Vhdub8vMyqvrDCmOHdPIm2WgEndRLnaQ2rhF5AaImk/Wubk8dg3Ajc9GhMHraapn9AMqnMgJKu2/iqMGkZUSnp3q44fed9nZGWG8lS83/Gc4jIlkjPgyN6B7EKDTPVltj7a87Nrlkx+rEOjOWZKZsHYNAB4m6ajJJUFPKbYxjtugezSPaPrm1Bpw5k/5vaQPiIR47lklcBDOgXAbs3ZkAgFFZ+UeiVhWMimsRUlorwdC7demqZIcuLzoWAfGNfW6fYZz6JkZe/Aa/cwK81vkbQmGneE62aeVf3AXZoXoy3X0ZslbcHz43ltiMVRIYnCnvlimDaBtA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Cdm/ncPtH18/U9rSu5gXZVMg+l1U2yQFNkmvfKR4MPc=; b=IIEaMZTZYj8J120HFFtj5cBm02X0uvFoHNydu1rt3dnJ/5TpsnVyd/wHN8L1etIXETFZPBtvNoMbGwhL3gyHKu0oL3zeboO+kKtxDpHemKiUppDT9CBLtX3cwUJxwenEAy6tA+aHAf20w6gQa/Lte0TMFIb2Fp1PDzEnvZfejmM= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=ming.qian@nxp.com; Received: from VE1PR04MB6368.eurprd04.prod.outlook.com (20.179.232.146) by VE1PR04MB6686.eurprd04.prod.outlook.com (20.179.235.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2814.21; Tue, 17 Mar 2020 11:29:41 +0000 Received: from VE1PR04MB6368.eurprd04.prod.outlook.com ([fe80::c962:b871:9b:853]) by VE1PR04MB6368.eurprd04.prod.outlook.com ([fe80::c962:b871:9b:853%7]) with mapi id 15.20.2814.021; Tue, 17 Mar 2020 11:29:41 +0000 From: Ming Qian To: ffmpeg-devel@ffmpeg.org Date: Tue, 17 Mar 2020 19:29:23 +0800 Message-Id: <20200317112923.31053-1-ming.qian@nxp.com> X-Mailer: git-send-email 2.17.1 X-ClientProxiedBy: SGBP274CA0015.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b0::27) To VE1PR04MB6368.eurprd04.prod.outlook.com (2603:10a6:803:11b::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from NXL53318.am.freescale.net (119.31.174.68) by SGBP274CA0015.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b0::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2814.18 via Frontend Transport; Tue, 17 Mar 2020 11:29:40 +0000 X-Mailer: git-send-email 2.17.1 X-Originating-IP: [119.31.174.68] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 2a120968-831b-4341-acc4-08d7ca667bf4 X-MS-TrafficTypeDiagnostic: VE1PR04MB6686: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:473; X-Forefront-PRVS: 0345CFD558 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4636009)(346002)(136003)(39860400002)(396003)(366004)(376002)(199004)(316002)(8936002)(81166006)(81156014)(4744005)(5660300002)(2616005)(1076003)(6666004)(956004)(8676002)(52116002)(86362001)(6506007)(36756003)(186003)(16526019)(6512007)(478600001)(44832011)(26005)(66556008)(6486002)(6916009)(66946007)(2906002)(66476007); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR04MB6686; H:VE1PR04MB6368.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: G6S93glpU2QvjTu68BO7dEkgoyEZVPjS0FWFbYcAX9G7eCsjllPJPSIPB+k6o8kocIOLvhxrBsUpkUIjh3UHrgChmhhPZePohhmRXUJihAxFqQDKj8/b1GOZotw9Twz5+xAJP9dOz6NYPr1Jx8YSqOBILZFgjWOs/RMSA/qn0X3Zqjuqfq/lB1capHAUX3vHeTDmrp7b7oaIRH7CFLoLch2xvru9nJIEZiumaL4Cpe8eriFw2CZuYEANQuMTj5ARN//RBjz1yjqqf9KfJM9qbLB6b1eqss7d+d4KbFXgXqeAMtONfEsdmsOqRel0t5LfG5StVfAfSHNNhVNMkGj7FzSvBcY+WPjHN7jrtDwJeDU8Q1QGl+XRxnOfGKuJ/UdW6kSMcWI4DY1e8UHaEFpGYd15iFF3wA72Pt4w9pE7QzNVbXDmhTH1EaNk6kyajpvf X-MS-Exchange-AntiSpam-MessageData: WUF6780wpywV6LKYxNHS2Vg3AHYsp8FITik1Ro+2CDGFYT1B0FI0+II6D4iV1O6d9VocxIB2Hg+9y51HC0k+XY+C7ZN+AkGWB7uXHSMi0E42N/R1KxpT+KKFCUxkCSV6IT1kRvWaLoE9hov3yIbg+g== X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2a120968-831b-4341-acc4-08d7ca667bf4 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2020 11:29:41.6638 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AkpDO7+d4AHKh9z/uwPpKD6gwl4SaG1PwtKb686ji0APfE2FyynQFNVOUYGm5vrvAPQVUSajEZo8OrdKH4CT3w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6686 Subject: [FFmpeg-devel] [PATCH v2] avcodec/v4l2_m2m: fix setting the frame rate X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" v4l2 set the frame rate through frame intervals, not set frame rate directly. the frame rate and frame intervals are reciprocal. so in libavdevice/v4l2.c we can see the following code: tpf->numerator = framerate_q.den; tpf->denominator = framerate_q.num; Signed-off-by: Ming Qian --- libavcodec/v4l2_m2m_enc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/v4l2_m2m_enc.c b/libavcodec/v4l2_m2m_enc.c index c9f1741bfd..84de63ec9d 100644 --- a/libavcodec/v4l2_m2m_enc.c +++ b/libavcodec/v4l2_m2m_enc.c @@ -172,7 +172,7 @@ static int v4l2_prepare_encoder(V4L2m2mContext *s) * settingss */ if (avctx->framerate.num || avctx->framerate.den) - v4l2_set_timeperframe(s, avctx->framerate.num, avctx->framerate.den); + v4l2_set_timeperframe(s, avctx->framerate.den, avctx->framerate.num); /* set ext ctrls */ v4l2_set_ext_ctrl(s, MPEG_CID(HEADER_MODE), MPEG_VIDEO(HEADER_MODE_SEPARATE), "header mode");