From patchwork Tue Feb 8 15:39:27 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Rheinhardt X-Patchwork-Id: 34184 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6602:2c4e:0:0:0:0 with SMTP id x14csp911827iov; Tue, 8 Feb 2022 07:39:56 -0800 (PST) X-Google-Smtp-Source: ABdhPJx7XQBdfXqYJ7m5xs9glbKgx1imw7t0D2v7LTot+RzbntRX8L+BwjRYcRVDegjjGLAtXju9 X-Received: by 2002:a05:6402:35c3:: with SMTP id z3mr5014447edc.17.1644334796242; Tue, 08 Feb 2022 07:39:56 -0800 (PST) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id gl1si719058ejc.348.2022.02.08.07.39.55; Tue, 08 Feb 2022 07:39:56 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@outlook.com header.s=selector1 header.b=DLRSJcFZ; arc=fail (body hash mismatch); spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=outlook.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4D61968B163; Tue, 8 Feb 2022 17:39:53 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-oln040092069105.outbound.protection.outlook.com [40.92.69.105]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D523368B0CD for ; Tue, 8 Feb 2022 17:39:45 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=alnEGtavv0lSp1HLmhNx0mOllURGVMMxaRwldsDtr+QL7uwcjztOqZPOsWW4r28959mTgaBi+MmWX8j+moRYkdAQeHE5A19hvCLRLbcF5GIGBfeFziJSRpx2nd7MK0U50ML5NzA0Naykhjydo19D9iNGfOh1WjbZbuIpsK6PGFzurJZQcjlIo0XnWIxeu0lh0ZSmQzM/Uev78Fwy5nb5xI254F8fm2AMJBIgxgNd87pYI/vbuWZ/XG7w2PhnA8isSDWX4o7YCJTMDxUWXmxRiziPMnbEGfaarZTwcMDTcEk5JMaH1RYvjY4hY45zSpPYjBHR89x5Zobw8jTJ01mUwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=N41LiIYMkgA4TobZ6HPmiOdvGVKTmQnDBAeLN3XtMDY=; b=AHZ84I7vwYZD5K61BcGWOaU66t4pnYVTUZrD4m9wq9G5fSBbmf8y6iddrPpiaIbhptUqF/cNPgfugAHaoMHU9vM1dkKmMRPY4ALgEIpan62E5X1PjPIfEAqJ0dZA4Vll4RHhz86sBlOplWkMWF1pspe9Yj79p8cIoe3IjQLseCpXJTTFh1C+hshAs2eYGGvOT4Qn+m6PYZAvOR3wAW8wTPuTgm+Or8K0lm5vFmI17QZ/E28Z+o/SJMfbgenH4VbkXQBWfnCFzVOqTpDhDOVuPLx4JaLGnPyypON5FaP8QTv6r3XokZ2beiECf9j2gCfpecpID4zxGDXp1h+pjVU5FA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=N41LiIYMkgA4TobZ6HPmiOdvGVKTmQnDBAeLN3XtMDY=; b=DLRSJcFZtIsSXH/EnLrsqa/5A5hnsEMEmHdpNqKKDWxSjYbz19UdYBb/J6iqUlxe+lvq5OuTb4kirQdQpGm9fDGOoBiCLJDnkk0h8fZOf2wNIewevOYI34Kxeq+pApX6ZCWK2LIZ/osjcJFkLVVc/kdWzKVGDlz2gRiA768Kt93OUehlv/24nqrVyaoVK+sqvB7sDlQC9RNGpIx3ROTfcbLvDJtR8Zz1gFgQFmVCE2Q6eRXmLiJqI8Hhp1b/80s/ImGeOFL0DC4j7qoI4VJgvIOIrUrUD8Vl82yhAqKjnIfInTC62O4wQfQlqQe9q2R8bI9Z7uTB3+kDR+V3MA+7+A== Received: from AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) by DB9PR03MB7552.eurprd03.prod.outlook.com (2603:10a6:10:2c1::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.19; Tue, 8 Feb 2022 15:39:44 +0000 Received: from AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::ac56:2ff4:d304:ab22]) by AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::ac56:2ff4:d304:ab22%6]) with mapi id 15.20.4951.019; Tue, 8 Feb 2022 15:39:44 +0000 From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Tue, 8 Feb 2022 16:39:27 +0100 Message-ID: X-Mailer: git-send-email 2.32.0 X-TMN: [6C3o+1uWq7sdN6vS4ymWycdYQKLIg746] X-ClientProxiedBy: AS9PR06CA0010.eurprd06.prod.outlook.com (2603:10a6:20b:462::33) To AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) X-Microsoft-Original-Message-ID: <20220208153927.1172564-1-andreas.rheinhardt@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 88d71f13-570b-4b63-2bd0-08d9eb193aeb X-MS-Exchange-SLBlob-MailProps: S/btQ8cKWiQlB9bKabCTlYh0pf6YrAz8MIXo3oONYf0AwCST7r7e/CmFWh4JYtcSZdNcEVrwUA4PjGs7HmDZZTC6ZkFpVmCWrn3JfB1/DQJ3nf0fI0a9uc+f6cA1SZncSoH3SGuPjGrEXzNqu0exhHZLe74EoBD0MA+kStmdpsgXQuMFpKwM+t48xG2e+M+6n+iILMkFoxDMqCQVh6+XbA1M2fm/sQcAfKTPMPl+Ve28DWxDq9pphBk5aY/xJg5rMII0fbUXWmLSWU5YI6SOD7B45qDVzQ4pc+hWYf5Bl/5FwGQQdtz80Wad86FgY2NT3/5dKmXLZUK3uR+oSAFHI7IgIwe2MWYGpArIY7EBozBPs32pt+6d+fKf71lAW7Oxxqw5Pk/peHghmLy5tM8RwfCq9Mjdynxohw1X6CT7YJLl26cfUgmTYvnCiC0qu2ADnk+y8i3+reb85e+FlnW2CP3xyxJ8yeNE7mdICbH3S9Vbfn4/IBgenQSMB8yFPFyiLoIyknETsdS/nF7udaxfVc5JcxGf+SuV8eChP941/rfZCtOeW4YWG2LtcjxEH/uiQPnKrv0/scSx1l1CkJW99WjVkkY5bX0ItiQOqFbXIf2D3iMq/c3cXtcj5k/zaI2rWai37G8phySnpiW5l95IDjZWO2IRV/u4dTpiVy+vLyJF8aIpkwnqwn+Ke18FqkD+exGYovkD0SSc32N85nQufdX/N158dl6qybE2NFQncsrKjeA3WMIp+VrE5nuyYOi1cgSpt9W+BgU= X-MS-TrafficTypeDiagnostic: DB9PR03MB7552:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: adO5TbukRJvJNliK/RFogP6fK8mEJOUwpzRCOWvOAZbSWpzGXGeCI4tTCZGFexC69f4qLPnBlXrk7AM03PZxu1xy57Rb+8225WvOuQdlvG3BH0z0Xt3DB14C6pM/Luej1ufGuBPnIcUY8evRbQfmqi+oBrJcwFxUmTqmiOp4RWn+gsDyCPd6rwRANWH1BW5438mtJ1pVmu7fTfr//ouheeYCmd4poc4Nn6bhZ7roqn44dX8lg17xKZ2sy74jGSRXyRI69SCW2dcqKGosSteEd0SbIIYrktfg5bFv8FjTrXzNQ/skRcP3KLB0fOp5MI6+tspu1Cw3S1fULsqqmtf9Uuqi3Z8avxl1mOUyIBcBpSdbmsp/C/DAVP9j08dOGSSZjAn3PuRlw/AlOtK8bxz63ld6h48ldK8rActxM+eMU1dgA3P13Fewoa31jiQ/+SfYLVC20taQkbiwi7ANzVKRA6+zTw0GyLBLWzcc26FdpjMbqipYE8KElRKS6cADPWnTh3g8c04BBslf4GgPOyps8OxgAAT2WfXECc0vziI9mLgLuAl3QszoWjEeFqfpsH2FlBcSjN5XZhJb1rqiZFwgKg== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: P9ciqOFZGDOLNHO+rd3gr7EcTr5NA82yTNcFcmXqZ9plZg7ULqA4oArrKW9kdo8PXol4Fu+DM8bUNrxPOeeUwQmoZPur52ZeGYWdx2kHyTnZNtmLQ1KTrKlH+NwF/phoxK51lOAu9TSwvKVjKkSRKEi7No6dU4WMIT/3lsPGFu4JVCZ0RiPAi/nhk4IeEBWObK03ZhIvneneEnLNq0G2KSJAb6Iq82MxB3WuHz9xfJagPLUuW4mBkT1kOkBeTij8oO3NXGoe01TcDCvEthhGgGYYpdf104aUPmW6L4T+jF2PubMYA/9tr5n2ESMPrfI56lqh3W7IR+22Rd2l9gBpaz1ysmBOxZFfkV3DJWjQ456sfq1rebO2d69V3weSI2cEqmICXgs7kUc7ZZ/r7bK/ZWT4pjWkK4bNEfs+cK14UBbfwP8O05frGJqfvOhXJY3OybMUq8c5kM4dxtb/ynNZhMd5x+g+MQS+FYQU0KZ9wCFJ8Gv5ZkW/pqttaImTbiy6dB8ehSqbqAfDHT+SCawDmfigx8RWn0XUU1/KllHuYviY37riUADhjCFeiHOV40sYFOG5ZV4OdwbiLXm4WD2r8V8YgIkDso+EdDDwnjttX+lxfnYwKCrcv3ixVaj+mIpGK+nR9s9ubGgv11dOkI9LsPV/K+eiuBcc/TIQRr7aX72U3ddXnnjV8N5HcEudMp/gqYj8tRc14+Qaeavcy9KtGJmaynEFzTPcBFUOjTL8FgBsBgMLt8zJcy7D2tyl9aOeGPRr07Ms4gSz8tmBeBvsDiRmY5lQn1THFO7bMEpXorMqETjRxS/MvXcUAvPwXeEiqBIEEYxtbBvHxaSPdu1TRdDi6TvX6z30GCwF4qrCgZQYTRhjEd1ofygTSgUkiLLlF0Jnn4KDJKhTFtrlnEycPQF6ZMM/eFEnGDapmEYdRywvnh2JugaAkQVqdBJgoLHVBOkENMp5dtWodlhLIkMvFg== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 88d71f13-570b-4b63-2bd0-08d9eb193aeb X-MS-Exchange-CrossTenant-AuthSource: AM7PR03MB6660.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2022 15:39:44.6867 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR03MB7552 Subject: [FFmpeg-devel] [PATCH] avcodec/vp8: Remove always-false check X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: /+uMfliZD4du Since e9b66175793e5c2af19beefe8e143f6e4901b5df a codec's close function is never ever called for a codec whose init function has not been called; in particular, it is never ever called if the AVCodecContext's private data has not been allocated. Signed-off-by: Andreas Rheinhardt --- libavcodec/vp8.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/libavcodec/vp8.c b/libavcodec/vp8.c index a70d94bd82..c9d9117528 100644 --- a/libavcodec/vp8.c +++ b/libavcodec/vp8.c @@ -2826,9 +2826,6 @@ av_cold int ff_vp8_decode_free(AVCodecContext *avctx) VP8Context *s = avctx->priv_data; int i; - if (!s) - return 0; - vp8_decode_flush_impl(avctx, 1); for (i = 0; i < FF_ARRAY_ELEMS(s->frames); i++) av_frame_free(&s->frames[i].tf.f);