From patchwork Wed Feb 16 06:02:33 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Rheinhardt X-Patchwork-Id: 34331 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6838:90eb:0:0:0:0 with SMTP id a11csp952356nkf; Tue, 15 Feb 2022 22:02:53 -0800 (PST) X-Google-Smtp-Source: ABdhPJyZN4haUDIObiizlbEgfHsXF68ateJutrzFyBHEDyVTrowdW6sXmNSdngkEIm8Odbs37UTx X-Received: by 2002:aa7:c047:0:b0:40b:488:547c with SMTP id k7-20020aa7c047000000b0040b0488547cmr1323340edo.76.1644991373445; Tue, 15 Feb 2022 22:02:53 -0800 (PST) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id x18si1338998edd.417.2022.02.15.22.02.52; Tue, 15 Feb 2022 22:02:53 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@outlook.com header.s=selector1 header.b=nzNmUG2E; arc=fail (body hash mismatch); spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=outlook.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6B2B768AF07; Wed, 16 Feb 2022 08:02:49 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-oln040092068013.outbound.protection.outlook.com [40.92.68.13]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C2C3568030F for ; Wed, 16 Feb 2022 08:02:42 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nS+QbwXGePa8XvguifN6ifqBiNtunwAwUTUgcit22BTbPf9iH5fzaeB05wUHxp3p9LoQXdszGgwV7N2wspuaTbR3dKbIwHFO0TGH+IFOYItXN877UuXmQxKL09Vrf9rCqcaBoKYJP77HHn5mOY6GyxsffX5k3+jalXjbMQvxpGQwJ4cotzmMgx6YZCG/gMlE7w+fozPe1rYx1iw8JF2LoYhrvz4Elu+sURHC+GTGurc3WfXzGRrX1kb5aYXIsrlXWZONYXajdzvcc+jtxD8UbFA6e+YN/rsyBxOq2ddZWYic0npy418BqUztcK9tM/qkCCY4WVwZVx9lbEu6uhtb5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VjhmVhlmSTpss9gYrp7zNN76g6c5VIP1weyl1hnge8U=; b=VSerA2cPUBUEM07plVqcisbv0fSdzMBXnB08nyWKi8Xyf3DkARHp4fT1ewkYjOkQolqul0CuAxVRSYr5pGN/GcshwpFTlD9vRcvCBVirrVhkdJ54Y7NswyHP9GIqiiPtyD0Pf6I0g9L0UPxqBf5V5W1cn3nmq8bxtzh17XGS2iiF/TJN///a7LJHXkB0sCabOV5C5S/0yukV7GNtlIwBMaHqaipC7h7SMn4wlRmvPEtp3/gR4SqYJyJQq6kjUMzuRzel7peoezlUwSrRCMzIjtm00og5LLUNXD4o9ucmYb7L4Mcds3RNdt5b+MpbJEgWxiQeYhOmrZVxquZquziSdQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VjhmVhlmSTpss9gYrp7zNN76g6c5VIP1weyl1hnge8U=; b=nzNmUG2EFNvifJG87Dq4fHO5jK+mxLjwzE//Rz0Og4XH9ytEbmkJ+RCfHGARav6PxL+Cvqv2eWKSP2jjUttBrtxxNH6QfwNrKaTw7CwRCch7Kx9uNxAJ7w5rAJhQAy8uaYVXjxgulAqBz1h62fur5fh3M7qOmWG2CJ6gAeayBZxlPsjpjntqU59t/DWCWa27ssU7WWDa+yyHIGDrO+GBqroxwwgQJoEgy8iajESZg+c1GxS7ILuHD73HX3+8lQTvlgcxg58e5k3SjUbGJz3jMIaB29mqG9u7by4fnWO/JRq6AC8Za1tkmgmN1OPkhXmD04+IFMDW3GbM/MoljVsLtQ== Received: from AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) by AM5PR0301MB2529.eurprd03.prod.outlook.com (2603:10a6:203:8::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.14; Wed, 16 Feb 2022 06:02:40 +0000 Received: from AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::b8d3:effd:9a3c:4090]) by AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::b8d3:effd:9a3c:4090%4]) with mapi id 15.20.4995.016; Wed, 16 Feb 2022 06:02:40 +0000 From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Wed, 16 Feb 2022 07:02:33 +0100 Message-ID: X-Mailer: git-send-email 2.32.0 X-TMN: [1yPkG9TglHPPx6InnspSrhC43iqxKZbr] X-ClientProxiedBy: AM6P195CA0046.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:87::23) To AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) X-Microsoft-Original-Message-ID: <20220216060233.583579-1-andreas.rheinhardt@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0f27c404-1b6f-4d52-f358-08d9f111f0c7 X-MS-Exchange-SLBlob-MailProps: S/btQ8cKWiR4S4SJ/5k7cpGHxQbpwl4/qmiAtG7HRfkXLiOYE4j9xbwQGJSY8/HZu8Jzc8RWOWOqpchqxBYctk1F1TBANR6pemA4seLANYvr0v2f9TeMj/vTITLWVJcxi3488REg4u5PBT7d00ULCdHD+Fgz92YJqoHP6ufyd/OMNrhB/iUpcsisef4iZvOFccIkQlMzg7bMIXcg463pazFSi/WrSMvUpWk8EnOtUEU/uIjNeJIKtH2gL6D4h2YfXc+yzpUTNUlT7t7pGSazXjVg0clLoEWdktU2T4fbmmlkvTnTR4xGzLm+9eSTS1lkc3DUKsvZWl4MVUSdS6bpLIynhC20uvv3ypStc5z6pod9nB0qVCOu3XIyXEG0IyRkvg+KFELqEMx7j2pX9b28KMSdY3ShkiLjIuhl1YHuDvT+6Bjq92n7zIOgUkRPGmwzybzdUa5hWTC4P5TBMtaDOLvNlAXqUgnOw95zsSZnuJTMmsAa/IZubz8hXASbxTP+3dDi7qGp3EVLUjS/plA3Ryl/RK+yQR1Ej28XcUoyuxmrtNU3dssfCZeNIHL1roNvIL8HXMRVHWSfQBvqvuwhFyA+EEwPt73WO+HuDb+pAi/pmNFF+tW4x5gP/RM8FvSrypiM8Gy75MRR4vZsfjcXK9q6AIzOKfewqsyCl/4tq7UyNCh0m0ACmMaW2U0Tr2dsheRvHD77mD9ZEbfC3x38nEoPv0TkUFw5gnw/onWtzyj44gi2eYFxzF4kqnY2Q9DKOm44wUPneFI= X-MS-TrafficTypeDiagnostic: AM5PR0301MB2529:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VKiO8TwoG9aAaHNe7Ug/0nUW9ukO/DHzm+26al/+q/hs5qq5Urn9acDQv/91Uoeh2FBNWuTiJqYUv/J8z+pQgM5Q8KkzNOD0XoltzyJo4FS9LI9/fCif8Q9eYGF6llTWUMkec9Q6BSWlV2RxMGoNuvoLwVFbDcHPVoS09DHIagOCWhVYLC9RCw1Qh+am2FBQRyf73STxkCiKtWIC892UrhUYN0RUSWEQAc4Zvaktju7a6apiDoX5Bg/is3Jv2Z7pWux9aWouIlypZjrkJ6hxHhnCZSw/VChWy7+mtRx860OWfhXNKAe4yOZ2hPlC8gxqAS2jVhuc1IOTQ+iBH6IHHo1+qdzmRxnNf3LT0dngSYAZvz6PiaPaF6H4X4YSvaXsciIEMqL7X645rniOPzZsDRv1wb63Eu/Dgje7QfxZAkHozvIhwAVpH/mCLs22SRQEr/WpsJxKVRBVARHUe7Na1arrMRFWhUxztGUq8FfsCVab3K5nSp68znTwhfWdBLNurIAuF8keCEE8HeG51xMVYZV7KHtZWwbihyIlODfpsQt8nM+dKr7FHTqDwmMJtQfJs25/2u0sOnHhAffWI0yoCg== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: zd3MPx6tc+CYGWkScXSTYMZEpVsS9DG0EyW7LS1m+WK77AdRYHk7zLF/CyYaZG90vJkMvxX5ZdwnPbvS4wAKvy+dNQmTcOqmW+CMrQ2YyayBzHkofwY8Dwrs57a+Opo/0gjUEjvHkAhw74hBiQoo64f065HU7CxV25JImm+ui5GPV4z1UeOFRa2jN3qWKM6I/fZVs+SeOV2KDDlh9fSrlHLznLBI6lc8QYIY9u+QzLyauP9/1H7Oqip08BPCqRZJBwOPSLtTnxE/N07AxFWJswEW8dQJ6ISHSESjH2WW35AwcQj5641VmnZcqhEEp5SyzWODkj7OvzW/tsdmg0W4nM0Y2m0lniyi4GfH/wpDdMUMWpEC90CnJbseXETeYCckgYNOM1Mfi7ZTwF+EcxjYKsASd0dZuZbjmaYQ5qIOR5Szgmj+2MRtbm1k3SFaFROmQzu9jRsB2Sineja6GSBDyP7KupJBpIDcTjUKSx50ZHIvb1WWa6kVlYeJnAEmbs+qTHskVQwUP/hAleeSwS/WLNJilLZKF2M3NietH7qzEXerO6kDH9c4hMNWA7LKsTCXub6L7F8KSSKrWAuGQN4xNaMtX1uIQ87ux9uKJHxo0UUceHz2wn0RRWTTGxiS/O0UGjJ/Lz0anCGVie4nJ1OdrJpyyD36H0Zm4NOeaTriPa4+FqnvcZqr3bKoOD7bCyISQSXTXn1Yyra6nbvGyE66Zw51rGiJmS8mcuAbz6V6gdItyVw1qDDn+HD2Flx5T6ZxD6nQgQrTiiUF/vHmfaKn6pghoQ9++h46VgWFR6WAy8167Tll3czPmEDKkyIsGTuTQPaLT7PJRERSwyZ1l9q6vAJnkLS4dXc194O5m/lOfwvL6+p+uXCeyLPLzIVY6cSS1r3EWrgxz+gqU75LZE+PLoe0n7+oc/Dge94D82boJvqRcp/ITOpnZyekMWYyW/M4RHMp8adafHM5IX7BcxJ92g== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0f27c404-1b6f-4d52-f358-08d9f111f0c7 X-MS-Exchange-CrossTenant-AuthSource: AM7PR03MB6660.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2022 06:02:40.9290 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0301MB2529 Subject: [FFmpeg-devel] [PATCH] avfilter/fifo: Remove unused buffer frame X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: gU+7ncClM/u1 Forgotten in 03c8fe49ea3f2a2444607e541dff15a1ccd7f0c2. Signed-off-by: Andreas Rheinhardt --- What is actually the use-case of these filters? The documentation states that they are auto-inserted, yet this is no longer true any more since 4ca1fb9d2a91757c8c4c34dd456abf340e3f765f. libavfilter/fifo.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/libavfilter/fifo.c b/libavfilter/fifo.c index 1c7be88ae1..8b34055fde 100644 --- a/libavfilter/fifo.c +++ b/libavfilter/fifo.c @@ -38,13 +38,6 @@ typedef struct Buf { typedef struct FifoContext { Buf root; Buf *last; ///< last buffered frame - - /** - * When a specific number of output samples is requested, the partial - * buffer is stored here - */ - AVFrame *out; - int allocated_samples; ///< number of samples out was allocated for } FifoContext; static av_cold int init(AVFilterContext *ctx) @@ -65,8 +58,6 @@ static av_cold void uninit(AVFilterContext *ctx) av_frame_free(&buf->frame); av_free(buf); } - - av_frame_free(&s->out); } static int add_to_queue(AVFilterLink *inlink, AVFrame *frame)