From patchwork Wed Mar 18 14:31:03 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Rheinhardt X-Patchwork-Id: 18291 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 14D6D44B58C for ; Wed, 18 Mar 2020 16:31:17 +0200 (EET) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E6B2468B71F; Wed, 18 Mar 2020 16:31:16 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 80C7168B0BE for ; Wed, 18 Mar 2020 16:31:10 +0200 (EET) Received: by mail-wr1-f51.google.com with SMTP id w16so14287433wrv.13 for ; Wed, 18 Mar 2020 07:31:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=P2NONRDeixiHd2UYHQ7ZUlqF9dxm0taT1KxXabedk40=; b=U00Eqft+gKsi0M2OKz+on+dajWS6lntWbfT8266RJZ/4uKB7dmlxX/Ijiyzc570yS2 S3D+kfKT76r+7yLmvfvmCR78Y/8oFd6no2/BdTSLrlF/bF4RbhoPhvOMmNbOaKw4w4dW LKSvGj+rtxZoSbxvyttzt9DcEUxGMKJWkqTGkXqSTuO8Ty6NXaqHEdFXKe9hT5NUKMBf Ol4O4TE4bXtXXBD0FUdTNARDRvo8nCzruYmriNxk760n++ewKEBmnEMKpMyKAOeL7ugr PY89QcEjke0EzNvQArhDFLLpEP8iZfz0aLKrzZ0a3eeR/7z4ElQNUToCtzh160gfv9VW esag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=P2NONRDeixiHd2UYHQ7ZUlqF9dxm0taT1KxXabedk40=; b=m6hkfG1TN2f0ExFQ7dpImnWojTwlry4+H15FAHTzeBQc6PWc7oxJeLXPCBRC0O/53G n+LzjWmw2UvcwbHkhmWWINY4QL/sNF20qlJFGvjpMd+GkHwAZtui9mMDvfuPdCBgLrjN c60umjRp6IAAUvqOaGUIZH5rr1xCtmvlUrbAC+5qMNvrFa9L+Q/ZJ1YF2/n6D0xWm+wh pVMld1NZAalVerouYg0gmtWUwOfVSyyp8wX8t8hTHh7Sp2DN3S6DPCqP/Vxle3+b/8lR Lj+dHmcCfwv+x4de7VIWYcjvHc8ahxbBDCFlT1ItZ7OZjQRPUMz4tYRt0jw0T9vrUB6T vvSw== X-Gm-Message-State: ANhLgQ2MKD+lsHq2oiEu0lPS5sHRwyqphUUYbfCEA6hs7ev8CoSfCXDe arpNx+KHlLFNS5Q+0sVFAwNH/S7Q X-Google-Smtp-Source: ADFU+vsOM3w5RDO+Eiqy8JA+Oj9SaunsnaU2AWtUJqalKrtsZ2VmIl2yn91RTKsWS4TFrkpt1HeTBQ== X-Received: by 2002:a05:6000:12c5:: with SMTP id l5mr5636168wrx.134.1584541869635; Wed, 18 Mar 2020 07:31:09 -0700 (PDT) Received: from sblaptop.fritz.box (ipbcc1ab57.dynamic.kabel-deutschland.de. [188.193.171.87]) by smtp.gmail.com with ESMTPSA id j11sm2235744wrt.14.2020.03.18.07.31.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Mar 2020 07:31:09 -0700 (PDT) From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Wed, 18 Mar 2020 15:31:03 +0100 Message-Id: <20200318143103.22384-1-andreas.rheinhardt@gmail.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] avformat/avformat: Remove redundant "NOT PART OF PUBLIC API" X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" AVStream.request_probe as well as AVStream.mux_ts_offset are below the separator of public and private fields, so that a further "NOT PART OF PUBLIC API" is redundant. Signed-off-by: Andreas Rheinhardt --- I initially also wanted to remove the internal note for AVStream's private fields ("be aware that physically removing these fields will break ABI"), but then I became aware that ffmpeg.c uses several of them (pts_wrap_bits, first_dts, cur_dts, codec_info_nb_frames). If I am not mistaken, this means that one can't even add new public fields in front of the public/private boundary in AVStream at all. libavformat/avformat.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavformat/avformat.h b/libavformat/avformat.h index 9b9b634ec3..f9291a26ec 100644 --- a/libavformat/avformat.h +++ b/libavformat/avformat.h @@ -1124,7 +1124,6 @@ typedef struct AVStream { * -1 -> probing finished * 0 -> no probing requested * rest -> perform probing with request_probe being the minimum score to accept. - * NOT PART OF PUBLIC API */ int request_probe; /** @@ -1170,7 +1169,6 @@ typedef struct AVStream { /** * Timestamp offset added to timestamps before muxing - * NOT PART OF PUBLIC API */ int64_t mux_ts_offset;