From patchwork Tue Mar 22 17:47:34 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Unterweger X-Patchwork-Id: 34905 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:ab0:5fda:0:0:0:0:0 with SMTP id g26csp717357uaj; Tue, 22 Mar 2022 10:47:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxrXYo4rjdmRg3nLO0V8Dp3P7zNbs+PqpAjPYbG+1O94MhAPO3vjLW2clK5smmZ6faGvy3E X-Received: by 2002:a50:baa8:0:b0:415:b0bc:6353 with SMTP id x37-20020a50baa8000000b00415b0bc6353mr30144367ede.220.1647971269772; Tue, 22 Mar 2022 10:47:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647971269; cv=none; d=google.com; s=arc-20160816; b=nB7NnLMdvMDpxSfy45UMuwgYjl4rHo/5EjlcFkzfk1tor/pAWUT3xdDkO9D+lmKcaD kI1sn3PfXuHKiVUe8P6HHpTtPeO9yOmsxcDNRZPvocGrhW4y7cQGqRXL3jT7lve2cB81 AgBmAD7dqD0j0oXl1WtwYkYwkU1EAiHrGJsyBKwCLPKV7GC+Ca4Yw3a0OhRrXas/naxb 0lSFq5YK3foXq86XCbxnGHoylGE3IHSFCXvENpjp2Dp6E2VGLDc3OxWuCqa3i1hRcbX9 bxqcYe98lqbWM43QxXZ0bK/6EkQJLGYTNQx9FsQS0+fbLaOXv0jUzSbhUzgz6dMsoilY UfLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:content-language:to:from:user-agent:mime-version :date:message-id:dkim-signature:delivered-to; bh=6DXiYyWYSfJPWAGP8Zydwqy40lMODMs+xbP9TXCbOjk=; b=IwDIcRXmRfxSoiysII0VXZi0MXPRTCyR80RPvSDvVQYsXG6nPwnN6Vk2RI3BmoT2y1 OKr1n1dva6s8Vrqoo5TpSWbGxqn/GQe1NIVt7bGwpTYoxdn1Owd58MkzZ046gIMczHt/ SuITZ5kvk3Hi2EFaVt05aPGmWX2qhMou0NW/tP3C6LCJwXGuEMp4XzN7CT4vTxLjea5G tLjqvUbwtGT22fb3W74aj0yV9iiHSclt4CxAaVU90hs8kfyoKofXqkm/QlKAsYBz2Uij IG64oQWIQ041l7xyle9qjmZvnKO0FMIDaKjIuxK46CEhsv0HMdNY/wzA5t9NOol45ssM RYHA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20210112 header.b=HxbYcvMR; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id bi20-20020a170906a25400b006df76385e6bsi10411165ejb.779.2022.03.22.10.47.49; Tue, 22 Mar 2022 10:47:49 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20210112 header.b=HxbYcvMR; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 05F1F68B16B; Tue, 22 Mar 2022 19:47:45 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id BBD1F68B11B for ; Tue, 22 Mar 2022 19:47:38 +0200 (EET) Received: by mail-wr1-f49.google.com with SMTP id h23so23887074wrb.8 for ; Tue, 22 Mar 2022 10:47:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:from:subject:to :content-language:content-transfer-encoding; bh=2N+bysiJ0nSWEnSRA2udPKZW6AExKkGTTJFuDaxkv14=; b=HxbYcvMRTGLGXxAKBr8kMSa4ZszoToy7r2IgbmRf7UKCjglKxEdsiglA+jsxdM3B3H nql20yJfiuoTnnV5gEsxeqwV81e92dcXc9M7dtVRSuTr4xz5uAtkSUg+anXm5XYlXFzw eUTWIRJkIhG5qxWGFpEGw6V9moWgymJ8BohKwctobOTVFRRgqP45uIbZWL78W22pQJq+ dPsEtwiBiSJnh4J2+q8QORwLmoXrd4t7SSXe7DTfQxuYxOBJv5DDH+FU+USNsiwkBnlG Hrzi/rmItDMUkux5NeDshU1ra/fQCNr2zxb+Eu7piCGBaTOz+Hl2jDyIpMC8Go3eFaIg uk2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:from :subject:to:content-language:content-transfer-encoding; bh=2N+bysiJ0nSWEnSRA2udPKZW6AExKkGTTJFuDaxkv14=; b=ZlAgtta+AgwMdXIJ3H3qEx3iJe0SO0413Tt1WTQIUgjIUGnkMwsp4E6qFu4G+npBaE gSzR+pSg+P8Py71FXsS+c9AZT67c+LOlJvxPu50r0dNGzElwH41c9WPULOu41t0MCrVb MijKZKRuBv3rJcZF2NYkj7ojF+uvqFFd2GONBXRnC8Ck4VAWy8EWLte7CL0pN0st0VTI 8nQb7siYYzY/trwr4mTzdlwsw2Iac+PPakkL0V242tJ47Omc5yi0avob4ExvyJ/S6ret lWJWqaODmPsMCFI+NrIYz749LtMkJse7Wjy1/HBoMKRXM0ujrHaY87DgHD99fNP1xNVL RcDQ== X-Gm-Message-State: AOAM531RMvjTFmu2V8rURsdKdTl81uH9qzjcYb4MTy3cVZpkNjJJJGQB y6j37F6Z2D4hSxgtLEzVSoDjg1kOIRk= X-Received: by 2002:a05:6000:1547:b0:204:213:ae28 with SMTP id 7-20020a056000154700b002040213ae28mr13262501wry.114.1647971258175; Tue, 22 Mar 2022 10:47:38 -0700 (PDT) Received: from ?IPV6:2001:871:242:8728:1cf3:1aa8:df01:4a15? ([2001:871:242:8728:1cf3:1aa8:df01:4a15]) by smtp.gmail.com with ESMTPSA id z18-20020a5d6412000000b0020400dde72esm8928037wru.37.2022.03.22.10.47.37 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Mar 2022 10:47:37 -0700 (PDT) Message-ID: <8fd28808-07f8-9458-b032-8792c67a38fd@gmail.com> Date: Tue, 22 Mar 2022 18:47:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 From: Andreas Unterweger To: ffmpeg-devel@ffmpeg.org Content-Language: de-AT Subject: [FFmpeg-devel] [PATCH v2 1/2] doc/examples/transcode_aac: Don't ignore last encoded frame X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: Tam+FPwYv+5b The last encoded frame is now fetched on EOF. It was previously left in the encoder and caused a "1 frame left in queue" warning. Signed-off-by: Andreas Unterweger --- doc/examples/transcode_aac.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/doc/examples/transcode_aac.c b/doc/examples/transcode_aac.c index 9102e55f16..c9b93f6439 100644 --- a/doc/examples/transcode_aac.c +++ b/doc/examples/transcode_aac.c @@ -377,6 +377,8 @@ static int decode_audio_frame(AVFrame *frame, if (error < 0) return error; + *data_present = 0; + *finished = 0; /* Read one audio frame from the input file into a temporary packet. */ if ((error = av_read_frame(input_format_context, input_packet)) < 0) { /* If we are at the end of the file, flush the decoder below. */ @@ -555,7 +557,7 @@ static int read_decode_convert_and_store(AVAudioFifo *fifo, AVFrame *input_frame = NULL; /* Temporary storage for the converted input samples. */ uint8_t **converted_input_samples = NULL; - int data_present = 0; + int data_present; int ret = AVERROR_EXIT; /* Initialize temporary storage for one input frame. */ @@ -675,18 +677,17 @@ static int encode_audio_frame(AVFrame *frame, frame->pts = pts; pts += frame->nb_samples; } - + + *data_present = 0; /* Send the audio frame stored in the temporary packet to the encoder. * The output audio stream encoder is used to do this. */ error = avcodec_send_frame(output_codec_context, frame); - /* The encoder signals that it has nothing more to encode. */ - if (error == AVERROR_EOF) { - error = 0; - goto cleanup; - } else if (error < 0) { - fprintf(stderr, "Could not send packet for encoding (error '%s')\n", - av_err2str(error)); - goto cleanup; + /* Check for errors, but proceed with fetching encoded samples if the + * encoder signals that it has nothing more to encode. */ + if (error < 0 && error != AVERROR_EOF) { + fprintf(stderr, "Could not send packet for encoding (error '%s')\n", + av_err2str(error)); + goto cleanup; } /* Receive one encoded frame from the encoder. */ @@ -857,7 +858,6 @@ int main(int argc, char **argv) int data_written; /* Flush the encoder as it may have delayed frames. */ do { - data_written = 0; if (encode_audio_frame(NULL, output_format_context, output_codec_context, &data_written)) goto cleanup; From patchwork Tue Mar 22 17:47:39 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Unterweger X-Patchwork-Id: 34906 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:ab0:5fda:0:0:0:0:0 with SMTP id g26csp717385uaj; Tue, 22 Mar 2022 10:47:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwbfs/R2pv2LuFpfH5MW9TEJ1Mqdcl5GZKxdsHM4ok/Cx5+aWgg6qEl6oCMf32F5T77RiMn X-Received: by 2002:a17:907:72d3:b0:6df:e767:f07d with SMTP id du19-20020a17090772d300b006dfe767f07dmr14881466ejc.420.1647971278552; Tue, 22 Mar 2022 10:47:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647971278; cv=none; d=google.com; s=arc-20160816; b=GhO/hYmgXFMgb8BfzQQIMKECaDJ7tUfvOTUI1QqRDJBhydm+nxTrHNjvfB2h1ofuMC iiFpk0LIdB2Xr+nTN5l2czFK5ldCXRGrrBAPSt5jZZoNrFCRMySILWMY42TS0EqTT8Ts EdMft3r217luMTCy7LjnKjxjTDN+5iQA4jSnC9/GnMZTYLWAxYm5f4gZklAbDhaVnhxe VraXSXp2plZcsqnVetIm//98Ysp3Nirq35EZToz+EkJDbX9QL/X+aHVkloEwHawFbKGg fHFS83Io7PYhMY12dJyXBUCjMeMl7HYzmVnPPC/Y43Q4erpMix0t0q51ghLdGYMEUsWN BmjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:content-language:to:from:user-agent:mime-version :date:message-id:dkim-signature:delivered-to; bh=U4lHb6346skhq2JvuX42z9O4Sh4bgpaTzI6uvM9QevI=; b=YF1LD3xWfNwY/qtl58oue8/Bf6P1VYo2Ddwt21tmHOxVnejgidhBuyWBgyMe2Sj7A2 J6T2pFBQ/HUk8cmYNf4fjsd+lFZoXZJC/ypSqmtV1IadT05aZg3x3jhacaaRX0gtJEtG eql6BjCx1RX/Sx8TnGUOVoNDsM6gsXrqZgHOQBCFg1+y8DC5faTibFgzVFleF7xkx1Vj cnl+Uwzx2F2rax1ItimzXuy2X1DmRjnAyjTj+fdqzlistrXEBNreAVfPF4ezUC7oxnj8 TbP7AebnTW2FhgMrWZ9IM+Eh7IjN2dPLg6MZaFz++ot1ZSNRh7TvJPugxB8KaFgoSbpE iprQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20210112 header.b=CzHbh4Xc; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id i5-20020a50d745000000b00418c2b5be44si13273493edj.294.2022.03.22.10.47.58; Tue, 22 Mar 2022 10:47:58 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20210112 header.b=CzHbh4Xc; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0D4F768B16F; Tue, 22 Mar 2022 19:47:51 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 90A1368B151 for ; Tue, 22 Mar 2022 19:47:43 +0200 (EET) Received: by mail-wr1-f46.google.com with SMTP id h4so6541291wrc.13 for ; Tue, 22 Mar 2022 10:47:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:from:subject:to :content-language:content-transfer-encoding; bh=SW/uItGj/JEm9llEHVqeJBfykgq/MAzeD2agEDusy+A=; b=CzHbh4XcogSzI0clRc9e0FuQYt+WnJ5CeZExpehiJNK/cvF97jMTAVb3NM1EPuPO99 ubhdER0PADvkaQ3T9eb497VEWPDCxoD/d6rNY8w4VGIdAxmH0vW1CoxmZhNUUTHN2aKD 9O6igXBzo3gU/w0P1EOSyoRZfw1DTqYvgDA/K43j32vSYphH68fYcnphPHJ5g8UZ4AJr ThmXle3iwv6PWY1T3aTo+bKo29IxKO2kqnOZfiCUHcdshvHovF7AV1yD+//2W3aX45VA vxqGAb08IJB3ROXRpo2udr/M8EY2hOILIpHhdd7R0lEEPKC8hZta1FWAF1RHInM27dev zvbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:from :subject:to:content-language:content-transfer-encoding; bh=SW/uItGj/JEm9llEHVqeJBfykgq/MAzeD2agEDusy+A=; b=AcMmzP8EXlP06ocAR8Z6WLJoD1xnU6cHP1uUpsSj6iNgJn1lZZc2s/qyHiSRn5mrMt gXzpGQOpqX6MIlGbSaLooPG6Q++vuwskvZ+HZYCTYDrcBLpUQXZiZBJBfVo0OChK+9rL k2xMVHv5EmfvHN/DZ7MFSfoF+kM4VWLnNoYq85lyXZGvzX3T0i3lFFMEkVk/UJAiCB0Q E4mCj2jveWYl5AIRcccO5Zak0DZ5lV/wUp0Fwb74v8F5fVKBprKYuz7irAqfasMm8AkL lD2vqYV5Lw475TBJOPpzToIh6VCLC9Ue+Hbl1QCqnw0GUZfzmYVVZufMimCaSOck+Y8L KrwA== X-Gm-Message-State: AOAM5333udYVAdSZirIMs999BTZtOhZM3wHXyrMXwFRnHosHDMkYimmY rT8o9EtXWO1nPN7dTbF+EOYxJNvmg0M= X-Received: by 2002:adf:e8c9:0:b0:204:116:9e04 with SMTP id k9-20020adfe8c9000000b0020401169e04mr13881642wrn.19.1647971263051; Tue, 22 Mar 2022 10:47:43 -0700 (PDT) Received: from ?IPV6:2001:871:242:8728:1cf3:1aa8:df01:4a15? ([2001:871:242:8728:1cf3:1aa8:df01:4a15]) by smtp.gmail.com with ESMTPSA id bg20-20020a05600c3c9400b0037fa5c422c8sm2501868wmb.48.2022.03.22.10.47.42 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Mar 2022 10:47:42 -0700 (PDT) Message-ID: Date: Tue, 22 Mar 2022 18:47:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 From: Andreas Unterweger To: ffmpeg-devel@ffmpeg.org Content-Language: de-AT Subject: [FFmpeg-devel] [PATCH v2 2/2] doc/examples/transcode_aac: Set decoder packet timebase X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: 1ew+CNwAgsnL Previously, the default timebase caused two warnings during decoding about not being able to update timestamps for skipped and discarded samples, respectively. Signed-off-by: Andreas Unterweger --- doc/examples/transcode_aac.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/doc/examples/transcode_aac.c b/doc/examples/transcode_aac.c index c9b93f6439..6197369756 100644 --- a/doc/examples/transcode_aac.c +++ b/doc/examples/transcode_aac.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 2013-2018 Andreas Unterweger + * Copyright (c) 2013-2022 Andreas Unterweger * * This file is part of FFmpeg. * @@ -120,6 +120,10 @@ static int open_input_file(const char *filename, avformat_close_input(input_format_context); return error; } + + /* Set the packet timebase for the decoder. The input file's sample + * rate is used as the denominator for simplicity. */ + avctx->pkt_timebase = (AVRational) { 1, avctx->sample_rate }; /* Save the decoder context for easier access later. */ *input_codec_context = avctx;