From patchwork Tue Apr 26 08:20:24 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhao Zhili X-Patchwork-Id: 35440 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:3b9e:b0:7d:cfb5:dc7c with SMTP id b30csp2291087pzh; Tue, 26 Apr 2022 01:20:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwYDdD2p98Ja5Ow6hWaAfgXrd+lFWIYpGPZ62UN42WqvejE6RqS7f3ChbyjCgG0rlqzBXFF X-Received: by 2002:a17:907:7f94:b0:6da:64ec:fabc with SMTP id qk20-20020a1709077f9400b006da64ecfabcmr20112185ejc.717.1650961246411; Tue, 26 Apr 2022 01:20:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650961246; cv=none; d=google.com; s=arc-20160816; b=GTmAnoHXzwh3OewWDvj7Va59+BJdzbH6AmZLPzXDa4Rj5pO3hrOrH5omWC+EjyJyeD ztsNlwZw3wxGBP90qwSpSkg9370ERFc82dYtil+oa5AR2UGhn1/HgsvvP5tgWCloh7GF utkGUJ7035+jc9KYWk2Vfe92/UGgtCVLX+BWIBCy8GE7ikA6NLqc/TacsYHOtizappCY 2o3m2Mj+BHqD0hSHSGmx82ijdrmXAW2WM6k/9qrZs9u8rYI+cqPKClRHk/Rct6mEQyJ8 YcEQ+gLGGPy+NUNfwtt57f9lATMJSn6RnNiTnpjeQObyE+21cbG/9wBO8qY7fvKlqcEm Y4Hg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:date:to:from:message-id :dkim-signature:delivered-to; bh=lm+yUYCxas+8McxwUVAv5ew7oKaIqsT/Yd3LZIDOT/k=; b=KIhTErSBI6e1uDQfCe5mI2LRl/hxfUyeiQ/Nbbvg9jxyR2fEAYwmCGnQKQ8I5ZobOs tZhNIK6kf8lNkjUwY+znGtTcZok2SvdR5XAbHg2jun8t4VYJKp2kLpAXQbd/rS5mKFDU WoQypcrOxaxfKqRBrQG70787mR+5j9xpkbQ48ZuwYCGzKsO4C7EpDL/8sTCaoxlBWrGJ Oe/WxJm7FVMsC/UgjoPksc8dXplNlnHtAg7a+O6WvrvI9yw6F5pVMRUtmHrcLaoKApyX BfL9zC3TwwtDkNqJCRHaSOG6mUHw4H7YXa0q2rBWNwGLh3Zp0kigya5YGXFWEX1QDYiz kDfA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@foxmail.com header.s=s201512 header.b=ueeWQc7I; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=foxmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id s19-20020aa7d793000000b00425c9955318si8219277edq.345.2022.04.26.01.20.43; Tue, 26 Apr 2022 01:20:46 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@foxmail.com header.s=s201512 header.b=ueeWQc7I; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=foxmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CF51268B29B; Tue, 26 Apr 2022 11:20:39 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from out203-205-221-149.mail.qq.com (out203-205-221-149.mail.qq.com [203.205.221.149]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id DD95468B261 for ; Tue, 26 Apr 2022 11:20:32 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1650961227; bh=jF4xmvkwHkTBLldi+2qCNZmexwwEGBdbKEClFSytAyM=; h=From:To:Cc:Subject:Date; b=ueeWQc7I8gbo52HnbYPtIqfBYJ2M2uNfDeZJMHIZojP/ndK9Wu7ltFfJUjgeBG7Vh ApzJgdCg3AGeAnMNZrqXTG9DWI7AGlOaUPQTE4V1RVvg3VT9WfI3jHZKJy0g/Ltkpn KYsXUA4UuNsLaKCJ0Ch63N0wF/zrIaA8584BcNss= Received: from ZHILIZHAO-MB2.tencent.com ([113.108.77.52]) by newxmesmtplogicsvrszb7.qq.com (NewEsmtp) with SMTP id 51A3A6B5; Tue, 26 Apr 2022 16:20:26 +0800 X-QQ-mid: xmsmtpt1650961226tf7xxs0v7 Message-ID: X-QQ-XMAILINFO: OG9RsPdae1zRKKxVcqa3EID5Tg0SFD/hEo9uYZK7VumRUH0sazopzVFJRyg5Hv Iu816XXFWPiPFPNqjDxdLNz44Gi61WLIA3IlCXg39KnITs/G4VEjnRsiMNFWpoZJkzPWYpKO0ZpC K88bYHcM6Nl+FgzwFfA/0tnMR8QBWWXqmAUx594nC98hjoz00LXNTCUexhpl1+G0aAnZK+XyecYN 0ULZknVOADig1bhyvfXrPY4o38OUwkz0NBqi6y4nWDf2uyaDq/6uGGR1rHWqpBOhPvpHuZHIndAd zFFe+XsPkMTG64ydnDAdI2Us+jTuChque+n9b4RFHSkkcguvV8w6xfZhQWW9rLQ7bVqEMMPi/lK8 SQrsBL2O6J2gv2h3Rr3PdC8VlTvBUgVK+dcIlbGJRd/8mH3NOCcTjAFPa0Y8y85nLEaMtzH3XXQ7 Vg1ffJA2oK0/iowrICNSYRElTM682UMbH5HbI5LzrbsFpFOqVzqk11/tKKIrFBt+vw46b2TPYIZg UPHF+fMujBxFvh8Tlqp2qBZVDyBBvjKPEtJh74IGQAMpm7n6LWfsrRqc6ubogQQOl8+hljblFpU1 nAh/QXcCvgr/xrCBIDiDB4RsxtlNKoG+UCUK9ni00D0cfNA56rnHCYjQLzNwS29wHQui0eSQ8+uU tPgoZc5eBX6kQEUrEVn0+5b54+MUskwinK8d1IK/jtFGW1KbHsGiIbObRwWfY34nXjKdhERqGNxv /xZy+6Qy03awfV6NztfnrWOrRwRKwKzSZ2+OzfbxaI3FD23ODHzOkeB46kKC25/rhvr1g/Q+Clms Hw7IPZiNNilInCwrC3QEXOr25os5aUuoM5jp16h0RpJgyETPgNZHb/VMSD+vYg3vtyt1hVN7FY8T vzQdmyuLbCGsu4jsSsf/MnqyEAQOH7evYPgnfo2ejBngD0VHLUIAE= From: Zhao Zhili To: ffmpeg-devel@ffmpeg.org Date: Tue, 26 Apr 2022 16:20:24 +0800 X-OQ-MSGID: <20220426082026.85353-1-quinkblack@foxmail.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 1/3] avformat/mov: remove an always true condition X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Zhao Zhili Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: KtG1O1BhJ0nU --- libavformat/mov.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 26aeeaea0c..6116078b1a 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -7693,9 +7693,6 @@ static int mov_read_default(MOVContext *c, AVIOContext *pb, MOVAtom atom) atom.size = INT64_MAX; while (total_size <= atom.size - 8 && !avio_feof(pb)) { int (*parse)(MOVContext*, AVIOContext*, MOVAtom) = NULL; - a.size = atom.size; - a.type=0; - if (atom.size >= 8) { a.size = avio_rb32(pb); a.type = avio_rl32(pb); if (((a.type == MKTAG('f','r','e','e') && c->moov_retry) || @@ -7729,7 +7726,6 @@ static int mov_read_default(MOVContext *c, AVIOContext *pb, MOVAtom atom) a.size = avio_rb64(pb) - 8; total_size += 8; } - } av_log(c->fc, AV_LOG_TRACE, "type:'%s' parent:'%s' sz: %"PRId64" %"PRId64" %"PRId64"\n", av_fourcc2str(a.type), av_fourcc2str(atom.type), a.size, total_size, atom.size); if (a.size == 0) { From patchwork Tue Apr 26 08:20:25 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhao Zhili X-Patchwork-Id: 35442 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:3b9e:b0:7d:cfb5:dc7c with SMTP id b30csp2291177pzh; Tue, 26 Apr 2022 01:21:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwdb1hdc0QPLCkbh3BtbYecxr4XploCkIA39NIJX9ghKiWUfWfFGaGvG29ochSDllluETC9 X-Received: by 2002:a50:e70f:0:b0:425:da3c:4731 with SMTP id a15-20020a50e70f000000b00425da3c4731mr12749604edn.223.1650961264023; Tue, 26 Apr 2022 01:21:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650961264; cv=none; d=google.com; s=arc-20160816; b=r2/pnrpnKXh0fPtvxiaMH7CE/obNCyl/3qFl7/JfdbfoITF2fn9OdUWYwi4szK0Gid zHkRe1HttXd9xNIuZAjJtiOP2TqDX31+7rRhvj1OA9p2fDZbtO1/Lg3RgRZiDpbg1ATh ADSWO7BK46JNYQhtIAuTBmJSKaSHCLj3/Msj0G+EBVRtGpzyKXKqQ2/shzqvixadTNbY 7MmmATCwiTEYwtUDZM/ZculUJc0qMZrBae29QkqFZhcQglcarSClCR4ACPo1iYiiVWHL u8alW5f5r+bttIPWQS/QGp+Pi+VpMvQv4pHyEIMLTKz7zjMdArdF9U9ut3ouljVfqWkq QG7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:references:in-reply-to:date :to:from:message-id:dkim-signature:delivered-to; bh=NYAR4kNVKUa9+WzKECoxvv/vwc4Mz6zNEBNY45zjRxA=; b=TByS89+Pa+KoTaITQhEmDG7mz0YeReCztxOLj8Q6r/Y+RuQbi1jx+Jtk22nC73MJcN wloYj6E+MncAzzbNwD8IwAbmVQ1wtZ816sOk8P0S5abRgTbBg4U4OyGezMHIc/sP5/0f oH6rcRtoZ1nJFufJPIwVN8pphQVmDHYTPU+I6wmeARiXOR3asOM7jhdlGyrY5EHeARy5 zwnSX3YHt+lBcIc2LMRlaAmRaPhwFaoCTZMsljpMy5k1zqiMQAd9XXyfi/Lxa7YsOpn9 LQVhUbb6obKYC9Rr9fILfe2CUNtYH0Zc7vkYgsPVViBOExyrBPgC9zYopfHAtt2bDb62 AjUg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@foxmail.com header.s=s201512 header.b=ubEFLHpm; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=foxmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id o22-20020a056402439600b00423f40b8548si16348162edc.579.2022.04.26.01.21.03; Tue, 26 Apr 2022 01:21:04 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@foxmail.com header.s=s201512 header.b=ubEFLHpm; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=foxmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E2CC468B2F7; Tue, 26 Apr 2022 11:20:43 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from out203-205-221-240.mail.qq.com (out203-205-221-240.mail.qq.com [203.205.221.240]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9D4DD68B29B for ; Tue, 26 Apr 2022 11:20:33 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1650961228; bh=+fl5Iu3VtJbsnzz2SxWJumbieBGcisOUwTTgMzVhdvA=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=ubEFLHpm3gETMy9FuQAI2BxSiKxzDCMACAjqL+qMA2cg83fAOlqgsoqPzh7oyhFts BPVMdNlMe3vBgxkB+qgMaKIsjj+b7v/voBId00A/fvV/0vFZM8FWaD3uYrACB91hdG a47qhg2zLMRT70n+IW41KoBVQW2H7Z4fnvKtvYMM= Received: from ZHILIZHAO-MB2.tencent.com ([113.108.77.52]) by newxmesmtplogicsvrszb7.qq.com (NewEsmtp) with SMTP id 51A3A6B5; Tue, 26 Apr 2022 16:20:26 +0800 X-QQ-mid: xmsmtpt1650961227tzai09piu Message-ID: X-QQ-XMAILINFO: MXdylPHsT1M8MSe3DfnsYe9QAsx9ROCcC9Tl1zwJBolKLVZUXHhx9U35lIgGcr iku5POsAA964GynBGYrvSrAJuDfFr2PTblwbD7b2IFh9xtlrXGutEPZkpf2KGdnSptW/JxzMuRQG Ds9FVfcEJQDGn8moCLS3WYUfXfHwCFu+wHFagafIIV3nQ3Hv1cp7WPblo5Rgl5eXThK17+gVFQET +V2MLI8cfJh738/ByHptVbiR1Cr1DnaODEhN4eFqccuuZapSJ18TV90E0y1tx/ZNn/VwovReu3FR xhz79eKaMDn8Fk1nYCSLo0/U7IfoOe7rWI3aGm3Y5jiWXpTWJnya2IP2JQPHcmsgA6qO7XgplIyB peGZ6LlCLN++zA1lHwK77di8cMAEQNhtOBqX2DnfLHGry8h7ue234aXj6ZPMJfYD2dPGuQ1o3CI/ XD/TQDOhiS4v/lwthei9+ET1R0NcueEBUGXNxnHzbDGnSYwTAo/knCoMs3bWRnsRRRQUTE2CXh3b DQMJjQ9kYKFbFPS1id+lCXanDs5cS6K51UIFWg6ajhZO1mXXvdi61C4avtw5+HmEB/UCrBjhPoVa tVHQTu2d0f+SoyFuMpksGS3C8c0EwH7haiW6C4NHD6E/fDr4r9z14QOKo7KRR2FjvG1lGxAT98Hr 9AZOlx/9UGD/bq4vR105fGbn1FWmcZol6PVR210iYnRmS7Djl8Cr4raQSzBrb70w59vBoBk2NqCb 0s+khQQ3Fo0BytdBEqJb9PLBgQ+U+C4MUmpmaTzT8v/KrqmXGPyZLLM+vqwRC1ljfGGmEZZzJW7Z kmBjaJhBQodEKYWihX4cLSYUoQjIZoVxb5Gr2lYHQQIo5a3JGNmCSZlMuIfV3uxsOAO3/3N05K3Z 7uaMwNcqxtcoZCDAL+GuRR3Q2jpvqF+OQmmeV3/EQrSxabTIjcYLuvyZiLYdeyt0WpAbDlRS61 From: Zhao Zhili To: ffmpeg-devel@ffmpeg.org Date: Tue, 26 Apr 2022 16:20:25 +0800 X-OQ-MSGID: <20220426082026.85353-2-quinkblack@foxmail.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20220426082026.85353-1-quinkblack@foxmail.com> References: <20220426082026.85353-1-quinkblack@foxmail.com> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 2/3] avformat/mov: reindent after previous commit X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Zhao Zhili Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: P+V19tWMYX/F --- libavformat/mov.c | 40 ++++++++++++++++++++-------------------- 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 6116078b1a..e948c6cd0f 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -7693,12 +7693,12 @@ static int mov_read_default(MOVContext *c, AVIOContext *pb, MOVAtom atom) atom.size = INT64_MAX; while (total_size <= atom.size - 8 && !avio_feof(pb)) { int (*parse)(MOVContext*, AVIOContext*, MOVAtom) = NULL; - a.size = avio_rb32(pb); - a.type = avio_rl32(pb); - if (((a.type == MKTAG('f','r','e','e') && c->moov_retry) || - a.type == MKTAG('h','o','o','v')) && - a.size >= 8 && - c->fc->strict_std_compliance < FF_COMPLIANCE_STRICT) { + a.size = avio_rb32(pb); + a.type = avio_rl32(pb); + if (((a.type == MKTAG('f','r','e','e') && c->moov_retry) || + a.type == MKTAG('h','o','o','v')) && + a.size >= 8 && + c->fc->strict_std_compliance < FF_COMPLIANCE_STRICT) { uint32_t type; avio_skip(pb, 4); type = avio_rl32(pb); @@ -7710,22 +7710,22 @@ static int mov_read_default(MOVContext *c, AVIOContext *pb, MOVAtom atom) av_log(c->fc, AV_LOG_ERROR, "Detected moov in a free or hoov atom.\n"); a.type = MKTAG('m','o','o','v'); } + } + if (atom.type != MKTAG('r','o','o','t') && + atom.type != MKTAG('m','o','o','v')) { + if (a.type == MKTAG('t','r','a','k') || + a.type == MKTAG('m','d','a','t')) { + av_log(c->fc, AV_LOG_ERROR, "Broken file, trak/mdat not at top-level\n"); + avio_skip(pb, -8); + c->atom_depth --; + return 0; } - if (atom.type != MKTAG('r','o','o','t') && - atom.type != MKTAG('m','o','o','v')) { - if (a.type == MKTAG('t','r','a','k') || - a.type == MKTAG('m','d','a','t')) { - av_log(c->fc, AV_LOG_ERROR, "Broken file, trak/mdat not at top-level\n"); - avio_skip(pb, -8); - c->atom_depth --; - return 0; - } - } + } + total_size += 8; + if (a.size == 1 && total_size + 8 <= atom.size) { /* 64 bit extended size */ + a.size = avio_rb64(pb) - 8; total_size += 8; - if (a.size == 1 && total_size + 8 <= atom.size) { /* 64 bit extended size */ - a.size = avio_rb64(pb) - 8; - total_size += 8; - } + } av_log(c->fc, AV_LOG_TRACE, "type:'%s' parent:'%s' sz: %"PRId64" %"PRId64" %"PRId64"\n", av_fourcc2str(a.type), av_fourcc2str(atom.type), a.size, total_size, atom.size); if (a.size == 0) { From patchwork Tue Apr 26 08:20:26 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhao Zhili X-Patchwork-Id: 35441 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:3b9e:b0:7d:cfb5:dc7c with SMTP id b30csp2291140pzh; Tue, 26 Apr 2022 01:20:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx1+w947tsxIlx84hOT7WBXySy7j8+1t4VCsAnqPoT1L+H7Gcs5yB0zgFMKMsNumwT0qvwk X-Received: by 2002:aa7:de93:0:b0:418:d700:662a with SMTP id j19-20020aa7de93000000b00418d700662amr23101185edv.107.1650961254406; Tue, 26 Apr 2022 01:20:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650961254; cv=none; d=google.com; s=arc-20160816; b=C+K5OL5NtYm6zy463Fi5/2jhQC9LMZGnSYvnMCvblFdYMTgdu3H3AdrfS97Ru+GaCI ESw1HjPrCWtBeHPkUwHi3FsD5X+rpZZ0krU/XC6oEi7sJtcD3OIEbECm4WHABGWgEtNq 540BaVlFCxVOlZkaNO8qH5S9jz9a1frplnXO2pmhTDoGK7oUEWz4iXxCtEsns/eu7Goq /QSDTwmkMi88nEbxBTVGgVmBB5uiDWyFI+6ZqaYs+mraSDOMmc/GKWTZZEisiSpoBdEa 1jSJEZsslD7NY6RniKbrSHIrw/COy70VUT4yTYRD0gzSa2mbdE83Y5E/OIZwnAEnyisF Notg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:references:in-reply-to:date :to:from:message-id:dkim-signature:delivered-to; bh=XuBLkyz6NVaa/fLDOe7Z7194w+W5+KN950hY0ZcsUd8=; b=Cwb4mfNUsj2eq66O843doiq90lM/ciZcxFSrZl6vOTkAlpyyf52x0IK2QYVDeehM+T nDsMwInUsL5rF71Jla4oCP+JxwGmHzQx7YTkY0uRgwVAKGSCdb3Zajw1nq5qiSx9r6tX NFaNYFC//zBWSje5Cta6yZ7ZoQEL4cPXQ9FLNgiqRcHy7MHbqJOFoYDuk/vwTMBGeH78 BY0qlUJQ0pRcepga4mJQDwSmB20TSkXjLmTFY3E2Y4uGzRtC8y2mMVxkt+rYeFJ+dWw5 xG1pelZtHDTUqQcTXyAP/OP9CNHfXA0+80YOckgFbt1pqU1Dtvv1hrF+N/8V5FjFpEEC zMdA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@foxmail.com header.s=s201512 header.b=aX+mv9jj; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=foxmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id f10-20020a0564021e8a00b00425ff4df720si533478edf.560.2022.04.26.01.20.54; Tue, 26 Apr 2022 01:20:54 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@foxmail.com header.s=s201512 header.b=aX+mv9jj; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=foxmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CDDBB68B2F2; Tue, 26 Apr 2022 11:20:42 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from out203-205-221-240.mail.qq.com (out203-205-221-240.mail.qq.com [203.205.221.240]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8AFB768B27B for ; Tue, 26 Apr 2022 11:20:33 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1650961229; bh=suljzgI1PGbT8sdPpMhgscSMKEf1/vTgzFQgny6bD+0=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=aX+mv9jjWjnAjG7kVKsXQZEmZTUABWqG6IuAhmQQNQuMNshovLBY0SgQKNaV1q8fi iQphyjjCFFhh8uoCttOQ9tWMvcpq77yqxnz94s8kdF66WyNhpp5geTBn56CQsh5XNx 3terl+HmPQTWuXUrHB/CqQmh3WWPNtP+9c6AYkNQ= Received: from ZHILIZHAO-MB2.tencent.com ([113.108.77.52]) by newxmesmtplogicsvrszb7.qq.com (NewEsmtp) with SMTP id 51A3A6B5; Tue, 26 Apr 2022 16:20:26 +0800 X-QQ-mid: xmsmtpt1650961228tp4154fj3 Message-ID: X-QQ-XMAILINFO: NLNuKjcZ2ePXs1S877sNlpGxNy6KsfWXIxZnO3cjTAtmVcl4xYFELpBDP7TywW ZoY4vC5hqpRXSai2tgMsCF86YaiScm27p0u2XRXx1ncZ9nNcRK7cYJ8Cown79AEM5HOeB6dCv6Xq rX/YvD1+upLpRqoUexk54ZuI60km0rU4WcllOwkuNqShjlXAVleT1MG6Y83sCLB7xZXxXBRq/UZT zdvW0+Ke3380KaiHAZI1zxDjI5FFxNENQUxyWz2IdpNa0D05niNf1RamijVmhUdGkO7WE5Z2t0lu 27lXv2AaY2Ns5xPN5UCjGpOWGGLfSl3Gu8hgChNiGaXdFeBKSJIhTryd5tkS//wUUq9a2DHm3f14 m3AjG7S3eTeLoZUxWNMjQOE2hb2l0FModfxkxg3I+L5CvTa3aYi320XDnyYV5cE5QGQBuXjPxYVO 8gmR+P1EzYC0Br1ZcjgGEyQ0LZUb8IBmtgDm7l7PhJo165rgl/Jbz5lPD8G+//7C0LWPATkCwRFl cloWHEu0ZEiP6vpDtjxxWZ20vfeAeJ7Qa2q6ARP6h7XSjiMdRGhEMGB7eHJsBz7LY1hZ/boVwkRF 6Ez+jRTBxIbgs7AWCuXIkniPeLKrFqdOeBcN7URDUWIcw1/2PTUEcFQm/n2Nc+C+8dAAmXWsBwbn +8wab3vD7HTxlrYZvUwg1pW5bS99tphod6zytLM+s0z1LJ7ySuKCp+5ejklx+rhpCTE6Uj686BjA hZtYatUv1IepK/S6OG2qaeP9EFD001RzWU+cJ7ndJKTSqx6oy9iqSFChaSeMnSaxub7LnUa2zkxH 8HcTlXLtKVfeRbcl97LliDlyliiazf32IxAy+tbNs1NlOz8YeQjiku5RKsLLxDRPXGHUE9sVPBNi qSp8tKbiSmv1Ur8POM3u18681qfefIbSP6Z1K7Dx8+vREU0LG8Udvjc15ZlbExgyoQS3S3XMVkXi xrwn585sU= From: Zhao Zhili To: ffmpeg-devel@ffmpeg.org Date: Tue, 26 Apr 2022 16:20:26 +0800 X-OQ-MSGID: <20220426082026.85353-3-quinkblack@foxmail.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20220426082026.85353-1-quinkblack@foxmail.com> References: <20220426082026.85353-1-quinkblack@foxmail.com> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 3/3] avformat/mov: fix use invalid box size/type due to eof X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Zhao Zhili Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: 1oi5gvzEqTXb --- libavformat/mov.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index e948c6cd0f..429f9fcbf7 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -7691,10 +7691,12 @@ static int mov_read_default(MOVContext *c, AVIOContext *pb, MOVAtom atom) if (atom.size < 0) atom.size = INT64_MAX; - while (total_size <= atom.size - 8 && !avio_feof(pb)) { + while (total_size <= atom.size - 8) { int (*parse)(MOVContext*, AVIOContext*, MOVAtom) = NULL; a.size = avio_rb32(pb); a.type = avio_rl32(pb); + if (avio_feof(pb)) + break; if (((a.type == MKTAG('f','r','e','e') && c->moov_retry) || a.type == MKTAG('h','o','o','v')) && a.size >= 8 &&