From patchwork Sat May 28 15:07:00 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aman Karmani X-Patchwork-Id: 35976 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:6914:b0:82:6b11:2509 with SMTP id q20csp1403364pzj; Sat, 28 May 2022 08:07:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzzzrFO0nCAEnVEbiirj+qh2XE0TO5CxXzalZ+Yz8XJP8mj0ACLeMKgIV4DGsTwtA1bSscH X-Received: by 2002:a05:6402:42d4:b0:412:c26b:789 with SMTP id i20-20020a05640242d400b00412c26b0789mr49181780edc.232.1653750435175; Sat, 28 May 2022 08:07:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1653750435; cv=none; d=google.com; s=arc-20160816; b=abgaLC/2SDeMyKdnuO0OZZbF7UDVQ4KFN0KiJkNq05DwXeftvUXLo8xwm6HWhAJpxJ lcnhhrvCO9wCdw1PcZFmjWYqHB+60w94NQzCWNnPKdalophRQ1IvFjGYLKDTAQLPMObV +4DYJhkxmBjWsDlfMorz7PjrjG5Ze1LR96gPMXkLXCxnGO2zBQf/MS3lO+D6oCjhpGTY tmicLTqa2ZxMirIDdawmhi7fIWYwBddo3QrYpIalzFqdP68cFbynhJygOQvbT9mPF7lw QTEUIpAJWPhSUt/t3MMrOgvRikdGbNT7dPyhCTdQe7qe+Dtz0IMU2eCMq0piMfvcaKvr BKng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:to:mime-version:fcc:date:references :in-reply-to:message-id:from:dkim-signature:delivered-to; bh=I3GmKLVefZNIlZysEy5CIrqe5UXivSDnurXa1TZjS68=; b=h3nKdHuSAEP12ueWMgG+c5u0j+1MmPHLbSFJ1dbB7san60brRkrVTzeNs7SJvDuZxx Y92884WRL1vb00uYAn/5gVBGSQvPZ3eag22BdyOfDiJa+X3ttrpkJeEmosBALkgOmpVV pBInE7OX2s3DIjJat7ffhTjpnhAmQ4OyfIerT7F7qD70kldB+ESsfsJw+zY+Rv1A/hj4 cG05OJOcnPmckKrk6VcFv531o1OiTHzvauYg7TlaP2WNIOALbP9XHHsmaoLd7xwb041H Pgmtu8yJ/7OC2oWuO4oWMGDVDC3+ulf/xTsHwWout1mQ9KJVm1PR9UeQS5sT693cpRUv 2fMQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20210112 header.b=eYDsybxV; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id di14-20020a170906730e00b006f4b2a75be9si8878845ejc.841.2022.05.28.08.07.14; Sat, 28 May 2022 08:07:15 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20210112 header.b=eYDsybxV; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E2D9568B610; Sat, 28 May 2022 18:07:10 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E18D368B13B for ; Sat, 28 May 2022 18:07:03 +0300 (EEST) Received: by mail-pj1-f47.google.com with SMTP id x2-20020a17090a1f8200b001e07a64c461so9536909pja.4 for ; Sat, 28 May 2022 08:07:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:message-id:in-reply-to:references:date:subject:fcc :content-transfer-encoding:mime-version:to:cc; bh=aO+jnTgR+lXqA/HAv0DibgrZyzTevDAxKUP9AKyDlGU=; b=eYDsybxV3YJWoWyoqZlV42lNltvk20TY7n1N5tVcsMBkqhU8Y3AM9mMIDFONV98aWV 7UwExpP0vUXMTIYNyk8tvjwIgytupj5V4y2P5Zt4/qmohosPcbH2omiMQ/KUL+XtAwwa D1HJXo+UM97crewQy9V1Xnt4KWqXbXqSBEqCySHhvbGcItbeSnYssfDzBJDHvcH6FJ+Q SxOWSQEUCExuZzZA/zab569vJWmSP0hMlOxeGZa9yC9TupSsQJ7V+ZKJZEFF6FcDU2kP sx+okmCyymIRnKOQyPUbO/L7xJY2na0PZ989TMVMDF8O82nxf6QzSG4PoPPcpzhsEewM NN7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:message-id:in-reply-to:references:date :subject:fcc:content-transfer-encoding:mime-version:to:cc; bh=aO+jnTgR+lXqA/HAv0DibgrZyzTevDAxKUP9AKyDlGU=; b=rCJbtDHlUYSHYEtIJjbjx9VL42RE1+2PoxRHDDBSWhKg4kQx9DDHu5fe1Mm/OxamZ4 geQnSTATOkaWysIx0OI7FfuqsZgUaGp52XDBBwBsRFrCb2H/9gKbjcuNRKJhZ/en/OxS je/OhgaBCDYziiUdTlemrgTXzfSOl77McAH+/CNFqmLD0KUGHEiDlEkIv1gHVk/5p6XI DpGqpK6pq2XVm+R6pg1H8Cb+nUa6q+OD22qPmEHwmhtXycpb/FKz9Wvuzp4OC2pDfvMD NHRI3qPBQ2oosV/RcQgPjdk6Og1EdMgmPRQ6e2b457vBWCi+XQKJOc8JioyWlHvr4hOq eEUQ== X-Gm-Message-State: AOAM532esuewjJ1S6Fb/UnC2VRfm3XYZ2AFIL7sI3lp01PXxsz8uRf8x l6joMl1gYa8E5szvFfd+xb93cmUBBe7nuQ== X-Received: by 2002:a17:902:ccc4:b0:156:5d37:b42f with SMTP id z4-20020a170902ccc400b001565d37b42fmr47875763ple.157.1653750422128; Sat, 28 May 2022 08:07:02 -0700 (PDT) Received: from [127.0.0.1] (master.gitmailbox.com. [34.83.118.50]) by smtp.gmail.com with ESMTPSA id c10-20020a170902c2ca00b0015e8d4eb207sm5680137pla.81.2022.05.28.08.07.01 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 28 May 2022 08:07:01 -0700 (PDT) From: softworkz X-Google-Original-From: softworkz Message-Id: In-Reply-To: References: Date: Sat, 28 May 2022 15:07:00 +0000 Fcc: Sent MIME-Version: 1.0 To: ffmpeg-devel@ffmpeg.org Subject: [FFmpeg-devel] [PATCH v4] libavutil/tests/md5: Remove 'volatile workaround' to avoid warnings X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Carl Eugen Hoyos , softworkz , James Almer Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: H0u+PihxNoW+ From: softworkz Those are always showing up on Patchwork when FATE tests are failing, covering some possibly more useful information. The volatile keyword was used as a workaround for an eight year old clang version. Signed-off-by: softworkz --- libavutil/tests/md5: Avoid warnings Those are always showing up on Patchwork when FATE tests are failing, covering some possibly more useful information. v4: * The problem still exists: https://patchwork.ffmpeg.org/check/62130/ * as was suggested, this patch removes the volatile keyword altogether Published-As: https://github.com/ffstaging/FFmpeg/releases/tag/pr-ffstaging-20%2Fsoftworkz%2Fsubmit_md5-v4 Fetch-It-Via: git fetch https://github.com/ffstaging/FFmpeg pr-ffstaging-20/softworkz/submit_md5-v4 Pull-Request: https://github.com/ffstaging/FFmpeg/pull/20 Range-diff vs v3: 1: e54769c621 ! 1: 21fdf3eba2 libavutil/tests/md5: Avoid warnings @@ Metadata Author: softworkz ## Commit message ## - libavutil/tests/md5: Avoid warnings + libavutil/tests/md5: Remove 'volatile workaround' to avoid warnings - Those are always showing up on Patchwork - when FATE tests are failing, covering - some possibly more useful information. + Those are always showing up on Patchwork when FATE tests are failing, + covering some possibly more useful information. + + The volatile keyword was used as a workaround for an eight year old + clang version. Signed-off-by: softworkz @@ libavutil/tests/md5.c: int main(void) - volatile uint8_t in[1000]; // volatile to workaround http://llvm.org/bugs/show_bug.cgi?id=20849 - // FIXME remove volatile once it has been fixed and all fate clients are updated + -+#if defined(__clang__) && defined(__clang_major__) && __clang_major__ < 4 -+ volatile // volatile to workaround http://llvm.org/bugs/show_bug.cgi?id=20849 -+#endif + uint8_t in[1000]; for (i = 0; i < 1000; i++) libavutil/tests/md5.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) base-commit: 9fba0b8a8c754a012fc74c90ffb7c26a56be8ca0 diff --git a/libavutil/tests/md5.c b/libavutil/tests/md5.c index 42e4538e0a..0ac8f2834e 100644 --- a/libavutil/tests/md5.c +++ b/libavutil/tests/md5.c @@ -33,8 +33,8 @@ int main(void) { uint8_t md5val[16]; int i; - volatile uint8_t in[1000]; // volatile to workaround http://llvm.org/bugs/show_bug.cgi?id=20849 - // FIXME remove volatile once it has been fixed and all fate clients are updated + + uint8_t in[1000]; for (i = 0; i < 1000; i++) in[i] = i * i;