From patchwork Sun Mar 29 00:08:04 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lance Wang X-Patchwork-Id: 18474 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id F08D2449D15 for ; Sun, 29 Mar 2020 02:08:18 +0200 (EET) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D310868B3D0; Sun, 29 Mar 2020 02:08:18 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-pj1-f65.google.com (mail-pj1-f65.google.com [209.85.216.65]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6052F68AEEB for ; Sun, 29 Mar 2020 02:08:12 +0200 (EET) Received: by mail-pj1-f65.google.com with SMTP id ng8so5779729pjb.2 for ; Sat, 28 Mar 2020 17:08:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=PcanG6YQU8PQdfWjL1Mkq0aWT/u1sqCx/SNhr0sf8b8=; b=moZuJm0IjQns4HwJZGwrzT8GUwvip8NTuk5vNLu1/o5COEz8C4JnGloFxo/O2h4HTh sWvd6PPz3GQwPNTS/YEqbOsmCZuXpDcDardY6Sb5ghIOUyHTsSGhRU3+6tEwo8jc82ZY 24RyBrf5dL/SoAZdKFqEFWppLlBEyURHklc4Jtaj9O0T2hwtf+gx5bOadNcwtYoJsU6G WOBB6AdT96/SHo6aHwP4S5gYhqfKctITA6nmPGP8FC3T+DYeCVIPZLN4kNVfOC/YKuKn OGKAXnZrI5Ax+DjWd2qDWrJlzv+AoLuNSLjyzCiMTx4FjI2ze69RclV+gtRhQxwp9IKV kmPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=PcanG6YQU8PQdfWjL1Mkq0aWT/u1sqCx/SNhr0sf8b8=; b=EsusUJEdGpQdMFC0I1fRycha+dmLrM/ViGsZvzTq4DfTaeGpbviqk9HVNptt+xkIaO xnny9Yy9VC9PLJL133xC6vuKV9mlOdFPq9TsP/r13OrygmmKzYDZoTuNN4cU9PMGJJaG BB3BgOYizyfGCalweCrNmVZNWVr9D/IdZQ80VSK1fUaO8BJjYTCBjcmsfaHvYR3gM7tT zxkNUMT707KcyuqGRHkao3xcyCOCsvILv3Ad5Kvye5HsvwmVm18vYjtfQHHG9Dn3jYbK Mi2kD+0DVWBrO4s61rUNGaMiiYvJhvzmHqjNOQTkc8dp1HVh7ihlhxLXUWTggfbJ5eH6 WSVw== X-Gm-Message-State: ANhLgQ33mRYRSahgoj3yClnNbRZ+MnXutTjM6kyFW/AAMIN1F8PLe4Tu wEv0Xn3FqpvXrpQoENBFJjXhmZJ/ X-Google-Smtp-Source: ADFU+vsToGoJwlq4JvPvoRgoa2uhUZ4vw0GDkuKP+zioZxDrlZt0j+Zj2lswRD8g0sbZT+2tUJzu8A== X-Received: by 2002:a17:90a:9e9:: with SMTP id 96mr7550810pjo.168.1585440490474; Sat, 28 Mar 2020 17:08:10 -0700 (PDT) Received: from vpn.localdomain ([47.90.99.151]) by smtp.gmail.com with ESMTPSA id a71sm7169653pfa.162.2020.03.28.17.08.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 28 Mar 2020 17:08:09 -0700 (PDT) From: lance.lmwang@gmail.com To: ffmpeg-devel@ffmpeg.org Date: Sun, 29 Mar 2020 08:08:04 +0800 Message-Id: <20200329000805.22636-1-lance.lmwang@gmail.com> X-Mailer: git-send-email 2.9.5 In-Reply-To: <20200325230424.2787-1-lance.lmwang@gmail.com> References: <20200325230424.2787-1-lance.lmwang@gmail.com> Subject: [FFmpeg-devel] [PATCH v3 1/3] avfilter/af_acrossover: Check sscanf() return value X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Limin Wang MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" From: Limin Wang Signed-off-by: Limin Wang --- libavfilter/af_acrossover.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavfilter/af_acrossover.c b/libavfilter/af_acrossover.c index f70c50b..002f378 100644 --- a/libavfilter/af_acrossover.c +++ b/libavfilter/af_acrossover.c @@ -99,7 +99,10 @@ static av_cold int init(AVFilterContext *ctx) p = NULL; - av_sscanf(arg, "%f", &freq); + if (av_sscanf(arg, "%f", &freq) != 1) { + av_log(ctx, AV_LOG_ERROR, "Invalid syntax for frequency[%d].\n", i); + return AVERROR(EINVAL); + } if (freq <= 0) { av_log(ctx, AV_LOG_ERROR, "Frequency %f must be positive number.\n", freq); return AVERROR(EINVAL); From patchwork Sun Mar 29 00:08:05 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lance Wang X-Patchwork-Id: 18475 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 0415C449D15 for ; Sun, 29 Mar 2020 02:08:23 +0200 (EET) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E2F5668B614; Sun, 29 Mar 2020 02:08:22 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com [209.85.215.195]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 06E0568B4BB for ; Sun, 29 Mar 2020 02:08:14 +0200 (EET) Received: by mail-pg1-f195.google.com with SMTP id h8so6732849pgs.9 for ; Sat, 28 Mar 2020 17:08:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=GokYXQh4vyjL3Wqq1T6U9qeVKCEnw4oIszYtxYKK6PU=; b=JwHQPOyTjmmNOQxsHD1dCGu5RKnelB1oG8+XcVkOu7EMFLZ1z12J4wOX5a9REzGIWs SBkDmy33biKMmGv5R47qPvKGxn2xzxA0Q/GGe/DEulCXcEAay3DVU95T6fnYaklRtne6 c4Ze4mZWeRDBTqZ95qceVeQKwZsCeGIMGiS2ZfdsitR8vO4+1g3tmlQEZImL24Fge/p5 sHHIEPAEC44OkjCUYj/QKvkS6JQfJn6WAA5gNop8UrFwz5UZ18PisPe1YZAmwhDiJrGN XRuZxmMHY24OMprUYPg6dbFWEoZZM/Zv0xugrpNqar24LPeKq/Y2BlFQ9K31MHwaYXse pamg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=GokYXQh4vyjL3Wqq1T6U9qeVKCEnw4oIszYtxYKK6PU=; b=C7RRkbs9kxZyCfsla1jSgIdG7DN921B0GiJTVvhEc15ceUfQgIQq84PwPvQdv+GUEU L3NATGprBpWnm7pyGTwn+KMJ7zD3WVSneLUJ9Vk7SQVoDzc9v52TyJFGkEn3J2u8Eoa2 2EUDwQGFOiVlzaVNdXIAib8/AIbB6PN6YemBQzlJsqvc4E9b7nWQNiCG7GmksSXeCBjs 1BiqkCS8KQAAUXZljgKB/wERWQ5ddczz86FxbcQee67YIiQJZlUfWCPldsRuKnnlilhr vxHV6QpMVhL5r6pA5k8xysB3EJW1bghrMeGZ8QZLWlxapK4YmJ800xBcRfBr4y7rWoYa EO9Q== X-Gm-Message-State: ANhLgQ1fp96QGH+XMV7gOdQuOgUnSlJGDPddcNX8G/W6f9UmVg296jpM V7zWC1W5HZgTEznCtzgQPRiKpDEd X-Google-Smtp-Source: ADFU+vvqJppvfYTYaiD5DN3XNgwcq3QEAKKzOGDWmAb481xcF1cnYK3inXNTlzRBs38NNi2kVS3jEg== X-Received: by 2002:a62:e515:: with SMTP id n21mr6248719pff.103.1585440491949; Sat, 28 Mar 2020 17:08:11 -0700 (PDT) Received: from vpn.localdomain ([47.90.99.151]) by smtp.gmail.com with ESMTPSA id a71sm7169653pfa.162.2020.03.28.17.08.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 28 Mar 2020 17:08:11 -0700 (PDT) From: lance.lmwang@gmail.com To: ffmpeg-devel@ffmpeg.org Date: Sun, 29 Mar 2020 08:08:05 +0800 Message-Id: <20200329000805.22636-2-lance.lmwang@gmail.com> X-Mailer: git-send-email 2.9.5 In-Reply-To: <20200329000805.22636-1-lance.lmwang@gmail.com> References: <20200325230424.2787-1-lance.lmwang@gmail.com> <20200329000805.22636-1-lance.lmwang@gmail.com> Subject: [FFmpeg-devel] [PATCH v3 3/3] avfilter/af_adelay: Check sscanf() return value X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Limin Wang MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" From: Limin Wang Signed-off-by: Limin Wang --- libavfilter/af_adelay.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavfilter/af_adelay.c b/libavfilter/af_adelay.c index c964777..6ac81c2 100644 --- a/libavfilter/af_adelay.c +++ b/libavfilter/af_adelay.c @@ -155,7 +155,10 @@ static int config_input(AVFilterLink *inlink) ret = av_sscanf(arg, "%d%c", &d->delay, &type); if (ret != 2 || type != 'S') { div = type == 's' ? 1.0 : 1000.0; - av_sscanf(arg, "%f", &delay); + if (av_sscanf(arg, "%f", &delay) != 1) { + av_log(ctx, AV_LOG_ERROR, "Invalid syntax for delay.\n"); + return AVERROR(EINVAL); + } d->delay = delay * inlink->sample_rate / div; }