From patchwork Thu Jun 16 08:59:57 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thilo Borgmann X-Patchwork-Id: 36253 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:1a22:b0:84:42e0:ad30 with SMTP id cj34csp820241pzb; Thu, 16 Jun 2022 02:00:16 -0700 (PDT) X-Google-Smtp-Source: AGRyM1u0KsSFxWR1anvWDTATOweVIoIK+4lf892w2pgKENO0o1h7JEJUemxyOpclZjsqEIp6vI5o X-Received: by 2002:a05:6402:3807:b0:435:20fb:318d with SMTP id es7-20020a056402380700b0043520fb318dmr5074765edb.272.1655370016482; Thu, 16 Jun 2022 02:00:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655370016; cv=none; d=google.com; s=arc-20160816; b=w+ZYWFV2Ts+/xpgcgAhY79qf6J7faSbmx2Jrzb38FJVSsnglF6rGPo/wgbmqVabahq 6ghUPTSBNfweG5efYdOHUSd9M8aEZFUSBbDkt1KSf3cWqU+g0bGxlNSozMGLxov6bXJf VI+vJYnx5whHQcDB+j+XIwg80K6LXS7x6F8iPLrp1lNpRD0egDDT6xyNXBirMRRKOnG+ 4X3JaCZ4/E41BKLf148pLr3P6bkP+r6klht5Q+Bg3IEneb9RZVxy1uSc6i0iZO1e2UHy lrgU07WUZXmExk/V6mzz96d0LCMLQZj7Dc8E8ObQ9Lh16eYR4g3JoveQOVjRbGUg0+WQ fAtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject:from:to :content-language:mime-version:date:message-id:dkim-signature :delivered-to; bh=5HeKtI6612oPZ4C/JZMqGBXep2xwVJdqmaKlQfz8hpc=; b=Cy1EufG6qkVyWyjDBKnNEiEpU3IpCY9TDOOb9rWpDSw7HklrmiUAl7kiFKPm9dJknA d3L+zshw23Sn5zdsVqQCqPb06LMbZl+btMC7G8RlaU4q2KruaRzdt1sIGNFfxCl5xf+p iz8qGJyNF+2EyBO32auCmcNT/CK2HdMB3ref5/R12Fh8IiAvUWMLRlmGhQpTZbHyex1F Fuo8ggX3469jEOG9CWA0Q/wqTaqXwZqIAZHYpli5YanDSEjYdnvknRkaSaVtnCqGKvfM VTfnBS87EZT/eiel0xC/mHPOK59Ic5hgMj5D6TKp/5bG3P7jejqZQtjt81ItJSyM0mDC o7HQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@mail.de header.s=mailde202009 header.b=u3HdF+Wf; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mail.de Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id dm16-20020a170907949000b006e07d5f6986si1336715ejc.933.2022.06.16.02.00.15; Thu, 16 Jun 2022 02:00:16 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@mail.de header.s=mailde202009 header.b=u3HdF+Wf; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mail.de Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7092768B7C5; Thu, 16 Jun 2022 12:00:04 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from shout01.mail.de (shout01.mail.de [62.201.172.24]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 67C6068B27B for ; Thu, 16 Jun 2022 11:59:58 +0300 (EEST) Received: from postfix01.mail.de (postfix01.bt.mail.de [10.0.121.125]) by shout01.mail.de (Postfix) with ESMTP id 0AF38A05FF for ; Thu, 16 Jun 2022 10:59:58 +0200 (CEST) Received: from smtp02.mail.de (smtp02.bt.mail.de [10.0.121.212]) by postfix01.mail.de (Postfix) with ESMTP id E73F2801CF for ; Thu, 16 Jun 2022 10:59:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mail.de; s=mailde202009; t=1655369997; bh=BLukT7lCJrrNAojVe7z6S+xYeL2NyNUp4BASsQXsUWc=; h=Message-ID:Date:To:From:Subject:From:To:CC:Subject:Reply-To; b=u3HdF+WfGh8r++69Pdb0zEfyp/rQfEWAfERIsCAN1XdK2M3vkpmOymrMfTKnK7zCT uxDiE5+oPg7pR2TkmsnPw+tEFXxb+t24iWkQzXPS3RO2CyvdKJRb4CGg5pB3mS3wJD XAax1bKBGjLaDEQ7faJ8wjI+Ny6sqLp8mgYHI1aCJw8HEb3awim7VL4/yPnsc0lhwQ VPn2vBMEmk2Qt+0MBRmNtm/EfsLXWtgqmmvGA0ufMgGpIKUKSAH4cB8BiYrGD0/yug ApPD0Kj1qmg7w0KrJ7pQtNOtfTem4R+1C1DQwGnBM6PcK2Rbv5WrhVoKJZrV9ERmrB jEpohW89OZiwg== Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by smtp02.mail.de (Postfix) with ESMTPSA id C0238A0A62 for ; Thu, 16 Jun 2022 10:59:57 +0200 (CEST) Message-ID: <1657f1e0-116a-92e2-033f-4a9493f9de92@mail.de> Date: Thu, 16 Jun 2022 10:59:57 +0200 MIME-Version: 1.0 Content-Language: en-US To: FFmpeg development discussions and patches From: Thilo Borgmann X-purgate: clean X-purgate: This mail is considered clean (visit http://www.eleven.de for further information) X-purgate-type: clean X-purgate-Ad: Categorized by eleven eXpurgate (R) http://www.eleven.de X-purgate: This mail is considered clean (visit http://www.eleven.de for further information) X-purgate: clean X-purgate-size: 3075 X-purgate-ID: 154282::1655369997-0000737C-3E230923/0/0 Subject: [FFmpeg-devel] [PATCH] tests/checkasm/sw_scale: Fix alignment for movdqa X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: HqV48lPZ8SQT Hi, movdqa in ff_yuv2yuvX_sse3() expects a 16-byte alignment according to its documentation causing segfaults in fate-checkasm-sw_scale. -Thilo From ed84410b2371a758dad03d3830bfb4f3d86cd4ed Mon Sep 17 00:00:00 2001 From: Michael Goulet Date: Thu, 16 Jun 2022 10:14:50 +0200 Subject: [PATCH] tests/checkasm/sw_scale: Fix alignment for movdqa SSE3 instruction movdqa in ff_yuv2yuvX_sse3() expects a 16-byte aligned address for a memory address, or else a segfault is generated. The src_pixels buffer below was not aligned to 16 bytes on the stack necessarily, so we got segfaults during fate-checkasm-sw_scale. Therefore 16-byte align all of these local variables, aligning them too much shouldn't hurt. --- tests/checkasm/sw_scale.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tests/checkasm/sw_scale.c b/tests/checkasm/sw_scale.c index 31d9a525e9..b643a47c30 100644 --- a/tests/checkasm/sw_scale.c +++ b/tests/checkasm/sw_scale.c @@ -75,11 +75,11 @@ static void check_yuv2yuvX(void) int dstW, const uint8_t *dither, int offset); const int16_t **src; - LOCAL_ALIGNED_8(int16_t, src_pixels, [LARGEST_FILTER * LARGEST_INPUT_SIZE]); - LOCAL_ALIGNED_8(int16_t, filter_coeff, [LARGEST_FILTER]); - LOCAL_ALIGNED_8(uint8_t, dst0, [LARGEST_INPUT_SIZE]); - LOCAL_ALIGNED_8(uint8_t, dst1, [LARGEST_INPUT_SIZE]); - LOCAL_ALIGNED_8(uint8_t, dither, [LARGEST_INPUT_SIZE]); + LOCAL_ALIGNED_16(int16_t, src_pixels, [LARGEST_FILTER * LARGEST_INPUT_SIZE]); + LOCAL_ALIGNED_16(int16_t, filter_coeff, [LARGEST_FILTER]); + LOCAL_ALIGNED_16(uint8_t, dst0, [LARGEST_INPUT_SIZE]); + LOCAL_ALIGNED_16(uint8_t, dst1, [LARGEST_INPUT_SIZE]); + LOCAL_ALIGNED_16(uint8_t, dither, [LARGEST_INPUT_SIZE]); union VFilterData{ const int16_t *src; uint16_t coeff[8];