From patchwork Mon Jun 27 10:02:30 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ting Fu X-Patchwork-Id: 36485 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:8b27:b0:88:1bbf:7fd2 with SMTP id l39csp1923428pzh; Mon, 27 Jun 2022 03:18:39 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uMCYLwQC1gh4DhOENifOkhFWSu+ZeaYzu89oKdaOMKRB6fljzPqKQc8/PsNQMSybuvPDyp X-Received: by 2002:a17:906:6c82:b0:709:f868:97f6 with SMTP id s2-20020a1709066c8200b00709f86897f6mr11942659ejr.555.1656325119355; Mon, 27 Jun 2022 03:18:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656325119; cv=none; d=google.com; s=arc-20160816; b=oQhmSgRej194QlN8jkKgLvDPEIThhChYK+FchSr8vc+AGUosTEWuvQ239E2tFKrfo2 nwq9ZyFlCYO/L1pHKdzVzXPBHAmHh9VJ0oMdnIsVwtPohR9q7kYGrRpoXE2svGRUp8sW jGlNu/PYWkftAtVUz4e2cbijLSnnYm4X8Mj4x6kM1bhuiEpp8U7qf/WnUL0OAXjACpDU +vFRNF0L7SgV0PaVmmbq2LOgTKcO58E8bP7BfKNbcbQAiqSCF9ORbe6JNPApa+i8mulM QeDpz8RvW17QqzIVn/2pYPBvF5NOcdxJH904YGnBHC3uN6C3X1dyVuuLyfIa+Mrtb6PA pK0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:message-id:date:to:from:dkim-signature :delivered-to; bh=4CgemuIF9FKOFRfGyhAsojkOrzQFCfcVFX+1pZYTIt0=; b=foAkIG1HGSjJNmPa2lWGiR0+TUkH8WKkox3tP/u7STKLd/f0h2K6eWtqIX4mLb6XEa PsquTPJjo7sPlSioGaWYNCev5W9+wPSgKwCoJX5tXrTY+e4GjWgavxJ1huherDgO8PT8 qxzZGoFjcOS404efFXYSWpeSmOXuP6Qf+aeeV8TDPVrKJZR49LMcM1TtgHi0VxVXs+Jd dmkIxwHh4Zl/PpXW3PEeOYdF0SyqW7q+HJ7UTwoUZh8q9yCx+I64VQeuXTHZ2SXFiwHy AkIZfzCH/UU/7Tca3l+NcyX3P6Pf1hS7i9P7lKB+RuOfQxLlj5uTY/y1x6022jblFoIw 21dQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@intel.com header.s=Intel header.b=Qe6qC5WY; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id o18-20020a170906975200b006f445fe1697si11693391ejy.35.2022.06.27.03.18.37; Mon, 27 Jun 2022 03:18:39 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@intel.com header.s=Intel header.b=Qe6qC5WY; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id F34A268B838; Mon, 27 Jun 2022 13:18:33 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2DF8B68B6D3 for ; Mon, 27 Jun 2022 13:18:25 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1656325111; x=1687861111; h=from:to:subject:date:message-id; bh=UfyI3yIBIAGI0LBDrBEcz7R25Eqx1Z7m9hjB7UUPwq0=; b=Qe6qC5WYBISFpNMIVggQMAYf640xfDJVxzpWAxS+oBTIjTexHZx12XJG eSy8YyjWz5Sq5Q0LNDlGK+MWam6pJ4MfTOSmJk7c7gqel89B2oU7o4g3e 5qkX6iDxQFlfoqQTtMdCk2WvpI+OEE6jijNA2GXGRD1BlcMZ2+uRIAaHR PAzxaiI+AOXVZykmwzRPV9oTqhjn+JYLClVWDDRofNYnLPOrgxGJT+pGV o6cT1Ps1BIJzxjxMGfrQFvjcJOCi6LpP48jf9qiXB6thMCGJx++VyWzNV rrPoKkEspwvZoKmTHS1VcwgIHIpIh89nvB6UaCnSPQTR0yfqOmyMxMaJp w==; X-IronPort-AV: E=McAfee;i="6400,9594,10390"; a="270160607" X-IronPort-AV: E=Sophos;i="5.92,226,1650956400"; d="scan'208";a="270160607" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jun 2022 03:18:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,226,1650956400"; d="scan'208";a="587390380" Received: from semmer-ubuntu.sh.intel.com ([10.239.159.83]) by orsmga007.jf.intel.com with ESMTP; 27 Jun 2022 03:18:22 -0700 From: Ting Fu To: ffmpeg-devel@ffmpeg.org Date: Mon, 27 Jun 2022 18:02:30 +0800 Message-Id: <20220627100230.31863-1-ting.fu@intel.com> X-Mailer: git-send-email 2.17.1 Subject: [FFmpeg-devel] [PATCH] lavf/sr: fix the segmentation fault caused by incorrect input frame free. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: Z0RJ0nIe4Fed This issue would cause segmetaion fault when running srcnn model with sr filter by TensorFlow backend. This filter would free the frame incorectly. Signed-off-by: Ting Fu --- libavfilter/vf_sr.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavfilter/vf_sr.c b/libavfilter/vf_sr.c index 0890c8ba18..cb24c096ce 100644 --- a/libavfilter/vf_sr.c +++ b/libavfilter/vf_sr.c @@ -159,8 +159,9 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *in) sws_scale(ctx->sws_uv_scale, (const uint8_t **)(in->data + 2), in->linesize + 2, 0, ctx->sws_uv_height, out->data + 2, out->linesize + 2); } - - av_frame_free(&in); + if (in != out) { + av_frame_free(&in); + } return ff_filter_frame(outlink, out); }