From patchwork Thu Jun 30 20:14:40 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Rheinhardt X-Patchwork-Id: 36555 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:8b27:b0:88:1bbf:7fd2 with SMTP id l39csp555899pzh; Thu, 30 Jun 2022 13:15:02 -0700 (PDT) X-Google-Smtp-Source: AGRyM1syB5HUthCN9Sq5S0xnqQB2wda1EM5xfGAplP8MWFjZnb0znNXZeYGaTnevibH83hu9jBe5 X-Received: by 2002:a17:907:7f1d:b0:722:f2fe:8eaf with SMTP id qf29-20020a1709077f1d00b00722f2fe8eafmr10565127ejc.279.1656620101978; Thu, 30 Jun 2022 13:15:01 -0700 (PDT) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id qw18-20020a1709066a1200b0072a6b4767d0si2889107ejc.793.2022.06.30.13.15.01; Thu, 30 Jun 2022 13:15:01 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@outlook.com header.s=selector1 header.b=LWNeSTLF; arc=fail (body hash mismatch); spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=outlook.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4FC5C68B5E2; Thu, 30 Jun 2022 23:14:57 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-oln040092066086.outbound.protection.outlook.com [40.92.66.86]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4F4C468AFF7 for ; Thu, 30 Jun 2022 23:14:50 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lqC3n9MK0WIIn7u9VytdXTFV02wVDmytBl8cBCwkAh35BJ6xNk1Nc77hpTfVdleK84j5jgtHMyx2iNFXcINRrsYxAV63vXLJrGi7i9g7+yh3Z5tnjpN9NA//DnUnzO+hZLxxOKggEIG86NH1a3FggkSbasHJFj3dMwF05+mSDROG1AyacL/7ewuABdsMY0QGKbLtpuW4w2pNiMFNpMFwId5uFG8Q1KrMi3oc/PuLrFaDKatVkx+o/IOtyH4nrUMepzJQqSUPqB9elA6YR5V7x0GZSdt7XhHjH9TvLKQ7/dMCtwKNhgcfazbfeOZtmxR5JgDvBQl57cQ7PIbiAYnD2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nF89CZHVTPh2L4u1J2atRJg25iiLKDNu5GaGBfmMp2M=; b=OLvpDQj0+yLkyfrl/53/SekgH77sMICyDYBFA/UOkNBFW50N/dpXfZm/NvQWi3XJxU9BaM4ynryp7llHv2gDwiD4Md2uA2EJVDIeei8g2EfQ+UzyqwFIn2JjCY5/ifKZ1o/FVUCUCxl7cDOc04bvG8my4Cw4Hc1se7gPScREdC/xxRxmRnqy/4JY0VAe6Vn2Cjb0KM1x+OpGIzQzBQLzfLfeE+77/wJ5lQtzT94mIDFCZLCcIDcWuqOej02ws58yjXhO9zd8U9NLGq8osU7uSsFZkkiEc/yY+LwdqufaiaGFyhhVQvSypE5xcqm4Q0Nrrwiwgj40yGIr3LNY4M2bBA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nF89CZHVTPh2L4u1J2atRJg25iiLKDNu5GaGBfmMp2M=; b=LWNeSTLFyz/FvgfJx0spMplL8caET1RMEfaDTrYVenTek2TEZ3l8FaeML7JBMnFLNr4gPZbUNFAsKgtP+vfBxLWTySNO+08gRbiR4wOIi3duYO2MHkYpK46l4bH4QF05tOpcRocawSozIwlXGif8v/s/6htloRP9Y11xdGEYNJ7ac49gTAKEhId8oXlmVkIepJEFytdexnvSlDt9E00K132oRMgwUQUJrXqHzHLrdDa17Bh3VTJUfdTxQv73W4YaaA4JrsXTUuICNQIaOoWpojA+UPnkb5ZqczA7U9IQ31aSpTaJ8xJD6t2CxVboFIpmshgbRCldCf8WTv5awkDmhg== Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) by PAXPR01MB8349.eurprd01.prod.exchangelabs.com (2603:10a6:102:218::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15; Thu, 30 Jun 2022 20:14:48 +0000 Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::60b9:9f29:40cc:f01c]) by DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::60b9:9f29:40cc:f01c%10]) with mapi id 15.20.5373.018; Thu, 30 Jun 2022 20:14:48 +0000 From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Thu, 30 Jun 2022 22:14:40 +0200 Message-ID: X-Mailer: git-send-email 2.34.1 X-TMN: [/1PmFwkgnehrr+VQoJW7TSKb5Sw3FVPX] X-ClientProxiedBy: AM6P195CA0098.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:86::39) To DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) X-Microsoft-Original-Message-ID: <20220630201440.1754739-1-andreas.rheinhardt@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b14b744c-c7f7-4669-1fd8-08da5ad52e66 X-MS-Exchange-SLBlob-MailProps: gjx25WM8ZNXqMBxJfDcJWCkSlr5voV0a9bxcHyQFIBpvh5QokSxBj6O6BJKfVrUAc9yNw0HNyvxWiWtgo2FhieGAI0SKDCG09iLJXICBliCOOqRkT1kvSvJ96laBEk6hSHW/Lf1IkXwqulCWbIc0qlWU5GspoE2dJxfTeCYHZppTMlyLVHnnF7hO0NkF6bA8fqvME5YHf2a+huZotU4VpZI0Ph6syfkGxjyBdoFRooBdrqAKnewT2H/x6/Hjn97jJAKlz1NlrB81JTqTX7KisUZyJAKDwxPaTT5arMOWUEGHuD8HOPrRBk01hy3PekXc3PodOd+xe4RQVNtRMw90BG8UJcB3KS90SMIB4jgmKccRiSCwwKIsxE5dGNdpOcscvF9LqSU4SxiszBjh/Pym88lM7JiUeK7e8gon3Pd8iZWFUpGCCedLL5MUNeQxrKcEf0M0HCjw9WcfoBu22XEsGObYxjiAaYcIa4mH/zPc+W4aJbdNgcmaqBtFxC8V0OGHz5qGURtVqRCqQTknXr9CzxpMDqHTn1QlKqLxKc9NpD0N/9nTAqktFYYYKAK+zyPM7HxFHoEcsDkHaGijmtC18wlWPBn/o+n1RqeQIy5SUBULiP1TDWfx6pkjnKRw04nZyFCJSonKUtwv9FFaiHB3undNu30OxPk9O6MFVevEsePF0EcRX9S4ZvvdvJUn6hTrl8KQf947bOBrNYx1DMgq4+Nxag/jY5B8RJs/i27pZkM= X-MS-TrafficTypeDiagnostic: PAXPR01MB8349:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uDimQMyPUTSH8fvwtbju7j4a/kjbjCXB1KG6T4ENqoXHEPQ6qw4ZZ4cvrOlDwep3ZskpVi2cSXS/muaFno95bXfsf7i0zrc3/N5+dCDiKa6EuvgvnQg9iIe+7fY/2xpX5CzEaxVmLqKGJkUjApPzRGoLfNhCpO7thTjBLQgXVJWUTAEFMh8kpw2jMFiyWGPxJY8YmZUHbKhfhuG25CgbzeR8t2sJRl2wUHEIX4lQHWSwOzISAd6r/zZQJeKvtAU9iXikju/ra0M++oDfRtpX2+stlxFVSJ1SWez5CeqYZAkmKWXIpn95Y3hXrtPThQfaKWIl3QTukGg6At9fMPyn/1l2jjVloS4DBk4ers06EzzZyi3VOKP0JGoe88NJWYyphf2X5cD7GpGmjzF4w+arHbjR2k5LqCSSch+adfp7+gAYBq3UJ1We0PSxhJk6soLLWDMO+sdnqQl/mIYt9u5BMHXJeF+VULiRKvUm66uQIeE8zwTr9tIVuVeAytVYB9EGTa/21QUaiyZjCCgtEsDl6gIdqHT4Ql9z8wEqMk3/Ub2GphFaBdD+nCWZaeD3XJ/WOs4A4PkpN80IHhDpdtifXWpgz//8F0ozIUPRIkfqVmYkPEUEmjs8FEn5cvN09/xw0uZKgf625Olynv15GlvgeQ== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: e7UivYN7rCRuWDswtzA4+P4UI2JAgNfXO/ayhgtHTzke2weMTffpOfdN0k1RIbqr10HJ/986hojM1qmGll9iu0jtaCncZ9gdrDlXnLMJZZhlMcXruouyC38dVkAwhudtoh8Tk/eHk+NEvAQsqxZHHn8A8C76t0z/wngcnS+c3sFDSfp53IVr2qTzJpAKi7U0ZD5jmVgzRuar2H7gVSA2wPnKvvMkONEX6/OOjFjtqjI+jyJbd/MgjFYjKjvxOblxdNd/bvWC+C44DWed6wbeh3uHuDbWYj+fbKcjp5CLqgCUsbAdLbU9g8cRRx+3QMljT+5/SEGZxgkJcB4JeavcVLMRn5AyS/Q/KsqZSsELsDMSBIsbxvKkuarZOe1x9MtfzA7Al1eeLt86CJv6uhD+1jzAtHHGjPinhSbsDDZrok0oI2iQVSwNLpzIS83uONSbQlww17d3x/bVbyw8Yus1ZVnhSExIA7y9YBFeit3d/egNVneKfv4lDp7us/f3qAc02ya7wy9ANDivCm89wiTxmG48vXrAdcs/9kiho2NMAbRCRxkQ+TZ52apGVFFP1hKyv7vyW3SQnuy3PkUZxGlXauZSFKmP6Tla3EY3jR71j1/G3vxxaP+nDFQ45MoZHHUQj+Nt8Q3KYdp3f2+H560/zd7YOYYvZg2P6g0nsp3KD/4gEdKzG9HvKvWiYztAYKi+5Nxble3duFxirZjU9JG1O9Ju/K87RWiq1XUHRgDhJNKPmRKp+ytavwhVfAgpI9E//thTpuIvuuN6psR/JrBlqVqp/kAETiiLltR/xLgJK+P9zfGS0TmwyqAjBMxPEaJxTkGRHBgamohkrZsXGPzmA6VeEXT+D7yL1RWj9yD8m6mzmeCIGAxVt1Yfk9wxQSk/uxHBrgmj14m5eJE8xjvYjmhqIMs7ALpMyd+t4KW2E1ei61fJwJ7l6io68ijOzqPBvZzId8sk4QeKoh8YupIxwfQ4xS/Q7wia+YQfXGZmmw41Dz/Z1FWF3Jquf871JP/G7tcfMv4eEhomkFTOTGgR2uQvVeHOjnUh7wyqLu3zFa77oR5bh0XVBTur7heV+FrTlleelGvZ5n+zWq6L7Q/VclRpOyNoFcpggtKHCiPXCEzlT/iPIablATzOSnkC0zLB6yl+UKSvL2+SaZ14lVAZ2t0ZJGeK0hV5KTOtpwt5S9sKpi2hmNmWA0xdnusVrSWo7p/Y9h5+h2+f/vPRHRg0+/twYAzxXfw8uq0FXUnBYrGi/2vWd/0c9FWRmT27MoE/TtDonVDvWgDM6kfWz6cssGLmrd5g4z2kjHazJYPhBP8= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b14b744c-c7f7-4669-1fd8-08da5ad52e66 X-MS-Exchange-CrossTenant-AuthSource: DB6PR0101MB2214.eurprd01.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jun 2022 20:14:48.4481 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR01MB8349 Subject: [FFmpeg-devel] [PATCH] avformat/movenc: Fix invalid check X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: FK+CdMo3acp7 Regression since c9de096851803d45444ae9dfe3a390a2d53ac71b. Fixes Coverity ID 1506839. Signed-off-by: Andreas Rheinhardt --- libavformat/movenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 0ef6b3c76e..a4dace7c1d 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@ -424,7 +424,7 @@ static int handle_eac3(MOVMuxContext *mov, AVPacket *pkt, MOVTrack *track) if (!info->pkt && !(info->pkt = av_packet_alloc())) return AVERROR(ENOMEM); - if ((ret = avpriv_ac3_parse_header(&hdr, pkt->data, pkt->size) < 0)) { + if ((ret = avpriv_ac3_parse_header(&hdr, pkt->data, pkt->size)) < 0) { if (ret == AVERROR(ENOMEM)) goto end;