From patchwork Fri Sep 2 23:00:25 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Rheinhardt X-Patchwork-Id: 37616 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:139a:b0:8f:1db5:eae2 with SMTP id w26csp1244384pzh; Fri, 2 Sep 2022 16:00:46 -0700 (PDT) X-Google-Smtp-Source: AA6agR6JUndBE1YnDRspceKHHvQyOlxONzsYxTzSX9dJFSPDw6aYOSd5acFzqTuV+RsWyMXEkK5p X-Received: by 2002:a17:906:9be4:b0:741:480a:387a with SMTP id de36-20020a1709069be400b00741480a387amr21920588ejc.147.1662159646024; Fri, 02 Sep 2022 16:00:46 -0700 (PDT) Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id az23-20020a170907905700b0073d8691cf38si1923364ejc.526.2022.09.02.16.00.42; Fri, 02 Sep 2022 16:00:46 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@outlook.com header.s=selector1 header.b=Cu8a8uGq; arc=fail (body hash mismatch); spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=outlook.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id ED01768B9DC; Sat, 3 Sep 2022 02:00:38 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-oln040092073017.outbound.protection.outlook.com [40.92.73.17]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3859568B8EC for ; Sat, 3 Sep 2022 02:00:32 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K/bfWow8gzWaE/O6bmPErXIQwVath9WfdFXE32eSoNMNp/QUZ9kT5HKlPv/SN/WNG6Yq9MLumHvqgpnItr+MLR4K8Mpr5LQ5bDnRxxa59QRZ1NDpro67JDpFTU2U+P695F/HhBYbvBr9oyCUY5JUFnFMNORxSI5++qq2/+FkdCRRPLXG2eCdMPHJ7m3Yd3NVB7EZy6ZfO03jI09cLD206LMdW1o+D7bBHeae0MHC5nIXdOxaftfVuz8SZ2L+18g4sgcK/aB93SxCvOaGhtVTj/6tfKxzPdXZ4OGytfdWjN4TWRX6wXyBKAFyuCh0lWLPk/tEK3MGHMS3PgAs01ICYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=g6SPmPwlyfH51c9xjay3tGNfmyuOMRlmvbC9bsO9xaw=; b=OL8YVmJnJx2KVarrNzxaoULUUglZV51oPos6F3+j+qGXv0mOAL1j7ktaQXUSxf9HkASSmhS9qCmnQGmaCodp7dK33/sOmmd0WYODFeHbhZcLft8uus0w8O7Kaua65XW3aw62IiLPMztIQU+jIAUqWonjHxLdp82HQS8Hn0X0vMiYUpu3+L7ODYVJBm1oR6E+0fn2IemJlrsVklXBJXR7K1xhDujQM3V7knRVT8jLgO3v5Oufk1Lbg6ipaP2ELne5uX4E1WbWRNNGlGwu+rJXYNLbU/wRNDrBACSCnIuXj5eXOQX9NcWaQZewGsKp0TKCASJwgIZNDoeqaVErbhmlgQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=g6SPmPwlyfH51c9xjay3tGNfmyuOMRlmvbC9bsO9xaw=; b=Cu8a8uGqTlNN39whXeiIEnL3l+1rjPQX3xjf5/+QJTwy8qyvxYifr6vlsAR9wM/doyMIHb/Wl6umI4rNZMrcSUlLjD2qihmQBOcWc22vuJO9ipkXIUymQ+CtbT5+hCGT8JCkdxdHYVi+1qdlAoKy8rsP0pLRICh7bCP0lTEmhyHJ/2lxpGW8xYCwOR8UmT6GIL49EGngJ5ZN52euQIMaV2zs9oo2/34aKEznlE+FiSo3c+lNkcbFp0Npp4Vfk+XBkqsq6wbOS0uGZ8oJ6wtfHbGBcmCWGbVKoiiQc8PeGI0uQsCUeRd8Qak0usy01jwDzgzh1n2cbcjs8ubTz2Sr0g== Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) by AS4P250MB0872.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:58b::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.14; Fri, 2 Sep 2022 23:00:30 +0000 Received: from AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::f85a:9a02:f8be:7c47]) by AS8P250MB0744.EURP250.PROD.OUTLOOK.COM ([fe80::f85a:9a02:f8be:7c47%2]) with mapi id 15.20.5588.010; Fri, 2 Sep 2022 23:00:30 +0000 From: Andreas Rheinhardt To: ffmpeg-devel@ffmpeg.org Date: Sat, 3 Sep 2022 01:00:25 +0200 Message-ID: X-Mailer: git-send-email 2.34.1 X-TMN: [CkNeuDB3s44K0Er9iP8GDYxGpgKUb0Gh50JLkiGO58A=] X-ClientProxiedBy: ZR0P278CA0177.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:45::11) To AS8P250MB0744.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:541::14) X-Microsoft-Original-Message-ID: <20220902230025.1094142-1-andreas.rheinhardt@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9a4b2ace-b155-4b4e-92c3-08da8d36eec3 X-MS-Exchange-SLBlob-MailProps: AZnQBsB9Xmro6QgSszs9gPQjHH1wC5Q2pLpysmeshzsKnAF5pDsdQl8vzDDli8pbiNZ05vHGXmtCR20+XUhGiSeXGv9tiDciuHSNWZfTfeUd0VMXj7CMdwFs6m9lf92E0SqscYPILBEhyDM8WtqIPWw2D9J3lNYtIKEDTugA+3KXVpkzhLjeHF6SEGcXspZacQsARJDakvMJQZIeCIJm0DrA7zpB3tpi1giAS756SQsW9DHSbavqMJT+uNAPMoo85rEGYtVk9ldcEtrbXvsmTTjq0YfcYiuVECzL+tmj3/RwPFR0CAfHRmDyPjOHJJuc1zs4aUQSR+GaCpjtMyQSnXO7jdvYyLlS4Fpj7hysV78OMlhuzEW+cALR4CF8GKXRdoGBrgoexvQWH6hpkLCa63DQkdogScbKYqqV9Pk2NplxB1iFzYqTFBwBtOXyBNKqp4v9IyEPtUHliVeZbOhieybJj7SXZI8SA2qc/V3hiqxf7dD/yjyV78sREU02mjKv4wJK5wZPj0n6VSz2V2cvW0pzhKFQYMoq05/AhPxGPdBOsxRL2CznpaUj6L5DoDEreZMFkB4KvzcqnuUZ8rk6o9+POw4B/fu0EYTKgfNMHhcIXPyoUTiD91+EvnzVY0DVdAVM9MiA1Gd3lTWg9dXMCfcI+3phLQ6VePnwVki5D+ZjpEXd7XTV4pRyIaLU0G8ZGegyVZwgYuOj8xxwARJ9nMIaZoNIkjJHHhEmzwVdTv4juACelCxNW0fceHKfPUaIK6ZFKujjVYs= X-MS-TrafficTypeDiagnostic: AS4P250MB0872:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ow6lb0V60ligU8U/N6+ZyxYFNciWLUYSlQxykQFfYakaTpiQp0ysFURMX8gUA+hCnWycG7aceD1oZSQ2roEut9tlL01J0aMohisU7/jDtlNrix1x5vpKLA3+b6J/DiMOyUJvtVVclDIilFQiFkZ26lzduMpkqZfxaOTV0ohG8ee/EVNoWALeTzMQu+irV7PyyD5vQxgHQQsIZHzWkk2JoeAgeXPGEzerDvqqAzMDhhb5FWyoTjyOxuwgwIknePO0dCT+MsHYxSfp5ysC3Vm7XaC6wILbumfAF2nsMAFdAFxlyVYhwiq2Ea/hchWToCBzgZaox/CCgXU5wPhfV0PoZuIHmVRbiSsQahdvRrsqYyxke4yBeUmVk0oYiqeW7K8Mu/zYKNEvJDZN9EihM8f9nfpoLfqasUUJX7rwCILvzTBSiTcIiBcZplEojdUX1LioKuulqo0xdF21y0t1fks2uZxLz34dAzSKltDns55FUXPt3nlbemS0t9qxjrR5jnzMkvT6CvnDaq9aV+kiAfwTZxuNmo9E2pyUAaASQp8ffZZohwjzEALj6aoGTjQd+Jz0w/w0ngEid8OVP7o1CnifdFe6+RKmywLE0Uq2oCN5//L1A9Vm/q0DyyxWtaTNoRAj0FUaqYFshaK/hDROh97PgA== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: RyheMA1YaSTt9H+izkXT9KgWyzwNtNuWE3aU0kkbUCtAHODSxdx2++E/cnYu7cKzZWexv8gn9BeRU0TDR+frED16MusyFOi97HJ0u/tsgy3Ag2Fs588yjXSn5yQDQnn3HGhJA+YIjgITSVTv709gKZxHi7qtlOWzrxhl7jYlH3POh5tFLK0Wf0TUZTOgbquS0VRjGZy7DrIw+yNaKYMTqqBUusWCAJ2AcVR7hpKMv2mcEtfoqlbDck8jl4xbvXQu1hOBD02KMmpPMuwur59gx7XaNv0BsdluUTpdgVgBW1RhvHQp8fHeSWDUina6+0Dpn7ZS0WDvXnZ72C3tZLOLSzI+wGe+XpyG00E1+irwI5vhawaqdySmQvJXPgsqI0Da6t8sFFfbN9QWBPkSAhfg5Hwrry7RifE6IG874xmFuhg4BmbNbtKVBtGUxPLhD8X5mOkE8vHRtad0O/jNbWyAHyCp2hTV7y/2/SbnflkDvlkCAO2dCmgVEuVlK1xiCDiEYXStk4rnK4kwcG1VvPe6kT2Uba8qkgq/G4R9pWDJgsXPOHbb9hjmHRRK01jDCfgHTUCTaOud27eIxFLf2JQO36i6rOMgwP06MbxZzdEy8M6d3haATEz5k5vkqEVRoS1wZ6KTHwOf6mQvBlNGpddUj1MAkrV+U6FSrlXldIgiMqicBl0c7WMulEMNeJlVkDFrTUnTTaMTn/p+q6HIBNG1dKo8x48dTNken+5yEOeWs8rDIi4fvnVGcJv3tyGdx3Bj591GDOm4gjTtBBZouHm7Nsx7hjFxHT66ls9DGwGUWYg8q/UvkG4RrwS0ssEUFPgo7gmxw4nldfKBxe8RUrnbMEAhApqP1m2LSBM2uH5D0HTQSif7tnxkUbBOVje3ZDKsFiIH1OyxP7bacHIrmaVjrG7pzCG0bl+B7kpBz0xa/N6StPsqkFXamGikx3upk1w9asR0EfWW5WVnp06Eg5D1/C3OGbFRsDEf4GFqH8WqyBrraLC6uPo5TQHU3Jry1qP46oui85t9iTsxh5qxJ3PXMRpRkgt0121XaR20WpNNNv8E1gwAYZCE+Ny6zG3BTI2vF/odUSV0JAn+mV+UPzOeLQY0SXvBb+/LRGd1Snh2R40zoJuwFMu3Lom35sflFRu0hVq7dCfXNW788IplqcZWbfgdpRIZfg1VTu0xcASmm0nqLchqWjg1ABlba3O9QE03AhPFwvLBAo/KgzPp6oYDewcI5M4oUSwAGTxZ9+c02e4YP6jgpYVpmUgO7OC4dwIAgaj//hiHSLdMRoA3Uj7ncmUd1NbHqgblIzWbsRNtF2RxZVMAUj+8X0r/8qP2mnl+ X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9a4b2ace-b155-4b4e-92c3-08da8d36eec3 X-MS-Exchange-CrossTenant-AuthSource: AS8P250MB0744.EURP250.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2022 23:00:30.4723 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4P250MB0872 Subject: [FFmpeg-devel] [PATCH] avcodec/mathops: Set hidden visibility where advantageous X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: 1vaD6BcmL38z It is advantageous for ff_crop_tab, as the base pointer used to access this table is not the first element of it. But the real base pointer is still at a constant offset from the code/the GOT and can therefore be accessed relative to the instruction pointer (if supported by the arch) or relative to the GOT; without this, one has to first load address of ff_crop_tab (potentially via the GOT) and then offset manually (which is what the earlier code did). Signed-off-by: Andreas Rheinhardt --- libavcodec/mathops.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/mathops.h b/libavcodec/mathops.h index f81d21f9c4..c89054d6ed 100644 --- a/libavcodec/mathops.h +++ b/libavcodec/mathops.h @@ -24,6 +24,7 @@ #include +#include "libavutil/attributes_internal.h" #include "libavutil/common.h" #include "config.h" @@ -32,7 +33,7 @@ extern const uint32_t ff_inverse[257]; extern const uint8_t ff_log2_run[41]; extern const uint8_t ff_sqrt_tab[256]; -extern const uint8_t ff_crop_tab[256 + 2 * MAX_NEG_CROP]; +extern const uint8_t attribute_visibility_hidden ff_crop_tab[256 + 2 * MAX_NEG_CROP]; extern const uint8_t ff_zigzag_direct[64]; extern const uint8_t ff_zigzag_scan[16+1];