From patchwork Thu Sep 8 09:25:03 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Hubert Mazur X-Patchwork-Id: 37755 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:139a:b0:8f:1db5:eae2 with SMTP id w26csp164191pzh; Thu, 8 Sep 2022 02:25:55 -0700 (PDT) X-Google-Smtp-Source: AA6agR5VFdctG1TdieHFpy4Bv0f6LUnINuPcfNkMkZjcBC1+e6wXTYLq9Uz+OkFNOkWZG/29+DZ5 X-Received: by 2002:a17:907:72c9:b0:770:fbb8:b6d with SMTP id du9-20020a17090772c900b00770fbb80b6dmr3553565ejc.680.1662629155257; Thu, 08 Sep 2022 02:25:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662629155; cv=none; d=google.com; s=arc-20160816; b=UGnw5l/RU2MQoRkNWETgCpeJvByw5Cz2K9p1ZR2W6lk6a8NjoixN2aHicSJKv3caVc mv/hSsT3Px/sRL7meA7M7b49Gnimsu1zHWlU9E/07No1/A2bjOsrXeXifw1Sf6MMZCv8 jN8x6JldRIvEOd2c0JXnpg/X5eaRZg7YKlQs1NSq+YmlRraXf1/ibwkFHR0QK0XsuY9x Jo32j3FDaeQlWpq377C8DTbDBCj5wckI5pYCAHSv2QCm11/GL38SSdHODM0q9CjW83SM hBT74lPja49fA08qbY7+3WbB50NvuThKR6irTWbn85vz4wycu2LuHGgr+tvK/jjKNgzY PWpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature:delivered-to; bh=/OXBxJgYgBN8LhlDDANya+ZLzGxf9S9F4/8yiScdDA4=; b=u219oH1N/R/smkeoNJvMt+h4b4mFZ1Dos8mFi0bIFhICQoCH3Q27VLaXl/4qmIaD5F P5JtX3Yr8ci5CqTEEr12qInzNPUrVUuigALfwcnfhRB6FP645/6xyNiinIh7+e0/G/g5 us+40vNSkLWM/2IsLo5doLTTgreRGdhlslMg0Tjz1s3Wl16ujOK/ia5Laqt6TkJt+xXx KP1X2RxrC3P/RwuNuI4XcrD1IPc88qTc3W/EHr5niM3jEu0WaAojM6bERJylqjbHcTp7 vUeLGPrVnq2Drl0uPuCLVI2y3EbfmsEZFGjvsoZhvHO0d06xPBfr60JRDg4pocOW3eSd o0qA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@semihalf.com header.s=google header.b=ifcKWgxj; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=semihalf.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id z12-20020a05640240cc00b00447e9c56162si2666603edb.11.2022.09.08.02.25.54; Thu, 08 Sep 2022 02:25:55 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@semihalf.com header.s=google header.b=ifcKWgxj; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=semihalf.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 165BB68BA6C; Thu, 8 Sep 2022 12:25:43 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5F58268B95B for ; Thu, 8 Sep 2022 12:25:36 +0300 (EEST) Received: by mail-lf1-f49.google.com with SMTP id u18so14417421lfo.8 for ; Thu, 08 Sep 2022 02:25:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf.com; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=/x7pZYKRS7WzhUsA/8scdjSZ5RWV8G9Gl51EGOh8EOM=; b=ifcKWgxjQ7zA3vRcqIrSpUSy0EYDun72PE48WKwrOqZDBvUxE1MSNlxvC6Uqdvq42T 4zcAf/xtpV/XH4S/e6AVpnvtLwDmqAfgImJ29vhaNyf8GpsIKK/T7yQHGRoR1c5taPW5 Dz9/5ngnldgI0DzNhw1CS95THZC6zksMVt39+VW4Md8wEQHnOIjV/oPEIjYHCvpc0pMx BsfWfhSFIR7bbQugoMeEnv+a67TupYFDkqOJVTr4blqMu5rnHwkyT9YBrIpe7FRy2mB2 NfxaUBmgH4b96TqExkk/tkbMhxAGxdA7/Cwrgbf6KoUbS9sitvqvBr+7SHNFfyJpHSdW 4fiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=/x7pZYKRS7WzhUsA/8scdjSZ5RWV8G9Gl51EGOh8EOM=; b=IxpuEkZGwpHHFKT8cEf9j+0rNopUbRL/ztAXBfheWkmrXK/4JekTLKGb+WTrIofDHJ 9ZoGXp3oo/OD6W1KDKotJfed/tMmdqo6MS+NfOxmsyAhgrQu+CFVe7p4oyz66bG7VWRn vq5PnCt55gQjqIAOf06UevJc/eHerQYwVKNoA2sggyWAeJ+P/oDgiuf732L82qX8Pnuo ARSCpsZC/nO16IM40kIiIcDS0lan/N4RPUHU+SV3zgFywZeeLmsFfr7BbJzmrYpBFXe4 N4Dh4BBWMki7fWMnmnU3p2+ZCFYwAHwOZg7qs6waxxjBxNW7V8e59Z2E4UpqVMxRdEI3 KRNA== X-Gm-Message-State: ACgBeo202Vz15cmD/T6Q6o6j9UiQyC6IlOMmiGOPF/RZLuIDYwnqiTLV 2Yl5++jQ2tl4xLV6FirfWd+cBilcpwgAgg== X-Received: by 2002:a05:6512:2804:b0:492:cef4:2210 with SMTP id cf4-20020a056512280400b00492cef42210mr2305709lfb.17.1662629135291; Thu, 08 Sep 2022 02:25:35 -0700 (PDT) Received: from hum-HP-ProBook-440-G7.semihalf.net (apn-46-169-39-115.dynamic.gprs.plus.pl. [46.169.39.115]) by smtp.gmail.com with ESMTPSA id k20-20020a2ea274000000b00261e8e4e381sm3103998ljm.2.2022.09.08.02.25.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Sep 2022 02:25:34 -0700 (PDT) From: Hubert Mazur To: ffmpeg-devel@ffmpeg.org Date: Thu, 8 Sep 2022 11:25:03 +0200 Message-Id: <20220908092507.63319-2-hum@semihalf.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220908092507.63319-1-hum@semihalf.com> References: <20220908092507.63319-1-hum@semihalf.com> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 1/5] lavc/aarch64: Add neon implementation for vsad16 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: gjb@semihalf.com, upstream@semihalf.com, jswinney@amazon.com, Hubert Mazur , martin@martin.st, mw@semihalf.com, spop@amazon.com Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: /UHhezXKTlG1 Provide optimized implementation of vsad16 function for arm64. Performance comparison tests are shown below. - vsad_0_c: 285.2 - vsad_0_neon: 39.5 Benchmarks and tests are run with checkasm tool on AWS Graviton 3. Co-authored-by: Martin Storsjö Signed-off-by: Hubert Mazur --- libavcodec/aarch64/me_cmp_init_aarch64.c | 5 ++ libavcodec/aarch64/me_cmp_neon.S | 65 ++++++++++++++++++++++++ 2 files changed, 70 insertions(+) diff --git a/libavcodec/aarch64/me_cmp_init_aarch64.c b/libavcodec/aarch64/me_cmp_init_aarch64.c index fb7c3f5059..ddc5d05611 100644 --- a/libavcodec/aarch64/me_cmp_init_aarch64.c +++ b/libavcodec/aarch64/me_cmp_init_aarch64.c @@ -41,6 +41,9 @@ int sse8_neon(MpegEncContext *v, const uint8_t *pix1, const uint8_t *pix2, int sse4_neon(MpegEncContext *v, const uint8_t *pix1, const uint8_t *pix2, ptrdiff_t stride, int h); +int vsad16_neon(MpegEncContext *c, const uint8_t *s1, const uint8_t *s2, + ptrdiff_t stride, int h); + av_cold void ff_me_cmp_init_aarch64(MECmpContext *c, AVCodecContext *avctx) { int cpu_flags = av_get_cpu_flags(); @@ -57,5 +60,7 @@ av_cold void ff_me_cmp_init_aarch64(MECmpContext *c, AVCodecContext *avctx) c->sse[0] = sse16_neon; c->sse[1] = sse8_neon; c->sse[2] = sse4_neon; + + c->vsad[0] = vsad16_neon; } } diff --git a/libavcodec/aarch64/me_cmp_neon.S b/libavcodec/aarch64/me_cmp_neon.S index 4198985c6c..1d0b166d69 100644 --- a/libavcodec/aarch64/me_cmp_neon.S +++ b/libavcodec/aarch64/me_cmp_neon.S @@ -584,3 +584,68 @@ function sse4_neon, export=1 ret endfunc + +function vsad16_neon, export=1 + // x0 unused + // x1 uint8_t *pix1 + // x2 uint8_t *pix2 + // x3 ptrdiff_t stride + // w4 int h + + ld1 {v0.16b}, [x1], x3 // Load pix1[0], first iteration + ld1 {v1.16b}, [x2], x3 // Load pix2[0], first iteration + + sub w4, w4, #1 // we need to make h-1 iterations + movi v16.8h, #0 + + cmp w4, #3 // check if we can make 3 iterations at once + usubl v31.8h, v0.8b, v1.8b // Signed difference pix1[0] - pix2[0], first iteration + usubl2 v30.8h, v0.16b, v1.16b // Signed difference pix1[0] - pix2[0], first iteration + + b.lt 2f + +1: + // abs(pix1[0] - pix2[0] - pix1[0 + stride] + pix2[0 + stride]) + ld1 {v0.16b}, [x1], x3 // Load pix1[0 + stride], first iteration + ld1 {v1.16b}, [x2], x3 // Load pix2[0 + stride], first iteration + ld1 {v2.16b}, [x1], x3 // Load pix1[0 + stride], second iteration + ld1 {v3.16b}, [x2], x3 // Load pix2[0 + stride], second iteration + usubl v29.8h, v0.8b, v1.8b // Signed difference pix1[0 + stride] - pix2[0 + stride], first iteration + usubl2 v28.8h, v0.16b, v1.16b // Signed difference pix1[0 + stride] - pix2[0 + stride], first iteration + ld1 {v4.16b}, [x1], x3 // Load pix1[0 + stride], third iteration + ld1 {v5.16b}, [x2], x3 // Load pix2[0 + stride], third iteration + usubl v27.8h, v2.8b, v3.8b // Signed difference pix1[0 + stride] - pix2[0 + stride], second iteration + saba v16.8h, v31.8h, v29.8h // Signed absolute difference and accumulate the result. first iteration + usubl2 v26.8h, v2.16b, v3.16b // Signed difference pix1[0 + stride] - pix2[0 + stride], second iteration + saba v16.8h, v30.8h, v28.8h // Signed absolute difference and accumulate the result. first iteration + usubl v25.8h, v4.8b, v5.8b // Signed difference pix1[0 + stride] - pix2[0 + stride], third iteration + usubl2 v24.8h, v4.16b, v5.16b // Signed difference pix1[0 + stride] - pix2[0 + stride], third iteration + saba v16.8h, v29.8h, v27.8h // Signed absolute difference and accumulate the result. second iteration + mov v31.16b, v25.16b + saba v16.8h, v28.8h, v26.8h // Signed absolute difference and accumulate the result. second iteration + sub w4, w4, #3 // h -= 3 + mov v30.16b, v24.16b + saba v16.8h, v27.8h, v25.8h // Signed absolute difference and accumulate the result. third iteration + cmp w4, #3 + saba v16.8h, v26.8h, v24.8h // Signed absolute difference and accumulate the result. third iteration + + b.ge 1b + cbz w4, 3f +2: + ld1 {v0.16b}, [x1], x3 + ld1 {v1.16b}, [x2], x3 + subs w4, w4, #1 + usubl v29.8h, v0.8b, v1.8b + usubl2 v28.8h, v0.16b, v1.16b + saba v16.8h, v31.8h, v29.8h + mov v31.16b, v29.16b + saba v16.8h, v30.8h, v28.8h + mov v30.16b, v28.16b + + b.ne 2b +3: + uaddlv s17, v16.8h + fmov w0, s17 + + ret +endfunc From patchwork Thu Sep 8 09:25:04 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hubert Mazur X-Patchwork-Id: 37756 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:139a:b0:8f:1db5:eae2 with SMTP id w26csp164246pzh; Thu, 8 Sep 2022 02:26:04 -0700 (PDT) X-Google-Smtp-Source: AA6agR6VLb1PGraceMcMipIEAOrRa7GVClcS15Y7BpMDrZncaHSnZXsoGW+SXzYz/kFydNclQ+FW X-Received: by 2002:a17:906:65c6:b0:73c:8897:65b0 with SMTP id z6-20020a17090665c600b0073c889765b0mr5417808ejn.322.1662629163888; Thu, 08 Sep 2022 02:26:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662629163; cv=none; d=google.com; s=arc-20160816; b=CxHi44oITPHvNNGhZAEQgmmaWcczr+xZdb25cb2h0zalkiV2zi3W0bUyPddzcr8tbM +4meXl6uEhAxmNBLX+NBQJmPD+H2ojfGRdQmatU1eVw39le86sqsRaSV7rM6LuSXApuW hfRxc+3BexRkvRfRh5Oec27Spqgums6IpoYIrb7vBjFSC0637SlyfzZ2ylXFi6jc0myp iwISVYw8lxj8iE63RUrDfEZucjl48+s70C8nT2LxrmKmWoAU5ka1gKckA0KN145I+p/e kbuUhfePP90cehOOb7HnIpNZ7l3UNTu+1HHhhlEQ8VK1q/G8devVZGPCtoOgF79bnlu+ Z4YA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature:delivered-to; bh=TH11U07ohV3HwDjvSDTM1FQ89uozoDuQQvSKnpCmX4E=; b=WrcI3d34suQLzPWhaf9+tsguNI+DvXV1Zh97I0daCuM4wY33n41vOvNijzsl9Ck2J2 PrbaCSXiA/HsXySA/STjsNcST8xdwp+5weKK7GGnktnXD0PP+h/SoVOLyBeRdi+KSQ3S 2MRoDFeNNkZr2KDz0r5dNB59fySNBCRwqnRN+xrMuyNMjWQBCnz76w41oJizLkiMKfMw WICsqElQCcpBm0IsZGVhezP34Ezv9brJNPJz3FeJ5dGbL0Dt6hCTnUMwOTqakTTNobjt a8iw1xYdKIJrNi8i2ntH6f5oRZx2VPAlopbrftHwB8guc2fDIXq1Ux+sjpf65x1or/uL i9Kw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@semihalf.com header.s=google header.b=nvu4Q2G3; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=semihalf.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id g29-20020a056402321d00b0044ec8f9905asi6140282eda.403.2022.09.08.02.26.03; Thu, 08 Sep 2022 02:26:03 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@semihalf.com header.s=google header.b=nvu4Q2G3; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=semihalf.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3FE4C68BA7D; Thu, 8 Sep 2022 12:25:44 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5528A68B32D for ; Thu, 8 Sep 2022 12:25:38 +0300 (EEST) Received: by mail-lf1-f41.google.com with SMTP id z25so26751035lfr.2 for ; Thu, 08 Sep 2022 02:25:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf.com; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=swz+tkpbq2c/Yh3Tdn8cz73DgaAZj1zC/h5HAsE+xEg=; b=nvu4Q2G3pqSdKUUHxFUFlKGFmtfpiXbhMBUobmjnrExTv2IbJ5YLo0i3epUXW/IlLF IdpW59vqX5hye11QoqCKqQVUtK4p2z3Kled6AhcNNZsLQH6LlV2ljcK8sG7O1dxAf6b8 /TC1EXD5dhqYF8DbVEWrf+l3EKO97CEFbwBebL4rJ2ShuNW9ORW4zgaFDs6aPPaKOeuq IuzYv8hrzGjQXyHalJmdLw6z8hZK0bMHqGLqpClTZoLexQGut+hGM4d9ODjAy6auVtbm SPrFzs0pAzuxzPp0Q5Ic/ONnJnMu6kj52dHilYBRTDXKLBOgD1jm3O41yaSUf0cLM8g3 gEAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=swz+tkpbq2c/Yh3Tdn8cz73DgaAZj1zC/h5HAsE+xEg=; b=ayQwLt9oOyEvfwl7tUk6InwPoXUBNFg7EA4kG20XY0xfstT3m7Ldg1P6cMT0Yb3/C1 X30AhnCfU5v7vpSVmi9F4d/alXuHlp7owYbbtVV0wOHUmVUzxnSVZA2nEQkmb1AZPwZP 3rOxeqortEQ7TcsDeUSxNthKw+ra2Ji+VRLpbgi5epA1eCEnrqr4YphE+SxTXHi4xzKB FfOFekx7BaVhMt0ArRHRG1md1isblePEQG9TMTJvHyAKtGWiJ/0r+cyXCUhmN7y1fEbZ 9oK0uhyWfEWHVFFLj82MgDlaS2b8kYYPxZX3Jd3S1BGkE5pduLdQcig44OD9yB+eQ9Ha 9Lng== X-Gm-Message-State: ACgBeo3M9VLGeAUuY1THTR7JBHFSFFQt4vuOaVu+2EWC+LFCvw98BN8J YCt/LUBDhWJc9QRFd30u1z4Xf0OTH3zemg== X-Received: by 2002:a05:6512:32c1:b0:48c:e9d8:7fd2 with SMTP id f1-20020a05651232c100b0048ce9d87fd2mr2272914lfg.331.1662629137186; Thu, 08 Sep 2022 02:25:37 -0700 (PDT) Received: from hum-HP-ProBook-440-G7.semihalf.net (apn-46-169-39-115.dynamic.gprs.plus.pl. [46.169.39.115]) by smtp.gmail.com with ESMTPSA id k20-20020a2ea274000000b00261e8e4e381sm3103998ljm.2.2022.09.08.02.25.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Sep 2022 02:25:36 -0700 (PDT) From: Hubert Mazur To: ffmpeg-devel@ffmpeg.org Date: Thu, 8 Sep 2022 11:25:04 +0200 Message-Id: <20220908092507.63319-3-hum@semihalf.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220908092507.63319-1-hum@semihalf.com> References: <20220908092507.63319-1-hum@semihalf.com> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 2/5] lavc/aarch64: Add neon implementation of vsse16 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: gjb@semihalf.com, upstream@semihalf.com, jswinney@amazon.com, Hubert Mazur , martin@martin.st, mw@semihalf.com, spop@amazon.com Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: vRdwfFXSE1tW Provide optimized implementation of vsse16 for arm64. Performance comparison tests are shown below. - vsse_0_c: 257.7 - vsse_0_neon: 59.2 Benchmarks and tests are run with checkasm tool on AWS Graviton 3. Signed-off-by: Hubert Mazur --- libavcodec/aarch64/me_cmp_init_aarch64.c | 4 ++ libavcodec/aarch64/me_cmp_neon.S | 87 ++++++++++++++++++++++++ 2 files changed, 91 insertions(+) diff --git a/libavcodec/aarch64/me_cmp_init_aarch64.c b/libavcodec/aarch64/me_cmp_init_aarch64.c index ddc5d05611..7b81e48d16 100644 --- a/libavcodec/aarch64/me_cmp_init_aarch64.c +++ b/libavcodec/aarch64/me_cmp_init_aarch64.c @@ -43,6 +43,8 @@ int sse4_neon(MpegEncContext *v, const uint8_t *pix1, const uint8_t *pix2, int vsad16_neon(MpegEncContext *c, const uint8_t *s1, const uint8_t *s2, ptrdiff_t stride, int h); +int vsse16_neon(MpegEncContext *c, const uint8_t *s1, const uint8_t *s2, + ptrdiff_t stride, int h); av_cold void ff_me_cmp_init_aarch64(MECmpContext *c, AVCodecContext *avctx) { @@ -62,5 +64,7 @@ av_cold void ff_me_cmp_init_aarch64(MECmpContext *c, AVCodecContext *avctx) c->sse[2] = sse4_neon; c->vsad[0] = vsad16_neon; + + c->vsse[0] = vsse16_neon; } } diff --git a/libavcodec/aarch64/me_cmp_neon.S b/libavcodec/aarch64/me_cmp_neon.S index 1d0b166d69..b3f376aa60 100644 --- a/libavcodec/aarch64/me_cmp_neon.S +++ b/libavcodec/aarch64/me_cmp_neon.S @@ -649,3 +649,90 @@ function vsad16_neon, export=1 ret endfunc + +function vsse16_neon, export=1 + // x0 unused + // x1 uint8_t *pix1 + // x2 uint8_t *pix2 + // x3 ptrdiff_t stride + // w4 int h + + ld1 {v0.16b}, [x1], x3 // Load pix1[0], first iteration + ld1 {v1.16b}, [x2], x3 // Load pix2[0], first iteration + + sub w4, w4, #1 // we need to make h-1 iterations + movi v16.4s, #0 + movi v17.4s, #0 + + cmp w4, #3 // check if we can make 3 iterations at once + usubl v31.8h, v0.8b, v1.8b // Signed difference of pix1[0] - pix2[0], first iteration + usubl2 v30.8h, v0.16b, v1.16b // Signed difference of pix1[0] - pix2[0], first iteration + b.le 2f + + +1: + // x = abs(pix1[0] - pix2[0] - pix1[0 + stride] + pix2[0 + stride]) + // res = (x) * (x) + ld1 {v0.16b}, [x1], x3 // Load pix1[0 + stride], first iteration + ld1 {v1.16b}, [x2], x3 // Load pix2[0 + stride], first iteration + ld1 {v2.16b}, [x1], x3 // Load pix1[0 + stride], second iteration + ld1 {v3.16b}, [x2], x3 // Load pix2[0 + stride], second iteration + usubl v29.8h, v0.8b, v1.8b + usubl2 v28.8h, v0.16b, v1.16b + ld1 {v4.16b}, [x1], x3 // Load pix1[0 + stride], third iteration + ld1 {v5.16b}, [x2], x3 // Load pix1[0 + stride], third iteration + sabd v31.8h, v31.8h, v29.8h + sabd v30.8h, v30.8h, v28.8h + usubl v27.8h, v2.8b, v3.8b + usubl2 v26.8h, v2.16b, v3.16b + usubl v25.8h, v4.8b, v5.8b + usubl2 v24.8h, v4.16b, v5.16b + sabd v29.8h, v29.8h, v27.8h + sabd v27.8h, v27.8h, v25.8h + umlal v16.4s, v31.4h, v31.4h + umlal2 v17.4s, v31.8h, v31.8h + sabd v28.8h, v28.8h, v26.8h + sabd v26.8h, v26.8h, v24.8h + umlal v16.4s, v30.4h, v30.4h + umlal2 v17.4s, v30.8h, v30.8h + mov v31.16b, v25.16b + umlal v16.4s, v29.4h, v29.4h + umlal2 v17.4s, v29.8h, v29.8h + mov v30.16b, v24.16b + umlal v16.4s, v28.4h, v28.4h + umlal2 v17.4s, v28.8h, v28.8h + sub w4, w4, #3 + umlal v16.4s, v27.4h, v27.4h + umlal2 v17.4s, v27.8h, v27.8h + cmp w4, #3 + umlal v16.4s, v26.4h, v26.4h + umlal2 v17.4s, v26.8h, v26.8h + + b.ge 1b + + cbz w4, 3f + +// iterate by once +2: + ld1 {v0.16b}, [x1], x3 + ld1 {v1.16b}, [x2], x3 + subs w4, w4, #1 + usubl v29.8h, v0.8b, v1.8b + usubl2 v28.8h, v0.16b, v1.16b + sabd v31.8h, v31.8h, v29.8h + sabd v30.8h, v30.8h, v28.8h + umlal v16.4s, v31.4h, v31.4h + umlal2 v17.4s, v31.8h, v31.8h + mov v31.16b, v29.16b + umlal v16.4s, v30.4h, v30.4h + umlal2 v17.4s, v30.8h, v30.8h + mov v30.16b, v28.16b + b.ne 2b + +3: + add v16.4s, v16.4s, v17.4s + uaddlv d17, v16.4s + fmov w0, s17 + + ret +endfunc From patchwork Thu Sep 8 09:25:05 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hubert Mazur X-Patchwork-Id: 37757 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:139a:b0:8f:1db5:eae2 with SMTP id w26csp164304pzh; Thu, 8 Sep 2022 02:26:13 -0700 (PDT) X-Google-Smtp-Source: AA6agR7TofkJYxka4rvfpga0pY8Ej0+3TJEtmNHXJEg3zLg5I41B8rad7ofiSgcMCjo14TDRO9OL X-Received: by 2002:a17:906:dd4:b0:741:9901:abb5 with SMTP id p20-20020a1709060dd400b007419901abb5mr5304973eji.321.1662629173495; Thu, 08 Sep 2022 02:26:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662629173; cv=none; d=google.com; s=arc-20160816; b=1I6hl+PetfPHz5HV7ZCO10N8TddGpue2l+i1PKaybhZKGmYsB0PHguMKZ7QbCXXxAx sSnGBUz5+rV7l/Rhr0mUgOiDMgkFHpbos01rkRG0mXPyClVRxnJrZfVe89Mp5zzlnHs2 fgXpTy5qP99LvsK8hH0PwQv/v33dK3Yf/PoyiJR/d2wxQ45lNwFbzQWYefQn8914rEyM Sy50b6nnTDvcx9s6RW+u4l8oadjithAWyaP7Wni6TMf5t5Ox7vWGE/+G0BNccrvJAZJF wiHltrK4Z+AseuCmslEHZregcz7Q/kjk2achfnpg9Zmbbm2gT50JsJ9htLasw9zNwnhL mLEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature:delivered-to; bh=kozZFl6xxOsV5c3Yzv5/hE3WOl2DBAVtDngM03kxDYI=; b=u5RKU0OCoUTNjqnTuPw42iY7FxSPJofGpHbeQSssFMPkrC0WL4cgv7ltNITWngP4Rx DFkmImrGvEKjHLY/nLqrjH0tB5eFuO39PfZ3oS2/PRkdVR06K3g6hqPheBq51J5TDLio hT+ser8zRErxx8GEh27juZwJSaptAE9FWpAWY21yD+Mvu85mXUk6Y2tvmp/yZLI/lsFt TFUbvobBYh9Gl2uujTRhIITq4VldOK2GURpghsGlXk33tsoQ85sMvtCRcjRl0WbbsYE2 kVSNj+g6WIkbHSt090OowSU2dZxdrY1pQwArJjqRQE1fMJo8Lr0R7fvrsH/XWk2imjom g6lg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@semihalf.com header.s=google header.b=kSgtOZrw; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=semihalf.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id x2-20020a05640225c200b00447cff2e436si11104881edb.200.2022.09.08.02.26.13; Thu, 08 Sep 2022 02:26:13 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@semihalf.com header.s=google header.b=kSgtOZrw; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=semihalf.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5D14368BA8D; Thu, 8 Sep 2022 12:25:46 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 40D3668BA7A for ; Thu, 8 Sep 2022 12:25:40 +0300 (EEST) Received: by mail-lf1-f42.google.com with SMTP id i26so10973943lfp.11 for ; Thu, 08 Sep 2022 02:25:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf.com; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=ELuepA24jL+85cNqfGsFQviKg6JRDAMybUX1LhsA2vo=; b=kSgtOZrw3KxWZfJD9Ao6l0pOD7fcPmlrctzeNQ1/DTYTaL5QnZnjQHLssmIfjqdc/P v4+vJJu9ZL2+FnoFuQ4GDnqJncbALuJNbjfUir3zEbGSoMScbvFi7poL9mN4uMmEijmy ogf0/aDnuaSuvYbkZnLBfy+E14V4t7XQxyti/zJ2x3Zhy9dbdGRo9B6J74cjsvZSXpy9 DOv+WjEilEeW8j0JuBub9enl0pPnPoHTnSQ/4lntf0IreZIZkjSKNqhLoae3sA3xuoF9 aZWGYuO4C+yroO+bFv2WubTBVrlF78icWPOL6gceylK6s2Omx6zgWtI8U2WTsMmNhEuG gASw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=ELuepA24jL+85cNqfGsFQviKg6JRDAMybUX1LhsA2vo=; b=UQ9aYNfmW9ibCp0MpqvB1mo6aNBCFQ74we+k43VXxvRm9s4KXi+vl8mWDbhRrGepE3 Rj9QvKggsyUvspXX2fzutweRgsnAIg9km4D/uZluQHVPJOmTbNSbTI5mv5wYClb3mrtl UKiKlellNED3LvV9q+ZPblVdd4MRpL/3hBfdxgSw4wAoFfN1sf87a5O+6tr1NItjBCbO 0zPN/bbfgnTxs5jpOEE3XvULtcURwj0J0yoV8UuDcLJgi0PSbWMvL4PY1D/4FHWl/sn1 sxO17SWzF0+4+X8gdK7YfuWr93f3G6eiCC0xAbgnep08mNKMZQc9L6jdj2+LdMPkWXFa 0pmA== X-Gm-Message-State: ACgBeo0zo50nf/yznsTqa9Qv80D5XUa+WBhrb74lOc7RJJ06H8GtM9PK fcBLpJW7Hy1smK+tcdtr0V/DiHWZBtgVgw== X-Received: by 2002:a05:6512:689:b0:496:ff8e:9fdc with SMTP id t9-20020a056512068900b00496ff8e9fdcmr2325955lfe.177.1662629139276; Thu, 08 Sep 2022 02:25:39 -0700 (PDT) Received: from hum-HP-ProBook-440-G7.semihalf.net (apn-46-169-39-115.dynamic.gprs.plus.pl. [46.169.39.115]) by smtp.gmail.com with ESMTPSA id k20-20020a2ea274000000b00261e8e4e381sm3103998ljm.2.2022.09.08.02.25.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Sep 2022 02:25:38 -0700 (PDT) From: Hubert Mazur To: ffmpeg-devel@ffmpeg.org Date: Thu, 8 Sep 2022 11:25:05 +0200 Message-Id: <20220908092507.63319-4-hum@semihalf.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220908092507.63319-1-hum@semihalf.com> References: <20220908092507.63319-1-hum@semihalf.com> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 3/5] lavc/aarch64: Add neon implementation for vsad_intra16 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: gjb@semihalf.com, upstream@semihalf.com, jswinney@amazon.com, Hubert Mazur , martin@martin.st, mw@semihalf.com, spop@amazon.com Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: ooyLU1WUQXdz Provide optimized implementation for vsad_intra16 function for arm64. Performance comparison tests are shown below. - vsad_4_c: 177.5 - vsad_4_neon: 23.5 Benchmarks and tests are run with checkasm tool on AWS Gravtion 3. Signed-off-by: Hubert Mazur --- libavcodec/aarch64/me_cmp_init_aarch64.c | 3 ++ libavcodec/aarch64/me_cmp_neon.S | 48 ++++++++++++++++++++++++ 2 files changed, 51 insertions(+) diff --git a/libavcodec/aarch64/me_cmp_init_aarch64.c b/libavcodec/aarch64/me_cmp_init_aarch64.c index 7b81e48d16..af83f7ed1e 100644 --- a/libavcodec/aarch64/me_cmp_init_aarch64.c +++ b/libavcodec/aarch64/me_cmp_init_aarch64.c @@ -43,6 +43,8 @@ int sse4_neon(MpegEncContext *v, const uint8_t *pix1, const uint8_t *pix2, int vsad16_neon(MpegEncContext *c, const uint8_t *s1, const uint8_t *s2, ptrdiff_t stride, int h); +int vsad_intra16_neon(MpegEncContext *c, const uint8_t *s, const uint8_t *dummy, + ptrdiff_t stride, int h) ; int vsse16_neon(MpegEncContext *c, const uint8_t *s1, const uint8_t *s2, ptrdiff_t stride, int h); @@ -64,6 +66,7 @@ av_cold void ff_me_cmp_init_aarch64(MECmpContext *c, AVCodecContext *avctx) c->sse[2] = sse4_neon; c->vsad[0] = vsad16_neon; + c->vsad[4] = vsad_intra16_neon; c->vsse[0] = vsse16_neon; } diff --git a/libavcodec/aarch64/me_cmp_neon.S b/libavcodec/aarch64/me_cmp_neon.S index b3f376aa60..ce198ea227 100644 --- a/libavcodec/aarch64/me_cmp_neon.S +++ b/libavcodec/aarch64/me_cmp_neon.S @@ -736,3 +736,51 @@ function vsse16_neon, export=1 ret endfunc + +function vsad_intra16_neon, export=1 + // x0 unused + // x1 uint8_t *pix1 + // x2 uint8_t *dummy + // x3 ptrdiff_t stride + // w4 int h + + ld1 {v0.16b}, [x1], x3 + sub w4, w4, #1 // we need to make h-1 iterations + cmp w4, #3 + movi v16.8h, #0 + b.lt 2f + +// make 4 iterations at once +1: + // v = abs( pix1[0] - pix1[0 + stride] ) + // score = sum(v) + ld1 {v1.16b}, [x1], x3 + ld1 {v2.16b}, [x1], x3 + uabal v16.8h, v0.8b, v1.8b + ld1 {v3.16b}, [x1], x3 + uabal2 v16.8h, v0.16b, v1.16b + sub w4, w4, #3 + uabal v16.8h, v1.8b, v2.8b + cmp w4, #3 + uabal2 v16.8h, v1.16b, v2.16b + mov v0.16b, v3.16b + uabal v16.8h, v2.8b, v3.8b + uabal2 v16.8h, v2.16b, v3.16b + b.ge 1b + cbz w4, 3f + +// iterate by one +2: + ld1 {v1.16b}, [x1], x3 + subs w4, w4, #1 + uabal v16.8h, v0.8b, v1.8b + uabal2 v16.8h, v0.16b, v1.16b + mov v0.16b, v1.16b + cbnz w4, 2b + +3: + uaddlv s17, v16.8h + fmov w0, s17 + + ret +endfunc From patchwork Thu Sep 8 09:25:06 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hubert Mazur X-Patchwork-Id: 37758 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:139a:b0:8f:1db5:eae2 with SMTP id w26csp164366pzh; Thu, 8 Sep 2022 02:26:24 -0700 (PDT) X-Google-Smtp-Source: AA6agR7SsT3ibwLcNHovmu5KCz9xB7hjO84Tn8nyJfpZrnpMHvwnWcvK0/A90fEqSmctPmqO/VKO X-Received: by 2002:a05:6402:90e:b0:443:ec4b:2b03 with SMTP id g14-20020a056402090e00b00443ec4b2b03mr6198446edz.71.1662629183833; Thu, 08 Sep 2022 02:26:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662629183; cv=none; d=google.com; s=arc-20160816; b=PvSn7coWIDh41zdHXw7sveKbLZm2WYPnRDFL3Q1ac0JV3sHPccMmEI7Qnv5l5xOnjQ yl8SqBjMelmXyb32qVAPL1diheruGmgimhfEM5NuGYo2FH51RUt2fbbcqiGzZhrW3sA6 /YEJMiKk5hAq6NgXMKNnaQjNDEb9w5s0EeIFUvzDviz6B68q/ddpWQZlDK6z8Z8L0TOe 98U8nncK3ZfkYGZwU17378DgYEObwDqgiZih9T4Y7x34fhUxtkx3a2sqmGl2KLz4Nuxn iHPJhBuDRMXSGA0e1KK6jv2BBvy9OapsZ/6xMXePzc0SFDfTrG4shdmwcxaYi59tuEQT SQeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature:delivered-to; bh=DCpXN4q5gVUyQ3E9YRD9AkzCs38fi/wkQ/Zpmcht+8o=; b=P0rYGUndmqJF4bd0W/RQCecXFXPE8BqwIUa0CXTdfReDhKJvdhP9g5m4eHYio4zTLd ifby83WHPnpdikDKSxwrv/zCE/Ukw+635r1RsdhFQBs4IRBcW1uUcmxtPC1xJzZAhJiz RRyU4u/USBbqCEsvi5tPhAn+emLiNa2akFw3VHtx0eFgOkBhk7mAr4vlM/AG+OwuseUy vt43mXL/qlh+bFCyCM5NV4fVsI5fbaBi0J9wXL2Am847Rjx8AwxB0Jz3mv0aX2SxTjIf 7CCuUBD0v30m1B8jaA2a+/NIwxCslZdGPrMv6oiEbGuYDSMylDVbfXslGRfYoMTOmkmk kR8Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@semihalf.com header.s=google header.b="AzW/8NOB"; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=semihalf.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id cw9-20020a170906478900b0076fa1e1274bsi1852055ejc.202.2022.09.08.02.26.23; Thu, 08 Sep 2022 02:26:23 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@semihalf.com header.s=google header.b="AzW/8NOB"; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=semihalf.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 980CA68BA90; Thu, 8 Sep 2022 12:25:48 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 59F9C68BA85 for ; Thu, 8 Sep 2022 12:25:42 +0300 (EEST) Received: by mail-lj1-f178.google.com with SMTP id b19so19131266ljf.8 for ; Thu, 08 Sep 2022 02:25:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf.com; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=aXzvkwLrmNTd/la6G18dkMvbsTys1Z/3w53y9gEGIxY=; b=AzW/8NOByKQyqmF7liBfcSvwN70Nn7eavuRwRrGy/2fCMe40wf1Tt1mj4x8vo1VR90 5CryPocGDcaLQ1kDatey7fyFHsronG+37iVVec2r7OKFYxBAX5pyYIgA8d3E9fu0EBOX 9hzmianaiwHhzubhfIP5eprCY1tJY6yH3Q6ZgRhF1HSjO7C8S8sZVHk1tHTfskCfh4SB a1HDQajIKduVGV0WgrGBBYwLDieq2oZNGFJbONWjRJ22htbR2H8p+KNnkV71Wjaj/Mgk kXQ/Klnm11DebYVNCCh7p78stmiILtnC90wIwpmF/+UYYoJzyeAjhJ9UDN058xb3pP3W RbBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=aXzvkwLrmNTd/la6G18dkMvbsTys1Z/3w53y9gEGIxY=; b=SeJ4eGcoArcUxE5jxBqOxi5kZ5PBP4sh1tKD/5X/3mZn5hnYOC1GktW6o8Uk2J/1rt c/S4xLESOXq/z5bomMNVAaSHT3MNEW0zaYu/0KhdY8/JcMlOQJWqlwYFtCO8ILMP1jVr 9CQRyFZJ73JwkUvlZnAPom0XipdZsC4JHi3MyQbrS/d4cnKj5T3ub/XZE8irXIDSKc30 oYWw/rQJ7IDwVJFZ99AsFkpdshvCn60FQZdbZhK8Pmai19YpnSjXOkdxiO3MwKl2cicB FGTKNasyV23LfaK8rsaj0A+RgX3+RH1Gmidq8HqcG5lydLjOBT6VVg4kqpnqoaNh/A95 DoIA== X-Gm-Message-State: ACgBeo0dpVf9jojKtz2ht5WyJcP+5K5BlntPS7lUhiJrvJl+gbSt5mqE AMe0hSI50PBz/9Qj5ottvsPZdVoSeHEEkA== X-Received: by 2002:a2e:a587:0:b0:25f:e6ac:c287 with SMTP id m7-20020a2ea587000000b0025fe6acc287mr2118171ljp.416.1662629141351; Thu, 08 Sep 2022 02:25:41 -0700 (PDT) Received: from hum-HP-ProBook-440-G7.semihalf.net (apn-46-169-39-115.dynamic.gprs.plus.pl. [46.169.39.115]) by smtp.gmail.com with ESMTPSA id k20-20020a2ea274000000b00261e8e4e381sm3103998ljm.2.2022.09.08.02.25.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Sep 2022 02:25:41 -0700 (PDT) From: Hubert Mazur To: ffmpeg-devel@ffmpeg.org Date: Thu, 8 Sep 2022 11:25:06 +0200 Message-Id: <20220908092507.63319-5-hum@semihalf.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220908092507.63319-1-hum@semihalf.com> References: <20220908092507.63319-1-hum@semihalf.com> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 4/5] lavc/aarch64: Add neon implementation for vsse_intra16 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: gjb@semihalf.com, upstream@semihalf.com, jswinney@amazon.com, Hubert Mazur , martin@martin.st, mw@semihalf.com, spop@amazon.com Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: PVbaoloftRh6 Provide optimized implementation for vsse_intra16 for arm64. Performance tests are shown below. - vsse_4_c: 155.2 - vsse_4_neon: 36.2 Benchmarks and tests are run with checkasm tool on AWS Graviton 3. Signed-off-by: Hubert Mazur --- libavcodec/aarch64/me_cmp_init_aarch64.c | 3 ++ libavcodec/aarch64/me_cmp_neon.S | 63 ++++++++++++++++++++++++ 2 files changed, 66 insertions(+) diff --git a/libavcodec/aarch64/me_cmp_init_aarch64.c b/libavcodec/aarch64/me_cmp_init_aarch64.c index af83f7ed1e..8c295d5457 100644 --- a/libavcodec/aarch64/me_cmp_init_aarch64.c +++ b/libavcodec/aarch64/me_cmp_init_aarch64.c @@ -47,6 +47,8 @@ int vsad_intra16_neon(MpegEncContext *c, const uint8_t *s, const uint8_t *dummy, ptrdiff_t stride, int h) ; int vsse16_neon(MpegEncContext *c, const uint8_t *s1, const uint8_t *s2, ptrdiff_t stride, int h); +int vsse_intra16_neon(MpegEncContext *c, const uint8_t *s, const uint8_t *dummy, + ptrdiff_t stride, int h); av_cold void ff_me_cmp_init_aarch64(MECmpContext *c, AVCodecContext *avctx) { @@ -69,5 +71,6 @@ av_cold void ff_me_cmp_init_aarch64(MECmpContext *c, AVCodecContext *avctx) c->vsad[4] = vsad_intra16_neon; c->vsse[0] = vsse16_neon; + c->vsse[4] = vsse_intra16_neon; } } diff --git a/libavcodec/aarch64/me_cmp_neon.S b/libavcodec/aarch64/me_cmp_neon.S index ce198ea227..cf2b8da425 100644 --- a/libavcodec/aarch64/me_cmp_neon.S +++ b/libavcodec/aarch64/me_cmp_neon.S @@ -784,3 +784,66 @@ function vsad_intra16_neon, export=1 ret endfunc + +function vsse_intra16_neon, export=1 + // x0 unused + // x1 uint8_t *pix1 + // x2 uint8_t *dummy + // x3 ptrdiff_t stride + // w4 int h + + ld1 {v0.16b}, [x1], x3 + movi v16.4s, #0 + movi v17.4s, #0 + + sub w4, w4, #1 // we need to make h-1 iterations + cmp w4, #3 + b.lt 2f + +1: + // v = abs( pix1[0] - pix1[0 + stride] ) + // score = sum( v * v ) + ld1 {v1.16b}, [x1], x3 + ld1 {v2.16b}, [x1], x3 + uabd v30.16b, v0.16b, v1.16b + ld1 {v3.16b}, [x1], x3 + umull v29.8h, v30.8b, v30.8b + umull2 v28.8h, v30.16b, v30.16b + uabd v27.16b, v1.16b, v2.16b + uadalp v16.4s, v29.8h + umull v26.8h, v27.8b, v27.8b + umull2 v27.8h, v27.16b, v27.16b + uadalp v17.4s, v28.8h + uabd v25.16b, v2.16b, v3.16b + uadalp v16.4s, v26.8h + umull v24.8h, v25.8b, v25.8b + umull2 v25.8h, v25.16b, v25.16b + uadalp v17.4s, v27.8h + sub w4, w4, #3 + uadalp v16.4s, v24.8h + cmp w4, #3 + uadalp v17.4s, v25.8h + mov v0.16b, v3.16b + + b.ge 1b + cbz w4, 3f + +// iterate by one +2: + ld1 {v1.16b}, [x1], x3 + subs w4, w4, #1 + uabd v30.16b, v0.16b, v1.16b + mov v0.16b, v1.16b + umull v29.8h, v30.8b, v30.8b + umull2 v30.8h, v30.16b, v30.16b + uadalp v16.4s, v29.8h + uadalp v17.4s, v30.8h + cbnz w4, 2b + +3: + add v16.4s, v16.4s, v17.4S + uaddlv d17, v16.4s + fmov w0, s17 + + ret +endfunc From patchwork Thu Sep 8 09:25:07 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Hubert Mazur X-Patchwork-Id: 37759 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:139a:b0:8f:1db5:eae2 with SMTP id w26csp164417pzh; Thu, 8 Sep 2022 02:26:33 -0700 (PDT) X-Google-Smtp-Source: AA6agR53iU+/fMpGzKRbWvjHLlD4vPx5/3VOYNn1pBdhVjWa2VldijiJL1L5c2xLIl0drkmOHXf1 X-Received: by 2002:a05:6402:3552:b0:448:e395:dc06 with SMTP id f18-20020a056402355200b00448e395dc06mr6369603edd.136.1662629193273; Thu, 08 Sep 2022 02:26:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662629193; cv=none; d=google.com; s=arc-20160816; b=yVKrTDk142wg5QcHFD6/mcwLj2OBhxqmlb39bxQx9zFvn9NWnpMy7zFWaL6qqGnBLd zLk3LOIWRmz4Ke+pRQaNUvxKpLkFrNLtxbo+IBMuj5aOjotRp57QSuIVCS9bh1rDmmc2 bUw4/2VR4Jw2s4NrSV2hikv7TPPD7HiFh818rhmK7rzo2SCSUSmvH+0UCrU2ivXTvPlE b5a/X68g5XAfGrgNsPuQ718NRe4vsTv2GGEfuo3y3eKK2O/VSWMIqHP7CPKk2ppsKgLw yYPUtozRI7fmO4FsFEDtRpPhnMhqyWKYPBWIGakSL4ATZTpni96YrBJek8FcwsWfJfmp 46AQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature:delivered-to; bh=n8B2MRNdk9OCOF/KulXoVJ7BxwptCNHqsb70uktmF3o=; b=o0Ee+sIV4hVz2m/3pQlhC60I45ItUIm8Faly6VUDWQwqw8gy3JwxNeJo9eziQUe4Xj MkRsOsziQPhsj+taYX3Anmif5Tg+Oeq+epLxne3dwcZLxl2l+ZdrIjPWGbAe8p+DiVj9 p+UFhruX11rWCsYUCBNl6iKSBfndsGWChaxveqLbO8bn9xj4yyn0uiPx39GLRe1fFOXf aOu9oqIkxRWaDtVUL8QrDFbJVuluB+20bQJY7Aff34oKz21fBwYo9erUDewK6c3NdJMg lAk6uLcwzRWWRncHNe8pme0GtCn0V0bHLmjlCxswKq6Ldu73lEprGl6rWRtXZ0NHMV9t 5Zyg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@semihalf.com header.s=google header.b=WJkwJO3i; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=semihalf.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id jg32-20020a170907972000b007420947aa83si1603887ejc.193.2022.09.08.02.26.32; Thu, 08 Sep 2022 02:26:33 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@semihalf.com header.s=google header.b=WJkwJO3i; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=semihalf.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A777568BAA0; Thu, 8 Sep 2022 12:25:51 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-lj1-f181.google.com (mail-lj1-f181.google.com [209.85.208.181]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B667D68BA91 for ; Thu, 8 Sep 2022 12:25:44 +0300 (EEST) Received: by mail-lj1-f181.google.com with SMTP id y18so4400171ljh.12 for ; Thu, 08 Sep 2022 02:25:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf.com; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=dIPGEg4kjgmxvuPmr4mYJjLBvOEFwogUCzIVnJMuyfs=; b=WJkwJO3ib6KDhLIQ875T/mqmxBb8DCfqr0+CBezq8FAe+4lfogqfyvB9n5MOWUMz1u UsgjpehD49YHyiUuLHdr2tvPYgR9x8K5ufpOJFqqMXBiA9Ov2Fb3hSCQ3+56thRJuIav rkRfyyKAkJ6JaX9WKpMaiKT8x0vMKahcIVg41oz3/PAzeHVOWN7ywxWRWYXjOzYLbRjp SMhtjNQKw+OqTA63xHSXwmaG0i6NxB4g+Rnnd5RA+fDCADZ36YV/CIVMJBsE583oBs2d sTv3jmXMF66+cM3i5rMYve1Ehup6rPQAjGFLriRfK25/wxpXfpuawId0oFZ7D2j1uj/L 19cQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=dIPGEg4kjgmxvuPmr4mYJjLBvOEFwogUCzIVnJMuyfs=; b=bODsffuOqVqPjOZkWaFgWHUn2RFOKsmx7HuCQo+k2FhjDuElSCEcIOJOXn0hhQMiQ5 KnSGLK71V6xuGRxoYjTzKQ0rWGjn/GkY1KxhRyL60uIQu04qimGKsPJXe6NyeIe4/qES xrBY1P3/Spk3McbIX9vyU3SIE1w/WCzUF/6MhHsVtFKeBwL0QYOQz8clMDZeWlYf1PV6 4awKkbJxF+BvjyjWh4cu500+v2rfVrVwpMCA/oJx6J3d9BfORd8HneKqSNNqy2NR9TEI fWgK8IHh6FJgHJNHAWMU7yhz8C6JNUNLdmzYu8Asg7v8NsyYjruPtEwlhRIj70QF4MD6 ZU/w== X-Gm-Message-State: ACgBeo3+WC8l4H2vaUvS9iUYh+OFyV36ci6zunASyFEE6Crm0VAFtdz9 M4H/zVjKxzywQKq0QNgHILUTRu4ChFGxsQ== X-Received: by 2002:a2e:a812:0:b0:261:8f2d:9530 with SMTP id l18-20020a2ea812000000b002618f2d9530mr2049734ljq.251.1662629143710; Thu, 08 Sep 2022 02:25:43 -0700 (PDT) Received: from hum-HP-ProBook-440-G7.semihalf.net (apn-46-169-39-115.dynamic.gprs.plus.pl. [46.169.39.115]) by smtp.gmail.com with ESMTPSA id k20-20020a2ea274000000b00261e8e4e381sm3103998ljm.2.2022.09.08.02.25.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Sep 2022 02:25:43 -0700 (PDT) From: Hubert Mazur To: ffmpeg-devel@ffmpeg.org Date: Thu, 8 Sep 2022 11:25:07 +0200 Message-Id: <20220908092507.63319-6-hum@semihalf.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220908092507.63319-1-hum@semihalf.com> References: <20220908092507.63319-1-hum@semihalf.com> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 5/5] lavc/aarch64: Provide neon implementation of nsse16 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: gjb@semihalf.com, upstream@semihalf.com, jswinney@amazon.com, Hubert Mazur , martin@martin.st, mw@semihalf.com, spop@amazon.com Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: RfkiZSWilXdW Add vectorized implementation of nsse16 function. Performance comparison tests are shown below. - nsse_0_c: 682.2 - nsse_0_neon: 116.5 Benchmarks and tests run with checkasm tool on AWS Graviton 3. Co-authored-by: Martin Storsjö Signed-off-by: Hubert Mazur --- libavcodec/aarch64/me_cmp_init_aarch64.c | 15 +++ libavcodec/aarch64/me_cmp_neon.S | 122 +++++++++++++++++++++++ 2 files changed, 137 insertions(+) diff --git a/libavcodec/aarch64/me_cmp_init_aarch64.c b/libavcodec/aarch64/me_cmp_init_aarch64.c index 8c295d5457..ade3e9a4c1 100644 --- a/libavcodec/aarch64/me_cmp_init_aarch64.c +++ b/libavcodec/aarch64/me_cmp_init_aarch64.c @@ -49,6 +49,10 @@ int vsse16_neon(MpegEncContext *c, const uint8_t *s1, const uint8_t *s2, ptrdiff_t stride, int h); int vsse_intra16_neon(MpegEncContext *c, const uint8_t *s, const uint8_t *dummy, ptrdiff_t stride, int h); +int nsse16_neon(int multiplier, const uint8_t *s, const uint8_t *s2, + ptrdiff_t stride, int h); +int nsse16_neon_wrapper(MpegEncContext *c, const uint8_t *s1, const uint8_t *s2, + ptrdiff_t stride, int h); av_cold void ff_me_cmp_init_aarch64(MECmpContext *c, AVCodecContext *avctx) { @@ -72,5 +76,16 @@ av_cold void ff_me_cmp_init_aarch64(MECmpContext *c, AVCodecContext *avctx) c->vsse[0] = vsse16_neon; c->vsse[4] = vsse_intra16_neon; + + c->nsse[0] = nsse16_neon_wrapper; } } + +int nsse16_neon_wrapper(MpegEncContext *c, const uint8_t *s1, const uint8_t *s2, + ptrdiff_t stride, int h) +{ + if (c) + return nsse16_neon(c->avctx->nsse_weight, s1, s2, stride, h); + else + return nsse16_neon(8, s1, s2, stride, h); +} diff --git a/libavcodec/aarch64/me_cmp_neon.S b/libavcodec/aarch64/me_cmp_neon.S index cf2b8da425..f8998749a5 100644 --- a/libavcodec/aarch64/me_cmp_neon.S +++ b/libavcodec/aarch64/me_cmp_neon.S @@ -847,3 +847,125 @@ function vsse_intra16_neon, export=1 ret endfunc + +function nsse16_neon, export=1 + // x0 multiplier + // x1 uint8_t *pix1 + // x2 uint8_t *pix2 + // x3 ptrdiff_t stride + // w4 int h + + str x0, [sp, #-0x40]! + stp x1, x2, [sp, #0x10] + stp x3, x4, [sp, #0x20] + str x30, [sp, #0x30] + bl X(sse16_neon) + ldr x30, [sp, #0x30] + mov w9, w0 // here we store score1 + ldr x5, [sp] + ldp x1, x2, [sp, #0x10] + ldp x3, x4, [sp, #0x20] + add sp, sp, #0x40 + + movi v16.8h, #0 + movi v17.8h, #0 + movi v18.8h, #0 + movi v19.8h, #0 + + ld1 {v0.16b}, [x1], x3 + subs w4, w4, #1 // we need to make h-1 iterations + ld1 {v2.16b}, [x2], x3 + ext v1.16b, v0.16b, v0.16b, #1 // x1 + 1 + cmp w4, #2 + ext v3.16b, v2.16b, v2.16b, #1 // x2 + 1 + + b.lt 2f + +// make 2 iterations at once +1: + ld1 {v4.16b}, [x1], x3 + ld1 {v6.16b}, [x2], x3 + ld1 {v20.16b}, [x1], x3 + ext v5.16b, v4.16b, v4.16b, #1 // x1 + stride + 1 + usubl v31.8h, v0.8b, v4.8b + usubl2 v30.8h, v0.16b, v4.16b + ld1 {v22.16b}, [x2], x3 + usubl v29.8h, v1.8b, v5.8b + usubl2 v28.8h, v1.16b, v5.16b + ext v7.16b, v6.16b, v6.16b, #1 // x2 + stride + 1 + saba v16.8h, v31.8h, v29.8h + ext v21.16b, v20.16b, v20.16b, #1 + saba v17.8h, v30.8h, v28.8h + usubl v27.8h, v2.8b, v6.8b + usubl2 v26.8h, v2.16b, v6.16b + ext v23.16b, v22.16b, v22.16b, #1 + usubl v25.8h, v3.8b, v7.8b + usubl2 v24.8h, v3.16b, v7.16b + saba v18.8h, v27.8h, v25.8h + saba v19.8h, v26.8h, v24.8h + + usubl v31.8h, v4.8b, v20.8b + usubl2 v30.8h, v4.16b, v20.16b + usubl v29.8h, v5.8b, v21.8b + usubl2 v28.8h, v5.16b, v21.16b + saba v16.8h, v31.8h, v29.8h + saba v17.8h, v30.8h, v28.8h + usubl v27.8h, v6.8b, v22.8b + usubl2 v26.8h, v6.16b, v22.16b + usubl v25.8h, v7.8b, v23.8b + usubl2 v24.8h, v7.16b, v23.16b + saba v18.8h, v27.8h, v25.8h + saba v19.8h, v26.8h, v24.8h + sub w4, w4, #2 + + mov v0.16b, v20.16b + mov v1.16b, v21.16b + cmp w4, #2 + mov v2.16b, v22.16b + mov v3.16b, v23.16b + + b.ge 1b + cbz w4, 3f + +// iterate by one +2: + ld1 {v4.16b}, [x1], x3 + subs w4, w4, #1 + ld1 {v6.16b}, [x2], x3 + ext v5.16b, v4.16b, v4.16b, #1 // x1 + stride + 1 + usubl v31.8h, v0.8b, v4.8b + ext v7.16b, v6.16b, v6.16b, #1 // x2 + stride + 1 + + usubl2 v30.8h, v0.16b, v4.16b + usubl v29.8h, v1.8b, v5.8b + usubl2 v28.8h, v1.16b, v5.16b + saba v16.8h, v31.8h, v29.8h + saba v17.8h, v30.8h, v28.8h + usubl v27.8h, v2.8b, v6.8b + usubl2 v26.8h, v2.16b, v6.16b + usubl v25.8h, v3.8b, v7.8b + usubl2 v24.8h, v3.16b, v7.16b + saba v18.8h, v27.8h, v25.8h + saba v19.8h, v26.8h, v24.8h + + mov v0.16b, v4.16b + mov v1.16b, v5.16b + mov v2.16b, v6.16b + mov v3.16b, v7.16b + + cbnz w4, 2b + +3: + sqsub v17.8h, v17.8h, v19.8h + sqsub v16.8h, v16.8h, v18.8h + ins v17.h[7], wzr + sqadd v16.8h, v16.8h, v17.8h + saddlv s16, v16.8h + sqabs s16, s16 + fmov w0, s16 + + mul w0, w0, w5 + add w0, w0, w9 + + ret +endfunc