From patchwork Fri Sep 9 22:50:32 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Will Cassella X-Patchwork-Id: 37810 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:139a:b0:8f:1db5:eae2 with SMTP id w26csp1196700pzh; Fri, 9 Sep 2022 15:50:53 -0700 (PDT) X-Google-Smtp-Source: AA6agR7/snk62ppbsrj57q3wS1kEXVHA8wWW2OkC/umwu6/UPNukR/MdfFMYjnRYWtKTJQixkyg3 X-Received: by 2002:a50:ff13:0:b0:43e:76d3:63e1 with SMTP id a19-20020a50ff13000000b0043e76d363e1mr12992995edu.271.1662763853451; Fri, 09 Sep 2022 15:50:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662763853; cv=none; d=google.com; s=arc-20160816; b=DvQujiLI40WM6zJNDEoBem+WqUFq8LWODvVchS1rEboYC31rHl/4n5TuWK54WiT91p Q1q8FRrqw2qaCNPOSP272io3HZs7wLGtHVG1zUFAPLYWYipP+dIZAisEPsvGhEGi/GOl NjYmyx1XYMe9wwhrmmFGo3XedXm9t+0RjKTyu3WA689l49Nqqa1C1wfHX5CUqYRK80pW CRklxwtMEz7bddxAgrM3UnmpI+XXvAOnGz8o/vJfv+ujxiBmTl95p2GYQYkOu4vqH7zM h5xnPEMRMSfY2uF3PoOi3NLk2fQuQ1FdSAc55x0uU4zxWDXsungE2k5rPGLykmiid5NL 38XQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:to:message-id:date:from:mime-version :dkim-signature:delivered-to; bh=HjMNX8emLURXtYmRYjz9GdU4OkRN78k8ITRT0Fg8wCc=; b=w60m58Y7I5on9ltM/la77tSVVLySoWhvJeY82FfH/jXWqcJrc8y4DaB4bbBiDpto5i rMwj8JMcC8w1fWAzbgLkEx9FyPP+nqfkZnkkYSCyidn/k1OpWVLn1cwb1REsJucT48O5 Oy+cCpP+YibzvkXkOaObBEV42djbuJoanA7TITve3W3k1fMs80jbPzUy7+KSn9RjuosF HEtwcG+HZ8AYf3YwiFqNRdK/Agvmoh/lIxmf1JkdOOdJVqDmNoz8YBXYgEnuVm1XBk6c +6H8tQwAxnbgkRU0q7HlQPabtySXoEpQ8PltGr4N04pvIhfYNzTqE4r/T6kkLBFPCZ5d Ot/w== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@chromium.org header.s=google header.b=VjTgGTAU; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id k12-20020a50cb8c000000b0043d00293d23si1187756edi.391.2022.09.09.15.50.53; Fri, 09 Sep 2022 15:50:53 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@chromium.org header.s=google header.b=VjTgGTAU; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 945C168BAE4; Sat, 10 Sep 2022 01:50:50 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-yw1-f169.google.com (mail-yw1-f169.google.com [209.85.128.169]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id AC96668B9F3 for ; Sat, 10 Sep 2022 01:50:44 +0300 (EEST) Received: by mail-yw1-f169.google.com with SMTP id 00721157ae682-333a4a5d495so35228967b3.10 for ; Fri, 09 Sep 2022 15:50:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date; bh=Vr2ug4QA0jSCoBX2PAtmYRo1K8RFQTLugDeIBtoe/o0=; b=VjTgGTAU0EttClcjb1wAmAqdP+zybZXzyW4ZsKFlbHLIqYxK//n1ix559uEWY8XFAP EFPXJX8oWv7xlquo65w+OpcJVA8+KvQLQu+qalHPlAlJALCjlw8MDF5yP8vKXlxk8W7m /xUDBpNsppPsuDzKijWnVHVJaNzGwNdREY4Ng= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date; bh=Vr2ug4QA0jSCoBX2PAtmYRo1K8RFQTLugDeIBtoe/o0=; b=FwTJ4NjEH/EmJ8CUzvQYXNLOhpPjz2y1rED2sjMYeXCG5G5Se+8bMpl9+saxb1Mjbw AG/fnM+WqYT4xiP2LFU+Fk0bRgi11TFzH74CwFcLwT43YunOioK1AfEgtUoP0vlbREkD ZAddgMxDzRN7XLjyFEfSmmYbrhseOW79xhNT6LBFVpSaZthWOD/nsFRvgVQ/KRHw2EkN xfVlKjx48KjPF70CkAQSQlAJqjFlXHmcbgSnAb9wf23CMzUH5y3MucDOkxos7TCPLjq4 06qTqJxXJSnHzaKIehf0g+wE4Doqd7ArMUYSkUhDVfXCUyZwdOhnsrb/YXRQ76C4qta5 E8gw== X-Gm-Message-State: ACgBeo2QHNkD54iudGlroKnA8z3xHf9p3wNewC61T8Zf1qzbrkcHvnSN H1Pe4NZxyNG1E4IScBJC9Xm8FgwDlhu9gUjx4x7/yeTS3YwAxS33e3NXy8aK X-Received: by 2002:a81:df14:0:b0:324:e852:5895 with SMTP id c20-20020a81df14000000b00324e8525895mr13754717ywn.200.1662763842997; Fri, 09 Sep 2022 15:50:42 -0700 (PDT) MIME-Version: 1.0 From: Will Cassella Date: Fri, 9 Sep 2022 22:50:32 +0000 Message-ID: To: ffmpeg-devel@ffmpeg.org Subject: [FFmpeg-devel] [PATCH] libavformat/riffec: Zero-initialize `channels` in `ff_get_wav_header` X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: /etRgBtcU3KY Clang's static analyzer complains that leaving the `channels` variable uninitialized could lead to a code path where the uninitialized value is written to `par->ch_layout.nb_channels` at the end of this function. This patch simply zero-initializes that variable to avoid that. Signed-off-by: Will Cassella --- libavformat/riffdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) if (size < 14) { diff --git a/libavformat/riffdec.c b/libavformat/riffdec.c index 3946ecb72f..fc75500d1f 100644 --- a/libavformat/riffdec.c +++ b/libavformat/riffdec.c @@ -94,7 +94,7 @@ static void parse_waveformatex(AVFormatContext *s, AVIOContext *pb, AVCodecParam int ff_get_wav_header(AVFormatContext *s, AVIOContext *pb, AVCodecParameters *par, int size, int big_endian) { - int id, channels; + int id, channels = 0; uint64_t bitrate = 0;