From patchwork Tue Sep 27 21:06:05 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gustav Grusell X-Patchwork-Id: 38391 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:3b1c:b0:96:9ee8:5cfd with SMTP id c28csp808294pzh; Tue, 27 Sep 2022 14:06:22 -0700 (PDT) X-Google-Smtp-Source: AMsMyM46xtz35A5GTnObToSC8kSbm47/GZ+n++Qa1VHqnYRXdMuEdu7SBnTmo6XRSa3DdAGgNcKf X-Received: by 2002:a17:907:3f28:b0:781:e093:d0db with SMTP id hq40-20020a1709073f2800b00781e093d0dbmr24251142ejc.295.1664312782712; Tue, 27 Sep 2022 14:06:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1664312782; cv=none; d=google.com; s=arc-20160816; b=m5P40Rf8Seb44sJWzdeaiJD/od4RlEJUHtN/OaspTX+t3puPGZoqfqJ1gAb5hX7XDC WkNXuQdY5nsaxGgUMKXzyNB9N9t3wDz8FfqQbmj0nweurvznKrWOlekGgqz3tgOIz/GG 9MGrgb8jkIzi/2+wSJo/UJ+OaZ/bOE4umzmTx5rIBAiH92q5eP26KSe3h24FDcB4kjW/ EnsMqnzRW2X/fCmt4esLEfRj+Cz8xBLfer6ekgPZ2ZPPXg27imbxkl3D+EBDYMJWd4Q8 ETwIr0s59prJGkgI/dRaglISH2K1i1o/bvzRoqGHow5+Gwfv+vrg+5WhGYoU/BfNbOGu Li5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:message-id:date:to:from :dkim-signature:delivered-to; bh=kgXYcqUEL46DgUeSXExxAgv3vikcGtbXM9e9toe9V1k=; b=WDozK5mu9mxbJYlpeRHGUKfz4Z3GQ9GL2Kf/RuSdB8m4cAOaHSOYUUxKMahW3CQjyZ MMeFUMr3DoWrnJXv/+WHCVPm7ue/LQz3X14Fz/w45cnkSSgnYnYYgWXW7vYFGT6UrSuq eUOZMn0IZ3+WhZsEhy03HDKx4mR7j85/7Xk9P+KOJ/AfWGcKdJOhBNE60g6NuWOEuo3b URaI3SMtTU3L/FC2MTt7etBWYTGs5BZU/p1Y0eZc084XNhMlAngj3JY9MtJ7iWUXqJLi mbBIMOmNGYuGdWMEPgmOTNKURjVIqvwOtGm2ITYjV9mps+PSt1dOmTqozplXRKCF8w9R w2jw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20210112 header.b=Z+XkcTOH; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id hq20-20020a1709073f1400b007820e1a4302si2408760ejc.675.2022.09.27.14.06.22; Tue, 27 Sep 2022 14:06:22 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20210112 header.b=Z+XkcTOH; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 56E1468BA88; Wed, 28 Sep 2022 00:06:19 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 40F3F68B3A2 for ; Wed, 28 Sep 2022 00:06:12 +0300 (EEST) Received: by mail-lf1-f50.google.com with SMTP id a3so17480941lfk.9 for ; Tue, 27 Sep 2022 14:06:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date; bh=mDmbN5Yuvi6ZfDAsIC6yOgOUc1SbvOtBfC5yUprFk9U=; b=Z+XkcTOHnqhJ5Y6aNaWKt7dAYBp2X7nzdk6NLLsjzdMPX5M+ChhoVMU+xnb//5AGnb Gs7ZCv0TZFOf6MVcqFjvOnebQXHJ1s/4kDK939YvLn4Z2VvZXPXPYvWyAxh8ynJQsyRw 7UYyQ2wYvFuxUlgGQginKLz1cQVLCyWvw+zfRIeHvTmJGihjzqqu4wm0RKdsptv9WNA/ BKHG7DyrfnCtPUsZ//+5/H3iM1u6N9Y1VUFAb6LWBWV+pRvfddmCeJbcnNTVjnHhfxHN p26NYnz99IJytGWzWzMEuSMYFXbZ6oI18h8E8c9CLl+mPSy0XTviN62LRbMMP1mEqUkW V/ZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date; bh=mDmbN5Yuvi6ZfDAsIC6yOgOUc1SbvOtBfC5yUprFk9U=; b=QM5vBI6Uydr2xzZN+daORruCrZnSg6fmm+7H8uk19Ffor07UkQDdQfUUIRgOW7goDz 3maffNUxnJFjd4fMbm6/YLaC5bvZpD306qAOj82eaCECOAIXK0Z/gFhh0TJVnjV63IPv fEmrHZ0PJVxqDe9uUh+73rWZ1PGeEq1R8rh9kGzd7iAvCvOBQitLrWggDMzGfYP+NJDH A1VyseC8SAHkMowH6jjBXdZexGZx8P+13x/DlF3W5jbXJY+LayHumd3JesiIEazzwIjv /61G5C2klmi+RHQYSrl73YF0pvbgFlnDOJP5RG2DSF55ZFmGAzZgFKd49YqaH5J5uI2S mELA== X-Gm-Message-State: ACrzQf3dem47+qZbzuF4HK7zFRk7WYT+SplPA3GAoRVmQRD8qf1mWaNm 3fwxVE/rl1VZtPFSRlJ1D5pAqcDaLbs= X-Received: by 2002:a05:6512:3d2a:b0:49a:92d:cddd with SMTP id d42-20020a0565123d2a00b0049a092dcdddmr12309481lfv.590.1664312771249; Tue, 27 Sep 2022 14:06:11 -0700 (PDT) Received: from localhost.localdomain (c80-216-190-179.bredband.tele2.se. [80.216.190.179]) by smtp.googlemail.com with ESMTPSA id z18-20020a19f712000000b00494a11c5f52sm262622lfe.256.2022.09.27.14.06.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Sep 2022 14:06:10 -0700 (PDT) From: Gustav Grusell To: ffmpeg-devel@ffmpeg.org Date: Tue, 27 Sep 2022 23:06:05 +0200 Message-Id: <20220927210605.692742-1-gustav.grusell@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] avcodec/libsvtav1: Add support for multipass encoding X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Gustav Grusell Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: S0mq7lux1eYT Implements support for 2-pass CRF and 3-pass VBR by implementing reading and writing of stats file, and passing the pass number on to the encoder. For 3-pass VBR, the first pass should be run with '-pass 1', the second with '-pass 3' and the third with '-pass 2'. Signed-off-by: Gustav Grusell --- libavcodec/libsvtav1.c | 82 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 82 insertions(+) diff --git a/libavcodec/libsvtav1.c b/libavcodec/libsvtav1.c index 2f5634cee0..73fece49b7 100644 --- a/libavcodec/libsvtav1.c +++ b/libavcodec/libsvtav1.c @@ -24,6 +24,7 @@ #include #include +#include "libavutil/base64.h" #include "libavutil/common.h" #include "libavutil/frame.h" #include "libavutil/imgutils.h" @@ -312,6 +313,22 @@ static int config_enc_params(EbSvtAv1EncConfiguration *param, cpb_props->avg_bitrate = avctx->bit_rate; } + if (avctx->flags & AV_CODEC_FLAG_PASS2) { + if (param->rate_control_mode == SVT_AV1_RC_MODE_VBR) { + if (avctx->flags & AV_CODEC_FLAG_PASS1) { + param->pass = 2; + } else { + param->pass = 3; + } + } else { + param->pass = 2; + } + } else if (avctx->flags & AV_CODEC_FLAG_PASS1) { + param->pass = 1; + } else { + param->pass = 0; + } + return 0; } @@ -371,6 +388,34 @@ static av_cold int eb_enc_init(AVCodecContext *avctx) return ret; } + if (svt_enc->enc_params.pass >= 2) { + int decode_size; + + if (!avctx->stats_in) { + av_log(avctx, AV_LOG_ERROR, "No stats file for %s pass\n", + svt_enc->enc_params.pass == 2 ? "second" : "third"); + return AVERROR_INVALIDDATA; + } + + svt_enc->enc_params.rc_stats_buffer.sz = strlen(avctx->stats_in) * 3 / 4; + svt_enc->enc_params.rc_stats_buffer.buf = av_malloc(svt_enc->enc_params.rc_stats_buffer.sz); + if (!svt_enc->enc_params.rc_stats_buffer.buf) { + av_log(avctx, AV_LOG_ERROR, + "Stat buffer alloc (%"SIZE_SPECIFIER" bytes) failed\n", + svt_enc->enc_params.rc_stats_buffer.sz); + svt_enc->enc_params.rc_stats_buffer.sz = 0; + return AVERROR(ENOMEM); + } + decode_size = av_base64_decode(svt_enc->enc_params.rc_stats_buffer.buf, avctx->stats_in, + svt_enc->enc_params.rc_stats_buffer.sz); + if (decode_size < 0) { + av_log(avctx, AV_LOG_ERROR, "Stat buffer decode failed\n"); + return AVERROR_INVALIDDATA; + } + + svt_enc->enc_params.rc_stats_buffer.sz = decode_size; + } + svt_ret = svt_av1_enc_set_parameter(svt_enc->svt_handle, &svt_enc->enc_params); if (svt_ret != EB_ErrorNone) { return svt_print_error(avctx, svt_ret, "Error setting encoder parameters"); @@ -544,6 +589,38 @@ static int eb_receive_packet(AVCodecContext *avctx, AVPacket *pkt) if (headerPtr->flags & EB_BUFFERFLAG_EOS) svt_enc->eos_flag = EOS_RECEIVED; + if (svt_enc->eos_flag == EOS_RECEIVED) { + if (svt_enc->enc_params.pass == 1) { + SvtAv1FixedBuf first_pass_stat; + EbErrorType ret = svt_av1_enc_get_stream_info( + svt_enc->svt_handle, + SVT_AV1_STREAM_INFO_FIRST_PASS_STATS_OUT, + &first_pass_stat); + if (ret == EB_ErrorNone) { + size_t b64_size = AV_BASE64_SIZE(first_pass_stat.sz); + avctx->stats_out = av_malloc(b64_size); + if (!avctx->stats_out) { + av_log(avctx, AV_LOG_ERROR, "Stat buffer alloc (%"SIZE_SPECIFIER" bytes) failed\n", + b64_size); + return AVERROR(ENOMEM); + } + av_base64_encode(avctx->stats_out, b64_size, first_pass_stat.buf, + first_pass_stat.sz); + } + } + if (svt_enc->enc_params.pass == 2) { + size_t b64_size = AV_BASE64_SIZE(svt_enc->enc_params.rc_stats_buffer.sz); + avctx->stats_out = av_malloc(b64_size); + if (!avctx->stats_out) { + av_log(avctx, AV_LOG_ERROR, "Stat buffer alloc (%"SIZE_SPECIFIER" bytes) failed\n", + b64_size); + return AVERROR(ENOMEM); + } + av_base64_encode(avctx->stats_out, b64_size, svt_enc->enc_params.rc_stats_buffer.buf, + svt_enc->enc_params.rc_stats_buffer.sz); + } + } + ff_side_data_set_encoder_stats(pkt, headerPtr->qp * FF_QP2LAMBDA, NULL, 0, pict_type); svt_av1_enc_release_out_buffer(&headerPtr); @@ -564,6 +641,11 @@ static av_cold int eb_enc_close(AVCodecContext *avctx) av_freep(&svt_enc->in_buf); } + if (svt_enc->enc_params.rc_stats_buffer.buf) { + av_freep(&svt_enc->enc_params.rc_stats_buffer.buf); + svt_enc->enc_params.rc_stats_buffer.sz = 0; + } + av_buffer_pool_uninit(&svt_enc->pool); av_frame_free(&svt_enc->frame);