From patchwork Sat Jan 7 03:54:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rui Ueyama X-Patchwork-Id: 39910 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:bc95:b0:ad:ade2:bfd2 with SMTP id fx21csp1606574pzb; Fri, 6 Jan 2023 19:54:48 -0800 (PST) X-Google-Smtp-Source: AMrXdXuucfNXVrQ0g/QN/+d9WVF6MEzoF2w5f/z07aAp4Z8AjG6G39G1Y+3V0WJaAd4tYitLQddU X-Received: by 2002:a17:906:b119:b0:7ff:727f:65cb with SMTP id u25-20020a170906b11900b007ff727f65cbmr48612644ejy.19.1673063688767; Fri, 06 Jan 2023 19:54:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673063688; cv=none; d=google.com; s=arc-20160816; b=nlhYDznIHPq07H5UmcORI2XxFLEfu56EfQlXgDC3HQj52h1JWZcjpD0BrT42eEf2Iy +Tb1auvN+o8QAVXBHfCJvlQ5Ls796Ni2RmEmnkoi4Mn7gN8welqTGcGBw4+ZpwE12Vvf Bg0Fy9k6SB1RoFQJ/2QTzJycfZlFOA54geXitvU2TDhXH5TEHh7jlumpVJ44vFUPXCdo wKyyyGgBIkgSIfwA6r7KOOmZjjaFnjVEnQDsNjEdmCS0fjZ08ZK2DuhDB3rpxgOrnvkQ UaMjp2rivWyrabEYMgvB/+7+FvRfntQFO9Olv95lAO8Q0ekS5Q6YgFepOLhjcGBDzD0R e9ag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:to:message-id:date:from:mime-version :dkim-signature:delivered-to; bh=hSE8zeVe3b1ah8df/AS+bI81ceT4maPOd7ZZ3bt0PT0=; b=XVSYbebG0mFTv6PcEgRcOorDFwW78bdedSvLOJdIXJaVOFfVPQy+tmX6TEzlERfkoV 2OTVz1uHY7TDD2P/rT41iw29sIdo+7IH7XL3yW9xYmTVWmbbvvaWYCutJOfJJYDEQeVU BIo3KLPdcaBvbzvKjxmYu1pHNuciMYCDbOOZ+1i8QguTWLmJ6Ou1/nytR08YZttaEbDK tyDarGy1zj/8+PY/Q3EEfxKiT2iP7xSQ2EXOjcXXYnFX3KO2R6wfKxLPrIvoT/XaEwBE 2zZ2XBp5z/NEU4muHQW8zlTfEvAYA0xvhk3r2rodC63t4QAtu6VksvVE/y5ciTOOqy9k +cww== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20210112 header.b=MUZ2U31M; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id he6-20020a1709073d8600b007e494438499si3572309ejc.166.2023.01.06.19.54.48; Fri, 06 Jan 2023 19:54:48 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20210112 header.b=MUZ2U31M; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9141168BD34; Sat, 7 Jan 2023 05:54:44 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-lj1-f173.google.com (mail-lj1-f173.google.com [209.85.208.173]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E00B368BAE2 for ; Sat, 7 Jan 2023 05:54:37 +0200 (EET) Received: by mail-lj1-f173.google.com with SMTP id n5so2852662ljc.9 for ; Fri, 06 Jan 2023 19:54:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=ugwPq9iIVEe2xzc+8HOmMo4uc315rfyN3kXaDIAzVAg=; b=MUZ2U31MKg/oux4R7BNp69EBarEeqa7B+CwzWCgOb81fTDIDqqc52c5eeiT4sTcqcs HMrGjiZJuU+TaSzY1B+tksG9ggHOqIuJGulhjpF7oZQH/PGW64+k9/9CgxfU0u5yyMSu k3pPVUyW2oyzibgmT8RZMW1yAoux/qLYZZ35w5or1bbTEp2vauj30sECs5+MmhLPa7+B uSeMj5TTZSXLMdaEySlJvttsQBt3LlFoo1fXhQjad1lnW9H5/tdRKER4wCohFsdDFDea NlNQgYAV0JNftdx7LpwlKZdKNWtTuY8W+BNDpI8TaxSbMLO67oT24BCWZuTHYkdP+U7M vDRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=ugwPq9iIVEe2xzc+8HOmMo4uc315rfyN3kXaDIAzVAg=; b=UDywo1Gu7QWQlk1YZCebxjW/VRaJv1TQOp1e4Io2rUsoKM+L5zOA9VLxc/v0E4l8hk MQwaD6PWWcxEuv8r8K9AYzMXtGYC89rYYQewgSKBC6jK/5lafEUIuPKT6sdFfRgVbQow tMGLe/DYaUFrVv9+6b7SZqn5c9/EQwk5qswy9VldA5hgqoyPT0qVgeHRYsXkCXLuSWI1 7j7fdJTzKQiM/W5IYNEev58td/SJ79xA3cLB6nFZXStcVK0qBfQDw4/u2Q7qoaYNgPpi 4SIElIFUdBt4nbdBs9+BXJBUZXhmTDehsgjWG8iuDpIPlr22lwy8DRN2/QeePYsm2+Bz 7I9A== X-Gm-Message-State: AFqh2koz2EmojpQRyPYQD4Y03xXgMXmLCHgnifHRdmWfP+mpKemED7I/ 6ou7BreXTgHycogT0gpDJNxo5LluMkXN4L01MwnaVpoK70EQqA== X-Received: by 2002:a2e:8742:0:b0:27f:da32:be4f with SMTP id q2-20020a2e8742000000b0027fda32be4fmr1839222ljj.256.1673063676701; Fri, 06 Jan 2023 19:54:36 -0800 (PST) MIME-Version: 1.0 From: Rui Ueyama Date: Sat, 7 Jan 2023 11:54:24 +0800 Message-ID: To: ffmpeg-devel@ffmpeg.org Subject: [FFmpeg-devel] [PATCH] arm32/neon: Avoid using bge/beq for function calls X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: gwshRJnrQyls It looks like compiler-generated code always uses `b`, `bl` or `blx` instructions for function calls. These instructions have a 24-bit immediate and therefore can jump anywhere between PC +- 16 MiB. This hand-written assembly code instead uses `bge` and `beq` for interprocedural jumps. Since these instructions have only a 19-bit immediate (we have less bits for condition code), they can jump only within PC +- 512 KiB. This sometimes causes a "relocation R_ARM_THM_JUMP19 out of range" error when linked with the mold linker. This error can easily be avoided by using `b` instead of `bge` or `beq`. Signed-off-by: Rui Ueyama --- libswresample/arm/audio_convert_neon.S | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) -- 2.34.1 diff --git a/libswresample/arm/audio_convert_neon.S b/libswresample/arm/audio_convert_neon.S index 085d50aafa..3fe114772c 100644 --- a/libswresample/arm/audio_convert_neon.S +++ b/libswresample/arm/audio_convert_neon.S @@ -133,12 +133,13 @@ endfunc function swri_oldapi_conv_fltp_to_s16_nch_neon, export=1 cmp r3, #2 - itt lt - ldrlt r1, [r1] - blt .L_swri_oldapi_conv_flt_to_s16_neon - beq .L_swri_oldapi_conv_fltp_to_s16_2ch_neon + bgt 2f + beq 1f + ldr r1, [r1] + b .L_swri_oldapi_conv_flt_to_s16_neon +1: b .L_swri_oldapi_conv_fltp_to_s16_2ch_neon - push {r4-r8, lr} +2: push {r4-r8, lr} cmp r3, #4 lsl r12, r3, #1 blt 4f