From patchwork Thu Apr 9 15:06:05 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthieu Bouron X-Patchwork-Id: 18796 Return-Path: X-Original-To: patchwork@ffaux-bg.ffmpeg.org Delivered-To: patchwork@ffaux-bg.ffmpeg.org Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by ffaux.localdomain (Postfix) with ESMTP id 6715E44A600 for ; Thu, 9 Apr 2020 18:06:21 +0300 (EEST) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3A3E868B862; Thu, 9 Apr 2020 18:06:21 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B5A3E68B824 for ; Thu, 9 Apr 2020 18:06:14 +0300 (EEST) Received: by mail-wm1-f52.google.com with SMTP id t203so86048wmt.2 for ; Thu, 09 Apr 2020 08:06:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ezKpizG4JhDWPalZASBuzl0eOEo/lxie8/jK+76+VoA=; b=BklNaU0o706Fc9/hsww7AcGJ/IgjWA4ElW5NRKa/qHrgQmqTHll5IRpdb0+kKwtRgQ i1yiYd5RxT0/2aDnr9tIFL2yLLEcDQ7y8PHGobjs3XlAJo2mB7ZR4k9PYi29pklljx12 XVeosRDLBG0FNRV8wf+PfzK2ZFEqWwrNVwew7EuuKXgKLJZy2w4m+/C/D1xRe0k1jsdl D3wGjmF/QQlwrUiX4QJtbfpvgn25gBL6f1fvmRK+zi/CaG5cqWbtI+hCPYnPAmIrIrX/ cvZIjCsHAuIIBSl6C+w/hYLcLcmi3Q0iUJl8E9SlMpoMYDhNneifgmc25WkFL6vnK7Wt sWSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ezKpizG4JhDWPalZASBuzl0eOEo/lxie8/jK+76+VoA=; b=sEGEn3dMNPBChVNqNZ3lwWWZ8rxcKaMsEXJkboApcDVCIomwRm0DZutMlM3AreYxpq KwNuW8uL9KN3ShqsdSkpYs05+rGuzhJ79aGFuKEPyU+OQA1oWP7jMZrHRYJvbJ7r/zc6 j1PPoN1kMb0xhDSXitkDUWifsTbf+fOF4m/HmmOw+PqvueBRdRzErVxPWuCYcNN4We72 iRe58JEQ94MPOJB/dNcqR4Pe9HnTkMOfPL7F2TZe6g8VbN+FZijryTFtaJWiB/67+Xym PV4iQ+qIuwis3AcZnyFO4PasurU4iM5gCEFBzOpzIggJu764eMlWakkRbgFrN9ZrjHXz /IQg== X-Gm-Message-State: AGi0PubVUWbwt2/fsO0+ji8CMAMjq9hMDxrRLBX5bVeWgu40iBsmoGji A2wYh7H/pp2YqbDxgrpEzoKb0osr X-Google-Smtp-Source: APiQypIhtrGqyxnyjNWTYlQuPibcjATQcOMdMJXKb8M4mL6ZhGsu0gpSc9IZ2TWwuGpDGLIOxQSTbw== X-Received: by 2002:a05:600c:295a:: with SMTP id n26mr399656wmd.16.1586444773819; Thu, 09 Apr 2020 08:06:13 -0700 (PDT) Received: from localhost.localdomain (lfbn-idf2-1-500-105.w86-246.abo.wanadoo.fr. [86.246.201.105]) by smtp.gmail.com with ESMTPSA id f2sm4901838wro.59.2020.04.09.08.06.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Apr 2020 08:06:13 -0700 (PDT) From: Matthieu Bouron To: ffmpeg-devel@ffmpeg.org Date: Thu, 9 Apr 2020 17:06:05 +0200 Message-Id: <20200409150605.16270-1-matthieu.bouron@gmail.com> X-Mailer: git-send-email 2.26.0 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] avcodec/mediacodec_wrapper: fix {input, output}_buffers global reference leak X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Matthieu Bouron Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Fixes ticket #8607. --- libavcodec/mediacodec_wrapper.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/libavcodec/mediacodec_wrapper.c b/libavcodec/mediacodec_wrapper.c index 5213cf640a7..79abc8b6aa9 100644 --- a/libavcodec/mediacodec_wrapper.c +++ b/libavcodec/mediacodec_wrapper.c @@ -1303,6 +1303,12 @@ int ff_AMediaCodec_delete(FFAMediaCodec* codec) ret = AVERROR_EXTERNAL; } + (*env)->DeleteGlobalRef(env, codec->input_buffers); + codec->input_buffers = NULL; + + (*env)->DeleteGlobalRef(env, codec->output_buffers); + codec->output_buffers = NULL; + (*env)->DeleteGlobalRef(env, codec->object); codec->object = NULL;