From patchwork Tue Jan 31 12:17:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anton Khirnov X-Patchwork-Id: 40193 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:3ca3:b0:b9:1511:ac2c with SMTP id b35csp4197400pzj; Tue, 31 Jan 2023 04:18:13 -0800 (PST) X-Google-Smtp-Source: AK7set8egZk3yvSPGYf0Nqi08Hse6Z3Qn2CViThsdstdB7OJLPV/t5/LHa/InCmN27JxZPv9H2Um X-Received: by 2002:a05:6402:1346:b0:4a2:4020:82ed with SMTP id y6-20020a056402134600b004a2402082edmr9224331edw.39.1675167493182; Tue, 31 Jan 2023 04:18:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675167493; cv=none; d=google.com; s=arc-20160816; b=UvZ/eFxtWyKurE2B3eLdznGY9s7F8AGAfoioTWhxah74MoVgGjAsf8b5QPPa6X2Ogi M784Vra1upKtEUI2ym15uw+BR3in6vlpaEBJV6NcBIRgRlVqvLkXXZ1dko37qYR0wkYX OIiCW/1rty/L1ojwMrLkUlwnw3HF6A+/GTiTJJ+Xb6IX8gOVlkLbs04Hn9Gh6MKck8GH P8e+kW9UFxPIzfE/F9q0UYnNQ5PUxXu7B5UheibA1YtNTgfzrCrMwXpXzA824kwxU7u6 m8h1j/G8kDoj6m+qkrRVqP4Yaa8T/ND0gxJvEdBulivYrvyZ0dytWIkeCXcqEIX7zJly vCmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:message-id:date:to:from :delivered-to; bh=SUKKqBEQuQKBqvRZhg1eHwT9NfRG1m/Hcbpxq5MyIEk=; b=ZclshjQY5c+1x62FQqbWsqGuxT4DtzSi+h1T7uLtDGHaWoD/OLJ0BSnmTaahdlO83R 25XiwrsZ9sXQ0wx3fPH5zCa3mH/YPS5DYF3uIiwwlY+oWIGiojqhqnWQNq3mpqYYX9xa 9FUtSBfecOexkIGqm0YY0yNbuuT+MrZk+Vm0gxsmQwf0Nxh7NfRlKijTjMgck6b6TgKM wNjHUXpNBZZtk+uRou9Y8U0IauM8BHsO8Gdt1Cy7vZglLFvRJNxx5GL78Yz+V4NwMN60 AZCLQbs7Bd0x6FWX9t2B6FHk2HDniUB4BfE6daj9hs+aF1aZd3tpOsK+OcFX535JQYWt L6vQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id y8-20020a50eb08000000b004a24e51305esi5162307edp.111.2023.01.31.04.18.12; Tue, 31 Jan 2023 04:18:13 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8550668BDE8; Tue, 31 Jan 2023 14:18:08 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C688368BD87 for ; Tue, 31 Jan 2023 14:18:01 +0200 (EET) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 3608E2404EC for ; Tue, 31 Jan 2023 13:18:01 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id TvNlfOZPxGNd for ; Tue, 31 Jan 2023 13:18:00 +0100 (CET) Received: from libav.khirnov.net (libav.khirnov.net [IPv6:2a00:c500:561:201::7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "libav.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 3F622240178 for ; Tue, 31 Jan 2023 13:18:00 +0100 (CET) Received: from libav.khirnov.net (libav.khirnov.net [IPv6:::1]) by libav.khirnov.net (Postfix) with ESMTP id E33093A0191 for ; Tue, 31 Jan 2023 13:17:59 +0100 (CET) From: Anton Khirnov To: ffmpeg-devel@ffmpeg.org Date: Tue, 31 Jan 2023 13:17:56 +0100 Message-Id: <20230131121756.1212-1-anton@khirnov.net> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] lavc: deprecate CrystalHD decoders X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: +BSSG41vDsVW The hardware is old and not relevant today. The decoders also have many special quirks and are effectively unmaintained. --- Philip confirmed on IRC that he no longer has the hardware for maintaining this and does not believe it is relevant today. --- Changelog | 1 + MAINTAINERS | 2 -- configure | 4 +++- libavcodec/crystalhd.c | 4 ++++ libavcodec/version_major.h | 3 +++ 5 files changed, 11 insertions(+), 3 deletions(-) diff --git a/Changelog b/Changelog index aa0dad13a1..323effec05 100644 --- a/Changelog +++ b/Changelog @@ -35,6 +35,7 @@ version : - ffmpeg CLI new options: -enc_stats_pre[_fmt], -enc_stats_post[_fmt] - hstack_vaapi, vstack_vaapi and xstack_vaapi filters - XMD ADPCM decoder and demuxer +- CrystalHD decoders deprecated version 5.1: diff --git a/MAINTAINERS b/MAINTAINERS index 48e2ec4fd4..f87d43fce5 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -151,7 +151,6 @@ Codecs: ccaption_dec.c Anshul Maheshwari, Aman Gupta cljr Alex Beregszaszi cpia.c Stephan Hilb - crystalhd.c Philip Langdale cscd.c Reimar Doeffinger cuviddec.c Timo Rothenpieler dca* foo86 @@ -265,7 +264,6 @@ Codecs: xwd* Paul B Mahol Hardware acceleration: - crystalhd.c Philip Langdale dxva2* Hendrik Leppkes, Laurent Aimar, Steve Lhomme d3d11va* Steve Lhomme mediacodec* Matthieu Bouron, Aman Gupta diff --git a/configure b/configure index 47790d10f5..a4ce3b5b32 100755 --- a/configure +++ b/configure @@ -6999,7 +6999,9 @@ enabled vdpau && enabled vdpau && check_lib vdpau_x11 "vdpau/vdpau.h vdpau/vdpau_x11.h" vdp_device_create_x11 -lvdpau -lX11 -enabled crystalhd && check_lib crystalhd "stdint.h libcrystalhd/libcrystalhd_if.h" DtsCrystalHDVersion -lcrystalhd +enabled crystalhd && check_lib crystalhd "stdint.h libcrystalhd/libcrystalhd_if.h" DtsCrystalHDVersion -lcrystalhd && \ + warn "CrystalHD support is deprecated and will be removed, please contact the developers if you are interested" \ + "in maintaining it." if enabled vulkan; then check_pkg_config_header_only vulkan "vulkan >= 1.2.189" "vulkan/vulkan.h" "defined VK_VERSION_1_2" || diff --git a/libavcodec/crystalhd.c b/libavcodec/crystalhd.c index 8673a491d4..688cdffbcb 100644 --- a/libavcodec/crystalhd.c +++ b/libavcodec/crystalhd.c @@ -329,6 +329,10 @@ static av_cold int init(AVCodecContext *avctx) av_log(avctx, AV_LOG_VERBOSE, "CrystalHD Init for %s\n", avctx->codec->name); + av_log(avctx, AV_LOG_WARNING, "CrystalHD support is deprecated and will " + "be removed. Please contact the developers if you are interested in " + "maintaining it.\n"); + avctx->pix_fmt = AV_PIX_FMT_YUYV422; /* Initialize the library */ diff --git a/libavcodec/version_major.h b/libavcodec/version_major.h index 2c0443c4c8..f38566f62c 100644 --- a/libavcodec/version_major.h +++ b/libavcodec/version_major.h @@ -55,4 +55,7 @@ #define FF_API_VT_HWACCEL_CONTEXT (LIBAVCODEC_VERSION_MAJOR < 60) #define FF_API_AVCODEC_CHROMA_POS (LIBAVCODEC_VERSION_MAJOR < 60) +// reminder to remove CrystalHD decoders on next major bump +#define FF_CODEC_CRYSTAL_HD (LIBAVCODEC_VERSION_MAJOR < 61) + #endif /* AVCODEC_VERSION_MAJOR_H */