From patchwork Wed Mar 1 15:44:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: jackarain X-Patchwork-Id: 40561 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:d046:b0:cd:afd7:272c with SMTP id hv6csp3561532pzb; Wed, 1 Mar 2023 07:45:19 -0800 (PST) X-Google-Smtp-Source: AK7set/9qZXDK06u/eeKaKdbNpnEdtGmV7Ht43fWY//cltKLF9ZTi0EVekcpFmfq1lmi4RDkV2c5 X-Received: by 2002:a17:906:7c8:b0:8b1:a3c7:a9c9 with SMTP id m8-20020a17090607c800b008b1a3c7a9c9mr5941492ejc.70.1677685519606; Wed, 01 Mar 2023 07:45:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677685519; cv=none; d=google.com; s=arc-20160816; b=HEgJCUx/zR+Fv4lNsp7/32hJVL0soJRIYfBv/4Rl17R3U1os6kFABY2jJdynMqTf7G tzNmFoj33kCrB06qvmzwpo0GjEcMmHrD+6bzppBbFr6ZGogqiYB2Bs1mnWX2jqZTiQ7R V/hHU2Q+aDvAHPIoXmrF6i7PelYLkJSrlCln0G8RjJc8VYmYjlc2n2YcRRByWKXnuLK0 2ub8fXAAR0uSm/jR1yKkdOHiHMBE1S6QiTMOtnN4vLnF2OhnMs1Xua8QSNgtuYEKyBe1 rP29MRpf6QPvS7XHfQOWDeyfNLy3ZEy5vo72HA1w/eEMNbPmOs1NWcfTxXwNeaGbMb+o YUVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature:delivered-to; bh=MNDEpmbiNsedI1qrNO7/ur57iYXfAo8cHHqZyRIwhkw=; b=vSuVuDsJmhII++Nfl4ypsW+S7oQEkRCoc0bMjR/sur5vgxEZn/MbIZgylZbAt+xSSl dG/k77hFvivv7ujFdqil/JwzN3u4kzw16gQRwiAPaghM5D8BW6XWjDPFi/D4ETpaWHoc BcvT1kxRrll6xbvgGS2mWyWmCMdQFNYe+ihXydwNv3beyLqs1hRln3I5gIJLt/r6Qowy Ja4DnRJBP4jzvUtL3fb6hkxkL7Rp9d/JBoNr2RqsjJ/rzJC+36HdYGFKyKRaX0o3mOXb si0RxAVy0yg1SBvii6kC9V09x4SdfZJ+rhp+PJeW/GeglXXErwVLv3FNkgqQp5As8IXR uDcg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20210112 header.b=HilmW83+; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id p23-20020a17090653d700b008f100fd5096si1606634ejo.887.2023.03.01.07.45.18; Wed, 01 Mar 2023 07:45:19 -0800 (PST) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20210112 header.b=HilmW83+; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id AD16C68ABFF; Wed, 1 Mar 2023 17:45:15 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id ECC9068086D for ; Wed, 1 Mar 2023 17:45:08 +0200 (EET) Received: by mail-pj1-f54.google.com with SMTP id l1so13774373pjt.2 for ; Wed, 01 Mar 2023 07:45:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JpaAeXqqoMOTTg1UQFdVAW4bCtPssGYBRoLtwapXkFQ=; b=HilmW83+amcZf9qjGngq/IuEChDLMbyUWJLEVjBbvbuBnmyS4OfXvvYhwBq/k/N2ae yMAfRYLeiYozFNdVXSS//myc5VaQ2BZdlhch/HwmDGflmZHt7qY7UYtQ1198Yw9SI0nN ytowDQZVHfh1UL9lv7Z/dTpUkg9MEWR3ZTzrVr64OZMju1NQdwF7rAg2JRZdTj9WGvKe d49hzHH8a5caW5ZMEuOnJlzOs2YstXejZKIzvLURh6SN0oGMgQZ0JRo8odK6hzBCIuo5 Vnxa5k/ducvxFDR5Jhn5sK9nGhpG/QkKykcUO5jOh5/JlbN1zVEdJM6mBcoABt2uPXwt V2Mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JpaAeXqqoMOTTg1UQFdVAW4bCtPssGYBRoLtwapXkFQ=; b=69TuFXA2TcMIf7ssJmmg6VVcNLVrnW8RjQSYFZu8tiAkhqFiCPH2B62Bpo1lxw0qpv RQGskChNA7nDsD0K82aqwvo7xQvppRv/QUhDPlS+YNo+7NQE46BkbRUT2tg1sMoHoAUG Y++lpoixvli9KrA6hRL+dgyVMWA1shqhPpAH5Kfrs7NjuoUc/UqbXEzEZK+mwkYIRJi8 4t1guOnpivQjN9NsgkOrQA68D9Ewng+lQ6B69si4am0pgYUcHtLIQn9s1dAt/JPP2tkW fFJlGfZuzOmx7AdaLpUGVFRROdtJ1YN3oRRuENtaBFaqvwU2vC/Z17fif9pNOOHBlVcc 1vsg== X-Gm-Message-State: AO0yUKW6lLPsRN6ILgXkdVpWaOJVOxPylj5045mK78SGHv4qdAnfPS4x 5nB+zvhHdJAfMBsio3gUKVTraKl/Rn/MNREm X-Received: by 2002:a17:90b:384d:b0:230:cd41:bbdf with SMTP id nl13-20020a17090b384d00b00230cd41bbdfmr8019700pjb.26.1677685506685; Wed, 01 Mar 2023 07:45:06 -0800 (PST) Received: from localhost.localdomain ([2409:8a28:5083:e220::51b]) by smtp.gmail.com with ESMTPSA id cv23-20020a17090afd1700b0023747b0445fsm10145462pjb.14.2023.03.01.07.45.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Mar 2023 07:45:06 -0800 (PST) From: jackarain To: ffmpeg-devel@ffmpeg.org Date: Wed, 1 Mar 2023 23:44:56 +0800 Message-Id: <20230301154456.3407862-1-jack.wgm@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230301150757.3309799-1-jack.wgm@gmail.com> References: <20230301150757.3309799-1-jack.wgm@gmail.com> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] libavformat/tcp: add local_addr/local_port for network option X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: jackarain Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: lR5lRl0CpWxo Signed-off-by: jackarain --- doc/protocols.texi | 6 +++++ libavformat/network.c | 14 ++++++++---- libavformat/network.h | 2 +- libavformat/tcp.c | 53 ++++++++++++++++++++++++++++++++++++++++++- 4 files changed, 69 insertions(+), 6 deletions(-) diff --git a/doc/protocols.texi b/doc/protocols.texi index 21ae6181a0..b3fad55591 100644 --- a/doc/protocols.texi +++ b/doc/protocols.texi @@ -1882,6 +1882,12 @@ The list of supported options follows. Listen for an incoming connection. 0 disables listen, 1 enables listen in single client mode, 2 enables listen in multi-client mode. Default value is 0. +@item local_addr=@var{addr} +Local IP address of a network interface used for tcp socket connect. + +@item local_port=@var{port} +Local port used for tcp socket connect. + @item timeout=@var{microseconds} Set raise error timeout, expressed in microseconds. diff --git a/libavformat/network.c b/libavformat/network.c index 21e20b3e9a..de8b14be82 100644 --- a/libavformat/network.c +++ b/libavformat/network.c @@ -356,7 +356,7 @@ struct ConnectionAttempt { static int start_connect_attempt(struct ConnectionAttempt *attempt, struct addrinfo **ptr, int timeout_ms, URLContext *h, - void (*customize_fd)(void *, int), void *customize_ctx) + int (*customize_fd)(void *, int), void *customize_ctx) { struct addrinfo *ai = *ptr; int ret; @@ -371,8 +371,14 @@ static int start_connect_attempt(struct ConnectionAttempt *attempt, ff_socket_nonblock(attempt->fd, 1); - if (customize_fd) - customize_fd(customize_ctx, attempt->fd); + if (customize_fd) { + ret = customize_fd(customize_ctx, attempt->fd); + if (ret) { + closesocket(attempt->fd); + attempt->fd = -1; + return ret; + } + } while ((ret = connect(attempt->fd, ai->ai_addr, ai->ai_addrlen))) { ret = ff_neterrno(); @@ -402,7 +408,7 @@ static int start_connect_attempt(struct ConnectionAttempt *attempt, int ff_connect_parallel(struct addrinfo *addrs, int timeout_ms_per_address, int parallel, URLContext *h, int *fd, - void (*customize_fd)(void *, int), void *customize_ctx) + int (*customize_fd)(void *, int), void *customize_ctx) { struct ConnectionAttempt attempts[3]; struct pollfd pfd[3]; diff --git a/libavformat/network.h b/libavformat/network.h index 71c49a73fb..8a8cbe672e 100644 --- a/libavformat/network.h +++ b/libavformat/network.h @@ -336,6 +336,6 @@ void ff_log_net_error(void *ctx, int level, const char* prefix); */ int ff_connect_parallel(struct addrinfo *addrs, int timeout_ms_per_address, int parallel, URLContext *h, int *fd, - void (*customize_fd)(void *, int), void *customize_ctx); + int (*customize_fd)(void *, int), void *customize_ctx); #endif /* AVFORMAT_NETWORK_H */ diff --git a/libavformat/tcp.c b/libavformat/tcp.c index a11ccbb913..a897174f6c 100644 --- a/libavformat/tcp.c +++ b/libavformat/tcp.c @@ -36,6 +36,8 @@ typedef struct TCPContext { const AVClass *class; int fd; int listen; + char *local_port; + char *local_addr; int open_timeout; int rw_timeout; int listen_timeout; @@ -52,6 +54,8 @@ typedef struct TCPContext { #define E AV_OPT_FLAG_ENCODING_PARAM static const AVOption options[] = { { "listen", "Listen for incoming connections", OFFSET(listen), AV_OPT_TYPE_INT, { .i64 = 0 }, 0, 2, .flags = D|E }, + { "local_port", "Local port", OFFSET(local_port), AV_OPT_TYPE_STRING, { .str = NULL }, 0, 0, .flags = D|E }, + { "local_addr", "Local address", OFFSET(local_addr), AV_OPT_TYPE_STRING, { .str = NULL }, 0, 0, .flags = D|E }, { "timeout", "set timeout (in microseconds) of socket I/O operations", OFFSET(rw_timeout), AV_OPT_TYPE_INT, { .i64 = -1 }, -1, INT_MAX, .flags = D|E }, { "listen_timeout", "Connection awaiting timeout (in milliseconds)", OFFSET(listen_timeout), AV_OPT_TYPE_INT, { .i64 = -1 }, -1, INT_MAX, .flags = D|E }, { "send_buffer_size", "Socket send buffer size (in bytes)", OFFSET(send_buffer_size), AV_OPT_TYPE_INT, { .i64 = -1 }, -1, INT_MAX, .flags = D|E }, @@ -70,9 +74,42 @@ static const AVClass tcp_class = { .version = LIBAVUTIL_VERSION_INT, }; -static void customize_fd(void *ctx, int fd) +static int customize_fd(void *ctx, int fd) { TCPContext *s = ctx; + + if (s->local_addr || s->local_port) { + struct addrinfo hints = { 0 }, *ai, *cur_ai; + int ret; + + hints.ai_family = AF_UNSPEC; + hints.ai_socktype = SOCK_STREAM; + + ret = getaddrinfo(s->local_addr, s->local_port, &hints, &ai); + if (ret) { + av_log(ctx, AV_LOG_ERROR, + "Failed to getaddrinfo local addr: %s port: %s err: %s\n", + s->local_addr, s->local_port, gai_strerror(ret)); + return ret; + } + + cur_ai = ai; + while (cur_ai) { + ret = bind(fd, (struct sockaddr *)cur_ai->ai_addr, (int)cur_ai->ai_addrlen); + if (ret) + cur_ai = cur_ai->ai_next; + else + break; + } + freeaddrinfo(ai); + + if (ret) { + av_log(ctx, AV_LOG_ERROR, + "Failed to bind local addr: %s port: %s err: %s\n", + s->local_addr, s->local_port, gai_strerror(ret)); + return ret; + } + } /* Set the socket's send or receive buffer sizes, if specified. If unspecified or setting fails, system default is used. */ if (s->recv_buffer_size > 0) { @@ -97,6 +134,8 @@ static void customize_fd(void *ctx, int fd) } } #endif /* !HAVE_WINSOCK2_H */ + + return 0; } /* return non zero if error */ @@ -129,6 +168,18 @@ static int tcp_open(URLContext *h, const char *uri, int flags) if (buf == endptr) s->listen = 1; } + if (av_find_info_tag(buf, sizeof(buf), "local_port", p)) { + av_freep(&s->local_port); + s->local_port = av_strdup(buf); + if (!s->local_addr) + return AVERROR(ENOMEM); + } + if (av_find_info_tag(buf, sizeof(buf), "local_addr", p)) { + av_freep(&s->local_addr); + s->local_addr = av_strdup(buf); + if (!s->local_addr) + return AVERROR(ENOMEM); + } if (av_find_info_tag(buf, sizeof(buf), "timeout", p)) { s->rw_timeout = strtol(buf, NULL, 10); }