From patchwork Wed Mar 15 16:27:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhao Zhili X-Patchwork-Id: 40686 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:d046:b0:cd:afd7:272c with SMTP id hv6csp3562098pzb; Wed, 15 Mar 2023 09:28:20 -0700 (PDT) X-Google-Smtp-Source: AK7set92Ul7MXFUgUKSH2U4Uj6blxsfLWSOvylvvoyfEkKOndoOPZf1XgWK/zOaftX23jIKuTRRL X-Received: by 2002:a50:ff08:0:b0:4fd:14d5:bb47 with SMTP id a8-20020a50ff08000000b004fd14d5bb47mr3105238edu.38.1678897700384; Wed, 15 Mar 2023 09:28:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678897700; cv=none; d=google.com; s=arc-20160816; b=GrSj8ND14b68/baf0eHfWxM/010HC2lC86J84vZSDbpDjXk3BzlnRQKPUqUmXzWS5q UCWWAAhX0u0qbW62Hoy6+WVEjJaDaw1b8A5IVc9hViD/33XCYnSo8oTFlkgsqEEbSwpY 1oYVtik2vJnAMdA4dq8xPuXZ6LKchd7iSqlcFTyNih0HZutZ5ZuvD2BYv33KPOQc0xl/ JBhWoCwVO6sSFXpJ5IvuVf3UzPMrX+tNjh9ExHv+c6zPx34mOpCKcEtuZ9JI/no5bFZ0 R16PPAeSGwx9oLAmCukwQNHOuqcwCDEwN4jKvS8y1nBAShdkN2aVIxeeHocHWMhIXuY9 biGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:date:to:from:message-id :dkim-signature:delivered-to; bh=Y3ttAveHXM8AMtfDrLzg3rwbi5QmzyWu3MB1zthxTaE=; b=KjVgd0xHccvqTw+4kQS6OF19NCg1yo0KiPi8PcA8ClC+mzwDpsR/5BFodEtGluk+rU DFXLrv17fiwn+eQ5bhZgvszRSf3OvY7dMvKnVb7omB4Ru5LcgLvtHDT5C7qc8xBaEuc6 oH8ns5AKYa36ASc6J9R0r6PeYsUJ6cJ8ZqCkg0K7ZkxDOkyqW3E9xLPI8XYvSVGZgowT ZvtKUE0l/OAsfXW/JKy9T/AXExqmhopkqFRNxEqfVEaSXt6xPXMwa+nlEFZRcB+07lHj /I5Wp2xf49l92h+GF+6HwjOaTBphnAi+Mce8JYXjUL2ZFi5+da4MR+P61Z27bix7GVip k6Dg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@foxmail.com header.s=s201512 header.b=WLQbI3q7; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=foxmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id y13-20020aa7cccd000000b004ff7e44fa34si3116283edt.155.2023.03.15.09.28.19; Wed, 15 Mar 2023 09:28:20 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@foxmail.com header.s=s201512 header.b=WLQbI3q7; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=foxmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6090168BE16; Wed, 15 Mar 2023 18:28:15 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from out203-205-221-202.mail.qq.com (out203-205-221-202.mail.qq.com [203.205.221.202]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E485868B680 for ; Wed, 15 Mar 2023 18:28:07 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1678897677; bh=DMnoNhFDRW67yGAnQsJQYsU9zVopBVBRDHoT+V+2h8A=; h=From:To:Cc:Subject:Date; b=WLQbI3q7fKr84uIKYPO1GYLP+Dw2jLGF833eLKBNYfvNpvxbbXB8SZgzmbC2FHX8q xmuEC9tzxFav9Zxg3ax9/PKn/+BYHeJSO8SVGHyfNFLCmIsKm6C4wkBNR0rK/7IE7m 6WqAhMduvLAPryISMoIX78ZdcU0j07RiREVsAMhI= Received: from localhost.localdomain ([113.118.114.71]) by newxmesmtplogicsvrsza12-0.qq.com (NewEsmtp) with SMTP id 6F8ACC21; Thu, 16 Mar 2023 00:27:56 +0800 X-QQ-mid: xmsmtpt1678897676t8ik3srln Message-ID: X-QQ-XMAILINFO: N26DAMVpW7UE+rtOvPzaC0TER9N+elPivcWGjtr7pP00EH3xK3oItHFXWc1vgU jHezutFy6HEk7Il2nHtxSjqGSxB3p21zE/I7/vPKZV2SkrO7aCC+Wo5V8YfAJHJlJ6NGmzrlYCax OAH53Eo5vYPzLjBtnPyYIK6GRguE3JA3QUxhJ4aF6++qrbtranDIZF0/k/kgVGDPzJJxV9wFCgbN DBPTaOZ+0krJcNG45So+jrbiBMDlrN0ywcfw1/vR3lq6S/o38ihEn9ivwfn9njRvvltehqiIJCht Lw17iXVAvt6LuYmlsoGyPycMZBHk/9nIfspvEHrCvE0vbdkkF7OB7Ow34TwjyesbViPRcGxMRfV1 uBnTynh5kQJa5fsYy98AsMijQFoeZdVbNESza97tmTEFysgnYbPzYlTXT5VUZvON1z11DJzea21w sm3Suyld7mr3AvTnIcf6r/Uti279OPuMwtz5AkQpx9guq/pwmltjSIO8VFeXv5caZB9Lz1vh/a3Z xmH45UlIvdEarkDMVk5eu0wwd9ivLqOT2O80CJFSPJe9hKpIrh161f5XkiNp/quJHRZf+U4SKz6r 3pPvJYZ1B8gyOrNEQBvNV/9acoMjQONvOAuPwxa96GThrxmdL/Je59jXKEmoWxQHzZCnNMoqNsGx rIFSaIUCR1odoI8TzntCvpznuKFolG6//YK7uaDEYdQkAqEhzC7jSzVc+ssfjs4oofP50jewEi+d Ty3nfb1dpVnFxzIRyIh4+Jajc0pxGkimVv9SbORDpM7tQRBoYmi4hEdmjNkuk6eIFrrQcVo9k2aE LBlG44WFoBzGhVN0DmWXpoX02vQVGdcr2EpkZDjnGYnNNeHLD8AzEjcn/rmkW/yPujCjjRxrGppj k0GwKnAg3B134m7q0cDdVN254o/ArbBtNin3O8A9aWfHzRPfvscvfimwDsDbchv3LLARVNEisDU/ 91v31cPwAwwe3w3hBSDQ== From: Zhao Zhili To: ffmpeg-devel@ffmpeg.org Date: Thu, 16 Mar 2023 00:27:51 +0800 X-OQ-MSGID: <20230315162752.385634-1-quinkblack@foxmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 1/2] avformat/flvenc: use extract_extradata bsf when necessary X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Zhao Zhili Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: 3MGt+sWSpoc9 From: Zhao Zhili --- libavformat/flvenc.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/libavformat/flvenc.c b/libavformat/flvenc.c index 64ea554dad..fbf7eabaf8 100644 --- a/libavformat/flvenc.c +++ b/libavformat/flvenc.c @@ -1023,13 +1023,15 @@ fail: static int flv_check_bitstream(AVFormatContext *s, AVStream *st, const AVPacket *pkt) { - int ret = 1; - if (st->codecpar->codec_id == AV_CODEC_ID_AAC) { if (pkt->size > 2 && (AV_RB16(pkt->data) & 0xfff0) == 0xfff0) - ret = ff_stream_add_bitstream_filter(st, "aac_adtstoasc", NULL); + return ff_stream_add_bitstream_filter(st, "aac_adtstoasc", NULL); } - return ret; + if (!st->codecpar->extradata_size && + (st->codecpar->codec_id == AV_CODEC_ID_H264 || + st->codecpar->codec_id == AV_CODEC_ID_MPEG4)) + return ff_stream_add_bitstream_filter(st, "extract_extradata", NULL); + return 1; } static void flv_deinit(AVFormatContext *s) From patchwork Wed Mar 15 16:27:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhao Zhili X-Patchwork-Id: 40687 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:d046:b0:cd:afd7:272c with SMTP id hv6csp3562236pzb; Wed, 15 Mar 2023 09:28:31 -0700 (PDT) X-Google-Smtp-Source: AK7set+iw54Skzq5XNq9DbkR6DWp94dMnoRlnqH+qh+O7aR7NAtrfe00x0OZ7C2aT5bW7Dlazifv X-Received: by 2002:aa7:d60e:0:b0:4fa:ecdc:e44b with SMTP id c14-20020aa7d60e000000b004faecdce44bmr2900521edr.24.1678897711206; Wed, 15 Mar 2023 09:28:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678897711; cv=none; d=google.com; s=arc-20160816; b=OPHRzLmeJ24l5UiVkp37t1ay5gEsgQBP2kZKlL0gNJwf4UuxkcSiZtVnDLX24wPcAy 6e89rCtnEtJpOwFnNm2SljgS7Bh3l3rWD4buGC2yAbWt8FdCfw0XJB6pfZjJpAsQSmsU Z7GkUjWWuIEbXsZIARefsDdQQBwX9P/avnMplIXvktCYd47MiGJoHEqPE3oOWSy3RF7h amuQfRfJtVitC9w4WfZyIcQSIxGP0ABlQBbSbU28kNgz6FrhQiuNaIfM5k018UJHnBaI kVhiwy8apZkAi9bBRam253dwQHATF0yJHtn7nJkpE280AR+tWZSCuuRJ5fVfstYoMduI nl2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:mime-version:references:in-reply-to:date :to:from:message-id:dkim-signature:delivered-to; bh=lLi4GgDEBe4D/aYkZVYYCoswd4+2Eol8j2BTIYkIwv0=; b=pJomiB+y8T+QCR9b+gFirVYcazQa0gpT17OmVCm5UljR+f8UBf45UrIcHH9pikLsB8 5DgJF8V1KiEMC4fFln+3JFGr/qYrv3E6rKuZTIq8isBVhKoV7RpUuxv2K3KEDMqa2nU5 1djIEyLnZ7hvyuFaOiSBqQVZMXBfeeBTM7zHyDYxi4DRjvNYoermwW1dySbGcxT/kfva JvChABCosLlF9om+GYXwzKI77t6Vx2MgNE/9NyG4ZLWxgU18+E1f9hZ5rvfEf7iwWrGn 37+QM1i7eDKM0FLis9Ot5vyMZhxw+Xxo6pyjwcYR+jZtfNqK8OcpYkbfrTAw+sXlomcQ HvVw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@foxmail.com header.s=s201512 header.b=Mp6Am35p; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=foxmail.com Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id q16-20020a1709060e5000b00927fa026899si2467036eji.327.2023.03.15.09.28.30; Wed, 15 Mar 2023 09:28:31 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@foxmail.com header.s=s201512 header.b=Mp6Am35p; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=foxmail.com Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7359668BE68; Wed, 15 Mar 2023 18:28:16 +0200 (EET) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from out203-205-221-209.mail.qq.com (out203-205-221-209.mail.qq.com [203.205.221.209]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E7A6E68BE09 for ; Wed, 15 Mar 2023 18:28:07 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1678897678; bh=0z2+IcgvLOXzpjHkCC7HLaJ4r3t+EFt6al+IrVO1VJk=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Mp6Am35pbJJAzn9G3WCfcPIi847ZTLvOjmDlf87jbkOYsZB2QDbMmAB2txPQgtGEv JKyphI9w6h/fNWQyqZvq73fAwMl69BMkuUMMX+ETN46EEHQaoFKDs8V8uOGDPT9WXk +A0M2Rnk5kjEpeTyD/N/WisS5DjM55r5C8AC9c1I= Received: from localhost.localdomain ([113.118.114.71]) by newxmesmtplogicsvrsza12-0.qq.com (NewEsmtp) with SMTP id 6F8ACC21; Thu, 16 Mar 2023 00:27:56 +0800 X-QQ-mid: xmsmtpt1678897677t0orcwrp9 Message-ID: X-QQ-XMAILINFO: MOpJcPT3Yy24Ynq3KA3zNzZfdGP3OhtQj7XcpknMz/IhuICYK6LUPZGUVvjJik I8nvXbgoz7P6iMqK/G/y+XvYXW0/PU62YB0vmheooNs/C8brOUUKveJvVbUdazzS0QwTs5uahLOv tfPA7O9sPsbmSuqXIlt3MFKUWu3SwyaW1yCanwXjhke68+C26ULqG8G6RI9YJPY65V+tZwJesYmd bsFy+kwoM54LVk+JIyezphbKEsljCPrDRt3BjPFqa8qfMwrLgNUYFlhKxXrZgT0kN+6g7IJMTi3g qdCUIoNC1WtMQhDSv+7rh3cwhsMbQZ4E5OujSg9YMTWKy24SDp8Cc3+pObzEUCr5bnuNZJPAsQFM gT5oYrYSv9JHdVM+aOSVdNWeELF+6kPJvu8RjXq4OMraxVLPRd7+KWade0M2EbyK6YbNpaRQsgzN SAS5YAtAmgIJlafIoT7wKM5iritKMs6uvuCWvnHQ1WgiSOMmkHy0rUapxtZ3XVpNhlIWcXeBcrX8 mGXJ6TJZilC0BeRBDCKJevPQF2w+Gy8iPtDtp6Pya5CXTVIzSDMPJc2XAA55KnfSZ2up+YEie8N1 E49io+ca9BdbY2gX/07wva8dYraM5g6Ky4isCsKaES9rMtfNhLHBxXze8yi5WhWXie+dXBgfBwRL eVbNDO2NenkFQetcZWttKDonyZrdM7/gcMJN6KRR/xvAgH9fyJ4l91MrJ4emtMwC1mlHDAN0YBuu jDI4AamyG8gJW/UIEhuoffNQNUwMKzGzcqjlhMYim+iusivaiY63IvcfzfWgZwr11FGkKIt6oGCa eOpiZ0cmnwfFpYCcdeC9MiUkRQiw0mz0QA295lx99vHQTn01eoDPByyd3nfz1QSm7Mfu/2D4/Iik V0qXj/A6ERvAbfuMAaMCRh4EnbZpksi3arRK1sVW4Xe9Sl9pItqMKZqM+3G2/MoQsn7qJXuG+ugF aROAYIaPKiZQuTBFNErx9mZex7Aeuk From: Zhao Zhili To: ffmpeg-devel@ffmpeg.org Date: Thu, 16 Mar 2023 00:27:52 +0800 X-OQ-MSGID: <20230315162752.385634-2-quinkblack@foxmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230315162752.385634-1-quinkblack@foxmail.com> References: <20230315162752.385634-1-quinkblack@foxmail.com> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 2/2] avcodec/mediacodecenc: warning when global header is requested. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Zhao Zhili Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: 5pAxC4Y7I/3+ From: Zhao Zhili Add suggests to use extract_extradata bsf. Signed-off-by: Zhao Zhili --- libavcodec/mediacodecenc.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/libavcodec/mediacodecenc.c b/libavcodec/mediacodecenc.c index 2ab56597fe..27a2cd883d 100644 --- a/libavcodec/mediacodecenc.c +++ b/libavcodec/mediacodecenc.c @@ -317,6 +317,10 @@ static av_cold int mediacodec_init(AVCodecContext *avctx) goto bailout; mediacodec_output_format(avctx); + if (avctx->flags & AV_CODEC_FLAG_GLOBAL_HEADER) + av_log(avctx, AV_LOG_WARNING, + "Mediacodec encoder doesn't support AV_CODEC_FLAG_GLOBAL_HEADER. " + "Use extract_extradata bsf when necessary.\n"); s->frame = av_frame_alloc(); if (!s->frame)