From patchwork Mon May 29 12:49:55 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anton Khirnov X-Patchwork-Id: 41880 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:c51c:b0:10c:5e6f:955f with SMTP id gm28csp1696463pzb; Mon, 29 May 2023 05:50:16 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5uQyb0vAGgaioPFUWCXANeQcwITqRVy2Eg3+gJcVDJKun8XeVcS1qxeCpVN13jCoJ1gZZJ X-Received: by 2002:a17:907:1b24:b0:969:f677:11b4 with SMTP id mp36-20020a1709071b2400b00969f67711b4mr11628856ejc.37.1685364616230; Mon, 29 May 2023 05:50:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685364616; cv=none; d=google.com; s=arc-20160816; b=Pmr5hvky+y3f6zygyr/vVPD6mwR0uL1B3ityBllyIWp5sdX6kD1m924MY65u4FovX0 iuFUBoBnE8+gPqtOMKTnYI/dwJMqgpKXMdtpOGfJ2gnS8pPakKy+A2a9B1gatUf59Utm q2aNnJCbGG80B3tRad9FiQIMWj24R7ftZUwx7PSOedFSBBLxWdLlX0BQXOQzRKCnmdVs SehUWGEHQXqS0wgxBHL+R+G0SlV6E+wU+b0exMHyoBodtctD7uAvWBOiFCKPewaqcVIs sifIekzWwXPa722IE5ka56r7NR3h5UjUThjyDAjWlXGagaW3xnD4QxurCG+tTNHcz3/0 zbSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:references:in-reply-to:message-id :date:to:from:delivered-to; bh=KrwtDZMj3u8mxzYLbPIYEM1ahysF4AcDZIeJB6L6IGQ=; b=XfttO4RgW53Hmsz0ZwN/JC0QccfN5cT4s+EE9JWHUnWpNIr5js3UUkZc3wxsqnwZz9 E1PFJGDknzX77lLUWPj4is5A9+ONg7l5RclbAgVCwxjkOx9EeKySYtqZKEczHjG4O0Pq neMOek8L/TS+nl+6rj6ovghl0c5nxI/wH3wN5ZzcffB6SY8gB/5RDIfc6z6wne+KaDTo rYXQ86RwNP73nSk/D9P5dNxFwnKUp1KD8q+r7VQdWywsSFSam9ekaXSqV3NTM6aIMfX3 biIPp5lqgXqaavnnSxVs/judmgme5zwsPe+xGObpVd0I2Ve97NPazwMutD0ee/SQTYNB QTCg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id wd9-20020a170907d60900b00965cf59bf1bsi6563185ejc.31.2023.05.29.05.50.15; Mon, 29 May 2023 05:50:16 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2ABE168C1E6; Mon, 29 May 2023 15:50:13 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4993868C198 for ; Mon, 29 May 2023 15:50:06 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 924792404EC for ; Mon, 29 May 2023 14:50:05 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id 3K-UllQDZryG for ; Mon, 29 May 2023 14:50:04 +0200 (CEST) Received: from libav.khirnov.net (libav.khirnov.net [IPv6:2a00:c500:561:201::7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "libav.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id B71A2240177 for ; Mon, 29 May 2023 14:50:04 +0200 (CEST) Received: from libav.khirnov.net (libav.khirnov.net [IPv6:::1]) by libav.khirnov.net (Postfix) with ESMTP id 79C5C3A0139 for ; Mon, 29 May 2023 14:49:58 +0200 (CEST) From: Anton Khirnov To: ffmpeg-devel@ffmpeg.org Date: Mon, 29 May 2023 14:49:55 +0200 Message-Id: <20230529124955.16095-1-anton@khirnov.net> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230528194345.GP1391451@pb2> References: <20230528194345.GP1391451@pb2> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] fftools/ffmpeg: rework setting sub2video parameters X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: dEhLsyja9kor Set them in ifilter_parameters_from_dec(), similarly to audio/video streams. This reduces the extent to which sub2video filters need to be treated specially. --- You can also get the updated tree from ffmpeg_sub2video in my repo --- fftools/ffmpeg.c | 6 ++--- fftools/ffmpeg_demux.c | 21 +++++++++++++++ fftools/ffmpeg_filter.c | 58 ++++++++++++----------------------------- 3 files changed, 41 insertions(+), 44 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index 4624960c17..e9e60407d2 100644 --- a/fftools/ffmpeg.c +++ b/fftools/ffmpeg.c @@ -153,9 +153,9 @@ static int sub2video_get_blank_frame(InputStream *ist) AVFrame *frame = ist->sub2video.frame; av_frame_unref(frame); - ist->sub2video.frame->width = ist->dec_ctx->width ? ist->dec_ctx->width : ist->sub2video.w; - ist->sub2video.frame->height = ist->dec_ctx->height ? ist->dec_ctx->height : ist->sub2video.h; - ist->sub2video.frame->format = AV_PIX_FMT_RGB32; + frame->width = ist->sub2video.w; + frame->height = ist->sub2video.h; + frame->format = AV_PIX_FMT_RGB32; if ((ret = av_frame_get_buffer(frame, 0)) < 0) return ret; memset(frame->data[0], 0, frame->height * frame->linesize[0]); diff --git a/fftools/ffmpeg_demux.c b/fftools/ffmpeg_demux.c index 561b4b0002..817ccbbedc 100644 --- a/fftools/ffmpeg_demux.c +++ b/fftools/ffmpeg_demux.c @@ -1228,6 +1228,27 @@ static void add_input_streams(const OptionsContext *o, Demuxer *d) av_log(ist, AV_LOG_FATAL, "Invalid canvas size: %s.\n", canvas_size); exit_program(1); } + + /* Compute the size of the canvas for the subtitles stream. + If the subtitles codecpar has set a size, use it. Otherwise use the + maximum dimensions of the video streams in the same file. */ + ist->sub2video.w = ist->dec_ctx->width; + ist->sub2video.h = ist->dec_ctx->height; + if (!(ist->sub2video.w && ist->sub2video.h)) { + for (int j = 0; j < ic->nb_streams; j++) { + AVCodecParameters *par1 = ic->streams[j]->codecpar; + if (par1->codec_type == AVMEDIA_TYPE_VIDEO) { + ist->sub2video.w = FFMAX(ist->sub2video.w, par1->width); + ist->sub2video.h = FFMAX(ist->sub2video.h, par1->height); + } + } + } + + if (!(ist->sub2video.w && ist->sub2video.h)) { + ist->sub2video.w = FFMAX(ist->sub2video.w, 720); + ist->sub2video.h = FFMAX(ist->sub2video.h, 576); + } + break; } case AVMEDIA_TYPE_ATTACHMENT: diff --git a/fftools/ffmpeg_filter.c b/fftools/ffmpeg_filter.c index 2a73e3a3e3..4b5ccf50bd 100644 --- a/fftools/ffmpeg_filter.c +++ b/fftools/ffmpeg_filter.c @@ -458,13 +458,13 @@ static int ifilter_bind_ist(InputFilter *ifilter, InputStream *ist) InputFilterPriv *ifp = ifp_from_ifilter(ifilter); int ret; + ifp->ist = ist; + ifp->type_src = ist->st->codecpar->codec_type; + ret = ist_filter_add(ist, ifilter, filtergraph_is_simple(ifilter->graph)); if (ret < 0) return ret; - ifp->ist = ist; - ifp->type_src = ist->st->codecpar->codec_type; - return 0; } @@ -1110,38 +1110,6 @@ void check_filter_outputs(void) static int sub2video_prepare(InputStream *ist, InputFilter *ifilter) { - InputFilterPriv *ifp = ifp_from_ifilter(ifilter); - AVFormatContext *avf = input_files[ist->file_index]->ctx; - int i, w, h; - - /* Compute the size of the canvas for the subtitles stream. - If the subtitles codecpar has set a size, use it. Otherwise use the - maximum dimensions of the video streams in the same file. */ - w = ifp->width; - h = ifp->height; - if (!(w && h)) { - for (i = 0; i < avf->nb_streams; i++) { - if (avf->streams[i]->codecpar->codec_type == AVMEDIA_TYPE_VIDEO) { - w = FFMAX(w, avf->streams[i]->codecpar->width); - h = FFMAX(h, avf->streams[i]->codecpar->height); - } - } - if (!(w && h)) { - w = FFMAX(w, 720); - h = FFMAX(h, 576); - } - av_log(avf, AV_LOG_INFO, "sub2video: using %dx%d canvas\n", w, h); - } - ist->sub2video.w = ifp->width = w; - ist->sub2video.h = ifp->height = h; - - ifp->width = ist->dec_ctx->width ? ist->dec_ctx->width : ist->sub2video.w; - ifp->height = ist->dec_ctx->height ? ist->dec_ctx->height : ist->sub2video.h; - - /* rectangles are AV_PIX_FMT_PAL8, but we have no guarantee that the - palettes for all rectangles are identical or compatible */ - ifp->format = AV_PIX_FMT_RGB32; - ist->sub2video.frame = av_frame_alloc(); if (!ist->sub2video.frame) return AVERROR(ENOMEM); @@ -1525,7 +1493,7 @@ int ifilter_parameters_from_dec(InputFilter *ifilter, const AVCodecContext *dec) ifp->fallback.width = dec->width; ifp->fallback.height = dec->height; ifp->fallback.sample_aspect_ratio = dec->sample_aspect_ratio; - } else { + } else if (dec->codec_type == AVMEDIA_TYPE_AUDIO) { int ret; ifp->fallback.format = dec->sample_fmt; @@ -1534,6 +1502,17 @@ int ifilter_parameters_from_dec(InputFilter *ifilter, const AVCodecContext *dec) ret = av_channel_layout_copy(&ifp->fallback.ch_layout, &dec->ch_layout); if (ret < 0) return ret; + } else { + // for subtitles (i.e. sub2video) we set the actual parameters, + // rather than just fallback + ifp->width = ifp->ist->sub2video.w; + ifp->height = ifp->ist->sub2video.h; + + /* rectangles are AV_PIX_FMT_PAL8, but we have no guarantee that the + palettes for all rectangles are identical or compatible */ + ifp->format = AV_PIX_FMT_RGB32; + + av_log(NULL, AV_LOG_VERBOSE, "sub2video: using %dx%d canvas\n", ifp->width, ifp->height); } return 0; @@ -1574,8 +1553,7 @@ int ifilter_has_all_input_formats(FilterGraph *fg) int i; for (i = 0; i < fg->nb_inputs; i++) { InputFilterPriv *ifp = ifp_from_ifilter(fg->inputs[i]); - if (ifp->format < 0 && (ifp->type_src == AVMEDIA_TYPE_AUDIO || - ifp->type_src == AVMEDIA_TYPE_VIDEO)) + if (ifp->format < 0) return 0; } return 1; @@ -1709,9 +1687,7 @@ int ifilter_send_eof(InputFilter *ifilter, int64_t pts, AVRational tb) } } - if (ifp->format < 0 && - (ifp->type_src == AVMEDIA_TYPE_AUDIO || - ifp->type_src == AVMEDIA_TYPE_VIDEO)) { + if (ifp->format < 0) { av_log(NULL, AV_LOG_ERROR, "Cannot determine format of input stream %d:%d after EOF\n", ifp->ist->file_index, ifp->ist->index);