From patchwork Fri Jun 9 13:19:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Artem Smorodin X-Patchwork-Id: 42027 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:c526:b0:117:ac03:c9de with SMTP id gm38csp1134943pzb; Fri, 9 Jun 2023 06:20:11 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7s7cP11kj0Zwd2DwajbxEvZiFPLkX6AdkoqxHZK9sLhVtpQolNo+8D92pk31sapTq3gZ2e X-Received: by 2002:a05:6402:150d:b0:514:8df2:b6e6 with SMTP id f13-20020a056402150d00b005148df2b6e6mr1258543edw.15.1686316811648; Fri, 09 Jun 2023 06:20:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686316811; cv=none; d=google.com; s=arc-20160816; b=tjdsxPNFaEnOEOtk3e602lhpeWRLQd9CuIdg3W2QMRK5v/B1x1Z6uX6cAIo6mTXdEZ wzeQnut8BnT4kQsnoHKLjV6RHMZGVLnKE9gtJYmtZjURKENGRHiok6sSyHXaen5/chH1 VCNwL6CLZd5bnrCK5qN9UTzF+kCYFrO9x9ufysRtrclm2IuusIY+GFZT2St2KcaLCRzk U36ZZiRi9CGzYfBHkGos8N3jOSkpi8zb8XvhIkfqPOVQnEJYuCvvZulKqT0EMgG/mI8j JzAD/fdsEPEuFxEn0VZMItFVFz+zAOMEZZ44NA4TpGNiHaaydwTNRYJ4CTSLPISMoiFz jO1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:subject:mime-version:accept-language:message-id:date :thread-index:thread-topic:to:from:dkim-signature:delivered-to; bh=ZlFpGoc3fZiBEjg6WGiatsrgeMl6wxo5Cam8Wodn3Wg=; b=EFT5q8xoXdzSx+wfCmiYOI/T0UKr9zbBu3C/uscnlX0w4hf+nkuRGzCJ8TspS7NNGo I0mt58wBLLyYSYO7/jySbgvO+CXl4pQCh0ZnK1Jd88Z/l65wUiX5dMyGmfXVN7937zuh 3eOuSrwn1Q1zMkX+UdYFvd7aMu8ktx33Dy8S35afyB1e/ozN1VgutFyIRO4iGwS35SNp EtOUlJJiSQu8qQw0cSY2rgWUVEfiICUv33NDiVq4yhAhgmzaYbwSEyGb5Eq3spMcx+xf HS/VX3Umaqx2iY/esJz09oh1yOCRRvhaYB9Y1yCFycGA+S3X1gnhQwdGYOcwFerUTzsm TcbA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@telestream.net header.s=mimecast20180518 header.b=dJmnGtDW; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=telestream.net Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id u8-20020aa7d0c8000000b00515947ac983si2370922edo.314.2023.06.09.06.19.48; Fri, 09 Jun 2023 06:20:11 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@telestream.net header.s=mimecast20180518 header.b=dJmnGtDW; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=telestream.net Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8579B68C315; Fri, 9 Jun 2023 16:19:44 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from us-smtp-delivery-122.mimecast.com (us-smtp-delivery-122.mimecast.com [170.10.129.122]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 63CA368BE2D for ; Fri, 9 Jun 2023 16:19:36 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telestream.net; s=mimecast20180518; t=1686316774; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=1y8glnJNCy8CQV12Dv/rUFC7QcAzPdUPZetdEzFwcE0=; b=dJmnGtDW3ipZbQbMQ4fp4CCwH6bPYoOXP0Lz8HhwmJxTfa6UICUIEYITgib/In07Eh/u8D /stBc1+ZyfUneJ3iAppveLyI6P2v2ivUyx4HvSB4LBwMBqaMphHIhbX05ypvSQ2E/Gf5pC o+YvehfBRMWcRBmEaayA5F5QalN6KbSbAm10v1zqSaao5Kp1yRUEEJfWUAolxXlfoqlQll vSBn/Xq/sTBUy3zKMe+kD3a5/LQU7S77uvdG9xEgaaWwcHJp6p79GgyvolkaQshdqTkwcM 6oOdD/GVspH3kpHoGlag9LXFxdhCC98UOJS1//HBkvIUDInQri7UXG1vFUlePg== Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2102.outbound.protection.outlook.com [104.47.58.102]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-443-agHEhIWzNwKL0Th89CK54w-1; Fri, 09 Jun 2023 09:19:30 -0400 X-MC-Unique: agHEhIWzNwKL0Th89CK54w-1 Received: from DM6PR14MB3645.namprd14.prod.outlook.com (2603:10b6:5:1b9::11) by CY8PR14MB6802.namprd14.prod.outlook.com (2603:10b6:930:76::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.33; Fri, 9 Jun 2023 13:19:27 +0000 Received: from DM6PR14MB3645.namprd14.prod.outlook.com ([fe80::e900:6b89:58b4:bbff]) by DM6PR14MB3645.namprd14.prod.outlook.com ([fe80::e900:6b89:58b4:bbff%6]) with mapi id 15.20.6455.030; Fri, 9 Jun 2023 13:19:27 +0000 From: Artem Smorodin To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [PATCH] fftools/ffmpeg_enc: Prevent duplicate A53 Closed Captions at frame rate up-conversion Thread-Index: Adma1E9moEryeuf7QXy4zmWJV5AGjg== Date: Fri, 9 Jun 2023 13:19:27 +0000 Message-ID: Accept-Language: ru-RU, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR14MB3645:EE_|CY8PR14MB6802:EE_ x-ms-office365-filtering-correlation-id: e6a8a538-9682-47d5-07c3-08db68ec269c x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0 x-microsoft-antispam-message-info: WiXShYdDAczGtl0NTPOiXJG7vzn13MyOHstUer0t2+9WXsxY4g2PalDKe5hgvBj+MY4aI7IyrfPEOplKK8zKnJnqHZoQz1CK/DfPZDu7y6VttnmcK7QdalGbgbkLxbiOpg3mOwOphn64YxaOyx4q2n05108iULBVooC3J91Yl93muV2opaFePo6fq7ofxxEg5F7MEQ1UQmkyoOACRFmzMEBbbdA0FbH9LtAhhTegbUa0gSGIq8eeC4rTIblXLCjYgpiPYimSIxzwQzfbVfyCFetC4jhqwT+0/3Ba90fYd7mPThmGSZchSik1t+ajsmf57ZjO71aENRhp/6MPJXVL8U9ovEBD4+oQkZzalXupqQ7AotwFMtioTT5fP+z3TdMmS1iZsZJ26N4wKVeevtmux1EiHXsE+SBfNY6hIP3v3EMFRRw3S6ZUasDUXwyA0VUTzdMu+GEmPkH55gd9BvzOf0R2WkSiNx1WYKwNnmU2d7qt76plNR9+hGgg3mM2yb52EPXVxecpaetDopE7OaY0j6iy/hPNiDouO2Ei+Q2LaIe0pdrHMH/J3SZ9h5ucEWjOX+OVbgMmAn+CIUlSD1j7/JaMfM5wVIgqDXcbU7ZnmIc0E7LnZ9MrKOABe6F6AyZ0 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR14MB3645.namprd14.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(136003)(346002)(39850400004)(366004)(376002)(396003)(451199021)(71200400001)(478600001)(52536014)(66476007)(6916009)(44832011)(8936002)(8676002)(66556008)(38070700005)(33656002)(2906002)(5660300002)(4744005)(86362001)(64756008)(122000001)(66446008)(66946007)(76116006)(316002)(55016003)(38100700002)(6506007)(41300700001)(9686003)(26005)(186003)(83380400001)(7696005); DIR:OUT; SFP:1102 x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: y+HiA5sfk1mE35adn78Q2RT84RtkdI5/rojQY7Pakq0kunpS3f2N1uF5dQ9OjSzB/Bd0I2fzw4JATcaLJ9ZfYnACJuFhHk1mVEEFdNx+8SEuVKuxmvN1eOnsR1Z2tGA/zv12/L+rhyKGy0KVpJrI1TT2jBH/dU/Pby61JzvOhR+M8cbpdmFebT4L+JJRreeKoMFE9g/bTqMLsvXh0yUS44V8ahNFVuKFJCtDjEl5OA/rc+ZGl9MgtONL7JnUDE4VaqS+44oyjD6+QfOwPhu3K3U0vCr/u19vBru9lzFJ0FJXkgKap/m82j/qtCALyQ6WH19Sj8caRV8NDFe59ycFpKb2bAmdJ1XzuBY0iP+UWPjaba0hdRFlxcTuFmlTTJhb3FTQHcbZKXsJgBSG+EXnvglc1tL9DJl8/7NA2AeKbKOHsFLmmEUEXingzEbQfFGCTQBdPOb688gGoXCc+4UNQWLK5LAC+euyqtHfz2qxPL7EhSrqSMTzY12fjQphbcBveUEaEFRlBhIiwgJm80GJcYdfMWUwx4k/WE7iloYC/qXiWFJZyfFSjtNOpuMpho+6jqPFpNA5EO1nOlLd175/i3rhW0uPMmPTnAWh9xGcomoyX1mJWttZq6E4e/bI1AUrrQlfFGwSlJI19mGfVpOORyR90tzWyAl/6Cg+XHnitcbihjDWBEsI8/udr7hShVbvCYpPLYEZoCjb+eGfYrZoymVcMFk6wlICFiJpiekQqygUz/s4gv607xxx5ntT0CtV/6jHFnHnwp9Siht8lfN35VCTGjUtAEms+Fdzjm/j8PZA1TfsE1PP0n8FL5DwXMlBUwe27BpW//Etd0Cxh8N5b7P6TFRH0FbZ+WuTqpjY3+gIOUhS57cF1+SWvGpHFg0NBCN8npVr6v5/55jsQuTFyhgMtXZcET+P0Td6TTOMdjz7aF0HVCH4CJ3NlqdETCHQLX1s9uCM+XsH5ydlCs/3K82Y5lTqXHCqvpe4UBnnXP9eo5sNG1qoVOqKsz4l63mV9o8NQzac6bXE0s5hmJSNCb2sc+tvfiHQcQRk4oqqUIV+ZxiEKuzMogWeyw+zEbCeOXFJGojI2UPmq2QJ1oHp2b3WhrLJYNulpYLeVrTzLGaLwGkXH3i8G1jDstTJsUfrss6zrPrKhZu/wdUjFTcV72w1Ivza4ElOR9kR5NOt6svAbZnaoa4C2MPhP07ZiuSwZNMzygQntoPo79mXDIoWaw8R84JfzUuT6JHOrYiyWTGurSuwrO4jTlLaY4ZI5II113tS3cNq02SjB+VItYbghvGoZCx1rf+pSaD23+OnnHHpAX8xFwL+CTgCR4Qdx6Nsn9DakGczYa78QD2zIcVoyWokc7KRIfhLa3qorH3C6itpuZExkQHC6zDjcbfAEDR3OKr9VpD6RamVS5mk/mjVGKgHyyREVkh6aUJ8xhE9KdqG8+Oh5rE+Kdku9RxkbKD94XZlZMrKDdzJGa8GedfmBlLrbxqDSqJ1kWqS8VGGwZGORRZVrGgRdvuBI+Q9yyZmeCuoOXe2yGPMsRySkF/pxczlnQz02UkNKJRYli3kRcNkwfUpBBdSymu+zcSGqJoCr40I1ruAsQmxkUP9GjiP2w== MIME-Version: 1.0 X-OriginatorOrg: telestream.net X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR14MB3645.namprd14.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e6a8a538-9682-47d5-07c3-08db68ec269c X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jun 2023 13:19:27.2030 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: baf11064-b50b-4207-b3c1-8f60fdecafb2 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: fPZhLJKMrckV0ylDqtzg/R+os1ofeTAdHai3bVUDFPg3JsKnFpVDVnU2vtz9z7SGUX955NxEUTq7VVlv/dzt6tHTCQeKhd0sp3xGQzv+Zss= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR14MB6802 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: telestream.net X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: [FFmpeg-devel] [PATCH] fftools/ffmpeg_enc: Prevent duplicate A53 Closed Captions at frame rate up-conversion X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: jM4zQgOtvzwb When up-converting frame rate, ffmpeg duplicates frames including side data. This causes duplicated characters in the output. This patch removes A53 side data from duplicated frames. Signed-off-by: Artem Smorodin --- fftools/ffmpeg_enc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fftools/ffmpeg_enc.c b/fftools/ffmpeg_enc.c index 2bf4782a9f..93d18034ca 100644 --- a/fftools/ffmpeg_enc.c +++ b/fftools/ffmpeg_enc.c @@ -1104,6 +1104,9 @@ static void do_video_out(OutputFile *of, OutputStream *ost, AVFrame *frame) else if (ret < 0) exit_program(1); + //Prevent duplicate Closed Captions at frame rate up-conversion + av_frame_remove_side_data(in_picture, AV_FRAME_DATA_A53_CC); + e->next_pts++; e->vsync_frame_number++; }