From patchwork Sun Jun 18 21:50:16 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 42207 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:be15:b0:121:b37c:e101 with SMTP id ge21csp314217pzb; Sun, 18 Jun 2023 14:50:37 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7obRXnNMrruMnhuqDM8I2bR+i+JEEC6Y4DI5lq1FJkf0KYUQYWy7Ne46upsTfe0wdWvl5z X-Received: by 2002:a5d:4bc1:0:b0:30f:cd58:1012 with SMTP id l1-20020a5d4bc1000000b0030fcd581012mr6398625wrt.11.1687125037142; Sun, 18 Jun 2023 14:50:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687125037; cv=none; d=google.com; s=arc-20160816; b=IfwB1sHuAodn53FkfRBqyKw/2JNaaykqORaszGiVuds6PPGqHZNs7sJeAdk8wVAkmo DwM/FIcnHbIJ6gAVR+bvl75ZfovD2nxqgWXKjwrB6Knarha3D3M4GJCrzV8ZM7hF119T 1jrPQO4ffV+EpAXsccU4H7VxlOD1bms0KrsE71JqmXEIDNbJsnM5S4nwCBQtBLgGxefL 6ihcktcuuQBr/arM/IKnSHIoclydhrPscNEPqdADfhoT7sVMpupYKSIOpheHZb+NzlCr t6xjOYw0iid59tRRwaawc7WByZaRvoHvASWD6eddG9Fw9yiET5C3tzfhkj+KRJsKUSK/ cYfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:message-id:date:to:from:delivered-to; bh=yRnVfNR9VhtQw3M+Kz+VD9VHQ2qCMNqL9yZXGBVC/Hc=; b=TxU/2f2zNUeZ48+ylzp4jQCigRbB5FQaaRjJ3hsfSmDJcq1bhtlDPyHN5S4jGMDpP8 aGzocPqqU+DTbpP3R+d8vydBQujeQCqi4iwKzlhdsrDM8aMC7o/8mAB+/i1juORDmqiL f8FUbYE+3x80dxLKSlB9NQPXnVP+j7ubeoXzAI9dBLwGtu1Ecfm5AJnyFQo73Hqw3xZv 0BAhz+1ozaf4UKMyubLVZqGADCa1gLu15zAyP0NtoJtIn4al+NrAQZW46jU+f9I89CA2 +u/sfZANfM/XDvupI7v2YdmxsW3WN6+lBiGKnHU6Nbt7Rv44831cwv0pDWNi5HU5S5dg b2tg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id c18-20020a17090603d200b0098879dbe312si1005530eja.431.2023.06.18.14.50.32; Sun, 18 Jun 2023 14:50:37 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6A36A68BF1D; Mon, 19 Jun 2023 00:50:29 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-02-2.mymagenta.at (mail-02-2.mymagenta.at [80.109.253.249]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 703E268A0F0 for ; Mon, 19 Jun 2023 00:50:23 +0300 (EEST) Received: from [192.168.232.136] (helo=ren-mail-psmtp-mg02.) by mail-02.mymagenta.at with esmtp (Exim 4.93) (envelope-from ) id 1qB0Hu-000k5K-N4 for ffmpeg-devel@ffmpeg.org; Sun, 18 Jun 2023 23:50:22 +0200 Received: from localhost ([84.115.40.24]) by ren-mail-psmtp-mg02. with ESMTP id B0HvqrzOlbZLDB0HvquNHy; Sun, 18 Jun 2023 23:50:23 +0200 X-Env-Mailfrom: michael@niedermayer.cc X-Env-Rcptto: ffmpeg-devel@ffmpeg.org X-SourceIP: 84.115.40.24 X-CNFS-Analysis: v=2.4 cv=Ufwy9IeN c=1 sm=1 tr=0 ts=648f7c1f a=4thelYDX6rwh+ygQwvsI+Q==:117 a=4thelYDX6rwh+ygQwvsI+Q==:17 a=MKtGQD3n3ToA:10 a=1oJP67jkp3AA:10 a=GEAsPZ9sns4A:10 a=NEAV23lmAAAA:8 a=5IjLu0dzwJt126JF8wkA:9 From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Sun, 18 Jun 2023 23:50:16 +0200 Message-Id: <20230618215021.3044-1-michael@niedermayer.cc> X-Mailer: git-send-email 2.17.1 X-CMAE-Envelope: MS4xfKa3S46c9EadXyFCc814lHZlFw6bKzEewvyq4M4ELU/DdBGq1SLUq6uJUgob5b1ZDdusZhuwzihbeiBn0ISCSHII+/onG3IKxMyIp93IU5fTeKhDZr3S Uy+ovjIuXAb+8s+sduqsBToW33QjoNXRffmNH2IyRgZyYlTRNbqt51jOC86DI1hgMOTJ66uVTdPh/w== Subject: [FFmpeg-devel] [PATCH 1/6] avformat/jpegxl_anim_dec: Perform operations in a different order X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: 4kOw37gibeRp Fixes: OOM Fixes: 59802/clusterfuzz-testcase-minimized-ffmpeg_dem_JPEGXL_ANIM_fuzzer-5681765466112000 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/jpegxl_anim_dec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/jpegxl_anim_dec.c b/libavformat/jpegxl_anim_dec.c index 6ea6c46d8f..c62b596f76 100644 --- a/libavformat/jpegxl_anim_dec.c +++ b/libavformat/jpegxl_anim_dec.c @@ -227,7 +227,7 @@ static int jpegxl_anim_read_packet(AVFormatContext *s, AVPacket *pkt) if (ctx->initial && size < ctx->initial->size) size = ctx->initial->size; - if ((ret = av_new_packet(pkt, size) < 0)) + if ((ret = av_new_packet(pkt, size)) < 0) return ret; if (ctx->initial) { From patchwork Sun Jun 18 21:50:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 42210 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:be15:b0:121:b37c:e101 with SMTP id ge21csp322804pzb; Sun, 18 Jun 2023 15:17:33 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7Qh4FIU7lAdK2uc4s0Gg93IBY/uX+zXHxrcs0pa+9BR+OtRyuQcYFyAved33VJiaSMB48i X-Received: by 2002:aa7:d459:0:b0:510:8ee2:2b05 with SMTP id q25-20020aa7d459000000b005108ee22b05mr5496813edr.38.1687126653713; Sun, 18 Jun 2023 15:17:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687126653; cv=none; d=google.com; s=arc-20160816; b=GPqeIJldzRFIDysz2fD+AZfr2jGo5/SJCaSGGXJWFH8P3FYwj5nYhO847RjsMwv/bM iM5MT49TbHMRFrqWeQqUuApvuOUG1lu5v/l4rTOVA2AEDeJ3CuRqUte2X38mi2EfSrBH +0M7GGEQpy+SsyxtIGUZj+K948cBsOZoPQeEkSDC9F5HllUwdGhtXheamWB28pz4kRJW OsveK4MTc3opPh62rNWEaRTHuYJTjmgIcF1Zq4EdAF/SSd8va9eTVTpRTrWQCpQU4jnU gnzF7IRL404aPO8vGzjAWJjLGlGgBWw3wZL7kqqGI7VIy21uZXnWZ2vOVMc1SHjnCqUI ARlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:references:in-reply-to:message-id:date :to:from:delivered-to; bh=rKxTOJcnHQToaPp/i+E6phgiajJUjnpdKBxLptGeNTw=; b=KX7Vp/mZ9Pv1B48e/sM2ucRn7IxwYk3szcH9NaXbHm+Ix8rCvxFvkX7PdliEqlfCvU fWf2PnBxkU6oLGaedaSExf6WD7QjFTqkoSBWPh2prUYtq8lRdaeyxIhW9JkZ2QvLHetA t1PIb3kIFNG77lWf3xHBn9JS1Se3pPGGh01KV4LuzdOh/iDKDz7rtNTKo+R5YaIskdRG KqVyov1C506pmIcZ2dMo/CKx8B3V5cUa2I/lHMK60dbhGRdznFPYfH/F9xeNBg3iWt7k 7QnsA0TmmXXSq54jEfTZyU111d3MgvBaXDvZAfaREJ1iGEnKz9nJEyGrTnVGa+jCv2X2 hT2Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id e23-20020a056402089700b005158563be4bsi14134099edy.291.2023.06.18.15.17.33; Sun, 18 Jun 2023 15:17:33 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 085EA68BECF; Mon, 19 Jun 2023 01:17:30 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-01-1.mymagenta.at (mail-01-1.mymagenta.at [80.109.253.246]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8AE65688386 for ; Mon, 19 Jun 2023 01:17:23 +0300 (EEST) Received: from [192.168.232.136] (helo=ren-mail-psmtp-mg02.) by mail-01.mymagenta.at with esmtp (Exim 4.93) (envelope-from ) id 1qB0Hu-00CHko-5v for ffmpeg-devel@ffmpeg.org; Sun, 18 Jun 2023 23:50:22 +0200 Received: from localhost ([84.115.40.24]) by ren-mail-psmtp-mg02. with ESMTP id B0HvqrzOxbZLDB0HvquNIC; Sun, 18 Jun 2023 23:50:23 +0200 X-Env-Mailfrom: michael@niedermayer.cc X-Env-Rcptto: ffmpeg-devel@ffmpeg.org X-SourceIP: 84.115.40.24 X-CNFS-Analysis: v=2.4 cv=Ufwy9IeN c=1 sm=1 tr=0 ts=648f7c1f a=4thelYDX6rwh+ygQwvsI+Q==:117 a=4thelYDX6rwh+ygQwvsI+Q==:17 a=MKtGQD3n3ToA:10 a=1oJP67jkp3AA:10 a=GEAsPZ9sns4A:10 a=NEAV23lmAAAA:8 a=Ama8Q3WLERFZ9mKeuh0A:9 From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Sun, 18 Jun 2023 23:50:17 +0200 Message-Id: <20230618215021.3044-2-michael@niedermayer.cc> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230618215021.3044-1-michael@niedermayer.cc> References: <20230618215021.3044-1-michael@niedermayer.cc> X-CMAE-Envelope: MS4xfKa3S46c9EadXyFCc814lHZlFw6bKzEewvyq4M4ELU/DdBGq1SLUq6uJUgob5b1ZDdusZhuwzihbeiBn0ISCSHII+/onG3IKxMyIp93IU5fTeKhDZr3S Uy+ovjIuXAb+8s+sduqsBToW33QjoNXRffmNH2IyRgZyYlTRNbqt51jOC86DI1hgMOTJ66uVTdPh/w== Subject: [FFmpeg-devel] [PATCH 2/6] avcodec/utils: fix 2 integer overflows in get_audio_frame_duration() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: EWR4Ia4Uc+xE Fixes: signed integer overflow: 256 * 668003712 cannot be represented in type 'int' Fixes: 59819/clusterfuzz-testcase-minimized-ffmpeg_dem_MATROSKA_fuzzer-4674636538052608 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/utils.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/utils.c b/libavcodec/utils.c index a8514ba6c1..672eb15d98 100644 --- a/libavcodec/utils.c +++ b/libavcodec/utils.c @@ -641,9 +641,9 @@ static int get_audio_frame_duration(enum AVCodecID id, int sr, int ch, int ba, if (sr > 0) { /* calc from sample rate */ if (id == AV_CODEC_ID_TTA) - return 256 * sr / 245; + return 256ll * sr / 245; else if (id == AV_CODEC_ID_DST) - return 588 * sr / 44100; + return 588ll * sr / 44100; else if (id == AV_CODEC_ID_BINKAUDIO_DCT) { if (sr / 22050 > 22) return 0; From patchwork Sun Jun 18 21:50:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 42212 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:be15:b0:121:b37c:e101 with SMTP id ge21csp329922pzb; Sun, 18 Jun 2023 15:44:06 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5ZTJkwewvrKDQdFM4UWDhfl2w/WkMcauZYL+PLwb1Glbu6uXFeIrdV5HhGvRxd2pWSWkza X-Received: by 2002:a17:907:16a2:b0:982:4abc:97d6 with SMTP id hc34-20020a17090716a200b009824abc97d6mr8020705ejc.4.1687128246303; Sun, 18 Jun 2023 15:44:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687128246; cv=none; d=google.com; s=arc-20160816; b=GKdR/AfjI7neJbR9NVqGukYZZAMpvCM1G6LN4+EZlWWuy1ZaT0PCDkH07GcwRfojZC rI9viPROl7REWrIFwg3XskcuxDB3Etd9kJc2MD+mE2Tf5xP8+vfcqBw6m1KaJQrxdEsL nw3vlNTPJXaB4rXxPdEyOprISPGfOdp8XZNFX2NCugPzymJhOGdYAnCvXPprwikZctZk F75fLGIBuG24iDiJR+/RrxeTGJxPKNozFXZbLL+lbE4oOCyO+vrvDo/RuUFCIwW31DLi uogNHLYRw53zSI/S38QiYpIGZS0dBlic7qkTwSvtTfDe22IAO1qfAsCnmdIMET3l7ooq zEJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:references:in-reply-to:message-id:date :to:from:delivered-to; bh=HKPr5XIzZZjhzLk95xKndZ4kcDIUyhGv7OXd0SHl5Pk=; b=C/AZ423ILkeQH1IeYw7dmaNMfKia/C+UWrqVb8a7W5HzVulggCCmBwrXH204ausvjU TOV08DAJdWVH00tPwVLT4taOL7oOZyWQvTJ7qj+O7Uxsa4svja7yKMhTedFc6ns79F3j kgvg16x2u28vyUzny/dDXkUmEF5Ro56DVm3PmivkESyFcm5eQQY3xiCoDmBxZx/Iu+Gz VWtpMp+THU81++NHlXdRj2LPNSpLFB0OoGXE/H9UwlH+p3I7KqlppISDs2/5moDzJ5ZH lrIA+Sb/5WdhmW8Q/+1LDL8LtJp5cAa1SPhGE4q114kt/BwLHfVSgTbXZcMod3GCMZ2a W2PA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id n2-20020a170906088200b00977d54350c2si10530026eje.916.2023.06.18.15.44.05; Sun, 18 Jun 2023 15:44:06 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4FF6F68BF30; Mon, 19 Jun 2023 01:44:03 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-01-1.mymagenta.at (mail-01-1.mymagenta.at [80.109.253.246]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8D55A68ABA6 for ; Mon, 19 Jun 2023 01:43:56 +0300 (EEST) Received: from [192.168.232.136] (helo=ren-mail-psmtp-mg02.) by mail-01.mymagenta.at with esmtp (Exim 4.93) (envelope-from ) id 1qB0Hu-00CHop-HC for ffmpeg-devel@ffmpeg.org; Sun, 18 Jun 2023 23:50:22 +0200 Received: from localhost ([84.115.40.24]) by ren-mail-psmtp-mg02. with ESMTP id B0HwqrzP4bZLDB0HwquNID; Sun, 18 Jun 2023 23:50:24 +0200 X-Env-Mailfrom: michael@niedermayer.cc X-Env-Rcptto: ffmpeg-devel@ffmpeg.org X-SourceIP: 84.115.40.24 X-CNFS-Analysis: v=2.4 cv=Ufwy9IeN c=1 sm=1 tr=0 ts=648f7c20 a=4thelYDX6rwh+ygQwvsI+Q==:117 a=4thelYDX6rwh+ygQwvsI+Q==:17 a=MKtGQD3n3ToA:10 a=1oJP67jkp3AA:10 a=GEAsPZ9sns4A:10 a=NEAV23lmAAAA:8 a=w-GfLOqwoN9W1uoqOhQA:9 From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Sun, 18 Jun 2023 23:50:18 +0200 Message-Id: <20230618215021.3044-3-michael@niedermayer.cc> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230618215021.3044-1-michael@niedermayer.cc> References: <20230618215021.3044-1-michael@niedermayer.cc> X-CMAE-Envelope: MS4xfFR2oEi2NtwF8/g5IO6xmSopH4o3DZZit/iK5a3FYxPcKQjdCc1o70STbGewdCTA0y4qAIeDUoBvj3R/I/zkKkQ0nuf8YUgdmauFTkKYnM/70c/iSSJv LoJWzqXj5HCPX5TPTXayV6tcmOl45RINTbBt1iGTU1u8FW9oJxQE2pOSp9NN6nNTz3PJY3MJlLpFPA== Subject: [FFmpeg-devel] [PATCH 3/6] avformat/jpegxl_anim_dec: add FF_JPEGXL_CONTAINER_SIGNATURE_LE X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: m6MTVAAEzcac Fixes: out of array read Fixes: 59828/clusterfuzz-testcase-minimized-ffmpeg_dem_JPEGXL_ANIM_fuzzer-5029813220671488 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/jpegxl_anim_dec.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/libavformat/jpegxl_anim_dec.c b/libavformat/jpegxl_anim_dec.c index c62b596f76..7e4d39385c 100644 --- a/libavformat/jpegxl_anim_dec.c +++ b/libavformat/jpegxl_anim_dec.c @@ -108,7 +108,7 @@ static int jpegxl_collect_codestream_header(const uint8_t *input_buffer, int inp static int jpegxl_anim_probe(const AVProbeData *p) { - uint8_t buffer[4096]; + uint8_t buffer[4096 + AV_INPUT_BUFFER_PADDING_SIZE]; int copied; /* this is a raw codestream */ @@ -123,7 +123,7 @@ static int jpegxl_anim_probe(const AVProbeData *p) if (AV_RL64(p->buf) != FF_JPEGXL_CONTAINER_SIGNATURE_LE) return 0; - if (jpegxl_collect_codestream_header(p->buf, p->buf_size, buffer, sizeof(buffer), &copied) <= 0 || copied <= 0) + if (jpegxl_collect_codestream_header(p->buf, p->buf_size, buffer, sizeof(buffer) - AV_INPUT_BUFFER_PADDING_SIZE, &copied) <= 0 || copied <= 0) return 0; if (ff_jpegxl_verify_codestream_header(buffer, copied, 0) >= 1) @@ -138,7 +138,8 @@ static int jpegxl_anim_read_header(AVFormatContext *s) AVIOContext *pb = s->pb; AVStream *st; int offset = 0; - uint8_t head[256]; + uint8_t head[256 + AV_INPUT_BUFFER_PADDING_SIZE]; + const int sizeofhead = sizeof(head) - AV_INPUT_BUFFER_PADDING_SIZE; int headsize = 0; int ctrl; AVRational tb; @@ -147,7 +148,7 @@ static int jpegxl_anim_read_header(AVFormatContext *s) uint64_t sig16 = avio_rl16(pb); if (sig16 == FF_JPEGXL_CODESTREAM_SIGNATURE_LE) { AV_WL16(head, sig16); - headsize = avio_read(s->pb, head + 2, sizeof(head) - 2); + headsize = avio_read(s->pb, head + 2, sizeofhead - 2); if (headsize < 0) return headsize; headsize += 2; @@ -178,10 +179,10 @@ static int jpegxl_anim_read_header(AVFormatContext *s) if (av_buffer_realloc(&ctx->initial, ctx->initial->size + read) < 0) return AVERROR(ENOMEM); } - jpegxl_collect_codestream_header(buf, read, head + headsize, sizeof(head) - headsize, &copied); + jpegxl_collect_codestream_header(buf, read, head + headsize, sizeofhead - headsize, &copied); memcpy(ctx->initial->data + (ctx->initial->size - read), buf, read); headsize += copied; - if (headsize >= sizeof(head) || read < sizeof(buf)) + if (headsize >= sizeofhead || read < sizeof(buf)) break; } } From patchwork Sun Jun 18 21:50:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 42208 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:be15:b0:121:b37c:e101 with SMTP id ge21csp314229pzb; Sun, 18 Jun 2023 14:50:42 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7s//t89FrigUGkTANRyOuIbiU+oWobeEjaGNTvfT4PLPQE0xjac4DWAHMe/R/3O4Six9kx X-Received: by 2002:a17:907:31c1:b0:988:882b:9a3 with SMTP id xf1-20020a17090731c100b00988882b09a3mr1798778ejb.36.1687125042198; Sun, 18 Jun 2023 14:50:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687125042; cv=none; d=google.com; s=arc-20160816; b=WFK9wsbk98T1PTLlayddrXLrelJdNTh0aeeau8RmAlLpwCMAGdGAYbBbMmNXlhuL6l nXHb+C5e6DsIWq8O20UL2yH+8OWHYOtbUT5oVspEb2/ApgLqFOsOyzROAdUiWIkYQ6L4 wlfIa3R3TFZBtM7/trG4SNqyTLaB8SUKHodEFArenW2JDQGikMhF0yWQjteBcm/4+lj/ y59LJR5nErNW6cOPvgBJq47ToziXzwImb0c8uKkmUGsndMhIeWIHxEt6ta9wMGKdYVJL Cq2IIYdREyainEZj26gA0VrszaeWjhMiklfErgO8aYFwXvChjuvB6L1hXOaKeIew6rVY rJFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:references:in-reply-to:message-id:date :to:from:delivered-to; bh=EIGgMmrN0G716vgf++YpIGjWXMlWvNqzALakHvrb+bY=; b=m6tgc/89Go9fHlUVASwF5DI79+lZ52ecOfW4BzPp3Zq/y2gM51cKfHul3H+5AWXHeD pGsTG016zxUTPNeOGs1Bfb9LhbWtxOzxshPVy0an52hFPlZdQyQTqLsB1h7u7G+B0D1H fVS4k4uz1c7a3y2nX4t3eo0ScpcPjygtRG4nOSwBwO2KgeVYsyZgN0NuxjfkJ8MvHZC0 a8DRwhDOlbFI0YmSPBvDN/4no7y29HCWNHfuKo0S+uTaVvpD2z2P7jLvMDqofOqZ3f0e lpqa78E7/wRaPK6RVD3srb9dWZOAIgJ2DaKoq2aLnTEemr0WG8e5cZbVkUX/MQBOZrHJ dUSQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id i1-20020a1709061cc100b009886470de61si1009666ejh.857.2023.06.18.14.50.41; Sun, 18 Jun 2023 14:50:42 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 64B9368BF50; Mon, 19 Jun 2023 00:50:30 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-02-2.mymagenta.at (mail-02-2.mymagenta.at [80.109.253.249]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id F1E9D68AD1B for ; Mon, 19 Jun 2023 00:50:23 +0300 (EEST) Received: from [192.168.232.136] (helo=ren-mail-psmtp-mg02.) by mail-02.mymagenta.at with esmtp (Exim 4.93) (envelope-from ) id 1qB0Hv-000k5K-PE for ffmpeg-devel@ffmpeg.org; Sun, 18 Jun 2023 23:50:23 +0200 Received: from localhost ([84.115.40.24]) by ren-mail-psmtp-mg02. with ESMTP id B0HwqrzPAbZLDB0HwquNIE; Sun, 18 Jun 2023 23:50:24 +0200 X-Env-Mailfrom: michael@niedermayer.cc X-Env-Rcptto: ffmpeg-devel@ffmpeg.org X-SourceIP: 84.115.40.24 X-CNFS-Analysis: v=2.4 cv=Ufwy9IeN c=1 sm=1 tr=0 ts=648f7c20 a=4thelYDX6rwh+ygQwvsI+Q==:117 a=4thelYDX6rwh+ygQwvsI+Q==:17 a=MKtGQD3n3ToA:10 a=1oJP67jkp3AA:10 a=GEAsPZ9sns4A:10 a=NEAV23lmAAAA:8 a=vMIWCQsNIXErQ2wHQhMA:9 From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Sun, 18 Jun 2023 23:50:19 +0200 Message-Id: <20230618215021.3044-4-michael@niedermayer.cc> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230618215021.3044-1-michael@niedermayer.cc> References: <20230618215021.3044-1-michael@niedermayer.cc> X-CMAE-Envelope: MS4xfFR2oEi2NtwF8/g5IO6xmSopH4o3DZZit/iK5a3FYxPcKQjdCc1o70STbGewdCTA0y4qAIeDUoBvj3R/I/zkKkQ0nuf8YUgdmauFTkKYnM/70c/iSSJv LoJWzqXj5HCPX5TPTXayV6tcmOl45RINTbBt1iGTU1u8FW9oJxQE2pOSp9NN6nNTz3PJY3MJlLpFPA== Subject: [FFmpeg-devel] [PATCH 4/6] avcodec/evc_parse: Check log2_sub_gop_length X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: X5bMCVDbMJ9L Fixes: 1.70141e+38 is outside the range of representable values of type 'int' Fixes: 59883/clusterfuzz-testcase-minimized-ffmpeg_BSF_EVC_FRAME_MERGE_fuzzer-5557887217565696 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/evc_parse.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/evc_parse.c b/libavcodec/evc_parse.c index 44be5c5291..822b236423 100644 --- a/libavcodec/evc_parse.c +++ b/libavcodec/evc_parse.c @@ -277,6 +277,8 @@ EVCParserSPS *ff_evc_parse_sps(EVCParserContext *ctx, const uint8_t *bs, int bs_ if (!sps->sps_pocs_flag || !sps->sps_rpl_flag) { sps->log2_sub_gop_length = get_ue_golomb(&gb); + if (sps->log2_sub_gop_length > 5U) + return NULL; if (sps->log2_sub_gop_length == 0) sps->log2_ref_pic_gap_length = get_ue_golomb(&gb); } From patchwork Sun Jun 18 21:50:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 42213 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:be15:b0:121:b37c:e101 with SMTP id ge21csp328897pzb; Sun, 18 Jun 2023 15:40:07 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6CJysi+Jp0S7f6fyRMawt3pJPrM2r41MELVVBoFX6tZZuvmUZXJksUtNgbQk3EXk2vdhQu X-Received: by 2002:a17:907:7243:b0:983:6312:829a with SMTP id ds3-20020a170907724300b009836312829amr6783299ejc.32.1687128007525; Sun, 18 Jun 2023 15:40:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687128007; cv=none; d=google.com; s=arc-20160816; b=xz9OAk3aNtFYikWtoD+qSm4JzzJzXxLq77AWIVKVBqa7kIiWHxwfBEpkpOpzfInH86 vhPtd6tFBRpA/6w07Ovv0WFT26mTfDWLbFRd/BhXAugWC533eKWKASkFQSK7GK7dER54 46ytPJWcb1f0T09v+328DgP/eg0hgJMgqt/WCwXS78K0vlQfYFbHw5UHAA9eiRVw1c9E 5qLpOPBlOtqvdG8KhLDlVaNqnjnHdBuiRMuwMUvyrkWATlouusJL67rPeJDFE/lO4U8C BSP0xVJcH76INp4S/F7642+qAiXuKZ2zad8aZf9544P6UdVGC82oa7m2tP4ZtkxDJotg bHiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:references:in-reply-to:message-id:date :to:from:delivered-to; bh=mbMFLTHAciPWkwVL6trDAKG56nbU9qrHNZwEYiP+4n8=; b=btDnqtxm037kWB8j0lIvH3j/1UIqFqgmvfg75KjazSFEGiW0Qy140FvHPOTs6PBlBx 9xagRHAUCi32kl98mavjlDOiS65HpU8uXaH+RUpGabQWG7cVGpwPXeojiwZr2Fb0aqL1 FUNbfxE/uBKjP/uyfSLUbyzd9zKK6zEVmPCPwI7uuhR8sPM0RfpUzmX+BHQpZKIkRHmc PnTgUxNHM3svvBCHdVKuVxvl+AEWlnNQ7N9oQM6b09jBE+OdEHtD7DAthdH+eSL2h8qs k2OvK/u6dCbUgqOLjYxIVS7ib+Onosu1TPUXmw4hF0lPIE2Wq3Ht9EIMfNVALMDSWCU5 iA9g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id lr20-20020a170906fb9400b0098287baecc2si5719661ejb.50.2023.06.18.15.40.06; Sun, 18 Jun 2023 15:40:07 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 09AB568BF08; Mon, 19 Jun 2023 01:40:04 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-01-1.mymagenta.at (mail-01-1.mymagenta.at [80.109.253.246]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 172A26881DA for ; Mon, 19 Jun 2023 01:39:58 +0300 (EEST) Received: from [192.168.232.135] (helo=ren-mail-psmtp-mg01.) by mail-01.mymagenta.at with esmtp (Exim 4.93) (envelope-from ) id 1qB0Hv-00CHbK-3I for ffmpeg-devel@ffmpeg.org; Sun, 18 Jun 2023 23:50:23 +0200 Received: from localhost ([84.115.40.24]) by ren-mail-psmtp-mg01. with ESMTP id B0Huq7GTgOG5ZB0HuqOLzd; Sun, 18 Jun 2023 23:50:22 +0200 X-Env-Mailfrom: michael@niedermayer.cc X-Env-Rcptto: ffmpeg-devel@ffmpeg.org X-SourceIP: 84.115.40.24 X-CNFS-Analysis: v=2.4 cv=KJo5sHJo c=1 sm=1 tr=0 ts=648f7c1e a=4thelYDX6rwh+ygQwvsI+Q==:117 a=4thelYDX6rwh+ygQwvsI+Q==:17 a=MKtGQD3n3ToA:10 a=1oJP67jkp3AA:10 a=GEAsPZ9sns4A:10 a=NEAV23lmAAAA:8 a=U3Fd5CXeQhZsrfIc9mEA:9 From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Sun, 18 Jun 2023 23:50:20 +0200 Message-Id: <20230618215021.3044-5-michael@niedermayer.cc> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230618215021.3044-1-michael@niedermayer.cc> References: <20230618215021.3044-1-michael@niedermayer.cc> X-CMAE-Envelope: MS4xfM0syu6130o6OBi+Q97Jnchp9pUJG+oL6dSKJV9x8iYpfV4qBIuzAgt9RdqE33XAlk6fc4Mo/9V+sjvcOGxl/6t6t0ONYBOzxBz9bxYDeRarHLszObTZ WWbTY3+ModZ8uHVK/jCzSgvoO2UuDGVomZcAd5Q7oTKeMxRBjQHYoxov3av0+W7MIouhb8ZqBta4iw== Subject: [FFmpeg-devel] [PATCH 5/6] avcodec/vmixdec: Fix several integer anomalies X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: 7aSiQZiqqz3+ Fixes: vmixdec.c:132:34: runtime error: signed integer overflow: -2147483648 * 1856 cannot be represented in type 'int' Fixes: vmixdec.c:119:20: runtime error: signed integer overflow: -1256 + -2147483648 cannot be represented in type 'int' Fixes: vmixdec.c:137:36: runtime error: signed integer overflow: 2147483416 * 16 cannot be represented in type 'int' Fixes: 59843/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VMIX_fuzzer-4857434624360448 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/vmixdec.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/vmixdec.c b/libavcodec/vmixdec.c index d0f2219a67..dac0827df2 100644 --- a/libavcodec/vmixdec.c +++ b/libavcodec/vmixdec.c @@ -116,7 +116,7 @@ static int decode_dcac(AVCodecContext *avctx, dc_run--; } else { dc_v = get_se_golomb_vmix(dc_gb); - dc += dc_v; + dc += (unsigned)dc_v; if (!dc_v) dc_run = get_ue_golomb_long(dc_gb); } @@ -129,12 +129,12 @@ static int decode_dcac(AVCodecContext *avctx, ac_v = get_se_golomb_vmix(ac_gb); i = scan[n]; - block[i] = (ac_v * factors[i]) >> 4; + block[i] = (unsigned)(ac_v * factors[i]) >> 4; if (!ac_v) ac_run = get_ue_golomb_long(ac_gb); } - block[0] = ((dc + add) * 16) >> 4; + block[0] = dc + add; s->idsp.idct_put(dst + x, linesize, block); } From patchwork Sun Jun 18 21:50:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Niedermayer X-Patchwork-Id: 42209 Delivered-To: ffmpegpatchwork2@gmail.com Received: by 2002:a05:6a20:be15:b0:121:b37c:e101 with SMTP id ge21csp314262pzb; Sun, 18 Jun 2023 14:50:50 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7ZOGbsfyDCkGdM+UKJQy4ClALxtuQqbEjROnX/uOb3ITccUJce3FZxkQ6zd9nepseZ8jav X-Received: by 2002:a17:906:dacb:b0:94e:e6b9:fef2 with SMTP id xi11-20020a170906dacb00b0094ee6b9fef2mr7149423ejb.67.1687125049983; Sun, 18 Jun 2023 14:50:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687125049; cv=none; d=google.com; s=arc-20160816; b=cAkinN+T68uXQMH9JlcexaplLg90FjrNN/anDzEiMfB5EmZTNXxgSs5C1m3cuJRS/j sE/sEQ1asLPi6gOHCgTSG5f+65iB8s6R6hUW8cPxH7qf4Ssr68OZ+4YX0DNiDLWPGetV NAgKWXkIwo0RYJZnY7iwwZj5WZ0dvO6Vs/P0ccr4ZDQmkeIJ16ugYtotIDfs99HUF1nW djv5cowsDLrd4yYoTTZfClFqteJNYc9eYiLEtqSgkj98xnda3s32/nkt+9mW/hCXIvoL E+0APm0+qmibjHco1CHVrykdtCuqw2BgfQC5F0OhX1ZROa4exhJxlHxKymgRTRNIu5zm wSAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:reply-to :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:references:in-reply-to:message-id:date :to:from:delivered-to; bh=7txo7otbqqcNTIRV4pm2/Hcj2drv3UR91tI7omKFzC8=; b=eIyjrl6tDbjNq1vKPid1Jt1NlkfFIf1kJDnrEBKDUCDtTfxJbMZJmQww2HdRHscKK/ m+wNGs0kBlhIe6HJbfDSnVcc/OU332R+G7SlkAjJKt7QyluqcorUDXoblKibJOW8SyKo 5f7FL/x9S/tPXyxQ96HubecJ/+nyhv3FPDtSxLuvtSJAW0PhJ6uhp4gam9LYFBrIwt63 zCZXCkxP9C5kT++Q3YlPoCvqBomUC09As7aJoAynr/ylDJe+9oUSNLFQ3cxRNrctOBcw kp/EHkMjfiULvaDtkg+8amsk5kJl64b/doX9vHdijgwdLgEZs3JKAxbKqDGSKUl8ohk1 gQLQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org. [79.124.17.100]) by mx.google.com with ESMTP id lv19-20020a170906bc9300b00987dbbdae33si1635302ejb.629.2023.06.18.14.50.49; Sun, 18 Jun 2023 14:50:49 -0700 (PDT) Received-SPF: pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) client-ip=79.124.17.100; Authentication-Results: mx.google.com; spf=pass (google.com: domain of ffmpeg-devel-bounces@ffmpeg.org designates 79.124.17.100 as permitted sender) smtp.mailfrom=ffmpeg-devel-bounces@ffmpeg.org Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8E87368BC18; Mon, 19 Jun 2023 00:50:31 +0300 (EEST) X-Original-To: ffmpeg-devel@ffmpeg.org Delivered-To: ffmpeg-devel@ffmpeg.org Received: from mail-02-2.mymagenta.at (mail-02-2.mymagenta.at [80.109.253.249]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 90FB668BF22 for ; Mon, 19 Jun 2023 00:50:24 +0300 (EEST) Received: from [192.168.232.136] (helo=ren-mail-psmtp-mg02.) by mail-02.mymagenta.at with esmtp (Exim 4.93) (envelope-from ) id 1qB0Hw-000jd7-BH for ffmpeg-devel@ffmpeg.org; Sun, 18 Jun 2023 23:50:24 +0200 Received: from localhost ([84.115.40.24]) by ren-mail-psmtp-mg02. with ESMTP id B0HxqrzPJbZLDB0HxquNIF; Sun, 18 Jun 2023 23:50:25 +0200 X-Env-Mailfrom: michael@niedermayer.cc X-Env-Rcptto: ffmpeg-devel@ffmpeg.org X-SourceIP: 84.115.40.24 X-CNFS-Analysis: v=2.4 cv=Ufwy9IeN c=1 sm=1 tr=0 ts=648f7c21 a=4thelYDX6rwh+ygQwvsI+Q==:117 a=4thelYDX6rwh+ygQwvsI+Q==:17 a=MKtGQD3n3ToA:10 a=1oJP67jkp3AA:10 a=GEAsPZ9sns4A:10 a=c5RBGETicSnhGOyKd9QA:9 From: Michael Niedermayer To: FFmpeg development discussions and patches Date: Sun, 18 Jun 2023 23:50:21 +0200 Message-Id: <20230618215021.3044-6-michael@niedermayer.cc> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230618215021.3044-1-michael@niedermayer.cc> References: <20230618215021.3044-1-michael@niedermayer.cc> X-CMAE-Envelope: MS4xfItjIY6R5NtTsVRPMZxDxL8H/OLW36c+0a/xRsHLMYGP/kIijkRtWZMMeEDfnXItg4TMfPKF1nuYBvDd2qBaFI6Pwz5udjvKoU2Bcj4UlJr3xusmlKXI CGVI6DiDbgLbydOZwaIA3+Agad1iTR05VIh1QHsIExbSPO5EnX/pfj2/JCNhM6PzIuaTznZgGvPBgw== Subject: [FFmpeg-devel] [PATCH 6/6] doc/developer: Require new modules to include tests X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" X-TUID: jvoLttQC44Ci Signed-off-by: Michael Niedermayer --- doc/developer.texi | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/doc/developer.texi b/doc/developer.texi index a7da2ce2d5..0c2f2cd7d1 100644 --- a/doc/developer.texi +++ b/doc/developer.texi @@ -805,7 +805,10 @@ Lines with similar content should be aligned vertically when doing so improves readability. @item -Consider adding a regression test for your code. +Consider adding a regression test for your code. All new modules +should be covered by tests. That includes demuxers, muxers, decoders, encoders +filters, bitstream filters, parsers. If its not possible to do that, add +an explanation why to your patchset, its ok to not test if theres a reason. @item If you added YASM code please check that things still work with --disable-yasm.